From unknown Sun Jun 22 00:55:15 2025 X-Loop: help-debbugs@gnu.org Subject: bug#63956: 29.0.91; tex-mode display problem in emacs-29 Resent-From: Jeff Norden Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 08 Jun 2023 04:31:04 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 63956 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 63956@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.168619866029758 (code B ref -1); Thu, 08 Jun 2023 04:31:04 +0000 Received: (at submit) by debbugs.gnu.org; 8 Jun 2023 04:31:00 +0000 Received: from localhost ([127.0.0.1]:55359 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q77IZ-0007jm-E5 for submit@debbugs.gnu.org; Thu, 08 Jun 2023 00:30:59 -0400 Received: from lists.gnu.org ([209.51.188.17]:45960) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q6xKs-0000Se-Ap for submit@debbugs.gnu.org; Wed, 07 Jun 2023 13:52:43 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q6xKs-0008IC-2V for bug-gnu-emacs@gnu.org; Wed, 07 Jun 2023 13:52:42 -0400 Received: from mail-pf1-x42d.google.com ([2607:f8b0:4864:20::42d]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1q6xKq-0006BQ-Ha for bug-gnu-emacs@gnu.org; Wed, 07 Jun 2023 13:52:41 -0400 Received: by mail-pf1-x42d.google.com with SMTP id d2e1a72fcca58-65314ee05c6so3722606b3a.1 for ; Wed, 07 Jun 2023 10:52:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1686160358; x=1688752358; h=to:subject:message-id:date:from:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=gWKaOqJHNcKjrMIQWdShOu135/A9fKAVPze8BPKJchs=; b=HIByuC13hntrQdBWGj+VjcVzDSoGK0SzQ5wSDrVOd5GjqJSLloaL+fS7PPLIaGxQhe Wi2Y297zjwjsp17tWuOBD1Zq+0C50ax45tyH9Z8RO4YUAJyFkPJrZZlViiMIo2wdW5IX f/xYkoAvQWavuATx/RCbZUYRC4j2G2n/Q1s4mooQNLO9daS8dVywvnmODjkg5fjwPi5b WWt3LVpeBdInoHdedqoPpgIDc7Y8uosVJNorNjaN8gjQd+x9vCAPJk1DKflviXFUOsnW BPIuOlvOoqjt3U/bgx7rB077A3VxLxHoBFgpuq/Ka7mB7C1j+8+Va/jMyvWGwC8sfik7 8L/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686160358; x=1688752358; h=to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=gWKaOqJHNcKjrMIQWdShOu135/A9fKAVPze8BPKJchs=; b=UCW5a5aCwQyd60ZQzKLGqaSh3u4IBUtlWvWf2zyVef4gQ9oEpOSB+UmIRW8BYaJp/R 3ifRCjYMwWFd63fkAGs3i9p+ArrfCIZ2bityvZzdVTSSK9rD2ZauWqZtt41qAyHp0p/I uDrd31wCTPIG52os6B/jPeLRxlxOdjtPHh0iLyj5w33QxRSdV8rf/9lNyskCl+I8dIG9 Wednv/txtl3Jayj5x39K+Lf0/nFECvDyTmYIsuJ1wDzWcY7MH2xYC8kTmQ5QwyjxzIom VI7Y2VblY4URHCfr4kxI9d7qFhMwAwzGHQ9dlpCUpTIM8ACoRQ5S4UjbXpa36pPEFkjz M2xA== X-Gm-Message-State: AC+VfDwdgOeMTXOshu4rg5sAx0PSw3QBC7MeyPd3w2Y3Whdij80aTDiJ AH4BChX07KQP6ckX6QC5MXgFk1N2ZK0Pq/ldc5Ov8Rxk6EM= X-Google-Smtp-Source: ACHHUZ6xAvXWWmBMvhgrS9ciV9lXGykur3kno1bno2S5falNACikIiDGVduhzeKzirAy/fU1G+b67XiVbbzycpqMkyM= X-Received: by 2002:a17:903:22c2:b0:1b0:3df7:5992 with SMTP id y2-20020a17090322c200b001b03df75992mr3364957plg.32.1686160358271; Wed, 07 Jun 2023 10:52:38 -0700 (PDT) MIME-Version: 1.0 From: Jeff Norden Date: Wed, 7 Jun 2023 12:52:10 -0500 Message-ID: Content-Type: text/plain; charset="UTF-8" Received-SPF: pass client-ip=2607:f8b0:4864:20::42d; envelope-from=norden.jeff@gmail.com; helo=mail-pf1-x42d.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Mailman-Approved-At: Thu, 08 Jun 2023 00:30:49 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) I've been trying out the 2nd emacs-29 pretest. It seems great. I haven't needed to tweak a single line of my .emacs or any of the custom files it loads (about 1200 lines in all). The new 'with-restriction' feature may simplify a project that I've been playing with for a while. However, I have found a minor issue with a change made to tex-mode. The simple calls to `display-buffer' in tex-mode.el have been replaced with: (display-buffer tex-shell display-comint-buffer-action) The default value for display-comint-buffer-action is set from display-buffer--same-window-action. As a result, the default behavior of `tex-buffer' or `tex-region' is that the document you are editing *disappears*, and and the window it was displayed in shows just the error messages (or lack thereof) from running TeX. You then need to switch back to the document's buffer to continue editing. This behavior makes no sense. It would be equivalent to running `compile' on a C file, and then only seeing the output from make/gcc/etc, with the source code hidden. The correct behavior in both cases is to show the process output in a window alongside the source. Anyone who has been using tex-mode for years would certainly find this new behavior disruptive, although it is easily corrected. I'm not sure if the `display-buffer' calls in tex-mode.el need to have an action argument, but if they do, it should be similar to what is used in compile.el. I'll be the first to admit that I'm not particularly well-versed in the current intricacies of buffer display actions (nor do I have any real desire to become so :-). Thanks, -Jeff From unknown Sun Jun 22 00:55:15 2025 X-Loop: help-debbugs@gnu.org Subject: bug#63956: 29.0.91; tex-mode display problem in emacs-29 Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 08 Jun 2023 09:16:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63956 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Jeff Norden , Sam Steingold Cc: 63956@debbugs.gnu.org Received: via spool by 63956-submit@debbugs.gnu.org id=B63956.168621576027326 (code B ref 63956); Thu, 08 Jun 2023 09:16:02 +0000 Received: (at 63956) by debbugs.gnu.org; 8 Jun 2023 09:16:00 +0000 Received: from localhost ([127.0.0.1]:55667 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q7BkL-00076d-91 for submit@debbugs.gnu.org; Thu, 08 Jun 2023 05:16:00 -0400 Received: from eggs.gnu.org ([209.51.188.92]:49546) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q7BkF-00076I-RM for 63956@debbugs.gnu.org; Thu, 08 Jun 2023 05:15:55 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q7Bk9-00065F-E7; Thu, 08 Jun 2023 05:15:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=+Vpj2MqG3OndbzvGU98qGKjoYizctYmUBweTdTiBc10=; b=c9coZxKyqUQV Rj2wXF6RLRQo2WAE1SIWFcCYvQ5Ve3kHRK4LH2R3I+IWO9r8QBTKS5AJJTuv7v2rONsokut23AVBu t/pbdbK9xeqktSVDICpF+Jt7uH8Z5Y7DBZPWea52Po6WnDU5SlRLwafx6hASQvL3EW+FqBSB4M39Z OX/GhK2DlMuOtZZt7v0HXn8L5T4OKK2IXtTfWAhb9dC7m3o8pdJZ6rzP/hzgyvV9JNfTTjtkBr1t+ HYxJpem29rq9M9QidiK3l2Cjkdi8ru+GaOPJS+EXra7C5x23cO8Tc0bh21I8EowkEnEywRjm9IRSo GlAP5V+i9fG6o0AZWepq+Q==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q7Bk7-00036x-Sv; Thu, 08 Jun 2023 05:15:45 -0400 Date: Thu, 08 Jun 2023 12:15:49 +0300 Message-Id: <83h6ri2u2i.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: (message from Jeff Norden on Wed, 7 Jun 2023 12:52:10 -0500) References: X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Jeff Norden > Date: Wed, 7 Jun 2023 12:52:10 -0500 > > I've been trying out the 2nd emacs-29 pretest. It seems great. > I haven't needed to tweak a single line of my .emacs or any of the > custom files it loads (about 1200 lines in all). The new > 'with-restriction' feature may simplify a project that I've been > playing with for a while. > > However, I have found a minor issue with a change made to tex-mode. > The simple calls to `display-buffer' in tex-mode.el have been replaced > with: > (display-buffer tex-shell display-comint-buffer-action) > The default value for display-comint-buffer-action is set from > display-buffer--same-window-action. > > As a result, the default behavior of `tex-buffer' or `tex-region' is > that the document you are editing *disappears*, and and the window it > was displayed in shows just the error messages (or lack thereof) from > running TeX. You then need to switch back to the document's buffer to > continue editing. This behavior makes no sense. It would be > equivalent to running `compile' on a C file, and then only seeing the > output from make/gcc/etc, with the source code hidden. The correct > behavior in both cases is to show the process output in a window > alongside the source. Anyone who has been using tex-mode for years > would certainly find this new behavior disruptive, although it is > easily corrected. > > I'm not sure if the `display-buffer' calls in tex-mode.el need to have > an action argument, but if they do, it should be similar to what is > used in compile.el. I'll be the first to admit that I'm not > particularly well-versed in the current intricacies of buffer display > actions (nor do I have any real desire to become so :-). Adding Sam, who made these changes in tex-mode.el. Sam, any comments? Jeff, would you please look at the 3 places in tex-mode where display-comint-buffer-action was added to calls to pop-to-buffer and display-buffer, and tell in which ones showing the buffer in the same window by default makes sense? I don't myself use tex-mode, so it is hard for me to tell. We could then discuss whether to remove the argument in some of the cases or make a tex-mode-specific user option to let users control that. For example, in the specific case of tex-display-shell it sounds like just dropping the argument would be TRT, since all of its callers want to show the shell buffer, but not in the selected window. What about the other two cases where this argument was added? Thanks. From unknown Sun Jun 22 00:55:15 2025 X-Loop: help-debbugs@gnu.org Subject: bug#63956: 29.0.91; tex-mode display problem in emacs-29 In-Reply-To: Resent-From: Sam Steingold Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 08 Jun 2023 17:45:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63956 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 63956@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Reply-To: sds@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.16862463012911 (code B ref -1); Thu, 08 Jun 2023 17:45:02 +0000 Received: (at submit) by debbugs.gnu.org; 8 Jun 2023 17:45:01 +0000 Received: from localhost ([127.0.0.1]:57505 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q7Jgy-0000kt-Rj for submit@debbugs.gnu.org; Thu, 08 Jun 2023 13:45:01 -0400 Received: from lists.gnu.org ([209.51.188.17]:50550) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q7Jgu-0000kg-GH for submit@debbugs.gnu.org; Thu, 08 Jun 2023 13:44:58 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q7Jgs-0003Eg-4i for bug-gnu-emacs@gnu.org; Thu, 08 Jun 2023 13:44:54 -0400 Received: from ciao.gmane.io ([116.202.254.214]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q7Jgq-0006JM-Ao for bug-gnu-emacs@gnu.org; Thu, 08 Jun 2023 13:44:53 -0400 Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1q7Jgn-0008lE-IH for bug-gnu-emacs@gnu.org; Thu, 08 Jun 2023 19:44:49 +0200 X-Injected-Via-Gmane: http://gmane.org/ From: Sam Steingold Date: Thu, 08 Jun 2023 13:44:40 -0400 Organization: disorganization Message-ID: <87ttvhkfw7.fsf@gnu.org> References: <83h6ri2u2i.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain User-Agent: Gnus/5.13 (Gnus v5.13) Cancel-Lock: sha1:ekDtDi2bcUe5FkTo1oku+KKzut8= X-Attribution: Sam X-Disclaimer: You should not expect anyone to agree with me. Received-SPF: pass client-ip=116.202.254.214; envelope-from=geb-bug-gnu-emacs@m.gmane-mx.org; helo=ciao.gmane.io X-Spam_score_int: -16 X-Spam_score: -1.7 X-Spam_bar: - X-Spam_report: (-1.7 / 5.0 requ) BAYES_00=-1.9, HEADER_FROM_DIFFERENT_DOMAINS=0.25, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.1 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.1 (--) > * Eli Zaretskii [2023-06-08 12:15:49 +0300]: > >> From: Jeff Norden >> Date: Wed, 7 Jun 2023 12:52:10 -0500 >> >> I've been trying out the 2nd emacs-29 pretest. It seems great. >> I haven't needed to tweak a single line of my .emacs or any of the >> custom files it loads (about 1200 lines in all). The new >> 'with-restriction' feature may simplify a project that I've been >> playing with for a while. >> >> However, I have found a minor issue with a change made to tex-mode. >> The simple calls to `display-buffer' in tex-mode.el have been replaced >> with: >> (display-buffer tex-shell display-comint-buffer-action) >> The default value for display-comint-buffer-action is set from >> display-buffer--same-window-action. >> >> As a result, the default behavior of `tex-buffer' or `tex-region' is >> that the document you are editing *disappears*, and and the window it >> was displayed in shows just the error messages (or lack thereof) from >> running TeX. You then need to switch back to the document's buffer to >> continue editing. This behavior makes no sense. It would be >> equivalent to running `compile' on a C file, and then only seeing the >> output from make/gcc/etc, with the source code hidden. The correct >> behavior in both cases is to show the process output in a window >> alongside the source. Anyone who has been using tex-mode for years >> would certainly find this new behavior disruptive, although it is >> easily corrected. >> >> I'm not sure if the `display-buffer' calls in tex-mode.el need to have >> an action argument, but if they do, it should be similar to what is >> used in compile.el. I'll be the first to admit that I'm not >> particularly well-versed in the current intricacies of buffer display >> actions (nor do I have any real desire to become so :-). > > Adding Sam, who made these changes in tex-mode.el. Eli, you sent your message to the amazon.com address. Why? The commit is tagged with my correct gnu.org address. Please only use sds@gnu.org for all communications. > Sam, any comments? I do not use `tex-buffer', but C-c C-f (which runs the command `tex-file') does exactly what it should - creates a new window showing `*tex-shell*'. Moreover, I just tried C-c C-b (which runs the command `tex-buffer') and it created a new `*tex-shell*' window too (or re-used an existing one) without replacing the window that shows my LaTeX. When I made the change, I was trying to fix https://debbugs.gnu.org/cgi/bugreport.cgi?bug=52467 (re-use the existing `*tex-shell*' window) and I think I did. Jeff, could you please reproduce the issue in `emacs -Q`? Thank you! -- Sam Steingold (https://aphar.dreamwidth.org/) on Pop 22.04 (jammy) X 11.0.12101004 https://lastingimpactpsychology.com https://steingoldpsychology.com https://honestreporting.com https://www.peaceandtolerance.org/ Live Lisp and prosper. From unknown Sun Jun 22 00:55:15 2025 X-Loop: help-debbugs@gnu.org Subject: bug#63956: 29.0.91; tex-mode display problem in emacs-29 Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 08 Jun 2023 18:35:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63956 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: sds@gnu.org Cc: 63956@debbugs.gnu.org Received: via spool by 63956-submit@debbugs.gnu.org id=B63956.16862492937902 (code B ref 63956); Thu, 08 Jun 2023 18:35:02 +0000 Received: (at 63956) by debbugs.gnu.org; 8 Jun 2023 18:34:53 +0000 Received: from localhost ([127.0.0.1]:57534 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q7KTF-00023N-0b for submit@debbugs.gnu.org; Thu, 08 Jun 2023 14:34:53 -0400 Received: from eggs.gnu.org ([209.51.188.92]:46102) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q7KTB-000238-2j for 63956@debbugs.gnu.org; Thu, 08 Jun 2023 14:34:52 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q7KT3-0007V6-SU; Thu, 08 Jun 2023 14:34:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=XO/c2eciV+LDbX0pQ+i1aoArvXW8+yPWGfcOCay5UdU=; b=aqpXu4OZDMFA ray3Kwd3VkZHJh0qgM+k/9akWX/WJhNL0pQu0IEHehPoaMNq0n4TOFHGrRDyG3aU0Qc9rzC1btJnO AnH60y1/xsNoDmOcG34vjY4JBnflWkdKw/YUIYBBmZjSVIJmcwgXYcMRrJEbsEpOUNPv5TCzwmTnr AZnFydAxqF5Wz6s3mnvW1IfxiZdenWYChCgli4bDKGxoHhTdYeC/73xBDnqxdEqYEU7iX2r4+wa/3 2QiryDHGYr6b5AjWt96eSAWsgtrgnq9ZVT9nC5pSU3FuGyBszNDZVT0Gff2mhlNLUpBQYMVBt41g+ IEnkku1j86MRK0VtF0uxXQ==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q7KSR-0007Hw-11; Thu, 08 Jun 2023 14:34:25 -0400 Date: Thu, 08 Jun 2023 21:34:09 +0300 Message-Id: <8335313ise.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <87ttvhkfw7.fsf@gnu.org> (message from Sam Steingold on Thu, 08 Jun 2023 13:44:40 -0400) References: <83h6ri2u2i.fsf@gnu.org> <87ttvhkfw7.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Sam Steingold > Date: Thu, 08 Jun 2023 13:44:40 -0400 > Posted-To: gmane.emacs.bugs > > > Adding Sam, who made these changes in tex-mode.el. > > Eli, you sent your message to the amazon.com address. Why? Because that's what appears in Git: commit 18b680cfd177e877991be2bd70ead628bbdc0aa0 Author: Sam Steingold AuthorDate: Tue Dec 28 17:27:41 2021 -0500 Commit: Sam Steingold CommitDate: Tue Dec 28 17:28:49 2021 -0500 Fix bug#52467 by adding a new custom variable 'display-comint-buffer-action' * lisp/window.el (display-comint-buffer-action): New `defcustom`, defaults to 'display-buffer-same-window' for backward compatibility. * lisp/cmuscheme.el (run-scheme, switch-to-scheme): Pass 'display-comint-buffer-action' to 'pop-to-buffer' instead of using 'pop-to-buffer-same-window'. * lisp/eshell/eshell.el (eshell): Likewise. * lisp/shell.el (shell): Likewise. * lisp/org/ol-eshell.el (org-eshell-open): Likewise. * lisp/progmodes/inf-lisp.el (inferior-lisp): Likewise. * lisp/progmodes/project.el (project-shell, project-eshell): Likewise. * lisp/textmodes/tex-mode.el (tex-display-shell, tex-compile-default) (tex-recenter-output-buffer): Pass 'display-comint-buffer-action' to 'pop-to-buffer'. > The commit is tagged with my correct gnu.org address. It isn't see above. > Please only use sds@gnu.org for all communications. Sorry, I cannot afford proofreading every address I copy from the Git logs. I simply don't have that kind of time. > > Sam, any comments? > > I do not use `tex-buffer', but C-c C-f (which runs the command > `tex-file') does exactly what it should - creates a new window showing > `*tex-shell*'. Moreover, I just tried C-c C-b (which runs the command > `tex-buffer') and it created a new `*tex-shell*' window too (or re-used > an existing one) without replacing the window that shows my LaTeX. > > When I made the change, I was trying to fix > https://debbugs.gnu.org/cgi/bugreport.cgi?bug=52467 (re-use the existing > `*tex-shell*' window) and I think I did. > > Jeff, could you please reproduce the issue in `emacs -Q`? I tried "M-x tex-buffer RET" in "emacs -Q", and I see what Jeff reports. Are you sure you don't have any customizations that get in the way? Or maybe post the exact sequence of commands you tried? From unknown Sun Jun 22 00:55:15 2025 X-Loop: help-debbugs@gnu.org Subject: bug#63956: 29.0.91; tex-mode display problem in emacs-29 Resent-From: Jeff Norden Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 09 Jun 2023 16:31:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63956 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii , Sam Steingold Cc: 63956@debbugs.gnu.org Received: via spool by 63956-submit@debbugs.gnu.org id=B63956.16863282484558 (code B ref 63956); Fri, 09 Jun 2023 16:31:01 +0000 Received: (at 63956) by debbugs.gnu.org; 9 Jun 2023 16:30:48 +0000 Received: from localhost ([127.0.0.1]:60228 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q7f0h-0001BS-Sz for submit@debbugs.gnu.org; Fri, 09 Jun 2023 12:30:48 -0400 Received: from mail-pl1-f175.google.com ([209.85.214.175]:55439) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q7f0f-0001BG-JL for 63956@debbugs.gnu.org; Fri, 09 Jun 2023 12:30:46 -0400 Received: by mail-pl1-f175.google.com with SMTP id d9443c01a7336-1b00ecabdf2so9568015ad.2 for <63956@debbugs.gnu.org>; Fri, 09 Jun 2023 09:30:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1686328239; x=1688920239; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=2tlTKWgVHIiDh3F1lgEHRE2BrKnbqVtrkfU2VXmdcUY=; b=Ip8a8mQ/mNMt0PDy/B7+/LT3HwX3m/y+LEXZSwjUOTYYrUYU7PBzsYnNGps05ouqUn GongxMotUcZypBkthk/uYavGI4/w8qGFtQt+/T8qNnsZ18HPc3eg+mtpKyh+lT0Ft24Q /Li8/JEb7+6bEVV/ZOU5NhFcTnTxjJ+jnOW4Fv9mdJjd7iD6t4iAZun77vljICFblc4S moipnzfPuESJEbgG6l6h+GCu7SCB1dEXADYGjba/YGImidfThpZiqp3BfJKzqCTbn6kl l6AutUzU/N3iVY66NoOmIxddCpTBP91P4AcV39dv513AJBWEMHAO0dPP4B26+SzMsaHV 16MQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686328239; x=1688920239; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=2tlTKWgVHIiDh3F1lgEHRE2BrKnbqVtrkfU2VXmdcUY=; b=dgU9bhfIr3chvvRhoDRG7Pit5Cam4cecJQbyJWYbqweC4vPG/MYGuhEdibRc+vTnOi kgFrjl718Z5dvsDNJu+ERv3bZpW6aEPlOTs9PNoo+XbadYiCTuCIeyoBj5+x4G62yUXL Qgp/tw8VKtnbMBu7nnUJ52XqeEOQhMGwqxKDraeZMgThyNh6qVSjUuWNBLLYjzLBFNHe s1msazFoLuEbmNvaLWRENwVKGDnEq2gKQsTlHVUBSoOrZ3rAh9/02DP8u1TC+w0WG4On 9I7PD2OKYxQp057g5MesyU/8Modet9TMOQ8CPTtPGmCegPj09VM4E5n1XfQYnHsjtxff 68Xg== X-Gm-Message-State: AC+VfDwEkReHE1znrDCyHau7MNbKJ4xLF3Xmv+uT1w4gR/iPJ6/wqbLD SkAGejwpXxY6h9FmLOgf2VxcY84qtJw8qz0813wrshExNdI= X-Google-Smtp-Source: ACHHUZ530Q8lcxwlFXT4AhMNPEXxmMTwW+i9wLxswbc/qSYDUMCtzz9admKZ806IsIrLUzSn8wcL9ahM4KHkqY+X41Q= X-Received: by 2002:a17:902:dacc:b0:1af:c1a7:3bb5 with SMTP id q12-20020a170902dacc00b001afc1a73bb5mr1924384plx.4.1686328239573; Fri, 09 Jun 2023 09:30:39 -0700 (PDT) MIME-Version: 1.0 References: <83h6ri2u2i.fsf@gnu.org> In-Reply-To: <83h6ri2u2i.fsf@gnu.org> From: Jeff Norden Date: Fri, 9 Jun 2023 11:30:13 -0500 Message-ID: Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Thu, Jun 8, Eli Zaretskii wrote: > From: Eli Zaretskii > To: Sam Steingold > Cc: 63956 debbugs.gnu.org > Subject: Re: bug#63956: 29.0.91; tex-mode display problem in emacs-29 > Date: Thu, 08 Jun 2023 21:34:09 +0300 > ... > > > Sam, any comments? > > > > I do not use `tex-buffer', but C-c C-f (which runs the command > > `tex-file') does exactly what it should - creates a new window showing > > `*tex-shell*'. Moreover, I just tried C-c C-b (which runs the command > > `tex-buffer') and it created a new `*tex-shell*' window too (or re-used > > an existing one) without replacing the window that shows my LaTeX. > > When I made the change, I was trying to fix > > https://debbugs.gnu.org/cgi/bugreport.cgi?bug=52467 (re-use the existing > > `*tex-shell*' window) and I think I did. > > > > Jeff, could you please reproduce the issue in `emacs -Q`? > > I tried "M-x tex-buffer RET" in "emacs -Q", and I see what Jeff > reports. Are you sure you don't have any customizations that get in > the way? Or maybe post the exact sequence of commands you tried? At first I thought there was a misunderstanding about the intended behavior, but then I realized that Sam is saying that his tex-shell window *doesn't* replace the editing window. I can also verify that it does replace the editing window, using "emacs -Q" with either 29.0.91 or emacs-30 built from the current git source. Since the default display action is replace-window, this makes sense. Sam: can you try it again after making sure that your display-comint-buffer-action has the default value (which should be '(display-buffer-same-window (inhibit-same-window))'? If I'm understanding things correctly, the point of this new variable is to make it easier to modify the way normal *shell* type buffers open, while leaving the traditional same-window behavior as the default. --- My own tex-mode use is very heavily customized (via eval-after-load), so I think I need to look a bit at the default behavior before I make any specific suggestions about changing tex-mode.el. I'll try to do that this weekend. -Jeff From unknown Sun Jun 22 00:55:15 2025 X-Loop: help-debbugs@gnu.org Subject: bug#63956: 29.0.91; tex-mode display problem in emacs-29 In-Reply-To: Resent-From: Sam Steingold Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 09 Jun 2023 20:02:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63956 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 63956@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Reply-To: sds@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.168634087626050 (code B ref -1); Fri, 09 Jun 2023 20:02:01 +0000 Received: (at submit) by debbugs.gnu.org; 9 Jun 2023 20:01:16 +0000 Received: from localhost ([127.0.0.1]:60643 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q7iIN-0006m4-H7 for submit@debbugs.gnu.org; Fri, 09 Jun 2023 16:01:16 -0400 Received: from lists.gnu.org ([209.51.188.17]:51626) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q7iIL-0006lu-Eh for submit@debbugs.gnu.org; Fri, 09 Jun 2023 16:01:14 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q7iIL-00087z-4w for bug-gnu-emacs@gnu.org; Fri, 09 Jun 2023 16:01:13 -0400 Received: from ciao.gmane.io ([116.202.254.214]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q7iIH-0004I1-K7 for bug-gnu-emacs@gnu.org; Fri, 09 Jun 2023 16:01:12 -0400 Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1q7iID-0009lj-4q for bug-gnu-emacs@gnu.org; Fri, 09 Jun 2023 22:01:05 +0200 X-Injected-Via-Gmane: http://gmane.org/ From: Sam Steingold Date: Fri, 09 Jun 2023 16:00:56 -0400 Organization: disorganization Message-ID: <87o7lojthj.fsf@gnu.org> References: <83h6ri2u2i.fsf@gnu.org> <87ttvhkfw7.fsf@gnu.org> <8335313ise.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain User-Agent: Gnus/5.13 (Gnus v5.13) Cancel-Lock: sha1:J7UyPXd099ei0htNKdhIPFZ5ZVY= X-Attribution: Sam X-Disclaimer: You should not expect anyone to agree with me. Received-SPF: pass client-ip=116.202.254.214; envelope-from=geb-bug-gnu-emacs@m.gmane-mx.org; helo=ciao.gmane.io X-Spam_score_int: -16 X-Spam_score: -1.7 X-Spam_bar: - X-Spam_report: (-1.7 / 5.0 requ) BAYES_00=-1.9, HEADER_FROM_DIFFERENT_DOMAINS=0.25, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.1 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.1 (--) > * Eli Zaretskii [2023-06-08 21:34:09 +0300]: > >> Eli, you sent your message to the amazon.com address. Why? > > Because that's what appears in Git: > > commit 18b680cfd177e877991be2bd70ead628bbdc0aa0 > Author: Sam Steingold > AuthorDate: Tue Dec 28 17:27:41 2021 -0500 > Commit: Sam Steingold > CommitDate: Tue Dec 28 17:28:49 2021 -0500 > > Fix bug#52467 by adding a new custom variable 'display-comint-buffer-action' > > * lisp/window.el (display-comint-buffer-action): New `defcustom`, > defaults to 'display-buffer-same-window' for backward compatibility. > * lisp/cmuscheme.el (run-scheme, switch-to-scheme): Pass > 'display-comint-buffer-action' to 'pop-to-buffer' instead > of using 'pop-to-buffer-same-window'. > * lisp/eshell/eshell.el (eshell): Likewise. > * lisp/shell.el (shell): Likewise. > * lisp/org/ol-eshell.el (org-eshell-open): Likewise. > * lisp/progmodes/inf-lisp.el (inferior-lisp): Likewise. > * lisp/progmodes/project.el (project-shell, project-eshell): Likewise. > * lisp/textmodes/tex-mode.el (tex-display-shell, tex-compile-default) > (tex-recenter-output-buffer): Pass 'display-comint-buffer-action' > to 'pop-to-buffer'. here is what I see: commit 18b680cfd177e877991be2bd70ead628bbdc0aa0 Author: Sam Steingold Date: 2021-12-28 17:27:41 -0500 Fix bug#52467 by adding a new custom variable 'display-comint-buffer-action' * lisp/window.el (display-comint-buffer-action): New `defcustom`, defaults to 'display-buffer-same-window' for backward compatibility. * lisp/cmuscheme.el (run-scheme, switch-to-scheme): Pass 'display-comint-buffer-action' to 'pop-to-buffer' instead of using 'pop-to-buffer-same-window'. * lisp/eshell/eshell.el (eshell): Likewise. * lisp/shell.el (shell): Likewise. * lisp/org/ol-eshell.el (org-eshell-open): Likewise. * lisp/progmodes/inf-lisp.el (inferior-lisp): Likewise. * lisp/progmodes/project.el (project-shell, project-eshell): Likewise. * lisp/textmodes/tex-mode.el (tex-display-shell, tex-compile-default) (tex-recenter-output-buffer): Pass 'display-comint-buffer-action' to 'pop-to-buffer'. >> The commit is tagged with my correct gnu.org address. > It isn't see above. I am confused. >> Please only use sds@gnu.org for all communications. > > Sorry, I cannot afford proofreading every address I copy from the Git > logs. I simply don't have that kind of time. I am with you, but note that you risk getting your emails bouncing. > Are you sure you don't have any customizations that get in the way? Yeah, looks like I do: --8<---------------cut here---------------start------------->8--- '(display-buffer-alist '(("shell\\*" nil (inhibit-same-window . t)))) --8<---------------cut here---------------end--------------->8--- When my change was discussed, I was told that adding a new custom variable was okay, but making it have non-trivial default is not. Maybe `display-comint-buffer-action' should default to `display-buffer-in-previous-window'? -- Sam Steingold (https://aphar.dreamwidth.org/) on Pop 22.04 (jammy) X 11.0.12101004 https://lastingimpactpsychology.com https://steingoldpsychology.com https://ij.org/ https://camera.org https://honestreporting.com Legends are time-tested rumors. From unknown Sun Jun 22 00:55:15 2025 X-Loop: help-debbugs@gnu.org Subject: bug#63956: 29.0.91; tex-mode display problem in emacs-29 Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 10 Jun 2023 05:57:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63956 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: sds@gnu.org, Jeff Norden Cc: 63956@debbugs.gnu.org, Stefan Monnier Received: via spool by 63956-submit@debbugs.gnu.org id=B63956.168637661322100 (code B ref 63956); Sat, 10 Jun 2023 05:57:02 +0000 Received: (at 63956) by debbugs.gnu.org; 10 Jun 2023 05:56:53 +0000 Received: from localhost ([127.0.0.1]:33087 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q7ram-0005kO-IX for submit@debbugs.gnu.org; Sat, 10 Jun 2023 01:56:52 -0400 Received: from eggs.gnu.org ([209.51.188.92]:49024) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q7ral-0005kA-3N for 63956@debbugs.gnu.org; Sat, 10 Jun 2023 01:56:51 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q7rac-0004tm-7i; Sat, 10 Jun 2023 01:56:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=fCfHrE0BXUHyMbR4ugvFRZ5RP2ccgSyoxssqTMWOVGs=; b=J0BOlrTVCvX1 Y+uGqzWCrBRIReH1NjyjNKb2icZ8MU9iCIcoGI7vQHLDhMOdo/vdgMjfbHyle57CW3FraWbzg7Hqx w5F4TxP1YnNGjfAD9bzuEj5SdAsU3zZ4ii3WG3LTOsf1ywY4n9AViUZRJCbmpEVWIQ4ATeFQoXEEY 0cnmYCFyG8ZdDmRnQUo6pOxeLKfbzarh/WozI24fZ4K+OCrImrJjaYFim1YzHCdnBUkc0nXuAw/5Q ZvYNHkTk05bCtbruoofga1Jre1TY9QUy8VQyTEoEUJQpIzH47lW2badON5LnKx0nXb1oysaA7jpPP jdFLsBdSNs8LS1aWRH1yZg==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q7raa-00006b-E4; Sat, 10 Jun 2023 01:56:42 -0400 Date: Sat, 10 Jun 2023 08:56:50 +0300 Message-Id: <837csb2731.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <87o7lojthj.fsf@gnu.org> (message from Sam Steingold on Fri, 09 Jun 2023 16:00:56 -0400) References: <83h6ri2u2i.fsf@gnu.org> <87ttvhkfw7.fsf@gnu.org> <8335313ise.fsf@gnu.org> <87o7lojthj.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Sam Steingold > Date: Fri, 09 Jun 2023 16:00:56 -0400 > > here is what I see: > > commit 18b680cfd177e877991be2bd70ead628bbdc0aa0 > Author: Sam Steingold > Date: 2021-12-28 17:27:41 -0500 > > Fix bug#52467 by adding a new custom variable 'display-comint-buffer-action' > > * lisp/window.el (display-comint-buffer-action): New `defcustom`, > defaults to 'display-buffer-same-window' for backward compatibility. > * lisp/cmuscheme.el (run-scheme, switch-to-scheme): Pass > 'display-comint-buffer-action' to 'pop-to-buffer' instead > of using 'pop-to-buffer-same-window'. > * lisp/eshell/eshell.el (eshell): Likewise. > * lisp/shell.el (shell): Likewise. > * lisp/org/ol-eshell.el (org-eshell-open): Likewise. > * lisp/progmodes/inf-lisp.el (inferior-lisp): Likewise. > * lisp/progmodes/project.el (project-shell, project-eshell): Likewise. > * lisp/textmodes/tex-mode.el (tex-display-shell, tex-compile-default) > (tex-recenter-output-buffer): Pass 'display-comint-buffer-action' > to 'pop-to-buffer'. > > >> The commit is tagged with my correct gnu.org address. > > It isn't see above. > > I am confused. I don't know why this happens, perhaps due to differences in Git versions? I'm guessing you have some non-trivial setup of your email address for Git or something? The @amazon.com address wasn't just concocted by my Git client out of thin air, right? I tried on 2 other systems. One of them, with Git v2.34.1 reports what you see; the other, with Git 2.17.1, reports what I see. > >> Please only use sds@gnu.org for all communications. > > > > Sorry, I cannot afford proofreading every address I copy from the Git > > logs. I simply don't have that kind of time. > > I am with you, but note that you risk getting your emails bouncing. When it bounces, I will look for a different address, so this is fine. But maybe you could make whatever email setup you have for Git so this doesn't happen in the first place? > > Are you sure you don't have any customizations that get in the way? > > Yeah, looks like I do: > --8<---------------cut here---------------start------------->8--- > '(display-buffer-alist > '(("shell\\*" nil (inhibit-same-window . t)))) > --8<---------------cut here---------------end--------------->8--- > > When my change was discussed, I was told that adding a new custom > variable was okay, but making it have non-trivial default is not. This is fine, but making commands use the default value of this new custom variable changes behavior, and at least for tex-buffer the change is for the worse. > Maybe `display-comint-buffer-action' should default to > `display-buffer-in-previous-window'? That works for me, but I think it's too late to change the default now, 1.5 years after the defcustom was introduced. (It could be a good idea for master, perhaps.) So at this point, on the release branch, I'd like to fix only the specific problems we see, without risking any unrelated breakage. To understand how best to solve this, I need you two (and anyone else who uses tex-mode) to look at the other uses of this defcustom in tex-mode, and tell me whether any of them also need fixing. As I wrote in my original message: > Jeff, would you please look at the 3 places in tex-mode where > display-comint-buffer-action was added to calls to pop-to-buffer and > display-buffer, and tell in which ones showing the buffer in the same > window by default makes sense? I don't myself use tex-mode, so it is > hard for me to tell. We could then discuss whether to remove the > argument in some of the cases or make a tex-mode-specific user option > to let users control that. For example, in the specific case of > tex-display-shell it sounds like just dropping the argument would be > TRT, since all of its callers want to show the shell buffer, but not > in the selected window. What about the other two cases where this > argument was added? Would you two please help me understand how best to fix this regression by providing the above information? TIA. From unknown Sun Jun 22 00:55:15 2025 X-Loop: help-debbugs@gnu.org Subject: bug#63956: 29.0.91; tex-mode display problem in emacs-29 Resent-From: Gregory Heytings Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 10 Jun 2023 12:56:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63956 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: 63956@debbugs.gnu.org, Jeff Norden , sds@gnu.org, Stefan Monnier Received: via spool by 63956-submit@debbugs.gnu.org id=B63956.168640171311686 (code B ref 63956); Sat, 10 Jun 2023 12:56:01 +0000 Received: (at 63956) by debbugs.gnu.org; 10 Jun 2023 12:55:13 +0000 Received: from localhost ([127.0.0.1]:33411 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q7y7c-00032P-EX for submit@debbugs.gnu.org; Sat, 10 Jun 2023 08:55:12 -0400 Received: from heytings.org ([95.142.160.155]:38582) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q7y7W-00032C-UR for 63956@debbugs.gnu.org; Sat, 10 Jun 2023 08:55:10 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=heytings.org; s=20220101; t=1686401706; bh=cSZavjWXei0lIHcLqE+A8UDU7t+JVbJTvTQUQ13+jMo=; h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References:From; b=7vY4w0L6W1rCJocjoJBLnipI34xJSOMQlI+RbzmqGniUCite5ym/IZvojsTDkGe2V rrb5gNVu4f1hDa54K0DIwlsWjl2WUd+8kO5ZEuZXvpRC6btvg5ziVb7ZbQFxKm0uKG 2MVCr9FouhxebekNGLY8g9gOwniluC8hDLGA1iJxxUYoq1Qsg+1lkN1aHMVwoxeb/f 78K4vE0YkR2FFp7mtFKQAK2XHJtNFpAwLFVEeG816i7ooFSGKCAUIFO/DYNCASXV2T q8dKixE7tPhp5WWMmtgkhmE84mVnd4oHbbgpS9bx8BnSprmvbsm0bXTUO5rrfEVYCB lIPYh9+dalLhA== Date: Sat, 10 Jun 2023 12:55:05 +0000 From: Gregory Heytings In-Reply-To: <837csb2731.fsf@gnu.org> Message-ID: <3c82fb01f423e31ef479@heytings.org> References: <83h6ri2u2i.fsf@gnu.org> <87ttvhkfw7.fsf@gnu.org> <8335313ise.fsf@gnu.org> <87o7lojthj.fsf@gnu.org> <837csb2731.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; format=flowed; charset=us-ascii X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > > I don't know why this happens, perhaps due to differences in Git > versions? I'm guessing you have some non-trivial setup of your email > address for Git or something? The @amazon.com address wasn't just > concocted by my Git client out of thin air, right? > > I tried on 2 other systems. One of them, with Git v2.34.1 reports what > you see; the other, with Git 2.17.1, reports what I see. > The difference is that since Git 2.23.0 "git log" behaves by default as if the --mailmap option was given, which uses the correspondence in the .mailmap file. The actual author of commit 18b680cfd1 is sdsg@amazon.com, but because of the line Sam Steingold in the .mailmap file the author is displayed as sds@gnu.org. From unknown Sun Jun 22 00:55:15 2025 X-Loop: help-debbugs@gnu.org Subject: bug#63956: 29.0.91; tex-mode display problem in emacs-29 Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 10 Jun 2023 13:13:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63956 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Gregory Heytings Cc: 63956@debbugs.gnu.org, norden.jeff@gmail.com, sds@gnu.org, monnier@iro.umontreal.ca Received: via spool by 63956-submit@debbugs.gnu.org id=B63956.168640274413356 (code B ref 63956); Sat, 10 Jun 2023 13:13:01 +0000 Received: (at 63956) by debbugs.gnu.org; 10 Jun 2023 13:12:24 +0000 Received: from localhost ([127.0.0.1]:33421 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q7yOG-0003TM-KN for submit@debbugs.gnu.org; Sat, 10 Jun 2023 09:12:24 -0400 Received: from eggs.gnu.org ([209.51.188.92]:56230) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q7yOE-0003T8-8d for 63956@debbugs.gnu.org; Sat, 10 Jun 2023 09:12:23 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q7yO7-0003Xx-Mh; Sat, 10 Jun 2023 09:12:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=jU1mdN8v0sB+su6uPE8PHN59IPuS46cIZh/6G0KmTK4=; b=OmEU8Ka2p32k u10ss3D+btWUgyZi6Z4hrxoJ8ykX9DNNi4Ckl7z7FMUsIVoY3O7a46cYKuBD3adcCBnhWBlUXh6GG lDFesVGaOHjDE1lh/K/RFM7WqORCLFxeqAwpADlC9fyjf2WPQrM8ik/U1ruAKv5JUrHGohQ7BTtxk 44JgRECBgAwjLJfUsN91qKjNDYwgL9lGx/0j7+ovHhGmdWNQzq5KZx9pLWIaU+UE6eTmoME5+3yAH 864zII0niiN8SSO0dCGKAfXtsM+x05n6zviOq4uyyXYauL7PuAZWciq4GpgZZWSwOKWEvBGSKrnq3 2xvPycb8qR3/1heN/3MFHQ==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q7yO5-0003FA-Ko; Sat, 10 Jun 2023 09:12:15 -0400 Date: Sat, 10 Jun 2023 16:12:24 +0300 Message-Id: <83legrzcjr.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <3c82fb01f423e31ef479@heytings.org> (message from Gregory Heytings on Sat, 10 Jun 2023 12:55:05 +0000) References: <83h6ri2u2i.fsf@gnu.org> <87ttvhkfw7.fsf@gnu.org> <8335313ise.fsf@gnu.org> <87o7lojthj.fsf@gnu.org> <837csb2731.fsf@gnu.org> <3c82fb01f423e31ef479@heytings.org> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Sat, 10 Jun 2023 12:55:05 +0000 > From: Gregory Heytings > cc: sds@gnu.org, Jeff Norden , 63956@debbugs.gnu.org, > Stefan Monnier > > > I tried on 2 other systems. One of them, with Git v2.34.1 reports what > > you see; the other, with Git 2.17.1, reports what I see. > > > > The difference is that since Git 2.23.0 "git log" behaves by default as if > the --mailmap option was given, which uses the correspondence in the > .mailmap file. Thanks (but I guess you meant --use-mailmap, not --mailmap). From unknown Sun Jun 22 00:55:15 2025 X-Loop: help-debbugs@gnu.org Subject: bug#63956: 29.0.91; tex-mode display problem in emacs-29 Resent-From: Gregory Heytings Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 10 Jun 2023 13:21:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63956 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: 63956@debbugs.gnu.org, norden.jeff@gmail.com, sds@gnu.org, monnier@iro.umontreal.ca Received: via spool by 63956-submit@debbugs.gnu.org id=B63956.168640324514162 (code B ref 63956); Sat, 10 Jun 2023 13:21:02 +0000 Received: (at 63956) by debbugs.gnu.org; 10 Jun 2023 13:20:45 +0000 Received: from localhost ([127.0.0.1]:33427 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q7yWL-0003gL-JW for submit@debbugs.gnu.org; Sat, 10 Jun 2023 09:20:45 -0400 Received: from heytings.org ([95.142.160.155]:38618) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q7yWJ-0003gC-60 for 63956@debbugs.gnu.org; Sat, 10 Jun 2023 09:20:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=heytings.org; s=20220101; t=1686403242; bh=1s/R2sDNPmeTqzsa4cZ2Mz3/RVXz97PMQEcX44OOgrQ=; h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References:From; b=6SvNLmkNQiF9c/4HxOe0KclFITiPjcXcAWsJqb1Cum23TB5crb1YL6HWkZhc1o0J2 GHWS3YewPpUHhvEiAWM5oXPtCNKTwXcJ+mHb5qhSyFuxMgbMdlENq3mmF0b1RuvyUf QBpT6FfxHX/Ue/FTPYzOQyutv0iDDAdfZj18rU1Az+kVemYgCPYE3CvbQQU3aXfg4k tZdxh7R/8rcbQTQ57f17Bhqr+sG1A2XmRteNJCrnvO3EUjZu0PbTPIWnOhY9qq8WjR mHpD5v2FcC8KRe97YrfAgP6EM3xXjeUm77DX+nhIc/dBTZhpWvE1b0bf9Y3Fj8TL6u oHSLrLM75tNtg== Date: Sat, 10 Jun 2023 13:20:41 +0000 From: Gregory Heytings In-Reply-To: <83legrzcjr.fsf@gnu.org> Message-ID: <3c82fb01f442a98262fe@heytings.org> References: <83h6ri2u2i.fsf@gnu.org> <87ttvhkfw7.fsf@gnu.org> <8335313ise.fsf@gnu.org> <87o7lojthj.fsf@gnu.org> <837csb2731.fsf@gnu.org> <3c82fb01f423e31ef479@heytings.org> <83legrzcjr.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >>> I tried on 2 other systems. One of them, with Git v2.34.1 reports >>> what you see; the other, with Git 2.17.1, reports what I see. >> >> The difference is that since Git 2.23.0 "git log" behaves by default as >> if the --mailmap option was given, which uses the correspondence in the >> .mailmap file. > > Thanks (but I guess you meant --use-mailmap, not --mailmap). > Yes and no: --mailmap and --use-mailmap are equivalent since Git 2.27.0, as are --no-mailmap and --no-use-mailmap. From unknown Sun Jun 22 00:55:15 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Jeff Norden Subject: bug#63956: closed (Re: bug#63956: 29.0.91; tex-mode display problem in emacs-29) Message-ID: References: <837csazff2.fsf@gnu.org> X-Gnu-PR-Message: they-closed 63956 X-Gnu-PR-Package: emacs Reply-To: 63956@debbugs.gnu.org Date: Sun, 11 Jun 2023 06:23:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1686464582-23504-1" This is a multi-part message in MIME format... ------------=_1686464582-23504-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #63956: 29.0.91; tex-mode display problem in emacs-29 which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 63956@debbugs.gnu.org. --=20 63956: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D63956 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1686464582-23504-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 63956-done) by debbugs.gnu.org; 11 Jun 2023 06:22:41 +0000 Received: from localhost ([127.0.0.1]:36592 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q8ETI-00066W-U4 for submit@debbugs.gnu.org; Sun, 11 Jun 2023 02:22:41 -0400 Received: from eggs.gnu.org ([209.51.188.92]:57232) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q8ETF-00066I-R1 for 63956-done@debbugs.gnu.org; Sun, 11 Jun 2023 02:22:39 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q8ET8-0001nM-Ay; Sun, 11 Jun 2023 02:22:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=oECbr4Jgwk68lCt3PrzPaweWyC0Q4uXexAjBb138tXs=; b=iR6Geq8oAw7o J+EZ1CkPxiFYLZDmBrDDQcihjTdMlcu4KGDmST/0o3+1Q2RnsL3mYCD3PJKFNDSKiZcpIH7GwBvRd QeKQ6e1ThN47o8CybXuLZFbY8N1TAJ2kVRjt0ZirDR8jeo5dbqB4uN6gZDkyAB4BsynMPeyi2xx5J uz+JV6q87U7BYJkSPU/OeJpoUhAc8mj7CN0RrYKt3vmm94YadS3ktLe/4xo0gaAb38U7akDe66V1a yJvAM0K3FDRw+XCKf6zSOmbPrmF05S7HuEJ4UPwWkT5i+LItzYRIWfA0NVRPVN1MBSk4y2v6qX04q Eu9KozTHijst1lR+wLWfNg==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q8ET7-00041D-IA; Sun, 11 Jun 2023 02:22:29 -0400 Date: Sun, 11 Jun 2023 09:22:41 +0300 Message-Id: <837csazff2.fsf@gnu.org> From: Eli Zaretskii To: sds@gnu.org, norden.jeff@gmail.com In-Reply-To: <837csb2731.fsf@gnu.org> (message from Eli Zaretskii on Sat, 10 Jun 2023 08:56:50 +0300) Subject: Re: bug#63956: 29.0.91; tex-mode display problem in emacs-29 References: <83h6ri2u2i.fsf@gnu.org> <87ttvhkfw7.fsf@gnu.org> <8335313ise.fsf@gnu.org> <87o7lojthj.fsf@gnu.org> <837csb2731.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 63956-done Cc: 63956-done@debbugs.gnu.org, monnier@iro.umontreal.ca X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Cc: 63956@debbugs.gnu.org, Stefan Monnier > Date: Sat, 10 Jun 2023 08:56:50 +0300 > From: Eli Zaretskii > > > Maybe `display-comint-buffer-action' should default to > > `display-buffer-in-previous-window'? > > That works for me, but I think it's too late to change the default > now, 1.5 years after the defcustom was introduced. (It could be a > good idea for master, perhaps.) So at this point, on the release > branch, I'd like to fix only the specific problems we see, without > risking any unrelated breakage. To understand how best to solve this, > I need you two (and anyone else who uses tex-mode) to look at the > other uses of this defcustom in tex-mode, and tell me whether any of > them also need fixing. As I wrote in my original message: > > > Jeff, would you please look at the 3 places in tex-mode where > > display-comint-buffer-action was added to calls to pop-to-buffer and > > display-buffer, and tell in which ones showing the buffer in the same > > window by default makes sense? I don't myself use tex-mode, so it is > > hard for me to tell. We could then discuss whether to remove the > > argument in some of the cases or make a tex-mode-specific user option > > to let users control that. For example, in the specific case of > > tex-display-shell it sounds like just dropping the argument would be > > TRT, since all of its callers want to show the shell buffer, but not > > in the selected window. What about the other two cases where this > > argument was added? > > Would you two please help me understand how best to fix this > regression by providing the above information? TIA. No further comments, so I've now added a new defcustom, called display-tex-shell-buffer-action, and made its default value be display-buffer-in-previous-window. With that, I'm closing this bug. ------------=_1686464582-23504-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 8 Jun 2023 04:31:00 +0000 Received: from localhost ([127.0.0.1]:55359 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q77IZ-0007jm-E5 for submit@debbugs.gnu.org; Thu, 08 Jun 2023 00:30:59 -0400 Received: from lists.gnu.org ([209.51.188.17]:45960) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q6xKs-0000Se-Ap for submit@debbugs.gnu.org; Wed, 07 Jun 2023 13:52:43 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q6xKs-0008IC-2V for bug-gnu-emacs@gnu.org; Wed, 07 Jun 2023 13:52:42 -0400 Received: from mail-pf1-x42d.google.com ([2607:f8b0:4864:20::42d]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1q6xKq-0006BQ-Ha for bug-gnu-emacs@gnu.org; Wed, 07 Jun 2023 13:52:41 -0400 Received: by mail-pf1-x42d.google.com with SMTP id d2e1a72fcca58-65314ee05c6so3722606b3a.1 for ; Wed, 07 Jun 2023 10:52:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1686160358; x=1688752358; h=to:subject:message-id:date:from:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=gWKaOqJHNcKjrMIQWdShOu135/A9fKAVPze8BPKJchs=; b=HIByuC13hntrQdBWGj+VjcVzDSoGK0SzQ5wSDrVOd5GjqJSLloaL+fS7PPLIaGxQhe Wi2Y297zjwjsp17tWuOBD1Zq+0C50ax45tyH9Z8RO4YUAJyFkPJrZZlViiMIo2wdW5IX f/xYkoAvQWavuATx/RCbZUYRC4j2G2n/Q1s4mooQNLO9daS8dVywvnmODjkg5fjwPi5b WWt3LVpeBdInoHdedqoPpgIDc7Y8uosVJNorNjaN8gjQd+x9vCAPJk1DKflviXFUOsnW BPIuOlvOoqjt3U/bgx7rB077A3VxLxHoBFgpuq/Ka7mB7C1j+8+Va/jMyvWGwC8sfik7 8L/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686160358; x=1688752358; h=to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=gWKaOqJHNcKjrMIQWdShOu135/A9fKAVPze8BPKJchs=; b=UCW5a5aCwQyd60ZQzKLGqaSh3u4IBUtlWvWf2zyVef4gQ9oEpOSB+UmIRW8BYaJp/R 3ifRCjYMwWFd63fkAGs3i9p+ArrfCIZ2bityvZzdVTSSK9rD2ZauWqZtt41qAyHp0p/I uDrd31wCTPIG52os6B/jPeLRxlxOdjtPHh0iLyj5w33QxRSdV8rf/9lNyskCl+I8dIG9 Wednv/txtl3Jayj5x39K+Lf0/nFECvDyTmYIsuJ1wDzWcY7MH2xYC8kTmQ5QwyjxzIom VI7Y2VblY4URHCfr4kxI9d7qFhMwAwzGHQ9dlpCUpTIM8ACoRQ5S4UjbXpa36pPEFkjz M2xA== X-Gm-Message-State: AC+VfDwdgOeMTXOshu4rg5sAx0PSw3QBC7MeyPd3w2Y3Whdij80aTDiJ AH4BChX07KQP6ckX6QC5MXgFk1N2ZK0Pq/ldc5Ov8Rxk6EM= X-Google-Smtp-Source: ACHHUZ6xAvXWWmBMvhgrS9ciV9lXGykur3kno1bno2S5falNACikIiDGVduhzeKzirAy/fU1G+b67XiVbbzycpqMkyM= X-Received: by 2002:a17:903:22c2:b0:1b0:3df7:5992 with SMTP id y2-20020a17090322c200b001b03df75992mr3364957plg.32.1686160358271; Wed, 07 Jun 2023 10:52:38 -0700 (PDT) MIME-Version: 1.0 From: Jeff Norden Date: Wed, 7 Jun 2023 12:52:10 -0500 Message-ID: Subject: 29.0.91; tex-mode display problem in emacs-29 To: bug-gnu-emacs@gnu.org Content-Type: text/plain; charset="UTF-8" Received-SPF: pass client-ip=2607:f8b0:4864:20::42d; envelope-from=norden.jeff@gmail.com; helo=mail-pf1-x42d.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Thu, 08 Jun 2023 00:30:49 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) I've been trying out the 2nd emacs-29 pretest. It seems great. I haven't needed to tweak a single line of my .emacs or any of the custom files it loads (about 1200 lines in all). The new 'with-restriction' feature may simplify a project that I've been playing with for a while. However, I have found a minor issue with a change made to tex-mode. The simple calls to `display-buffer' in tex-mode.el have been replaced with: (display-buffer tex-shell display-comint-buffer-action) The default value for display-comint-buffer-action is set from display-buffer--same-window-action. As a result, the default behavior of `tex-buffer' or `tex-region' is that the document you are editing *disappears*, and and the window it was displayed in shows just the error messages (or lack thereof) from running TeX. You then need to switch back to the document's buffer to continue editing. This behavior makes no sense. It would be equivalent to running `compile' on a C file, and then only seeing the output from make/gcc/etc, with the source code hidden. The correct behavior in both cases is to show the process output in a window alongside the source. Anyone who has been using tex-mode for years would certainly find this new behavior disruptive, although it is easily corrected. I'm not sure if the `display-buffer' calls in tex-mode.el need to have an action argument, but if they do, it should be similar to what is used in compile.el. I'll be the first to admit that I'm not particularly well-versed in the current intricacies of buffer display actions (nor do I have any real desire to become so :-). Thanks, -Jeff ------------=_1686464582-23504-1-- From unknown Sun Jun 22 00:55:15 2025 X-Loop: help-debbugs@gnu.org Subject: bug#63956: 29.0.91; tex-mode display problem in emacs-29 Resent-From: Jeff Norden Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 11 Jun 2023 15:46:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63956 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: 63956-done@debbugs.gnu.org, sds@gnu.org, monnier@iro.umontreal.ca Received: via spool by 63956-done@debbugs.gnu.org id=D63956.168649831327697 (code D ref 63956); Sun, 11 Jun 2023 15:46:01 +0000 Received: (at 63956-done) by debbugs.gnu.org; 11 Jun 2023 15:45:13 +0000 Received: from localhost ([127.0.0.1]:37621 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q8NFh-0007Cf-Fb for submit@debbugs.gnu.org; Sun, 11 Jun 2023 11:45:13 -0400 Received: from mail-pg1-f181.google.com ([209.85.215.181]:48629) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q8NFe-0007CQ-Rl for 63956-done@debbugs.gnu.org; Sun, 11 Jun 2023 11:45:11 -0400 Received: by mail-pg1-f181.google.com with SMTP id 41be03b00d2f7-51b4ef5378bso2252827a12.1 for <63956-done@debbugs.gnu.org>; Sun, 11 Jun 2023 08:45:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1686498305; x=1689090305; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=BIsXqc5MospOjQEph4bMNcPsye9FbtQ6hEVMNWnloDI=; b=FvGPhDXFfMTKg7qQET6Du+JAzGRhI1KXtZmr5Jml9gwqMgtInfXVcN4fqJYvbEOXCj oNgdQg3d4yL3mFZDY0PvUB8kk9bwwRrw5nJu8ETjtM0LlnsIezI5GE4FVolgRvlgrxtK FUjyJhUvfQhruzLETZ45PnpP4vvWLYP6jzaRC/PhDBkNav4uZpzUSIQFvo9ojw/StA03 t47m/V0m8LMH1Ft53FDYJuNjggyxnMcqLE4Js91vr+DSDQHWqAf6n1LGETQBuSoz2N4c siD2/EvQxQB7c5a4fnOBPfy3xNwf8h2BHL3VGSYuQ4wESV3axlrXyzSQKvRgi+UXr5hm G4+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686498305; x=1689090305; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=BIsXqc5MospOjQEph4bMNcPsye9FbtQ6hEVMNWnloDI=; b=jgWWoROAMKy50FRzOELwX8T00tFek1XM76yfbUadNEyIsFgSa2+aUlg4VZtxusSrXV koQt3E7LfPHccbarw87yBBS0G2dRVoexgkzNqNyvpdqKaLu8QZpCmscrMLa91XrXe5gz XR+vWXQoI/rmYd6nqT+eUra62p+kmVbMlXUN5TfWsZPHK8SdiXaPlYX80YxAtw8j47MK TTTZy+m5miiY2I6pxRYgOEby2Xf4ZWjeWID4u8L64xx/4Iup3UHRFsr+EKtzcL6/wniF 0/QzpLyda2mxJ2e0KTFrGjsWoe3mICJXmcxETshd1vLqdssJ51zxM50UnKh5ARyBdgbQ r2aA== X-Gm-Message-State: AC+VfDxTaXu2F+GY/iKsWNkdpk++PecSkiO6biN6P6hNXqMKzN1HNH+l bY1xDXNX9O8qrsRddtzFSArXnBO2wJL+loIYgDI= X-Google-Smtp-Source: ACHHUZ4WWjk3X3yCB/ZyDXmh7SlX35ZJTmzBvBnGrtojPxRzZ3etemXLe9nDtMAU/ReX2mASgJhs8DMZ6TWC415IBMw= X-Received: by 2002:a17:90b:1b50:b0:259:dda1:bee1 with SMTP id nv16-20020a17090b1b5000b00259dda1bee1mr6834579pjb.46.1686498304604; Sun, 11 Jun 2023 08:45:04 -0700 (PDT) MIME-Version: 1.0 References: <83h6ri2u2i.fsf@gnu.org> <87ttvhkfw7.fsf@gnu.org> <8335313ise.fsf@gnu.org> <87o7lojthj.fsf@gnu.org> <837csb2731.fsf@gnu.org> <837csazff2.fsf@gnu.org> In-Reply-To: <837csazff2.fsf@gnu.org> From: Jeff Norden Date: Sun, 11 Jun 2023 10:44:38 -0500 Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Sun, Jun 11, 2023 at 1:22=E2=80=AFAM Eli Zaretskii wrote: ... > No further comments, so I've now added a new defcustom, called > display-tex-shell-buffer-action, and made its default value be > display-buffer-in-previous-window. With that, I'm closing this bug. Eli: Sorry for the delay. I started to compose this response yesterday, but life intervened before I could finish and send it. Adding a new defcustom would be fine as well. --------------- I suggest just removing the actions from the two display-buffer calls and the pop-top-buffer call in tex-mode.el. I think this is definitely the right thing for the display-buffer calls, which apply to the *tex-buffer* created by `tex-file', etc. This buffer is very much like a *compilation* buffer. In fact, you can do much the same thing as tex-file using "M-x compile" by just changing "make -k" to "tex foo.tex" in the minibuffer. However, a *tex-shell* window works better for parsing errors, etc, since it is set up for TeX. In compile.el, display-buffer is actually called with an action of: '(nil (allow-no-window . t)) but I have no idea why. I can't think of a reason to run TeX on a file and not display the *tex-shell* buffer. The pop-to-buffer call only applies to a docview buffer created for previewing a pdf. This isn't a comint or shell window of any sort. Opening in a new frame might make sense, but I wouldn't suggest changing the behavior right now. ---- It was interesting to use tex-mode under 'emacs -Q', which I haven't done for many years. I've got a number of ideas for fixes and improvements. I'll try to write them up in a cogent way and post to emacs-devel for discussion. There is certainly nothing urgent enough to consider for the (imminent?) emacs-29 release. --------------- More generally: comint derived modes can be, and are, used for a variety of purposes. It seems that the intention of the new defcustom introduced by Sam is that it should apply to ones that provide an interactive shell-type buffer that is independent of other tasks. I wonder if 'display-shell-buffer-action' might be a better name. In any case, I think it would be good for the defcustom doc-string to list the derived modes that use it, so that people would know just what to expect if they customize it. It might even make sense to eventually use it for things like the pop-to-buffer call in `scratch-buffer', since lisp-interaction is a shell in the general sense. Currently, scratch-buffer uses pop-to-buffer-same-window like shell-mode previously did. Thanks, -Jeff From unknown Sun Jun 22 00:55:15 2025 X-Loop: help-debbugs@gnu.org Subject: bug#63956: 29.0.91; tex-mode display problem in emacs-29 Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 11 Jun 2023 16:02:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63956 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Jeff Norden Cc: 63956@debbugs.gnu.org, sds@gnu.org, monnier@iro.umontreal.ca Received: via spool by 63956-submit@debbugs.gnu.org id=B63956.168649930029660 (code B ref 63956); Sun, 11 Jun 2023 16:02:02 +0000 Received: (at 63956) by debbugs.gnu.org; 11 Jun 2023 16:01:40 +0000 Received: from localhost ([127.0.0.1]:37643 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q8NVY-0007iH-MG for submit@debbugs.gnu.org; Sun, 11 Jun 2023 12:01:40 -0400 Received: from eggs.gnu.org ([209.51.188.92]:54164) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q8NVX-0007i2-B7 for 63956@debbugs.gnu.org; Sun, 11 Jun 2023 12:01:36 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q8NVP-0000cW-Bs; Sun, 11 Jun 2023 12:01:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=9bkGVyLcRcgyhMLELAYMPJ6g/F5t3qTByvbOCNr41h8=; b=aEcvvvq7IYYh CQQKoWuWXFseiU5/fnvLCz19Uut1J2W4BYYgC48geLeAQbJweoTZiZlAR/k3vCVfe5F4EPTqODEei 7EDKKSd8IyVNHR7N856I8UxWnDuzSpHQmaQbjzZI7K2hoyjyhIXjuDAozJp+mf9wJNOSboTZ9Qm7+ vsk2pb1bPceo+7YKkfPA15+L6viJnJ4OHFtBCfHkjYf3TkSVT5WJWW3u/f0kUsitxGHv0BGh6sZPl EBq4Ady7B210W+cFBxtUq+KfKfR+iPirkoK0n9inFqax/AbIn/+e/ecnWB8cFr6EF3pTUGisHEefE Feh3JCu2h71WMKmB/Fp/Wg==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q8NVO-0001cF-1r; Sun, 11 Jun 2023 12:01:27 -0400 Date: Sun, 11 Jun 2023 19:01:40 +0300 Message-Id: <83ttvexa1n.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: (message from Jeff Norden on Sun, 11 Jun 2023 10:44:38 -0500) References: <83h6ri2u2i.fsf@gnu.org> <87ttvhkfw7.fsf@gnu.org> <8335313ise.fsf@gnu.org> <87o7lojthj.fsf@gnu.org> <837csb2731.fsf@gnu.org> <837csazff2.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Jeff Norden > Date: Sun, 11 Jun 2023 10:44:38 -0500 > Cc: sds@gnu.org, 63956-done@debbugs.gnu.org, monnier@iro.umontreal.ca > > I suggest just removing the actions from the two display-buffer calls > and the pop-top-buffer call in tex-mode.el. Meanwhile I installed a different fix: there's no a separate defcustom display-tex-shell-buffer-action, whose default should do what you want. If it doesn't do what you want, please tell the details, and let's take it from there. IOW, please try the latest emacs-29 branch of the Emacs Git repository, and see if tex-mode there behaves better. Thanks. From unknown Sun Jun 22 00:55:15 2025 X-Loop: help-debbugs@gnu.org Subject: bug#63956: 29.0.91; tex-mode display problem in emacs-29 Resent-From: Jeff Norden Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 11 Jun 2023 17:33:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63956 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: 63956@debbugs.gnu.org, sds@gnu.org, monnier@iro.umontreal.ca Received: via spool by 63956-submit@debbugs.gnu.org id=B63956.16865047486164 (code B ref 63956); Sun, 11 Jun 2023 17:33:02 +0000 Received: (at 63956) by debbugs.gnu.org; 11 Jun 2023 17:32:28 +0000 Received: from localhost ([127.0.0.1]:37707 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q8OvU-0001bL-C7 for submit@debbugs.gnu.org; Sun, 11 Jun 2023 13:32:28 -0400 Received: from mail-pf1-f176.google.com ([209.85.210.176]:58753) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q8OvS-0001b3-I7 for 63956@debbugs.gnu.org; Sun, 11 Jun 2023 13:32:27 -0400 Received: by mail-pf1-f176.google.com with SMTP id d2e1a72fcca58-65299178ac5so3936431b3a.1 for <63956@debbugs.gnu.org>; Sun, 11 Jun 2023 10:32:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1686504740; x=1689096740; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=r/wli/QYWn917sNhwkzkAxmnIQ8h79pmYFEFof+YDYY=; b=Vr0ncENRfonMrfCnVpgbMPX9ojC+N/zYOdWuuj2eeMc3bg6/RWbmZcG3hNpohYgjOq k5X0PRYJDvYui82hoerkBfowdsjtooW4tCQNW9lwq7hs3xH8fYuWyAEaKJM9JJD/XDcB K8drU7h8V5GZypwL9xxHAiEUzYf5kv6fujeoaF3pvSduDyYuzltouTdfc+fR6rKBhoh3 KS+6Zwyd+6Hc63EKOxZEAG8XKBTeL5L02CNKlmZA3DRiXwa1eDrgQD2z0Y1yXaCc6eFB Qa+w7B85NJVZQd6RPQv8roru6lfsyfph6GvEsS65KgtDdt/ambPpng1q2MqEqigGq9yH 3AhA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686504740; x=1689096740; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=r/wli/QYWn917sNhwkzkAxmnIQ8h79pmYFEFof+YDYY=; b=arBSbsYa0hmByC6QVYGgPc/1mna7D3AeTsU+qIUw2OwkkuONgygIzsJFZHCkwwHanh a+L2BALVggUlwm7iwmW+1qz7ksEc1R+AodUTeG6VJY35QxGYst/N7BvGRzg4vYsXbii/ DlzJ6cN+LzogqSZUqBSyEfU/mJij7J1ma1Zt+LXPC2u5eDlCYn1PqxRobxsfwTrF00XR p+hJGe0PSWF6VX8sf5wBmS3veshMz/xuzCvh6bHJhUuLZve5AoLDQYqoV4G30zZGr/N6 J6dEapvqK/IwWUF1iloBTqhkFPVsFWkNRiCEmPapoamp+Mv4lEHo3CnNO5SzgXMOGlgY SnZw== X-Gm-Message-State: AC+VfDx2LMrhaWAgKDu/lZKrGKjwLJLkEyztPbdQmv4UGI9GBaN1ZhsE W2nkoSBgxu/x7gqvp0GCQjbyL5iM59t+rerGXuQ= X-Google-Smtp-Source: ACHHUZ6BUmHfiWmWCYh+rACVDpis4cO96iGbi7hwnmbCd+1M6p0Sjkp76nmTl0B6QPxJmwKiB2iEP3xr+0q506HmBhA= X-Received: by 2002:a05:6a20:8e28:b0:111:4a86:f70 with SMTP id y40-20020a056a208e2800b001114a860f70mr9008664pzj.6.1686504740524; Sun, 11 Jun 2023 10:32:20 -0700 (PDT) MIME-Version: 1.0 References: <83h6ri2u2i.fsf@gnu.org> <87ttvhkfw7.fsf@gnu.org> <8335313ise.fsf@gnu.org> <87o7lojthj.fsf@gnu.org> <837csb2731.fsf@gnu.org> <837csazff2.fsf@gnu.org> <83ttvexa1n.fsf@gnu.org> In-Reply-To: <83ttvexa1n.fsf@gnu.org> From: Jeff Norden Date: Sun, 11 Jun 2023 12:31:54 -0500 Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Sun, Jun 11, 2023 at 11:01=E2=80=AFAM Eli Zaretskii wrote= : ... > > I suggest just removing the actions from the two display-buffer calls > > and the pop-top-buffer call in tex-mode.el. > > Meanwhile I installed a different fix: there's no a separate defcustom > display-tex-shell-buffer-action, whose default should do what you > want. If it doesn't do what you want, please tell the details, and > let's take it from there. > > IOW, please try the latest emacs-29 branch of the Emacs Git > repository, and see if tex-mode there behaves better. Works fine for me. Using -tex-shell-buffer-action for a docview buffer is perhaps a bit odd, but I'm sure you have more pressing issues to deal with right now. Again, apologies for the delay in responding. -Jeff From unknown Sun Jun 22 00:55:15 2025 X-Loop: help-debbugs@gnu.org Subject: bug#63956: 29.0.91; tex-mode display problem in emacs-29 Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 11 Jun 2023 18:15:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63956 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Jeff Norden , monnier@iro.umontreal.ca Cc: 63956@debbugs.gnu.org, sds@gnu.org Received: via spool by 63956-submit@debbugs.gnu.org id=B63956.168650725910667 (code B ref 63956); Sun, 11 Jun 2023 18:15:02 +0000 Received: (at 63956) by debbugs.gnu.org; 11 Jun 2023 18:14:19 +0000 Received: from localhost ([127.0.0.1]:37734 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q8PZz-0002lz-HR for submit@debbugs.gnu.org; Sun, 11 Jun 2023 14:14:19 -0400 Received: from eggs.gnu.org ([209.51.188.92]:33682) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q8PZv-0002ld-LX for 63956@debbugs.gnu.org; Sun, 11 Jun 2023 14:14:17 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q8PZp-0004KU-MK; Sun, 11 Jun 2023 14:14:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=VKsSnVmioaIvCOnFO+ehtPpsqTQqiqgXLk+MCLKalVs=; b=SWcMk/ZyjaNTA/1WIMrk L7vbXmGYcbCzl/1RHdyLBCAutMgEWikeRCDJcW7zp5m/eljABg0NbRTf3Z/8NSAH7Nvi7cLKJh80A yXD1AbZeRuARlnzS95LAkomWt8/cyo05TlevPGk/jEqdNskG4ZVXZBDZ9XVVpNwiSv6QPhJ/nm91k 25HfqpBLjnqIdKoonXB2iv1fHmFGT2zChVcWKIcV2GZDfDt5pgy9IbDxiRecIuOmyBPwFn21kUvpY 4sXvm+St2SAMwjsuq4L4DiN+LOpfSL76nwUJpVSc6OZnpVfiILeMqJ4LmrYRfVL0tdLU3co0fC/uC UvqN/a+znVEYwA==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q8PZp-0008DE-6P; Sun, 11 Jun 2023 14:14:09 -0400 Date: Sun, 11 Jun 2023 21:14:22 +0300 Message-Id: <83pm61yigx.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: (message from Jeff Norden on Sun, 11 Jun 2023 12:31:54 -0500) References: <83h6ri2u2i.fsf@gnu.org> <87ttvhkfw7.fsf@gnu.org> <8335313ise.fsf@gnu.org> <87o7lojthj.fsf@gnu.org> <837csb2731.fsf@gnu.org> <837csazff2.fsf@gnu.org> <83ttvexa1n.fsf@gnu.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Jeff Norden > Date: Sun, 11 Jun 2023 12:31:54 -0500 > Cc: sds@gnu.org, 63956@debbugs.gnu.org, monnier@iro.umontreal.ca > > On Sun, Jun 11, 2023 at 11:01 AM Eli Zaretskii wrote: > ... > > > I suggest just removing the actions from the two display-buffer calls > > > and the pop-top-buffer call in tex-mode.el. > > > > Meanwhile I installed a different fix: there's no a separate defcustom > > display-tex-shell-buffer-action, whose default should do what you > > want. If it doesn't do what you want, please tell the details, and > > let's take it from there. > > > > IOW, please try the latest emacs-29 branch of the Emacs Git > > repository, and see if tex-mode there behaves better. > > Works fine for me. Great, thanks for testing. > Using -tex-shell-buffer-action for a docview buffer is perhaps a bit > odd You could be right, but I couldn't find any callers of that function, so it was hard for me to reason about that specific case. Stefan, since you introduced tex-cmd-doc-view into tex-mode.el, could you take a look and tell whether using display-tex-shell-buffer-action in its default value there makes sense? If not, what would be a better default? From unknown Sun Jun 22 00:55:15 2025 X-Loop: help-debbugs@gnu.org Subject: bug#63956: 29.0.91; tex-mode display problem in emacs-29 Resent-From: Jeff Norden Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 11 Jun 2023 20:13:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63956 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: 63956@debbugs.gnu.org, sds@gnu.org, monnier@iro.umontreal.ca Received: via spool by 63956-submit@debbugs.gnu.org id=B63956.168651436222885 (code B ref 63956); Sun, 11 Jun 2023 20:13:02 +0000 Received: (at 63956) by debbugs.gnu.org; 11 Jun 2023 20:12:42 +0000 Received: from localhost ([127.0.0.1]:37749 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q8RQX-0005x3-SA for submit@debbugs.gnu.org; Sun, 11 Jun 2023 16:12:42 -0400 Received: from mail-pj1-f49.google.com ([209.85.216.49]:61787) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q8RQW-0005wp-Og for 63956@debbugs.gnu.org; Sun, 11 Jun 2023 16:12:41 -0400 Received: by mail-pj1-f49.google.com with SMTP id 98e67ed59e1d1-25bf202899aso30920a91.3 for <63956@debbugs.gnu.org>; Sun, 11 Jun 2023 13:12:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1686514355; x=1689106355; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=/bWHGPXvHcg6SjxxI7OzJ639twRQQxTg6d134ux7LLs=; b=JiIu+9Xz76p8xK2FhUKV2Q8BpWIiLZcxib1RvVT53dO5WN/TiyAKOXswVGJwm2WRY9 zuNOMmuH0qOTy9D2QXrv3vNFnlPL7MN7ToVatYKyVwx2Ve2WdsaZswvH5IahjAGlSPad o6RdSMtylJBn7flAWZTsnNy580PgauaEPa7ut/XxAAYwVS+4DruV7Vm0bNACugS8ZYoI ov1c4cBM/k2johR4z217kkEXTQV4HTAAo3Og1zUuK+SnDNMFI47L+BeZyEu+wXgCc4i9 YYIvI0JtfBqjQpXG1zNf+lsDHS4FI+cDgT4GNLP1d0g6WMc/APk56z/NHLCh7HyKbH1Q Ed6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686514355; x=1689106355; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=/bWHGPXvHcg6SjxxI7OzJ639twRQQxTg6d134ux7LLs=; b=Tfbu7Mfa1ni8i1UoS6awUO8Wk1Lybcv9XZaXSgMVxMCas7g4PCmizuA/RkEIEMCQWu GodXQvzX/6V8CL1IAeKtXNE7sUJl5mk/IuGbqBrg0LaqzM/OBuRe8EQg6kJHdCpcpjpb 2CMYRCQphmZX5DlI0+qYv5bPHwTOKF1MN2roSi5WiqOhgV7mHslGO0u1iFneH4qbimJH bQxRjThsHoDaEkSz4kwa1vTzI5T78zHd2iKnlsmENH+53Q4Ohc+4WBC+GoYlWH2msWCy VtvmIjeLMFIypD1B8C4ECIX75oJDyARf+IB/CEYE4b2vW+Xae2QeHS5vjB8Z/qarDWRB 7aXA== X-Gm-Message-State: AC+VfDyfUXnviTmm+o5n+eX6VzurPvHj+vF6rxsycioOTgzDNzVcSka6 7odZwcD2RcF4/CI2irrDzSmgNvYj3UsSeviiCaY= X-Google-Smtp-Source: ACHHUZ4ZPtwCekvhy3jo9I+W9tVRcff6VLnc+eAuHvjEWqZ/UH4Q1rCEl0aNSbXI7yzI3eGqc/9abJd/mDYeEo6V01c= X-Received: by 2002:a17:90a:194e:b0:259:3e7f:c60d with SMTP id 14-20020a17090a194e00b002593e7fc60dmr6210344pjh.3.1686514354696; Sun, 11 Jun 2023 13:12:34 -0700 (PDT) MIME-Version: 1.0 References: <83h6ri2u2i.fsf@gnu.org> <87ttvhkfw7.fsf@gnu.org> <8335313ise.fsf@gnu.org> <87o7lojthj.fsf@gnu.org> <837csb2731.fsf@gnu.org> <837csazff2.fsf@gnu.org> <83ttvexa1n.fsf@gnu.org> <83pm61yigx.fsf@gnu.org> In-Reply-To: <83pm61yigx.fsf@gnu.org> From: Jeff Norden Date: Sun, 11 Jun 2023 15:12:08 -0500 Message-ID: Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Sun, Jun 11, 2023 at 1:14 PM Eli Zaretskii wrote: > ... > > Using -tex-shell-buffer-action for a docview buffer is perhaps a bit > > odd > > You could be right, but I couldn't find any callers of that function, > so it was hard for me to reason about that specific case. Stefan, > since you introduced tex-cmd-doc-view into tex-mode.el, could you take > a look and tell whether using display-tex-shell-buffer-action in its > default value there makes sense? If not, what would be a better > default? Took me a bit to figure that out. Choosing the docview option from `tex-compile' results in pre-pending "tex-cmd-" to "doc-view" and then calling `tex-cmd-doc-view', which simply opens the pdf file (in docview mode) with pop-to-buffer. The other tex-compile commands that preview the document do so by running an external program such as ghostview or xdvi. That is why I was thinking that opening in a new frame might be appropriate. I've never used tex-compile, and I wonder if it gets much use in general. One of the ideas I was thinking of was adding it as a sub-menu of the TeX menubar entry, which would make it easier to use. Another thing, which I now realize is already listed as a 'fixme' item in tex-mode.el, is to check that, e.g., the corresponding pdf file is up to date (newer than the tex source) before previewing it. -Jeff From unknown Sun Jun 22 00:55:15 2025 X-Loop: help-debbugs@gnu.org Subject: bug#63956: 29.0.91; tex-mode display problem in emacs-29 Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 12 Jun 2023 11:50:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63956 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Jeff Norden , Stefan Monnier Cc: 63956@debbugs.gnu.org, sds@gnu.org Received: via spool by 63956-submit@debbugs.gnu.org id=B63956.1686570542694 (code B ref 63956); Mon, 12 Jun 2023 11:50:02 +0000 Received: (at 63956) by debbugs.gnu.org; 12 Jun 2023 11:49:02 +0000 Received: from localhost ([127.0.0.1]:39115 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q8g2f-0000At-Dw for submit@debbugs.gnu.org; Mon, 12 Jun 2023 07:49:02 -0400 Received: from eggs.gnu.org ([209.51.188.92]:43476) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q8g2b-0000AT-5i for 63956@debbugs.gnu.org; Mon, 12 Jun 2023 07:49:00 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q8g2U-0000SM-Qg; Mon, 12 Jun 2023 07:48:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=85N9rOpfR65SfxXzWTzJKt7uUNq5j4/6vt8E3InidmY=; b=sPP/PUWOtzIY Lao6nbefogBYZcYlaQL130DeFU/bwpApNjrCAD4GAkNl4aBXhoEehPecB/FBJ3oD9aaaNBJO0UAgP XVjRpMQcdQVvuwJL5UJYJ+Da2hEigFYuguR6LGu7x5WzhX7B6sGzv8pLAdp1C+8FgIFV2gauefSfj AnbGRZ4aHA/kd5oDJ1PHkpibprMJDmeeDI5oo1rP/Kue+yZRqXX9l/JQzfw/MRiC+Si/FnXSRbRpe dcYV+NPR+is76TuLUgiZTdqxgrpr6gWxy5hw3xUwQI9W8GPSiyPlEsqBSYQf9Ut8Yls5+0rcAVwIz Dsa79GL73nTR0yQU0U5OiA==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q8g2U-0005T6-9H; Mon, 12 Jun 2023 07:48:50 -0400 Date: Mon, 12 Jun 2023 14:49:05 +0300 Message-Id: <83legoyk7i.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: (message from Jeff Norden on Sun, 11 Jun 2023 15:12:08 -0500) References: <83h6ri2u2i.fsf@gnu.org> <87ttvhkfw7.fsf@gnu.org> <8335313ise.fsf@gnu.org> <87o7lojthj.fsf@gnu.org> <837csb2731.fsf@gnu.org> <837csazff2.fsf@gnu.org> <83ttvexa1n.fsf@gnu.org> <83pm61yigx.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Jeff Norden > Date: Sun, 11 Jun 2023 15:12:08 -0500 > Cc: monnier@iro.umontreal.ca, sds@gnu.org, 63956@debbugs.gnu.org > > On Sun, Jun 11, 2023 at 1:14 PM Eli Zaretskii wrote: > > ... > > > Using -tex-shell-buffer-action for a docview buffer is perhaps a bit > > > odd > > > > You could be right, but I couldn't find any callers of that function, > > so it was hard for me to reason about that specific case. Stefan, > > since you introduced tex-cmd-doc-view into tex-mode.el, could you take > > a look and tell whether using display-tex-shell-buffer-action in its > > default value there makes sense? If not, what would be a better > > default? > > Took me a bit to figure that out. Choosing the docview option from > `tex-compile' results in pre-pending "tex-cmd-" to "doc-view" and then > calling `tex-cmd-doc-view', which simply opens the pdf file (in > docview mode) with pop-to-buffer. OK, thanks. But did you see any difference between doing this the way Emacs 28 did (without 2nd argument to pop-to-buffer) and the way the code now does on the emacs-29 branch? IOW, does this scenario produce reasonable results after my recent changes? > The other tex-compile commands that > preview the document do so by running an external program such as > ghostview or xdvi. That is why I was thinking that opening in a new > frame might be appropriate. > > I've never used tex-compile, and I wonder if it gets much use in > general. One of the ideas I was thinking of was adding it as a > sub-menu of the TeX menubar entry, which would make it easier to use. > Another thing, which I now realize is already listed as a 'fixme' item > in tex-mode.el, is to check that, e.g., the corresponding pdf file is > up to date (newer than the tex source) before previewing it. Stefan, your comments on this, and in particular on the tex-cmd-doc-view function, will be appreciated. From unknown Sun Jun 22 00:55:15 2025 X-Loop: help-debbugs@gnu.org Subject: bug#63956: 29.0.91; tex-mode display problem in emacs-29 Resent-From: Jeff Norden Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 12 Jun 2023 16:43:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63956 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: 63956@debbugs.gnu.org, sds@gnu.org, Stefan Monnier Received: via spool by 63956-submit@debbugs.gnu.org id=B63956.1686588133865 (code B ref 63956); Mon, 12 Jun 2023 16:43:01 +0000 Received: (at 63956) by debbugs.gnu.org; 12 Jun 2023 16:42:13 +0000 Received: from localhost ([127.0.0.1]:40433 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q8kcP-0000Dt-Ay for submit@debbugs.gnu.org; Mon, 12 Jun 2023 12:42:13 -0400 Received: from mail-pg1-f177.google.com ([209.85.215.177]:61732) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q8kcJ-0000Db-Bb for 63956@debbugs.gnu.org; Mon, 12 Jun 2023 12:42:11 -0400 Received: by mail-pg1-f177.google.com with SMTP id 41be03b00d2f7-53fb4ee9ba1so2265651a12.3 for <63956@debbugs.gnu.org>; Mon, 12 Jun 2023 09:42:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1686588121; x=1689180121; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=TzpxLGr93aGGUQs1VTPndv38oDW/ctZi1ZJFXfZO96A=; b=K7crrfRTDh/inqHUufQRAmcP0Saxna4yrwqWwXPOK7Uzkxs7UhqL01ol6vCyDpDP78 EPaOFvP46Cw/0Zehed43Xm8jO9cpfUX33sLJHWPThvlU/zISh4XJV0Y8SlDAnEqI1ZPh g49ndIbEi61W1vu3fqo0iU0osFEC2fPC9bsqKVhJ0mqtxlREav8t3WJeyDwKrCfTSDk2 6VBh5ziN58aUW7zemayN04yoOfqBLC5FomURcpVLj8UAQGT2LBhgEyc21l8NqU3eF/fg f8NBdYrSo+yVr7/0jYUVvWmjzN4A0kECGW8OPYC0C8XZ5luBDUflfRuYzes0ZgYeOS1W 1N2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686588121; x=1689180121; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=TzpxLGr93aGGUQs1VTPndv38oDW/ctZi1ZJFXfZO96A=; b=h8xQjzvAKBd+cCNQ1eQkwNBVOMNFOkeuh/ehdp7QJuYk4r0rMiOqROtunxJPSmeLDt kF8Np7DK08a5092HH+LgevEenbaAhb3aJLCI30RG0G7MvQJs8mgIGNiNDAZiL2J2706i P7pO7hrGbajPP9xX0e0kn0C/f1PKZxMV+CQF94nSNAjDYlOKUIZ47kCA73Xv7x9Cr207 pXoHM83EJlffDPAcAPX2R2WMT4Ih7iUyrMp4iqoqjKFe1ir4oCubdCo3iSWrMDXdWSww X7p1eok/lg4H4IHM6TBaEp8DasXrbuvf5Xk72hAPtLOBi82hdr9LEIKCASVmbFamDGGg lyWg== X-Gm-Message-State: AC+VfDzorDEczWKRNxZzdMTb22Fbh4u1YEKnqe94WtYZou3M3WIm15OR Cu8yuo1QjuflBIWRDgNZNB95O89bnzBVDkRdgRQ= X-Google-Smtp-Source: ACHHUZ5ZQk7O6IER+FoDgIFsPSPQ9SRdpJYTlm6dRk6kCvUooWAErR4z7ZDmeA3vY0MEbrZNMp4P4bU2oPJ0TA38w5M= X-Received: by 2002:a17:90a:352:b0:25b:f289:c4f3 with SMTP id 18-20020a17090a035200b0025bf289c4f3mr1847171pjf.30.1686588121178; Mon, 12 Jun 2023 09:42:01 -0700 (PDT) MIME-Version: 1.0 References: <83h6ri2u2i.fsf@gnu.org> <87ttvhkfw7.fsf@gnu.org> <8335313ise.fsf@gnu.org> <87o7lojthj.fsf@gnu.org> <837csb2731.fsf@gnu.org> <837csazff2.fsf@gnu.org> <83ttvexa1n.fsf@gnu.org> <83pm61yigx.fsf@gnu.org> <83legoyk7i.fsf@gnu.org> In-Reply-To: <83legoyk7i.fsf@gnu.org> From: Jeff Norden Date: Mon, 12 Jun 2023 11:41:34 -0500 Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Mon, Jun 12, 2023 at 6:48=E2=80=AFAM Eli Zaretskii wrote: > OK, thanks. But did you see any difference between doing this the way > Emacs 28 did (without 2nd argument to pop-to-buffer) and the way the > code now does on the emacs-29 branch? IOW, does this scenario produce > reasonable results after my recent changes? The default behavior in emacs-29 is now the same as it was in 28.2, so I don't see any need to make further changes at this point. --- If my (admittedly limited) understanding of display buffer actions is correct, then calling display-buffer or pop-to-buffer with a 'reuse-window' action would only differ from a call without any action if either: (a) display-buffer-base-action has been customized, or (b) the buffer name has been listed in same-window-buffer-names or matches same-window-regexps This assumes that display-buffer-fallback-action has its default value, which it should since it is defined with defconst in window.el: (defconst display-buffer-fallback-action '((display-buffer--maybe-same-window ;FIXME: why isn't this redundant? display-buffer-reuse-window display-buffer--maybe-pop-up-frame-or-window display-buffer-in-previous-window display-buffer-use-some-window ;; If all else fails, pop up a new frame. display-buffer-pop-up-frame)) Perhaps this answers the question in the above code, --maybe-same-window seems to be for backwards compatibility to allow the use of the same-window- variables, which pre-date window actions. Using display-buffer-alist is the recommended way to do things now, and gets first priority. Thanks, -Jeff From unknown Sun Jun 22 00:55:15 2025 X-Loop: help-debbugs@gnu.org Subject: bug#63956: 29.0.91; tex-mode display problem in emacs-29 Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 12 Jun 2023 16:45:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63956 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Jeff Norden Cc: 63956@debbugs.gnu.org, sds@gnu.org, monnier@iro.umontreal.ca Received: via spool by 63956-submit@debbugs.gnu.org id=B63956.16865882881100 (code B ref 63956); Mon, 12 Jun 2023 16:45:01 +0000 Received: (at 63956) by debbugs.gnu.org; 12 Jun 2023 16:44:48 +0000 Received: from localhost ([127.0.0.1]:40438 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q8ket-0000Hg-RS for submit@debbugs.gnu.org; Mon, 12 Jun 2023 12:44:48 -0400 Received: from eggs.gnu.org ([209.51.188.92]:46624) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q8keo-0000HP-SP for 63956@debbugs.gnu.org; Mon, 12 Jun 2023 12:44:46 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q8kef-0000Ls-TJ; Mon, 12 Jun 2023 12:44:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=B8yruZBzujUU2/psAQGfNGJ33ZotrNhggwowjMKN9/w=; b=QAIx+jBC047PLV6iCiVl gegygGLizvPf1oz57VqOTqB96+yr4ziu4Z7y2KT1nx0/svWdFAwWkuZZVxoG0QYNHZYgYAOxPN1xW TBiNNHbtAtpg7em0xSjQGtybJW2FpLJ/tmoRt2A078ABRJ2rYq/aITdAMpO75QwAm/vDzrdhA055z /y5WEoF8UAtOXbbPliBhOAmlDPWQvxqqye0TNXXQ8jNEoQhsnaaDf3sFSprSepORvW0hKTS/dICpU PHthB1wLOdWxktDP9/NnDjJ1JfthsmkOhi+T15lty/CXnQPt+cK1UND0eTnlzDqiAHP1079Pg5kWq yk/aMJG/adXAvg==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q8kee-0002jv-Od; Mon, 12 Jun 2023 12:44:33 -0400 Date: Mon, 12 Jun 2023 19:44:49 +0300 Message-Id: <831qigy6im.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: (message from Jeff Norden on Mon, 12 Jun 2023 11:41:34 -0500) References: <83h6ri2u2i.fsf@gnu.org> <87ttvhkfw7.fsf@gnu.org> <8335313ise.fsf@gnu.org> <87o7lojthj.fsf@gnu.org> <837csb2731.fsf@gnu.org> <837csazff2.fsf@gnu.org> <83ttvexa1n.fsf@gnu.org> <83pm61yigx.fsf@gnu.org> <83legoyk7i.fsf@gnu.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Jeff Norden > Date: Mon, 12 Jun 2023 11:41:34 -0500 > Cc: Stefan Monnier , sds@gnu.org, 63956@debbugs.gnu.org > > On Mon, Jun 12, 2023 at 6:48 AM Eli Zaretskii wrote: > > OK, thanks. But did you see any difference between doing this the way > > Emacs 28 did (without 2nd argument to pop-to-buffer) and the way the > > code now does on the emacs-29 branch? IOW, does this scenario produce > > reasonable results after my recent changes? > > The default behavior in emacs-29 is now the same as it was in 28.2, so I > don't see any need to make further changes at this point. Thanks, good to know. I'll leave it to display-buffer experts to comment on the other point you made. From unknown Sun Jun 22 00:55:15 2025 X-Loop: help-debbugs@gnu.org Subject: bug#63956: 29.0.91; tex-mode display problem in emacs-29 Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 13 Jun 2023 01:35:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63956 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: 63956@debbugs.gnu.org, Jeff Norden , sds@gnu.org Received: via spool by 63956-submit@debbugs.gnu.org id=B63956.168662007229936 (code B ref 63956); Tue, 13 Jun 2023 01:35:01 +0000 Received: (at 63956) by debbugs.gnu.org; 13 Jun 2023 01:34:32 +0000 Received: from localhost ([127.0.0.1]:41006 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q8svX-0007mk-PZ for submit@debbugs.gnu.org; Mon, 12 Jun 2023 21:34:32 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:10479) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q8svT-0007mT-Qy for 63956@debbugs.gnu.org; Mon, 12 Jun 2023 21:34:31 -0400 Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 72439442A86; Mon, 12 Jun 2023 21:34:22 -0400 (EDT) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 0F9F8442A7D; Mon, 12 Jun 2023 21:34:21 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1686620061; bh=NLwzsBiaDsBXTke0hjtpcfB2ihfupuYL7zBfiNPsHN4=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=D5goovHy/E1PvmAF+Lj03dJI6VCQ0aT/jXGU4/oyw60tvjSngwZReV12X88Ga2cf1 rgwUtr22hOBhs7vCarE52dhCV5cTRynWtc/pvryc8QNIF9URrkHuQYt3MaeKOj/B2A DmGXt9nO0c2FBp9jtXiu+nUc/rLMOYXVA0penD2Bn3VIsqCqcM6IsOIDIggeb+OfV7 cC9srj18fgEBUZSRNuLEbVBmY/saBiIAFmTsz7mFzKuO5ey63JSljOtvG+KIJLAtGX vdSqA88mJd1qB34yOnUC7X9J4x66zS7QXPNCTypIfwaCt7THDkpHmzrb8vv11rPU7r WItFeEeC4z2jw== Received: from pastel (76-10-180-239.dsl.teksavvy.com [76.10.180.239]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id CC6D21204BA; Mon, 12 Jun 2023 21:34:20 -0400 (EDT) From: Stefan Monnier In-Reply-To: <83pm61yigx.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 11 Jun 2023 21:14:22 +0300") Message-ID: References: <83h6ri2u2i.fsf@gnu.org> <87ttvhkfw7.fsf@gnu.org> <8335313ise.fsf@gnu.org> <87o7lojthj.fsf@gnu.org> <837csb2731.fsf@gnu.org> <837csazff2.fsf@gnu.org> <83ttvexa1n.fsf@gnu.org> <83pm61yigx.fsf@gnu.org> Date: Mon, 12 Jun 2023 21:34:19 -0400 User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.152 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain KAM_NUMSUBJECT 0.5 Subject ends in numbers excluding current years T_SCC_BODY_TEXT_LINE -0.01 - X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > You could be right, but I couldn't find any callers of that function, > so it was hard for me to reason about that specific case. Stefan, > since you introduced tex-cmd-doc-view into tex-mode.el, could you take > a look and tell whether using display-tex-shell-buffer-action in its > default value there makes sense? If not, what would be a better > default? Hmm... when I introduced `tex-cmd-doc-view` it just used (pop-to-buffer (find-file-noselect file)) then when Sam Steingold introduced `display-comint-buffer-action` (in commit 18b680cfd177) he used it there as well, but I suspect this was a mistake because that command does not at all work like a comint thingy (my guess is that he's an AUCTeX user and just assumed that `tex-cmd-doc-view` is like other `tex-cmd-*` thingies). I'm not sure it's harmful to use `display-comint-buffer-action` or `display-tex-shell-buffer-action` there (e.g. I haven't noticed it being a problem in my own use since Sam's patch), but it doesn't seem necessary nor very natural (it's just not a "tex-shell" or "comint" buffer, it's a normal file buffer). Stefan From unknown Sun Jun 22 00:55:15 2025 X-Loop: help-debbugs@gnu.org Subject: bug#63956: 29.0.91; tex-mode display problem in emacs-29 Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 13 Jun 2023 11:14:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63956 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Stefan Monnier Cc: 63956@debbugs.gnu.org, norden.jeff@gmail.com, sds@gnu.org Received: via spool by 63956-submit@debbugs.gnu.org id=B63956.168665478627650 (code B ref 63956); Tue, 13 Jun 2023 11:14:01 +0000 Received: (at 63956) by debbugs.gnu.org; 13 Jun 2023 11:13:06 +0000 Received: from localhost ([127.0.0.1]:41455 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q91xQ-0007Bs-Pt for submit@debbugs.gnu.org; Tue, 13 Jun 2023 07:13:06 -0400 Received: from eggs.gnu.org ([209.51.188.92]:47248) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q91xL-0007BH-TL for 63956@debbugs.gnu.org; Tue, 13 Jun 2023 07:13:03 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q91x1-0004iX-HU; Tue, 13 Jun 2023 07:12:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=e4jRUNI4KQrXCQZMYG9ij2iT/+mu4+I5saD2Xi81I9g=; b=SJMka1cRyzaL 7WnIZq8/PIP2/AgXzJaDsQqeqPjdxAtc2UvXsfEecPgrXY4E0QCLkj6EoKCEf/G9vhwOe5sK01jCC mEnOeGoehi+Djk2NBcG+i/hao8F/YZj8efxa1TrVVXutHqv5mgxv8hK9ED36dPmETzw1bPMUOIUzF YhKOkNPTqLNjnEwxJIVsgfs+LntkDg6wqECgvpU3sR342UU1Pypv+gcc6dCR/QlEYI4bxkPS3zy1r Scqdsy3gGIuQeU+oHkpMV8wyOHjn8gRjNgs2V01z0pcdZdyz03d0fXGSaFcRDdiYuFxXP72Q0KSv9 z1n2QfutUyXuHcUASrcQAg==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q91x0-0000l3-Ri; Tue, 13 Jun 2023 07:12:39 -0400 Date: Tue, 13 Jun 2023 14:12:56 +0300 Message-Id: <83mt13wr7r.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: (message from Stefan Monnier on Mon, 12 Jun 2023 21:34:19 -0400) References: <83h6ri2u2i.fsf@gnu.org> <87ttvhkfw7.fsf@gnu.org> <8335313ise.fsf@gnu.org> <87o7lojthj.fsf@gnu.org> <837csb2731.fsf@gnu.org> <837csazff2.fsf@gnu.org> <83ttvexa1n.fsf@gnu.org> <83pm61yigx.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Stefan Monnier > Cc: Jeff Norden , sds@gnu.org, 63956@debbugs.gnu.org > Date: Mon, 12 Jun 2023 21:34:19 -0400 > > Hmm... when I introduced `tex-cmd-doc-view` it just used > > (pop-to-buffer (find-file-noselect file)) > > then when Sam Steingold introduced `display-comint-buffer-action` (in > commit 18b680cfd177) he used it there as well, but I suspect this was > a mistake because that command does not at all work like a comint thingy > (my guess is that he's an AUCTeX user and just assumed that > `tex-cmd-doc-view` is like other `tex-cmd-*` thingies). > > I'm not sure it's harmful to use `display-comint-buffer-action` or > `display-tex-shell-buffer-action` there (e.g. I haven't noticed it being > a problem in my own use since Sam's patch), but it doesn't seem > necessary nor very natural (it's just not a "tex-shell" or "comint" > buffer, it's a normal file buffer). Thanks, I removed the 2nd argument of pop-to-buffer there.