From unknown Sun Jun 22 11:33:07 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#63952 <63952@debbugs.gnu.org> To: bug#63952 <63952@debbugs.gnu.org> Subject: Status: [PATCH] gnu (hubbub): Fix build Reply-To: bug#63952 <63952@debbugs.gnu.org> Date: Sun, 22 Jun 2025 18:33:07 +0000 retitle 63952 [PATCH] gnu (hubbub): Fix build reassign 63952 guix-patches submitter 63952 Andy Tai severity 63952 normal tag 63952 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 07 22:22:33 2023 Received: (at submit) by debbugs.gnu.org; 8 Jun 2023 02:22:33 +0000 Received: from localhost ([127.0.0.1]:55249 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q75IH-0007rM-31 for submit@debbugs.gnu.org; Wed, 07 Jun 2023 22:22:33 -0400 Received: from lists.gnu.org ([209.51.188.17]:42230) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q75IC-0007rB-1a for submit@debbugs.gnu.org; Wed, 07 Jun 2023 22:22:31 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q75IB-0000Xd-PQ for guix-patches@gnu.org; Wed, 07 Jun 2023 22:22:27 -0400 Received: from mail-oi1-x234.google.com ([2607:f8b0:4864:20::234]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1q75I9-0003vq-Sn for guix-patches@gnu.org; Wed, 07 Jun 2023 22:22:27 -0400 Received: by mail-oi1-x234.google.com with SMTP id 5614622812f47-39aa8256db7so95974b6e.0 for ; Wed, 07 Jun 2023 19:22:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1686190944; x=1688782944; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:sender:from:to:cc:subject:date:message-id:reply-to; bh=SDJS93ZffqpBRC/TlxJ/5sfgsgDu56Ib0iww/cYJxaA=; b=RTvgr5cgiXUusRvpaTtg9Tnu/DUO/0AtT7b+GABjXdoDiSBbwFU363roStVZFFuJ2h Q9mbhLhFLnHTLfOsto5YxGcku9MaqnjBPTZNAGL3jZppG7oYg4yL6+FUnxVyFtZLZJVM n3humyTco1/l42FilpqABbUyrW1N8JKRv3sOEXkU0AcrRnPsENi408j0DLPa7w9ORuOP urCXH+mRBITIzCv8p9FYKT5/sIzk5Zkt0iis6g6OOjzvZGKn+JY343AXxyD7LFoV0w3W oeLqFt2H+g8k/aNLqWyECMtgQGNYk9xHBcOG0MAyNBl1P7aC0N11+vxCwsN5szPhLaYS ipSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686190944; x=1688782944; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:sender:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=SDJS93ZffqpBRC/TlxJ/5sfgsgDu56Ib0iww/cYJxaA=; b=PWG7zXPBd7dKHS50ISGo2PUylb45jNKADbZKup9SAFJmauiQTGOFzzvkpU+e/EXl2H UKa5ahIUTvxy63RL+uvN9bpHC7Vrmy42mCGn2h4dGzOIcq6qpdFV5QfSK3EpcE43BC5V 1AnpZ4PlaznuikuZSDKrC+qN7NzdFW4m+vU1S5SJMEs/8Q5r0UK5OZCU5I8BY1NAz3I1 NuA56/Ti7ld7ZlEmcGFR/zs61j1gQ+GzHM37Jx+mTqlHTya2H4f194wAs0rxTOvknvnA DmtLRoMNVPSmKh48VN+ee/bAwxKxuPSlf0+ajve06Z7MCrP1oTLRF6wFz2+0Nysf55hF 9r3A== X-Gm-Message-State: AC+VfDxh/qNJyyhnr6DVIwoLbhjQigimDE/kVPsY3DYiExT3JCK4zRto oLqbtWXqXTsx3Vrt7IiiLUFHuJMWHqk= X-Google-Smtp-Source: ACHHUZ7/zGGZvhWVbWXRJhMztbecz46yzJTLbrM/zQO3qDwdfsZDDlj/IcQ6W+nsdubgf7vjzESHfw== X-Received: by 2002:a05:6808:911:b0:398:59be:99a2 with SMTP id w17-20020a056808091100b0039859be99a2mr7032744oih.32.1686190943898; Wed, 07 Jun 2023 19:22:23 -0700 (PDT) Received: from localhost.localdomain ([98.37.226.98]) by smtp.googlemail.com with ESMTPSA id b16-20020a17090a551000b0024e026444b6sm3877152pji.2.2023.06.07.19.22.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Jun 2023 19:22:23 -0700 (PDT) From: Andy Tai To: guix-patches@gnu.org Subject: [PATCH] gnu (hubbub): Fix build Date: Wed, 7 Jun 2023 19:22:20 -0700 Message-Id: X-Mailer: git-send-email 2.40.1 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2607:f8b0:4864:20::234; envelope-from=lichengtai@gmail.com; helo=mail-oi1-x234.google.com X-Spam_score_int: -14 X-Spam_score: -1.5 X-Spam_bar: - X-Spam_report: (-1.5 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.25, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.25, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.1 (-) X-Debbugs-Envelope-To: submit Cc: Andy Tai X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.1 (--) Fix for https://debbugs.gnu.org/cgi/bugreport.cgi?bug=63526 * gnu/packages/web.scm (hubbub): [source](patches): Add patch to fix build. * gnu/packages/patches/hubbub-prevent-Werror-maybe-uninitialized-build-failure-wit.patch: New file * gnu/local.mk (dist_patch_DATA): Add it. --- gnu/local.mk | 2 + ...aybe-uninitialized-build-failure-wit.patch | 40 +++++++++++++++++++ gnu/packages/web.scm | 4 +- 3 files changed, 45 insertions(+), 1 deletion(-) create mode 100644 gnu/packages/patches/hubbub-prevent-Werror-maybe-uninitialized-build-failure-wit.patch diff --git a/gnu/local.mk b/gnu/local.mk index 254037a3af..099e653707 100644 --- a/gnu/local.mk +++ b/gnu/local.mk @@ -58,6 +58,7 @@ # Copyright © 2022 jgart # Copyright © 2023 Zheng Junjie <873216071@qq.com> # Copyright © 2023 Ivana Drazovic +# Copyright © 2023 Andy Tai # # This file is part of GNU Guix. # @@ -1353,6 +1354,7 @@ dist_patch_DATA = \ %D%/packages/patches/http-parser-CVE-2020-8287.patch \ %D%/packages/patches/htslib-for-stringtie.patch \ %D%/packages/patches/hubbub-sort-entities.patch \ + %D%/packages/patches/hubbub-prevent-Werror-maybe-uninitialized-build-failure-wit.patch \ %D%/packages/patches/hueplusplus-mbedtls.patch \ %D%/packages/patches/hurd-add-without-rump-configure-option.patch \ %D%/packages/patches/hurd-fix-types-of-read-write-and-readables-methods-2.patch \ diff --git a/gnu/packages/patches/hubbub-prevent-Werror-maybe-uninitialized-build-failure-wit.patch b/gnu/packages/patches/hubbub-prevent-Werror-maybe-uninitialized-build-failure-wit.patch new file mode 100644 index 0000000000..6f289a770e --- /dev/null +++ b/gnu/packages/patches/hubbub-prevent-Werror-maybe-uninitialized-build-failure-wit.patch @@ -0,0 +1,40 @@ +From 69d81a8a4d4c223aad67cde0fdf64d64351b9802 Mon Sep 17 00:00:00 2001 +From: Andy Tai +Date: Sat, 27 May 2023 00:01:34 -0700 +Subject: [PATCH] prevent -Werror=maybe-uninitialized build failure with gcc 11 + when building tests tokeniser2 and tokeniser3 + +--- + test/tokeniser2.c | 2 +- + test/tokeniser3.c | 2 +- + 2 files changed, 2 insertions(+), 2 deletions(-) + +diff --git a/test/tokeniser2.c b/test/tokeniser2.c +index c8ab9c0..4caae38 100644 +--- a/test/tokeniser2.c ++++ b/test/tokeniser2.c +@@ -438,7 +438,7 @@ hubbub_error token_handler(const hubbub_token *token, void *pw) + /* Expected token only contained part of the data + * Calculate how much is left, then try again with + * the next expected token */ +- hubbub_token t; ++ hubbub_token t = { 0 }; + + t.type = HUBBUB_TOKEN_CHARACTER; + t.data.character.ptr += len; +diff --git a/test/tokeniser3.c b/test/tokeniser3.c +index e33d018..b3be901 100644 +--- a/test/tokeniser3.c ++++ b/test/tokeniser3.c +@@ -447,7 +447,7 @@ hubbub_error token_handler(const hubbub_token *token, void *pw) + /* Expected token only contained part of the data + * Calculate how much is left, then try again with + * the next expected token */ +- hubbub_token t; ++ hubbub_token t = { 0 }; + + t.type = HUBBUB_TOKEN_CHARACTER; + t.data.character.ptr += len; +-- +2.40.1 + diff --git a/gnu/packages/web.scm b/gnu/packages/web.scm index 3af4aa0b8d..387ceac058 100644 --- a/gnu/packages/web.scm +++ b/gnu/packages/web.scm @@ -5242,7 +5242,9 @@ (define-public hubbub (sha256 (base32 "1dimfyblmym98qa1b80c5jslv2zk8r44xbdrgrsrw1n9wr9y4yly")) - (patches (search-patches "hubbub-sort-entities.patch")))) + (patches (search-patches + "hubbub-sort-entities.patch" + "hubbub-prevent-Werror-maybe-uninitialized-build-failure-wit.patch")))) (build-system gnu-build-system) (native-inputs (list netsurf-buildsystem base-commit: e8f9fb3e03ea8fee0e13f13706a6b16414f74a7b -- 2.40.1 From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 07 23:35:40 2023 Received: (at control) by debbugs.gnu.org; 8 Jun 2023 03:35:40 +0000 Received: from localhost ([127.0.0.1]:55282 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q76R1-0003mq-S4 for submit@debbugs.gnu.org; Wed, 07 Jun 2023 23:35:40 -0400 Received: from mail-qt1-f170.google.com ([209.85.160.170]:50308) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q76R0-0003ma-87 for control@debbugs.gnu.org; Wed, 07 Jun 2023 23:35:39 -0400 Received: by mail-qt1-f170.google.com with SMTP id d75a77b69052e-3f9b5ec058aso1344931cf.0 for ; Wed, 07 Jun 2023 20:35:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=atai-org.20221208.gappssmtp.com; s=20221208; t=1686195332; x=1688787332; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :from:to:cc:subject:date:message-id:reply-to; bh=TlHlP9tpuSZczBPkP4bz9MJApkeCXpWDaWGhiEaMfSk=; b=uK/Yb+qBKaahpOrZ7vLpUjnynOQewkNuKUvy0kr6tP5e/8lGPFnG/oGT7tQTw4om7X Q4hunydzy6P2Z8/FHyMj6kICFhq+tXnPNwAjhfr6yHkqhaHHiCSlQkP05YeHfbpZG9cg IEY9g8qf1RsrjZG3gEbMjKIN5og697bCTrEQHT/Zu9cucgdmodIQcf8z53rihUtvcvQY IGrDUteqO8Bz6D1/9oTaXiBtZyE1HNSALCCXgiNfW3zhEJq4R+jgSfGCTPizBF7Fi6Fp EtP76SFjRrxcF63Bn1MdMafCnZZrcCwSll8jU6EmccLLh6VJAKSNmTUubpogrDOTQgsb KMOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686195332; x=1688787332; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=TlHlP9tpuSZczBPkP4bz9MJApkeCXpWDaWGhiEaMfSk=; b=WEJedhrwO99b/rNbx2ca9DA7iC9N6YaR6h42fympF3lL1PaXKjJTid63wWmGUVfm0H rKAnRqScR0upJkd12iX4N2312fp6HEXizjJjfesXRL3zXo6vLtGo3RapSArcuygkz1Q1 COWxdQkHTMtuQWtSNy3Yc1nsaB80l3kyug2e0Cixrbbm+sK1E4TTsO2uGW9Lwe1AOxUk eZ0lEsGxz7pDjecsJKv3CNQmyr9YVFJWUXucbS1ud/X3A+NiTkNU/yp5KmFu9nfMLJ4i u/m2Fz2TOm/c/uOQy3gbZB1Q4CULGXkanV1B6KtiecJR+UroBGJVwl9aY+v7FgRghCzr z62w== X-Gm-Message-State: AC+VfDyyUMFh6Ylfip8PX1IG7lJN9h4oMkU0qapUSebVrx7mc6qHTy+C eDoOUo6BGp8iVB0IBELoKU+VwVKVMKzWhhoeP5x7HWDf/Go= X-Google-Smtp-Source: ACHHUZ7Snxfkcob2TG9IruzXonagsyI03nDTXHi41V6mJ1fUx4NO5JeUcm5erUJIihhx1ubsoCnk0KVhjrHjxJbKqc8= X-Received: by 2002:a05:622a:18c:b0:3f3:8e79:5742 with SMTP id s12-20020a05622a018c00b003f38e795742mr5914013qtw.19.1686195332314; Wed, 07 Jun 2023 20:35:32 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Andy Tai Date: Wed, 7 Jun 2023 20:34:56 -0700 Message-ID: Subject: Re: To: GNU bug tracker automated control server Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) unblock 63526 by 63592 block 63526 by 63952 From debbugs-submit-bounces@debbugs.gnu.org Fri Jun 09 07:07:40 2023 Received: (at 63952-done) by debbugs.gnu.org; 9 Jun 2023 11:07:40 +0000 Received: from localhost ([127.0.0.1]:58463 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q7Zy0-000412-7Z for submit@debbugs.gnu.org; Fri, 09 Jun 2023 07:07:40 -0400 Received: from hera.aquilenet.fr ([185.233.100.1]:53740) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q7Zxy-00040h-5n; Fri, 09 Jun 2023 07:07:38 -0400 Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id 7B9732A2; Fri, 9 Jun 2023 13:07:32 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at hera.aquilenet.fr Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id gwRfxlV6JGfv; Fri, 9 Jun 2023 13:07:31 +0200 (CEST) Received: from jurong (unknown [IPv6:2001:861:c4:f2f0::c64]) by hera.aquilenet.fr (Postfix) with ESMTPSA id 931EC9E; Fri, 9 Jun 2023 13:07:31 +0200 (CEST) Date: Fri, 9 Jun 2023 13:07:30 +0200 From: Andreas Enge To: Andy Tai Subject: Re: ping on a build fix for a build failure (main branch) Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 63952-done Cc: guix-devel@gnu.org, 63526-done@debbugs.gnu.org, 63952-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hello Andy, Am Tue, May 30, 2023 at 10:54:20AM -0700 schrieb Andy Tai: > Hi, following previous comments (thanks) I have submitted a patch to > correctly fix a build failure due to compiler warnings, instead of > avoiding not building tests, on this Guix bug issue: > https://debbugs.gnu.org/cgi/bugreport.cgi?bug=63526 > Please review the patch (which shall be a simple and low risk fix). Thanks! I have reworked a bit the punctuation of the commit message, shortened the patch file name and pushed. By this I am closing the two corresponding bug reports (it would have been enough to send a second version of the patch to the first bug). Did you contact upstream? Looking at the test, it looked wrong before and after your patch... if (len < token->data.character.len) { hubbub_token t = { 0 }; t.type = HUBBUB_TOKEN_CHARACTER; t.data.character.ptr += len; t.data.character.len -= len; ... Adding to a previously undefined, now 0 pointer .ptr raised a warning for a reason, I think; and it looks like the t.data maybe should be token->data. But it is quite possible that this branch is not even reached by the test. Andreas From debbugs-submit-bounces@debbugs.gnu.org Fri Jun 09 13:29:11 2023 Received: (at 63952-done) by debbugs.gnu.org; 9 Jun 2023 17:29:11 +0000 Received: from localhost ([127.0.0.1]:60290 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q7fvD-0002mU-Bf for submit@debbugs.gnu.org; Fri, 09 Jun 2023 13:29:11 -0400 Received: from mail-qt1-f177.google.com ([209.85.160.177]:50177) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q7fvB-0002m8-8F; Fri, 09 Jun 2023 13:29:10 -0400 Received: by mail-qt1-f177.google.com with SMTP id d75a77b69052e-3f9b5ec058aso17725691cf.0; Fri, 09 Jun 2023 10:29:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=atai-org.20221208.gappssmtp.com; s=20221208; t=1686331742; x=1688923742; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=qyiKtKWt89vr3JVUM5OGvs5yRdGVWnpoHd27ZVjvEms=; b=A8pH/fXGfYsyrmjrTGjPyqENv6ybcRmpbgIKJBmIhUFRfzDhLh9LHMwo8oC1My9smM 26P/QmnVwg7B/VKWVWTJM9QCkzh8wqA1YDJ7pjSen1KdzVx4jiSqvfM78SV6zkCAtD6C rxbl382B4oZJrwM1YjXyExC3ymCzInxMu1wuMOxb9GaKcoB8N/FinovyWgiXWGF8BmlX hl0JPLut9SgN72g3uUFxekylftHZAeprphnu60huz949k3Slt0SuQjNpykmX1JutE9er ftZ7FgCROCWGgtQ4X5/3FsCKavHHlM2gPy/95WG0lSaQz0qEvxyiSOTGYKYobKqN9b4v 83Pw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686331742; x=1688923742; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=qyiKtKWt89vr3JVUM5OGvs5yRdGVWnpoHd27ZVjvEms=; b=eKWQ1xXA/VUX8uhXgxAghIYL15NfKLJUUXmlNexI5mAkOkPccsPSMdpO6Hx2MlEQAw zNdQFEc9unbdpNKy/6jOKiSyiL6Q69MxsTgiRjT37p93lZe8YhlB8Wv6ZK2NKXMcJbtL FXHgfvbCwFFcPS5rxJbddWsohiHM4m/OsTFBqoP605p8RLDd1T5rIRx2GbzFjTw6oaE3 TTOm2/PUzNvcZjZEuC0w3/Wu+XBvFXy/36ubO3xC1de+x2+5b+I25MPzXnr5Byj4bOiK WMp6xcIB4CmFO75k+Js+07tSGUIogedxHQTG8kMHBTdgSWih+heJRZOuSsa1WuiUK4r3 0SMw== X-Gm-Message-State: AC+VfDxM0Fjt+2emEi13nRmIEMVJ7jtJmbrI4Hv6X5nxxZpWJJvwgYR4 T8MN+quCyhEde7xrl96zFs8BcCfZCEhzc2KkwUM= X-Google-Smtp-Source: ACHHUZ5Jvx3I2rC1srkLU8IfKa7oDhQBVCQ7SUxGD+9Pc6V177FaDzQqxs0RTm24k+bwD86XPXcITktGH9IJyDBGrNo= X-Received: by 2002:ac8:7d0e:0:b0:3f3:8819:67eb with SMTP id g14-20020ac87d0e000000b003f3881967ebmr3040241qtb.6.1686331741931; Fri, 09 Jun 2023 10:29:01 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Andy Tai Date: Fri, 9 Jun 2023 10:28:25 -0700 Message-ID: Subject: Re: ping on a build fix for a build failure (main branch) To: Andreas Enge Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 63952-done Cc: guix-devel@gnu.org, 63526-done@debbugs.gnu.org, 63952-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) I did contact upstream, no response On Fri, Jun 9, 2023 at 4:07=E2=80=AFAM Andreas Enge wrote= : > > Hello Andy, > > Am Tue, May 30, 2023 at 10:54:20AM -0700 schrieb Andy Tai: > > Hi, following previous comments (thanks) I have submitted a patch to > > correctly fix a build failure due to compiler warnings, instead of > > avoiding not building tests, on this Guix bug issue: > > https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D63526 > > Please review the patch (which shall be a simple and low risk fix). Th= anks! > > I have reworked a bit the punctuation of the commit message, shortened > the patch file name and pushed. By this I am closing the two correspondin= g > bug reports (it would have been enough to send a second version of the > patch to the first bug). > > Did you contact upstream? Looking at the test, it looked wrong before and > after your patch... > if (len < token->data.character.len) { > hubbub_token t =3D { 0 }; > t.type =3D HUBBUB_TOKEN_CHARACTER; > t.data.character.ptr +=3D len; > t.data.character.len -=3D len; > ... > Adding to a previously undefined, now 0 pointer .ptr raised a warning > for a reason, I think; and it looks like the t.data maybe should be > token->data. But it is quite possible that this branch is not even > reached by the test. > > Andreas > --=20 Andy Tai, atai@atai.org, Skype: licheng.tai, Line: andy_tai, WeChat: andyta= i1010 Year 2023 =E6=B0=91=E5=9C=8B112=E5=B9=B4 =E8=87=AA=E5=8B=95=E7=9A=84=E7=B2=BE=E7=A5=9E=E5=8A=9B=E6=98=AF=E4=BF=A1=E4= =BB=B0=E8=88=87=E8=A6=BA=E6=82=9F =E8=87=AA=E5=8B=95=E7=9A=84=E8=A1=8C=E7=82=BA=E5=8A=9B=E6=98=AF=E5=8B=9E=E5= =8B=95=E8=88=87=E6=8A=80=E8=83=BD From unknown Sun Jun 22 11:33:07 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 08 Jul 2023 11:24:06 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator