From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 07 17:05:17 2023 Received: (at submit) by debbugs.gnu.org; 7 Jun 2023 21:05:17 +0000 Received: from localhost ([127.0.0.1]:54918 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q70LF-0005YW-0G for submit@debbugs.gnu.org; Wed, 07 Jun 2023 17:05:17 -0400 Received: from lists.gnu.org ([209.51.188.17]:49320) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q70LA-0005YL-9G for submit@debbugs.gnu.org; Wed, 07 Jun 2023 17:05:15 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q70L8-0001Fp-2b for bug-gnu-emacs@gnu.org; Wed, 07 Jun 2023 17:05:10 -0400 Received: from mr3.vodafonemail.de ([145.253.228.163]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q70L3-0003fw-FP for bug-gnu-emacs@gnu.org; Wed, 07 Jun 2023 17:05:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vodafonemail.de; s=vfde-mb-mr2-21dec; t=1686171898; bh=LSVRs3NbKr1hJY1OFexJRJe39WEpGwkpTHMWcRfnL6k=; h=Message-ID:Date:User-Agent:Content-Language:From:To:Subject: Content-Type:From; b=VG+1EdTpDzeXNBOH6iCWBsMpGFkkh3R4gAi+iMQwoMUBB32v13y5K7lrBW1t1CSm6 xr+999fk4WC6Cc2OG5vl7fb8AuALjB4G9KYXQ9TlyEkcbZu66GjrRKxab2eLAVjS2l 3wcuADZa8Am+cpz2c1JKgAtUdWo+HBuf7o2qK9YI= Received: from smtp.vodafone.de (unknown [10.0.0.2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by mr3.vodafonemail.de (Postfix) with ESMTPS id 4Qc0Gf0MS3z23xL for ; Wed, 7 Jun 2023 21:04:57 +0000 (UTC) Received: from [192.168.178.41] (port-92-194-147-229.dynamic.as20676.net [92.194.147.229]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp.vodafone.de (Postfix) with ESMTPSA id 4Qc0GY4XFDz9s02 for ; Wed, 7 Jun 2023 21:04:50 +0000 (UTC) Message-ID: <8c62dd9a-3cad-b992-bfc4-64b2f1db4485@vodafonemail.de> Date: Wed, 7 Jun 2023 23:04:50 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Content-Language: de-DE-frami, en-US From: Jens Schmidt To: bug-gnu-emacs@gnu.org Subject: =?UTF-8?Q?30=2e0=2e50=3b_=60vc-print-log=c2=b4_does_not_erase_buffe?= =?UTF-8?Q?r_when_called_from_*vc-change-log*_buffer=2c_at_least_for_CVS_log?= =?UTF-8?Q?s?= Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-purgate-type: clean X-purgate: clean X-purgate-size: 4305 X-purgate-ID: 155817::1686171893-54FF84DE-4CF4D776/0/0 Received-SPF: pass client-ip=145.253.228.163; envelope-from=jschmidt4gnu@vodafonemail.de; helo=mr3.vodafonemail.de X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) Start emacs -Q. Visit a CVS-controlled file. Then: C-x v l M-> C-x v l Notice the CVS log added once more after current end of log buffer. I tracked this down to the following snippet from `vc-do-command´: (save-current-buffer (unless (or (eq buffer t) (and (stringp buffer) (string= (buffer-name) buffer)) (eq buffer (current-buffer))) (vc-setup-buffer buffer)) That is, `vc-setup-buffer´ (which erases the buffer) is *not* called if the buffer where the VC command is to be executed in equals the current buffer. I guess that logic has a reason, so it probably should be some upper layer which should erase *vc-log-buffer*... For git, for example, function `vc-git-print-log´ calls `vc-setup-buffer´. Probably the other VC backends should follow suit? If this is the way to go, I could provide patches for VC backends CVS and RCS, pls let me know. In GNU Emacs 30.0.50 (build 2, x86_64-pc-linux-gnu, GTK+ Version 3.24.24, cairo version 1.16.0) of 2023-06-07 built on sappc2 Repository revision: a902156068ab071f93cc9bbd34cd320919b74064 Repository branch: master Windowing system distributor 'The X.Org Foundation', version 11.0.12011000 System Description: Debian GNU/Linux 11 (bullseye) Configured features: ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ JPEG JSON LCMS2 LIBOTF LIBSELINUX LIBSYSTEMD LIBXML2 M17N_FLT MODULES NOTIFY INOTIFY PDUMPER PNG RSVG SECCOMP SOUND THREADS TIFF TOOLKIT_SCROLL_BARS X11 XDBE XIM XINPUT2 XPM GTK3 ZLIB Important settings: value of $LC_COLLATE: POSIX value of $LC_TIME: POSIX value of $LANG: en_US.UTF-8 value of $XMODIFIERS: @im=ibus locale-coding-system: utf-8-unix Major mode: Git-Log-View Minor modes in effect: tooltip-mode: t global-eldoc-mode: t show-paren-mode: t electric-indent-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t buffer-read-only: t line-number-mode: t indent-tabs-mode: t transient-mark-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t Load-path shadows: None found. Features: (shadow sort mail-extr emacsbug message mailcap yank-media puny dired dired-loaddefs rfc822 mml mml-sec password-cache epa derived epg rfc6068 epg-config gnus-util text-property-search mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils parse-time iso8601 time-date subr-x sh-script rx smie treesit cl-seq executable misearch multi-isearch vc-hg vc-bzr vc-src vc-sccs vc-svn vc-cvs vc-rcs add-log log-view pcvs-util cl-extra help-mode vc vc-git diff-mode easy-mmode vc-dispatcher cl-loaddefs cl-lib rmc iso-transl tooltip cconv eldoc paren electric uniquify ediff-hook vc-hooks lisp-float-type elisp-mode mwheel term/x-win x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors frame minibuffer nadvice seq simple cl-generic indonesian philippine cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite emoji-zwj charscript charprop case-table epa-hook jka-cmpr-hook help abbrev obarray oclosure cl-preloaded button loaddefs theme-loaddefs faces cus-face macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget keymap hashtable-print-readable backquote threads dbusbind inotify lcms2 dynamic-setting system-font-setting font-render-setting cairo move-toolbar gtk x-toolkit xinput2 x multi-tty make-network-process emacs) Memory information: ((conses 16 61575 13745) (symbols 48 7721 0) (strings 32 23157 2232) (string-bytes 1 634764) (vectors 16 14390) (vector-slots 8 207631 12167) (floats 8 35 32) (intervals 56 586 0) (buffers 976 13)) From debbugs-submit-bounces@debbugs.gnu.org Thu Jun 08 09:12:53 2023 Received: (at 63949) by debbugs.gnu.org; 8 Jun 2023 13:12:53 +0000 Received: from localhost ([127.0.0.1]:55842 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q7FRd-0007Vm-GM for submit@debbugs.gnu.org; Thu, 08 Jun 2023 09:12:53 -0400 Received: from ledu-giraud.fr ([51.159.28.247]:46070) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q7FRZ-0007VW-0T for 63949@debbugs.gnu.org; Thu, 08 Jun 2023 09:12:52 -0400 DKIM-Signature: v=1; a=ed25519-sha256; c=simple/simple; s=ed25519; bh=lGYhoDZL 1SImRkh4Wwa+LEPjUuAqvJY4nH17kSK2FY0=; h=date:references:in-reply-to: subject:cc:to:from; d=ledu-giraud.fr; b=8uIrt2AKyk0ACXKs0SNo+ngsKmmvSn OYKQeHcYRFXWulrdE3v9IBnGKSToVtJDAVHjlgofNB3bsYUPofWvVaBw== DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=rsa; bh=lGYhoDZL1SImRkh4 Wwa+LEPjUuAqvJY4nH17kSK2FY0=; h=date:references:in-reply-to:subject: cc:to:from; d=ledu-giraud.fr; b=Uc6YIvrC4RnIEEIfhrwSYbsUlEsXyM1M63h8jJ SUDMiqQAxsU8J6YST4fgDyf5TaK8dyYQCCw/9CAgpMkDfEC58BR+9LwNnlhsokiOwiHHxM TDANXdYqcUOaRN5oNPRwPLlbVMTQOHSV2VE0Yc882BiMSAGQUAPbpTYmuHkQALvVehsSSM ux7/ROtx84TM4OiezUwM2up4myxRmSiEX8ESsRPuOYpawVdkaof4xp0OSPJrSsXBsQbCOt CAV83SABF+X6ibzoXm5jy6BYTxysR8c4Px+qf6u7TCTGlFpS+Ai8MyyhteUoPzAJ+d9w/0 1ta189aXVJZg3+Lt2vyto6lg== Received: from computer ( [10.1.1.1]) by ledu-giraud.fr (OpenSMTPD) with ESMTPSA id a6cba498 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Thu, 8 Jun 2023 15:12:46 +0200 (CEST) From: Manuel Giraud To: Jens Schmidt Subject: Re: bug#63949: 30.0.50; =?utf-8?Q?`vc-print-log=C2=B4?= does not erase buffer when called from *vc-change-log* buffer, at least for CVS logs In-Reply-To: <8c62dd9a-3cad-b992-bfc4-64b2f1db4485@vodafonemail.de> (Jens Schmidt's message of "Wed, 7 Jun 2023 23:04:50 +0200") References: <8c62dd9a-3cad-b992-bfc4-64b2f1db4485@vodafonemail.de> Date: Thu, 08 Jun 2023 15:12:45 +0200 Message-ID: <87fs729jxu.fsf@ledu-giraud.fr> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 63949 Cc: 63949@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Jens Schmidt writes: [...] > For git, for example, function `vc-git-print-log=C2=B4 calls > `vc-setup-buffer=C2=B4. Probably the other VC backends should follow sui= t? > > If this is the way to go, I could provide patches for VC backends CVS > and RCS, pls let me know. FWIW, I tested with mercurial (vc-hg.el) and it works correctly (as with git) but it have the same call to 'vc-setup-buffer' in 'vc-hg-print-log'. So I guess it would be logical that others backend "print-log" functions have this same call. (note: I could not test it but SVN and Bazaar print-log functions also have this call to 'vc-setup-buffer') --=20 Manuel Giraud From debbugs-submit-bounces@debbugs.gnu.org Thu Jun 08 16:21:49 2023 Received: (at 63949) by debbugs.gnu.org; 8 Jun 2023 20:21:49 +0000 Received: from localhost ([127.0.0.1]:57617 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q7M8j-0004nk-2G for submit@debbugs.gnu.org; Thu, 08 Jun 2023 16:21:49 -0400 Received: from mr4.vodafonemail.de ([145.253.228.164]:55972) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q7M8d-0004nT-RB for 63949@debbugs.gnu.org; Thu, 08 Jun 2023 16:21:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vodafonemail.de; s=vfde-mb-mr2-21dec; t=1686255697; bh=3Dmd8S6fv2n2A9xak7rY5zEQp6weteosYKgnQgGmyOM=; h=Message-ID:Date:User-Agent:Subject:Content-Language:To:References: From:In-Reply-To:Content-Type:From; b=DCuCI5/nZo0k6HtgZnEUnSvp/1q3VGv9wnGHiyGjRIP2flNwTct2ug1x+YXzw8MU7 u7wUXX4KQ0iPtx7vv1rmMYVxWPBE5/MELRxudvE6jpnwgO9b8xopQv7QwikNa4Zkye 40LTyxg+2F4EZBlL9TZXYRtmPPvHiE/BkPAhYBwg= Received: from smtp.vodafone.de (unknown [10.0.0.2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by mr4.vodafonemail.de (Postfix) with ESMTPS id 4QcbG91Bxzz1y36; Thu, 8 Jun 2023 20:21:37 +0000 (UTC) Received: from [192.168.178.41] (port-92-194-82-46.dynamic.as20676.net [92.194.82.46]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp.vodafone.de (Postfix) with ESMTPSA id 4QcbG15fKFzMks6; Thu, 8 Jun 2023 20:21:26 +0000 (UTC) Message-ID: Date: Thu, 8 Jun 2023 22:21:26 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: =?UTF-8?B?UmU6IGJ1ZyM2Mzk0OTogMzAuMC41MDsgYHZjLXByaW50LWxvZ8K0IGRv?= =?UTF-8?Q?es_not_erase_buffer_when_called_from_*vc-change-log*_buffer=2c_at?= =?UTF-8?Q?_least_for_CVS_logs?= Content-Language: de-DE-frami, en-US To: Manuel Giraud References: <8c62dd9a-3cad-b992-bfc4-64b2f1db4485@vodafonemail.de> <87fs729jxu.fsf@ledu-giraud.fr> From: Jens Schmidt In-Reply-To: <87fs729jxu.fsf@ledu-giraud.fr> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-purgate-type: clean X-purgate: clean X-purgate-size: 600 X-purgate-ID: 155817::1686255693-F97F94D1-A23AF2E5/0/0 X-Spam-Score: -1.8 (-) X-Debbugs-Envelope-To: 63949 Cc: 63949@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.8 (--) On 2023-06-08 15:12, Manuel Giraud wrote: > FWIW, I tested with mercurial (vc-hg.el) and it works correctly (as with > git) but it have the same call to 'vc-setup-buffer' in > 'vc-hg-print-log'. So I guess it would be logical that others backend > "print-log" functions have this same call. > > (note: I could not test it but SVN and Bazaar print-log functions also > have this call to 'vc-setup-buffer') Thanks for checking this out. Will provide patches for CVS and RCS in that direction. Probably I'll even do SCCS, which seems to lack the call to `vc-setup-buffer' as well. From debbugs-submit-bounces@debbugs.gnu.org Thu Jun 08 17:33:35 2023 Received: (at 63949) by debbugs.gnu.org; 8 Jun 2023 21:33:35 +0000 Received: from localhost ([127.0.0.1]:57772 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q7NGA-0006jD-SM for submit@debbugs.gnu.org; Thu, 08 Jun 2023 17:33:35 -0400 Received: from mr4.vodafonemail.de ([145.253.228.164]:53956) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q7NG8-0006iw-HB for 63949@debbugs.gnu.org; Thu, 08 Jun 2023 17:33:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vodafonemail.de; s=vfde-mb-mr2-21dec; t=1686260005; bh=1X/0SfnhJzuUOHS8yj8ig/7PJjcAZo+jscsQniuxb6U=; h=Message-ID:Date:User-Agent:Subject:Content-Language:From:To: References:In-Reply-To:Content-Type:From; b=p8KKXR0nj6724oTmiVLnxgiv40ikZq6l+6FEfBPvyZb+I0GDZqXQarEslDjF3my4x +tolfnJsDzc4OOHMFIgKEYdKsI0RQ5/kGOr3xsDBuuexCLXPFA2/kQWO6WYVxS78E6 LLnGCB/9MYsJy7JUUQUKpjgnv27zBSruR9NfXjJo= Received: from smtp.vodafone.de (unknown [10.0.0.2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by mr4.vodafonemail.de (Postfix) with ESMTPS id 4Qccs16JWbz1y0g; Thu, 8 Jun 2023 21:33:25 +0000 (UTC) Received: from [192.168.178.41] (port-92-194-82-46.dynamic.as20676.net [92.194.82.46]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp.vodafone.de (Postfix) with ESMTPSA id 4Qccrt3srXzHpxc; Thu, 8 Jun 2023 21:33:15 +0000 (UTC) Message-ID: Date: Thu, 8 Jun 2023 23:33:15 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: =?UTF-8?B?UmU6IGJ1ZyM2Mzk0OTogMzAuMC41MDsgYHZjLXByaW50LWxvZ8K0IGRv?= =?UTF-8?Q?es_not_erase_buffer_when_called_from_*vc-change-log*_buffer=2c_at?= =?UTF-8?Q?_least_for_CVS_logs?= Content-Language: de-DE-frami, en-US From: Jens Schmidt To: Manuel Giraud References: <8c62dd9a-3cad-b992-bfc4-64b2f1db4485@vodafonemail.de> <87fs729jxu.fsf@ledu-giraud.fr> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-purgate-type: clean X-purgate: clean X-purgate-size: 432 X-purgate-ID: 155817::1686260001-D27FB403-347F9BAC/0/0 X-Spam-Score: -1.8 (-) X-Debbugs-Envelope-To: 63949 Cc: 63949@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.8 (--) Root cause of this issue being that `vc-deduce-fileset' does not change buffer in Emacs 29 and newer, while it does in Emacs 27 and older. (Too lazy to check for Emacs 28.) So in Emacs 27 and older, a call to `vc-print-log' started from *vc-change-log* would change buffer to the vc parent buffer before calling the backend function, and thus `vc-do-command' would call `vc-setup-buffer' in the snippet mentioned above. From debbugs-submit-bounces@debbugs.gnu.org Thu Jun 08 18:11:35 2023 Received: (at 63949) by debbugs.gnu.org; 8 Jun 2023 22:11:35 +0000 Received: from localhost ([127.0.0.1]:57832 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q7Nqu-0007lE-Hw for submit@debbugs.gnu.org; Thu, 08 Jun 2023 18:11:35 -0400 Received: from mr4.vodafonemail.de ([145.253.228.164]:39896) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q7Nqd-0007kk-CW for 63949@debbugs.gnu.org; Thu, 08 Jun 2023 18:11:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vodafonemail.de; s=vfde-mb-mr2-21dec; t=1686262268; bh=VCx43EH7poQv+vHVkHyqBfXeSdr5x9wFAevwvNoxOOk=; h=Message-ID:Date:User-Agent:Subject:Content-Language:From:To: References:In-Reply-To:Content-Type:From; b=BFB9miy4MdaOQl0rvlC3jdzdIp8QsWiN0G1jo0AJ7hQMm59nOSn8MDRbkdkeDkE5d Pm/smIOQrMiL4WXSZk4FYTPvLMF7jxfRG5CH+yCOn1Uf2E+ANbokKa9R4j1jiX2UMA vOjltsNKDwxXXYgbJWozOZ1/zz8tsLl58kdOn7A4= Received: from smtp.vodafone.de (unknown [10.0.0.2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by mr4.vodafonemail.de (Postfix) with ESMTPS id 4QcdhX56b1z1xqm; Thu, 8 Jun 2023 22:11:08 +0000 (UTC) Received: from [192.168.178.41] (port-92-194-82-46.dynamic.as20676.net [92.194.82.46]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp.vodafone.de (Postfix) with ESMTPSA id 4QcdhP0YBQzKm4r; Thu, 8 Jun 2023 22:10:58 +0000 (UTC) Message-ID: <7bc0c78e-e4b5-0edc-0e9f-2f8fbafc352f@vodafonemail.de> Date: Fri, 9 Jun 2023 00:10:57 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: =?UTF-8?B?UmU6IGJ1ZyM2Mzk0OTogMzAuMC41MDsgYHZjLXByaW50LWxvZ8K0IGRv?= =?UTF-8?Q?es_not_erase_buffer_when_called_from_*vc-change-log*_buffer=2c_at?= =?UTF-8?Q?_least_for_CVS_logs?= Content-Language: de-DE-frami, en-US From: Jens Schmidt To: Manuel Giraud References: <8c62dd9a-3cad-b992-bfc4-64b2f1db4485@vodafonemail.de> <87fs729jxu.fsf@ledu-giraud.fr> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-purgate-type: clean X-purgate: clean X-purgate-size: 290 X-purgate-ID: 155817::1686262264-70FF84F8-E0771D7D/0/0 X-Spam-Score: -1.1 (-) X-Debbugs-Envelope-To: 63949 Cc: 63949@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.8 (--) Caused by commit d494833d47968fcd97ba549654a259d6fb6c2eee. There is another subtle change to (most likely) that, which seems to affect all backends: When calling `vc-print-log' from *vc-change-buffer*, it now modifies the VC parent buffer to itself, which is of course incorrect. From debbugs-submit-bounces@debbugs.gnu.org Thu Jun 08 18:45:04 2023 Received: (at submit) by debbugs.gnu.org; 8 Jun 2023 22:45:04 +0000 Received: from localhost ([127.0.0.1]:57861 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q7ONL-00009a-Eo for submit@debbugs.gnu.org; Thu, 08 Jun 2023 18:45:04 -0400 Received: from lists.gnu.org ([209.51.188.17]:41782) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q7ONG-00008p-7F for submit@debbugs.gnu.org; Thu, 08 Jun 2023 18:45:02 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q7ONF-0002bm-EV for bug-gnu-emacs@gnu.org; Thu, 08 Jun 2023 18:44:57 -0400 Received: from mr6.vodafonemail.de ([145.253.228.166]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q7ONC-0003Ka-LS for bug-gnu-emacs@gnu.org; Thu, 08 Jun 2023 18:44:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vodafonemail.de; s=vfde-mb-mr2-21dec; t=1686264287; bh=SFKfUhBNNur2CKuzFdQb3QppTqxlHUfwYfU9biqvhiM=; h=Content-Type:Message-ID:Date:User-Agent:Subject:Content-Language: From:To:References:In-Reply-To:From; b=lutsfa6E8L6FeYjX2efxvVgwj06PENo1rDdzV0faU3ZdtVAVJA5aLeJovBk+GL9gt mskJ41GZ46lxXCTV2CLPK5OUvs+/+TPF5GKJQfDpoVOr3LtQlNiv2zv036XzBZU9kX vX/O20y4DG3KxmiaOUUZABd3gZRvXTMm37SO2KDE= Received: from smtp.vodafone.de (unknown [10.0.0.2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by mr6.vodafonemail.de (Postfix) with ESMTPS id 4QcfRM2Xz4z1xyL for ; Thu, 8 Jun 2023 22:44:47 +0000 (UTC) Received: from [192.168.178.41] (port-92-194-82-46.dynamic.as20676.net [92.194.82.46]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp.vodafone.de (Postfix) with ESMTPSA id 4QcfRH01h4z9sK7 for ; Thu, 8 Jun 2023 22:44:39 +0000 (UTC) Content-Type: multipart/mixed; boundary="------------L19nTYjo3ump3Wb4YHxE94ky" Message-ID: <965f7636-1bac-02ff-e9f2-d6848aa2df4b@vodafonemail.de> Date: Fri, 9 Jun 2023 00:44:39 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: =?UTF-8?Q?Re=3a_30=2e0=2e50=3b_=60vc-print-log=c2=b4_does_not_erase?= =?UTF-8?Q?_buffer_when_called_from_*vc-change-log*_buffer=2c_at_least_for_C?= =?UTF-8?Q?VS_logs?= Content-Language: de-DE-frami, en-US From: Jens Schmidt To: bug-gnu-emacs@gnu.org References: <8c62dd9a-3cad-b992-bfc4-64b2f1db4485@vodafonemail.de> In-Reply-To: <8c62dd9a-3cad-b992-bfc4-64b2f1db4485@vodafonemail.de> X-purgate-type: clean X-purgate: clean X-purgate-size: 11249 X-purgate-ID: 155817::1686264283-38FF8404-4B0AC06B/0/0 Received-SPF: pass client-ip=145.253.228.166; envelope-from=jschmidt4gnu@vodafonemail.de; helo=mr6.vodafonemail.de X-Spam_score_int: -28 X-Spam_score: -2.9 X-Spam_bar: -- X-Spam_report: (-2.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.091, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -2.5 (--) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.5 (---) This is a multi-part message in MIME format. --------------L19nTYjo3ump3Wb4YHxE94ky Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Here come five patches for this issue, based on emacs-29: 0001-Always-erase-log-buffer-before-calling-vc-print-log.patch 0002-Always-erase-log-buffer-before-calling-vc-print-log.patch 0003-Always-erase-log-buffer-before-calling-vc-print-log.patch Name should be self-explaining, patches uncritical. 0004-Fix-documentation-bug-and-remove-obsolete-fixmes.patch `vc-deduce-fileset' uses `with-current-buffer' to protect the current buffer, which has not been reflected in comments. 0005-Avoid-setting-circular-vc-parent-buffer.patch This one fixes the issue related to VC parent buffer described in the previous update. The "local" change seems to be logical (a buffer should not be the VC parent buffer of itself), but I'm not quite sure about any adverse "global" consequences. --------------L19nTYjo3ump3Wb4YHxE94ky Content-Type: text/x-patch; charset=UTF-8; name="0001-Always-erase-log-buffer-before-calling-vc-print-log.patch" Content-Disposition: attachment; filename*0="0001-Always-erase-log-buffer-before-calling-vc-print-log.pat"; filename*1="ch" Content-Transfer-Encoding: base64 RnJvbSA5ZTNjYjgwMzhlYTViZWEzZTJmMTI5ZjAyNzFhMGNmM2VjOTQ4MTU5IE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKZW5zIFNjaG1pZHQgPGpzY2htaWR0NGdudUB2b2Rh Zm9uZW1haWwuZGU+CkRhdGU6IFRodSwgOCBKdW4gMjAyMyAyMzozNjo0NiArMDIwMApTdWJq ZWN0OiBbUEFUQ0ggMS81XSBBbHdheXMgZXJhc2UgbG9nIGJ1ZmZlciBiZWZvcmUgY2FsbGlu ZyBgdmMtKi1wcmludC1sb2cnCgpXaGVuIGNhbGxpbmcgYHZjLXByaW50LWxvZycgZnJvbSBi dWZmZXIgKnZjLWNoYW5nZS1sb2cqIGl0c2VsZiBmb3IKYmFja2VuZHMgU0NDUywgUkNTLCBh bmQgQ1ZTLCB0aGUgbG9nIGluZm9ybWF0aW9uIGlzIGluc2VydGVkIG9yCmFwcGVuZGVkIHRv IHRoZSAqdmMtY2hhbmdlLWxvZyogYnVmZmVyIGFnYWluIHdpdGhvdXQgcHJldmlvdXNseQpl cmFzaW5nIGl0LgoqIGxpc3AvdmMvdmMtc2Njcy5lbCAodmMtc2Njcy1wcmludC1sb2cpOiBB ZGQgY2FsbCB0bwpgdmMtc2V0dXAtYnVmZmVyJy4gKEJ1ZyM2Mzk0OSkKLS0tCiBsaXNwL3Zj L3ZjLXNjY3MuZWwgfCAyICsrCiAxIGZpbGUgY2hhbmdlZCwgMiBpbnNlcnRpb25zKCspCgpk aWZmIC0tZ2l0IGEvbGlzcC92Yy92Yy1zY2NzLmVsIGIvbGlzcC92Yy92Yy1zY2NzLmVsCmlu ZGV4IDAzZTlkMTJiNzZmLi5lNTQzMDc1M2E2NCAxMDA2NDQKLS0tIGEvbGlzcC92Yy92Yy1z Y2NzLmVsCisrKyBiL2xpc3AvdmMvdmMtc2Njcy5lbApAQCAtMzEwLDYgKzMxMCw4IEBAIHZj LXNjY3MtcHJpbnQtbG9nCiAgICJQcmludCBjb21taXQgbG9nIGFzc29jaWF0ZWQgd2l0aCBG SUxFUyBpbnRvIHNwZWNpZmllZCBCVUZGRVIuCiBSZW1haW5pbmcgYXJndW1lbnRzIGFyZSBp Z25vcmVkLiIKICAgKHNldHEgZmlsZXMgKHZjLWV4cGFuZC1kaXJzIGZpbGVzICdTQ0NTKSkK KyAgKHNhdmUtY3VycmVudC1idWZmZXIKKyAgICAodmMtc2V0dXAtYnVmZmVyIGJ1ZmZlcikp CiAgICh2Yy1zY2NzLWRvLWNvbW1hbmQgYnVmZmVyIDAgInBycyIgKG1hcGNhciAjJ3ZjLW1h c3Rlci1uYW1lIGZpbGVzKSkKICAgKHdoZW4gbGltaXQgJ2xpbWl0LXVuc3VwcG9ydGVkKSkK IAotLSAKMi4zMC4yCgo= --------------L19nTYjo3ump3Wb4YHxE94ky Content-Type: text/x-patch; charset=UTF-8; name="0002-Always-erase-log-buffer-before-calling-vc-print-log.patch" Content-Disposition: attachment; filename*0="0002-Always-erase-log-buffer-before-calling-vc-print-log.pat"; filename*1="ch" Content-Transfer-Encoding: base64 RnJvbSA0Y2I1ZWFhMjE2NjEwM2Q2NDVmYTc3OTcyYjQ1NmRkNmE0ZmFkMjgyIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKZW5zIFNjaG1pZHQgPGpzY2htaWR0NGdudUB2b2Rh Zm9uZW1haWwuZGU+CkRhdGU6IFRodSwgOCBKdW4gMjAyMyAyMzozNzo0NSArMDIwMApTdWJq ZWN0OiBbUEFUQ0ggMi81XSBBbHdheXMgZXJhc2UgbG9nIGJ1ZmZlciBiZWZvcmUgY2FsbGlu ZyBgdmMtKi1wcmludC1sb2cnCgpXaGVuIGNhbGxpbmcgYHZjLXByaW50LWxvZycgZnJvbSBi dWZmZXIgKnZjLWNoYW5nZS1sb2cqIGl0c2VsZiBmb3IKYmFja2VuZHMgU0NDUywgUkNTLCBh bmQgQ1ZTLCB0aGUgbG9nIGluZm9ybWF0aW9uIGlzIGluc2VydGVkIG9yCmFwcGVuZGVkIHRv IHRoZSAqdmMtY2hhbmdlLWxvZyogYnVmZmVyIGFnYWluIHdpdGhvdXQgcHJldmlvdXNseQpl cmFzaW5nIGl0LgoqIGxpc3AvdmMvdmMtY3ZzLmVsICh2Yy1jdnMtcHJpbnQtbG9nKTogQWRk IGNhbGwgdG8KYHZjLXNldHVwLWJ1ZmZlcicuIChCdWcjNjM5NDkpCi0tLQogbGlzcC92Yy92 Yy1jdnMuZWwgfCAyICsrCiAxIGZpbGUgY2hhbmdlZCwgMiBpbnNlcnRpb25zKCspCgpkaWZm IC0tZ2l0IGEvbGlzcC92Yy92Yy1jdnMuZWwgYi9saXNwL3ZjL3ZjLWN2cy5lbAppbmRleCA2 ZTAyNDZlYTc2Mi4uY2Y3NGFjMzExNTQgMTAwNjQ0Ci0tLSBhL2xpc3AvdmMvdmMtY3ZzLmVs CisrKyBiL2xpc3AvdmMvdmMtY3ZzLmVsCkBAIC01NTAsNiArNTUwLDggQEAgdmMtY3ZzLW1v ZGlmeS1jaGFuZ2UtY29tbWVudAogKGRlZnVuIHZjLWN2cy1wcmludC1sb2cgKGZpbGVzIGJ1 ZmZlciAmb3B0aW9uYWwgX3Nob3J0bG9nIF9zdGFydC1yZXZpc2lvbiBsaW1pdCkKICAgIlBy aW50IGNvbW1pdCBsb2cgYXNzb2NpYXRlZCB3aXRoIEZJTEVTIGludG8gc3BlY2lmaWVkIEJV RkZFUi4KIFJlbWFpbmluZyBhcmd1bWVudHMgYXJlIGlnbm9yZWQuIgorICAoc2F2ZS1jdXJy ZW50LWJ1ZmZlcgorICAgICh2Yy1zZXR1cC1idWZmZXIgYnVmZmVyKSkKICAgOzsgSXQncyBq dXN0IHRoZSBjYXRlbmF0aW9uIG9mIHRoZSBpbmRpdmlkdWFsIGxvZ3MuCiAgICh2Yy1jdnMt Y29tbWFuZAogICAgYnVmZmVyCi0tIAoyLjMwLjIKCg== --------------L19nTYjo3ump3Wb4YHxE94ky Content-Type: text/x-patch; charset=UTF-8; name="0003-Always-erase-log-buffer-before-calling-vc-print-log.patch" Content-Disposition: attachment; filename*0="0003-Always-erase-log-buffer-before-calling-vc-print-log.pat"; filename*1="ch" Content-Transfer-Encoding: base64 RnJvbSA0ZWIxYTk1MTIyOWQ5NjAyNmNhNThmOTY1YzY1MmFiOGU4MzkyODEyIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKZW5zIFNjaG1pZHQgPGpzY2htaWR0NGdudUB2b2Rh Zm9uZW1haWwuZGU+CkRhdGU6IFRodSwgOCBKdW4gMjAyMyAyMzozODo0NSArMDIwMApTdWJq ZWN0OiBbUEFUQ0ggMy81XSBBbHdheXMgZXJhc2UgbG9nIGJ1ZmZlciBiZWZvcmUgY2FsbGlu ZyBgdmMtKi1wcmludC1sb2cnCgpXaGVuIGNhbGxpbmcgYHZjLXByaW50LWxvZycgZnJvbSBi dWZmZXIgKnZjLWNoYW5nZS1sb2cqIGl0c2VsZiBmb3IKYmFja2VuZHMgU0NDUywgUkNTLCBh bmQgQ1ZTLCB0aGUgbG9nIGluZm9ybWF0aW9uIGlzIGluc2VydGVkIG9yCmFwcGVuZGVkIHRv IHRoZSAqdmMtY2hhbmdlLWxvZyogYnVmZmVyIGFnYWluIHdpdGhvdXQgcHJldmlvdXNseQpl cmFzaW5nIGl0LgoqIGxpc3AvdmMvdmMtcmNzLmVsICh2Yy1yY3MtcHJpbnQtbG9nKTogQWRk IGNhbGwgdG8KYHZjLXNldHVwLWJ1ZmZlcicuIChCdWcjNjM5NDkpCi0tLQogbGlzcC92Yy92 Yy1yY3MuZWwgfCAyICsrCiAxIGZpbGUgY2hhbmdlZCwgMiBpbnNlcnRpb25zKCspCgpkaWZm IC0tZ2l0IGEvbGlzcC92Yy92Yy1yY3MuZWwgYi9saXNwL3ZjL3ZjLXJjcy5lbAppbmRleCBj MjExMmI3NmFkMy4uMDU4NDZhN2RlMzUgMTAwNjQ0Ci0tLSBhL2xpc3AvdmMvdmMtcmNzLmVs CisrKyBiL2xpc3AvdmMvdmMtcmNzLmVsCkBAIC01NDgsNiArNTQ4LDggQEAgdmMtcmNzLXBy aW50LWxvZwogUmVtYWluaW5nIGFyZ3VtZW50cyBhcmUgaWdub3JlZC4KIElmIEZJTEUgaXMg YSBkaXJlY3RvcnkgdGhlIG9wZXJhdGlvbiBpcyBhcHBsaWVkIHRvIGFsbCByZWdpc3RlcmVk CiBmaWxlcyBiZW5lYXRoIGl0LiIKKyAgKHNhdmUtY3VycmVudC1idWZmZXIKKyAgICAodmMt c2V0dXAtYnVmZmVyIGJ1ZmZlcikpCiAgICh2Yy1kby1jb21tYW5kIChvciBidWZmZXIgIip2 YyoiKSAwICJybG9nIgogICAgICAgICAgICAgICAgICAobWFwY2FyICMndmMtbWFzdGVyLW5h bWUgKHZjLWV4cGFuZC1kaXJzIGZpbGVzICdSQ1MpKSkKICAgKHdpdGgtY3VycmVudC1idWZm ZXIgKG9yIGJ1ZmZlciAiKnZjKiIpCi0tIAoyLjMwLjIKCg== --------------L19nTYjo3ump3Wb4YHxE94ky Content-Type: text/x-patch; charset=UTF-8; name="0004-Fix-documentation-bug-and-remove-obsolete-fixmes.patch" Content-Disposition: attachment; filename*0="0004-Fix-documentation-bug-and-remove-obsolete-fixmes.patch" Content-Transfer-Encoding: base64 RnJvbSA4ZjYyY2Q3YmJlMzM2YmEwNjY4YWZiNzJjYmJiZDhjNDZjMTUzNzZhIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKZW5zIFNjaG1pZHQgPGpzY2htaWR0NGdudUB2b2Rh Zm9uZW1haWwuZGU+CkRhdGU6IFRodSwgOCBKdW4gMjAyMyAyMzo0NjozMyArMDIwMApTdWJq ZWN0OiBbUEFUQ0ggNC81XSBGaXggZG9jdW1lbnRhdGlvbiBidWcgYW5kIHJlbW92ZSBvYnNv bGV0ZSBmaXhtZXMKCkZ1bmN0aW9uIGB2Yy1kZWR1Y2UtZmlsZXNldCcgcHJlc2VydmVzIGN1 cnJlbnQgYnVmZmVyIHNpbmNlIGNvbW1pdApkNDk0ODMzZDQ3OTY4ZmNkOTdiYTU0OTY1NGEy NTlkNmZiNmMyZWVlLiAgQ2hhbmdlIGRvY3VtZW50YXRpb24KYWNjb3JkaW5nbHkuCiogbGlz cC92Yy92Yy5lbCAodmMtZGVkdWNlLWZpbGVzZXQpOiBDaGFuZ2UgZG9jIHN0cmluZy4KKHZj LWRlZHVjZS1maWxlc2V0LTEpOiBSZW1vdmUgbm93LW9ic29sZXRlIGZpeG1lIGNvbW1lbnQu ICAoQnVnIzYzOTQ5KQotLS0KIGxpc3AvdmMvdmMuZWwgfCA0ICsrLS0KIDEgZmlsZSBjaGFu Z2VkLCAyIGluc2VydGlvbnMoKyksIDIgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvbGlz cC92Yy92Yy5lbCBiL2xpc3AvdmMvdmMuZWwKaW5kZXggMTE0NGEyM2YzMTcuLjZiOTllYmE5 ZDNiIDEwMDY0NAotLS0gYS9saXNwL3ZjL3ZjLmVsCisrKyBiL2xpc3AvdmMvdmMuZWwKQEAg LTExMjAsNyArMTEyMCw3IEBAIHZjLWRlZHVjZS1maWxlc2V0CiBgdmMtY2hlY2tvdXQtbW9k ZWwnLiAgT3RoZXJ3aXNlLCB0aGVzZSAzIG1lbWJlcnMgbWF5IGJlIG9taXR0ZWQgZnJvbQog dGhlIHJldHVybmVkIGxpc3QuCiAKLUJFV0FSRTogdGhpcyBmdW5jdGlvbiBtYXkgY2hhbmdl IHRoZSBjdXJyZW50IGJ1ZmZlci4iCitUaGlzIGZ1bmN0aW9uIHByZXNlcnZlcyB0aGUgY3Vy cmVudCBidWZmZXIuIgogICAod2l0aC1jdXJyZW50LWJ1ZmZlciAob3IgKGJ1ZmZlci1iYXNl LWJ1ZmZlcikgKGN1cnJlbnQtYnVmZmVyKSkKICAgICAodmMtZGVkdWNlLWZpbGVzZXQtMSBu b3Qtc3RhdGUtY2hhbmdpbmcKICAgICAgICAgICAgICAgICAgICAgICAgICBhbGxvdy11bnJl Z2lzdGVyZWQKQEAgLTExNTEsNyArMTE1MSw3IEBAIHZjLWRlZHVjZS1maWxlc2V0LTEKIAkJ CQkgIChvciAoZGVyaXZlZC1tb2RlLXAgJ3ZjLWRpci1tb2RlKQogCQkJCSAgICAgIChkZXJp dmVkLW1vZGUtcCAnZGlyZWQtbW9kZSkKIAkJCQkgICAgICAoZGVyaXZlZC1tb2RlLXAgJ2Rp ZmYtbW9kZSkpKSkpCi0gICAgICAocHJvZ24gICAgICAgICAgICAgICAgICA7RklYTUU6IFdo eSBub3QgYHdpdGgtY3VycmVudC1idWZmZXInPyAtLVN0ZWYuCisgICAgICAocHJvZ24KIAko c2V0LWJ1ZmZlciB2Yy1wYXJlbnQtYnVmZmVyKQogCSh2Yy1kZWR1Y2UtZmlsZXNldC0xIG5v dC1zdGF0ZS1jaGFuZ2luZyBhbGxvdy11bnJlZ2lzdGVyZWQgc3RhdGUtbW9kZWwtb25seS1m aWxlcykpKQogICAgICAoKGFuZCAobm90IGJ1ZmZlci1maWxlLW5hbWUpCi0tIAoyLjMwLjIK Cg== --------------L19nTYjo3ump3Wb4YHxE94ky Content-Type: text/x-patch; charset=UTF-8; name="0005-Avoid-setting-circular-vc-parent-buffer.patch" Content-Disposition: attachment; filename="0005-Avoid-setting-circular-vc-parent-buffer.patch" Content-Transfer-Encoding: base64 RnJvbSA5ZjNmYzE2YWM2ZWIyZmJmNmM3M2FlZjVlNDc1NjlkYmEyY2I1ZDgwIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKZW5zIFNjaG1pZHQgPGpzY2htaWR0NGdudUB2b2Rh Zm9uZW1haWwuZGU+CkRhdGU6IEZyaSwgOSBKdW4gMjAyMyAwMDoyNDoyOCArMDIwMApTdWJq ZWN0OiBbUEFUQ0ggNS81XSBBdm9pZCBzZXR0aW5nIGNpcmN1bGFyIGB2Yy1wYXJlbnQtYnVm ZmVyJwoKT3RoZXJ3aXNlLCBjYWxsaW5nIGUuZy4gYHZjLXByaW50LWxvZycgZnJvbSBidWZm ZXIgKnZjLWNoYW5nZS1sb2cqCnNldHMgYHZjLXBhcmVudC1idWZmZXInIHRvIGl0c2VsZi4K KiBsaXNwL3ZjL3ZjLWRpc3BhdGNoZXIuZWwgKHZjLXNldHVwLWJ1ZmZlcik6IEF2b2lkIHNl dHRpbmcgY2lyY3VsYXIKYHZjLXBhcmVudC1idWZmZXInLiAgKEJ1ZyM2Mzk0OSkKLS0tCiBs aXNwL3ZjL3ZjLWRpc3BhdGNoZXIuZWwgfCAxMSArKysrKysrLS0tLQogMSBmaWxlIGNoYW5n ZWQsIDcgaW5zZXJ0aW9ucygrKSwgNCBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9saXNw L3ZjL3ZjLWRpc3BhdGNoZXIuZWwgYi9saXNwL3ZjL3ZjLWRpc3BhdGNoZXIuZWwKaW5kZXgg ZmQ1ZjY1NWEwZjYuLmFjNGQzYTc4YWZkIDEwMDY0NAotLS0gYS9saXNwL3ZjL3ZjLWRpc3Bh dGNoZXIuZWwKKysrIGIvbGlzcC92Yy92Yy1kaXNwYXRjaGVyLmVsCkBAIC0xODYsMTAgKzE4 NiwxMyBAQCB2Yy1zZXR1cC1idWZmZXIKICAgICAgIDs7IHdhbnQgYW55IG9mIGl0cyBvdXRw dXQgdG8gYXBwZWFyIGZyb20gbm93IG9uLgogICAgICAgKHdoZW4gb2xkcHJvYyAoZGVsZXRl LXByb2Nlc3Mgb2xkcHJvYykpKQogICAgIChraWxsLWFsbC1sb2NhbC12YXJpYWJsZXMpCi0g ICAgKHNldHEtbG9jYWwgdmMtcGFyZW50LWJ1ZmZlciBjYW1lZnJvbSkKLSAgICAoc2V0cS1s b2NhbCB2Yy1wYXJlbnQtYnVmZmVyLW5hbWUKLSAgICAgICAgICAgICAgICAoY29uY2F0ICIg ZnJvbSAiIChidWZmZXItbmFtZSBjYW1lZnJvbSkpKQotICAgIChzZXRxIGRlZmF1bHQtZGly ZWN0b3J5IG9sZGRpcikKKyAgICA7OyBEbyBub3Qgc2V0IHRoZSBWQyBwYXJlbnQgYnVmZmVy IGFuZCByZWxhdGVkIHZhcmlhYmxlcyB0bworICAgIDs7IG91cnNlbHZlcy4gIChCdWcjNjM5 NDkpCisgICAgKHVubGVzcyAoZXF1YWwgKGN1cnJlbnQtYnVmZmVyKSBjYW1lZnJvbSkKKyAg ICAgIChzZXRxLWxvY2FsIHZjLXBhcmVudC1idWZmZXIgY2FtZWZyb20pCisgICAgICAoc2V0 cS1sb2NhbCB2Yy1wYXJlbnQtYnVmZmVyLW5hbWUKKyAgICAgICAgICAgICAgICAgIChjb25j YXQgIiBmcm9tICIgKGJ1ZmZlci1uYW1lIGNhbWVmcm9tKSkpCisgICAgICAoc2V0cSBkZWZh dWx0LWRpcmVjdG9yeSBvbGRkaXIpKQogICAgIChsZXQgKChidWZmZXItdW5kby1saXN0IHQp CiAgICAgICAgICAgKGluaGliaXQtcmVhZC1vbmx5IHQpKQogICAgICAgKGVyYXNlLWJ1ZmZl cikpKSkKLS0gCjIuMzAuMgoK --------------L19nTYjo3ump3Wb4YHxE94ky-- From debbugs-submit-bounces@debbugs.gnu.org Thu Jun 08 19:09:33 2023 Received: (at submit) by debbugs.gnu.org; 8 Jun 2023 23:09:33 +0000 Received: from localhost ([127.0.0.1]:57874 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q7Ol2-0000on-Ko for submit@debbugs.gnu.org; Thu, 08 Jun 2023 19:09:33 -0400 Received: from lists.gnu.org ([209.51.188.17]:39500) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q7Okw-0000oX-C1 for submit@debbugs.gnu.org; Thu, 08 Jun 2023 19:09:30 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q7Oku-00070p-91 for bug-gnu-emacs@gnu.org; Thu, 08 Jun 2023 19:09:25 -0400 Received: from mr3.vodafonemail.de ([145.253.228.163]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q7Oks-0002l4-1d for bug-gnu-emacs@gnu.org; Thu, 08 Jun 2023 19:09:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vodafonemail.de; s=vfde-mb-mr2-21dec; t=1686265759; bh=2VdP0I/QOi77sP9BdbGGcgLG7c+9gbZSb1iylEphUzQ=; h=Message-ID:Date:User-Agent:Subject:Content-Language:From:To: References:In-Reply-To:Content-Type:From; b=S9D4NoWozGfw9LMHXEikzd4EofuN5xH9M1D3sVEFkkEoGMM6rgdNTIs4D2MNgJ+qF 35Ujl/BDWACMMOlaJwI0FqNZnvjJolt/207yBW58MwbhaHXGtgM23FJkw0Fc1hFt00 5I7Jrk/Z8o0OKmc+nHWJJgeGcbKemMyFPLKTRhYo= Received: from smtp.vodafone.de (unknown [10.0.0.2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by mr3.vodafonemail.de (Postfix) with ESMTPS id 4Qcfzg48TKz23q7 for ; Thu, 8 Jun 2023 23:09:19 +0000 (UTC) Received: from [192.168.178.41] (port-92-194-82-46.dynamic.as20676.net [92.194.82.46]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp.vodafone.de (Postfix) with ESMTPSA id 4Qcfzb1ptmzKm4G for ; Thu, 8 Jun 2023 23:09:12 +0000 (UTC) Message-ID: Date: Fri, 9 Jun 2023 01:09:11 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: =?UTF-8?Q?Re=3a_30=2e0=2e50=3b_=60vc-print-log=c2=b4_does_not_erase?= =?UTF-8?Q?_buffer_when_called_from_*vc-change-log*_buffer=2c_at_least_for_C?= =?UTF-8?Q?VS_logs?= Content-Language: de-DE-frami, en-US From: Jens Schmidt To: bug-gnu-emacs@gnu.org References: <8c62dd9a-3cad-b992-bfc4-64b2f1db4485@vodafonemail.de> In-Reply-To: <8c62dd9a-3cad-b992-bfc4-64b2f1db4485@vodafonemail.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-purgate-type: clean X-purgate: clean X-purgate-size: 617 X-purgate-ID: 155817::1686265755-C8FF84F8-B6D04F38/0/0 Received-SPF: pass client-ip=145.253.228.163; envelope-from=jschmidt4gnu@vodafonemail.de; helo=mr3.vodafonemail.de X-Spam_score_int: -28 X-Spam_score: -2.9 X-Spam_bar: -- X-Spam_report: (-2.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.091, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -2.5 (--) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.5 (---) Not sure about my previous patches 0004 and 0005. IMHO that commit d494833d47968fcd97ba549654a259d6fb6c2eee which introduced all these issues looks a bit flaky. (It does not even have a NEWS entry!) I think I understand what it's doing and the intention seems noble, even if it covers only a subset of VC operations. But that `with-current-buffer' around `vc-deduce-fileset', where that function explicitly declares that it changes buffer, seems to ask for more trouble. Probably somebody with deeper VC insight should review both commit d494833d47968fcd97ba549654a259d6fb6c2eee and my patches. From debbugs-submit-bounces@debbugs.gnu.org Fri Jun 09 02:09:42 2023 Received: (at 63949) by debbugs.gnu.org; 9 Jun 2023 06:09:42 +0000 Received: from localhost ([127.0.0.1]:58196 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q7VJe-0003vg-CM for submit@debbugs.gnu.org; Fri, 09 Jun 2023 02:09:42 -0400 Received: from eggs.gnu.org ([209.51.188.92]:33182) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q7VJY-0003vO-Ov for 63949@debbugs.gnu.org; Fri, 09 Jun 2023 02:09:40 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q7VJS-0001tr-UO; Fri, 09 Jun 2023 02:09:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=1nG14Ilzs+gVGuwKuSuQVgJgt0V3RRGaFIt4bKXWpJc=; b=IoWM4quhu2yp8tNpJcev 0hrtQKwIOBQqHQylBC55H4VqzVUGVwPevS2k9S6z5I1JCr8Gt+zBu9u/F1tMeSKK/5jPhuSq203Te 8SeGbJFXRNiNdD+ogCTAif8VpQ/aoNqTUxFLSRATl4FyIhVSyvi7IjFUH2GolIguKn2NS9Tg1YKn1 DBxfNFbxZqlBdnvlKno7yBBlMY00nI3jjf7BbNnLu5wkjiC6DfdVAm6gOyor4Cqg5U5i/vKqofVFh w1yINAgymq5w+OKnb9vneqPZcvdE+Oe3Wvs+jyMeVpG1opopz4sDbyKKC/r5exqcbnFJq6zYDIZik rKa24cYUeAzS/A==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q7VJP-0004iE-Kj; Fri, 09 Jun 2023 02:09:30 -0400 Date: Fri, 09 Jun 2023 09:09:36 +0300 Message-Id: <83y1kt180v.fsf@gnu.org> From: Eli Zaretskii To: Jens Schmidt In-Reply-To: <7bc0c78e-e4b5-0edc-0e9f-2f8fbafc352f@vodafonemail.de> (bug-gnu-emacs@gnu.org) Subject: Re: bug#63949: 30.0.50; =?utf-8?Q?`vc-print-log=C2=B4?= does not erase buffer when called from *vc-change-log* buffer, at least for CVS logs References: <8c62dd9a-3cad-b992-bfc4-64b2f1db4485@vodafonemail.de> <87fs729jxu.fsf@ledu-giraud.fr> <7bc0c78e-e4b5-0edc-0e9f-2f8fbafc352f@vodafonemail.de> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 63949 Cc: 63949@debbugs.gnu.org, manuel@ledu-giraud.fr X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Cc: 63949@debbugs.gnu.org > Date: Fri, 9 Jun 2023 00:10:57 +0200 > From: Jens Schmidt via "Bug reports for GNU Emacs, > the Swiss army knife of text editors" > > Caused by commit d494833d47968fcd97ba549654a259d6fb6c2eee. Which means this was a regression in Emacs 28, and we should try to fix it in Emacs 29. > There is another subtle change to (most likely) that, which seems to > affect all backends: When calling `vc-print-log' from > *vc-change-buffer*, it now modifies the VC parent buffer to itself, > which is of course incorrect. What do you mean by "modifies the VC parent buffer to itself"? Do you mean that vc-print-log makes the *vc-change-buffer* be the VC parent buffer? If so, why is this incorrect? From debbugs-submit-bounces@debbugs.gnu.org Fri Jun 09 02:41:53 2023 Received: (at 63949) by debbugs.gnu.org; 9 Jun 2023 06:41:53 +0000 Received: from localhost ([127.0.0.1]:58210 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q7Vom-0004ig-O8 for submit@debbugs.gnu.org; Fri, 09 Jun 2023 02:41:53 -0400 Received: from eggs.gnu.org ([209.51.188.92]:33502) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q7Voi-0004iQ-E0 for 63949@debbugs.gnu.org; Fri, 09 Jun 2023 02:41:51 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q7Vob-00016n-KY; Fri, 09 Jun 2023 02:41:42 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=akz8Iw9GaOnKtUSM150WHHySlLlshPWXUd3BSjZIAJU=; b=KmIWpBofGBGJR9HWW8b8 rnFnmps+WnaiRpIaBsxXK7p0L9HsDr2X7TUeZBcSJ6ULRF8oTs6dYKevuwAPyta6i+3gGupHFCBym p7sHPZD2Vt8VTEecMtn1Gypu7VAHjG9ZLhrzsiQyJ0RmlE1KIOogLfinbIk443yLjdT2fRSUc4kh5 6K+AUFIzRVXn7AtVoSBoEhCv82ERsgMFbAP4rqaa8alsR4qJpSJo0nWe8DlLoYerfm56qjjJmKYMl P4HEulPYi+8+QqRCHz1Lvp4s+xkKA04/e7zqaUX26gGcVcV9d+tqZxhwD0smdZ139/4quxai3ySSY E+rXtvcPCmo75g==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q7Vob-0007un-45; Fri, 09 Jun 2023 02:41:41 -0400 Date: Fri, 09 Jun 2023 09:41:48 +0300 Message-Id: <83wn0d16j7.fsf@gnu.org> From: Eli Zaretskii To: Jens Schmidt In-Reply-To: <965f7636-1bac-02ff-e9f2-d6848aa2df4b@vodafonemail.de> (bug-gnu-emacs@gnu.org) Subject: Re: bug#63949: 30.0.50; =?utf-8?Q?`vc-print-log=C2=B4?= does not erase buffer when called from *vc-change-log* buffer, at least for CVS logs References: <8c62dd9a-3cad-b992-bfc4-64b2f1db4485@vodafonemail.de> <965f7636-1bac-02ff-e9f2-d6848aa2df4b@vodafonemail.de> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 63949 Cc: 63949@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Fri, 9 Jun 2023 00:44:39 +0200 > From: Jens Schmidt via "Bug reports for GNU Emacs, > the Swiss army knife of text editors" > > Here come five patches for this issue, based on emacs-29: > > 0001-Always-erase-log-buffer-before-calling-vc-print-log.patch > 0002-Always-erase-log-buffer-before-calling-vc-print-log.patch > 0003-Always-erase-log-buffer-before-calling-vc-print-log.patch Please add comments there explaining the significance of the call to vc-setup-buffer and its effect, depending on what is the current buffer. > 0005-Avoid-setting-circular-vc-parent-buffer.patch > > This one fixes the issue related to VC parent buffer described in the > previous update. The "local" change seems to be logical (a buffer > should not be the VC parent buffer of itself), but I'm not quite sure > about any adverse "global" consequences. This code is very old, so at the very least we need to track its origin and understand why it was added, before discussing whether it should be removed. AFAICT, this code was introduced in commit 1a2f456b73bab4a711a51c8f84abf1d9f63a3b90, 30 years ago, and there's some explanation of the rationale in the log message. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Fri Jun 09 14:44:29 2023 Received: (at 63949) by debbugs.gnu.org; 9 Jun 2023 18:44:29 +0000 Received: from localhost ([127.0.0.1]:60328 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q7h65-0004gH-FT for submit@debbugs.gnu.org; Fri, 09 Jun 2023 14:44:29 -0400 Received: from mr6.vodafonemail.de ([145.253.228.166]:60136) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q7h63-0004g2-1E for 63949@debbugs.gnu.org; Fri, 09 Jun 2023 14:44:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vodafonemail.de; s=vfde-mb-mr2-21dec; t=1686336260; bh=Y0VILHubIwufTaMFJkJwKFxcCR9kznJJM2+334K8E/Q=; h=Message-ID:Date:User-Agent:Subject:Content-Language:To:References: From:In-Reply-To:Content-Type:From; b=m0KXom8+ucaf/TJszGGEse5rOUmxhiphwCzS4qXjQg2xndQo7z1FVG8HMKTB0rrAe obiibzt4FMe+nc+QEAZBJYnwKE07IphYUDf6AwrkreZM/6HwDBNUT2/HkCukn8G11i SzYbUI2vcT0NsdZwIVdW71vbFLvTGbTNo5i0I43c= Received: from smtp.vodafone.de (unknown [10.0.0.2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by mr6.vodafonemail.de (Postfix) with ESMTPS id 4Qd93S6LTWz1yDF; Fri, 9 Jun 2023 18:44:20 +0000 (UTC) Received: from [192.168.178.41] (port-92-194-25-231.dynamic.as20676.net [92.194.25.231]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp.vodafone.de (Postfix) with ESMTPSA id 4Qd93K3fh5z9s09; Fri, 9 Jun 2023 18:44:10 +0000 (UTC) Message-ID: <367a19b1-de9a-7e70-b550-27dba38dd970@vodafonemail.de> Date: Fri, 9 Jun 2023 20:44:09 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: =?UTF-8?B?UmU6IGJ1ZyM2Mzk0OTogMzAuMC41MDsgYHZjLXByaW50LWxvZ8K0IGRv?= =?UTF-8?Q?es_not_erase_buffer_when_called_from_*vc-change-log*_buffer=2c_at?= =?UTF-8?Q?_least_for_CVS_logs?= Content-Language: de-DE-frami, en-US To: Eli Zaretskii References: <8c62dd9a-3cad-b992-bfc4-64b2f1db4485@vodafonemail.de> <965f7636-1bac-02ff-e9f2-d6848aa2df4b@vodafonemail.de> <83wn0d16j7.fsf@gnu.org> From: Jens Schmidt In-Reply-To: <83wn0d16j7.fsf@gnu.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-purgate-type: clean X-purgate: clean X-purgate-size: 524 X-purgate-ID: 155817::1686336256-F77DD4DE-3ADAAB32/0/0 X-Spam-Score: -1.8 (-) X-Debbugs-Envelope-To: 63949 Cc: 63949@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.8 (--) > This code is very old, so at the very least we need to track its > origin and understand why it was added, before discussing whether it > should be removed. [...] Totally agreed. Pls ignore my patches for the time being, I just hacked them together before really thinking and getting to the root cause of my issues. I'm trying to get into contact with Nathan, the author of the enhancement that caused the regression, to see whether he can provide more information than what is contained in his bug#40967. From debbugs-submit-bounces@debbugs.gnu.org Fri Jun 09 16:27:58 2023 Received: (at 63949) by debbugs.gnu.org; 9 Jun 2023 20:27:58 +0000 Received: from localhost ([127.0.0.1]:60986 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q7iiE-0007UP-FE for submit@debbugs.gnu.org; Fri, 09 Jun 2023 16:27:58 -0400 Received: from mr4.vodafonemail.de ([145.253.228.164]:36910) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q7iiC-0007UB-MW for 63949@debbugs.gnu.org; Fri, 09 Jun 2023 16:27:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vodafonemail.de; s=vfde-mb-mr2-21dec; t=1686342471; bh=ieZ38042yCBbFfQeWAQpILW78lmrNgrXOwJciBOG78A=; h=Message-ID:Date:User-Agent:Subject:Content-Language:To:References: From:In-Reply-To:Content-Type:From; b=i4vWVFwjedGwe0BHfX4ngArlzMJUjQVje6UujaIUxd5zV0W3RndfMIho3YYGXxsQH 7G0nS2kwJ4wP8sh098V9Bjq7x1GZvgTjV6O60tyJihiFU4BSCdtvGxlf/5ytCEok3G LzNoJTXubOz9VEPQ4Ta0hcEWQiJ9XAITbGe4b6Dk= Received: from smtp.vodafone.de (unknown [10.0.0.2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by mr4.vodafonemail.de (Postfix) with ESMTPS id 4QdCLv2z2jz1y9V; Fri, 9 Jun 2023 20:27:51 +0000 (UTC) Received: from [192.168.178.41] (port-92-194-25-231.dynamic.as20676.net [92.194.25.231]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp.vodafone.de (Postfix) with ESMTPSA id 4QdCLh6bgxzMm7G; Fri, 9 Jun 2023 20:27:37 +0000 (UTC) Message-ID: <8477db3b-b237-aa4b-b4aa-41d31cb77ac1@vodafonemail.de> Date: Fri, 9 Jun 2023 22:27:37 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: =?UTF-8?B?UmU6IGJ1ZyM2Mzk0OTogMzAuMC41MDsgYHZjLXByaW50LWxvZ8K0IGRv?= =?UTF-8?Q?es_not_erase_buffer_when_called_from_*vc-change-log*_buffer=2c_at?= =?UTF-8?Q?_least_for_CVS_logs?= Content-Language: de-DE-frami, en-US To: Eli Zaretskii References: <8c62dd9a-3cad-b992-bfc4-64b2f1db4485@vodafonemail.de> <87fs729jxu.fsf@ledu-giraud.fr> <7bc0c78e-e4b5-0edc-0e9f-2f8fbafc352f@vodafonemail.de> <83y1kt180v.fsf@gnu.org> From: Jens Schmidt In-Reply-To: <83y1kt180v.fsf@gnu.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-purgate-type: clean X-purgate: clean X-purgate-size: 1324 X-purgate-ID: 155817::1686342467-7FFFE4B9-48ECDA2B/0/0 X-Spam-Score: -1.8 (-) X-Debbugs-Envelope-To: 63949 Cc: 63949@debbugs.gnu.org, manuel@ledu-giraud.fr X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.8 (--) On 2023-06-09 08:09, Eli Zaretskii wrote: > What do you mean by "modifies the VC parent buffer to itself"? Do > you mean that vc-print-log makes the *vc-change-buffer* be the VC > parent buffer? If so, why is this incorrect? Hope below recipe explains it. The general idea is to start a VC command first from the buffer of a VC-controlled file, then from the VC result buffer, again from the VC result buffer, etc. emacs -Q (from emacs-29) ;; current buffer equals README C-x v l ;; current buffer equals *vc-change-log* C-h v vc-parent-buffer => # ;; current buffer equals *vc-change-log* C-x v l C-h v vc-parent-buffer => # ;; current buffer equals *vc-change-log* C-x v l ;; git log of whole repository is displayed, not of README I backed out commit d494833d47968fcd97ba549654a259d6fb6c2eee from emacs-29 - both issues (the initial CVS-related one and the above one) are gone after having done so. Not all VC commands expose this problem. `vc-annotate' seems to work and even the VC parent buffer stays unchanged when invoking `vc-annotate' repeatedly. `vc-diff' gets the parent buffer wrong but seems to work when invoked from buffer *vc-diff* repeatedly even if parent buffer is wrong. From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 10 02:01:38 2023 Received: (at 63949) by debbugs.gnu.org; 10 Jun 2023 06:01:38 +0000 Received: from localhost ([127.0.0.1]:33097 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q7rfN-0005u2-Nm for submit@debbugs.gnu.org; Sat, 10 Jun 2023 02:01:37 -0400 Received: from eggs.gnu.org ([209.51.188.92]:52044) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q7rfK-0005tl-Km for 63949@debbugs.gnu.org; Sat, 10 Jun 2023 02:01:35 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q7rfD-0005g3-VH; Sat, 10 Jun 2023 02:01:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=BytZ5xbB4oAwNZJ7YuRGWWPT7eAKXhaWG01k581sSy4=; b=GE/EN3tHN5lYzFPGYaei Snpyg/kCth83Ju7wV6ucoo8LHSTFIhyLCLaqx+3ynsFsU78h8K/F3U2uP3SmozUPzQJGZWVksR0nG ToLCjJw4Olf+CaihiTnOztTeM+ndmqsf1t2Q+LUFHtbh5YQe9zrFlSnHyX4G4QT3Uv0+XaJRCl8nZ PgSYyHf3NMm4ghoi0ZqucpSJXksteXkU2slHgtqNzkm5r2rnVDYPsqZYEQlTJnbIqm9Lcs7VoODzf rUrtsghtSpTG4xXpjCpNCwBQS9Tw79KPGDzNFFzNkODGY8fRT7T9hu1lSMlFEvcnso6x8IWRwdthG XyICjtaMhvFs2g==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q7rfC-0005Kr-MA; Sat, 10 Jun 2023 02:01:27 -0400 Date: Sat, 10 Jun 2023 09:01:37 +0300 Message-Id: <834jnf26v2.fsf@gnu.org> From: Eli Zaretskii To: Jens Schmidt In-Reply-To: <8477db3b-b237-aa4b-b4aa-41d31cb77ac1@vodafonemail.de> (message from Jens Schmidt on Fri, 9 Jun 2023 22:27:37 +0200) Subject: Re: bug#63949: 30.0.50; =?utf-8?Q?`vc-print-log=C2=B4?= does not erase buffer when called from *vc-change-log* buffer, at least for CVS logs References: <8c62dd9a-3cad-b992-bfc4-64b2f1db4485@vodafonemail.de> <87fs729jxu.fsf@ledu-giraud.fr> <7bc0c78e-e4b5-0edc-0e9f-2f8fbafc352f@vodafonemail.de> <83y1kt180v.fsf@gnu.org> <8477db3b-b237-aa4b-b4aa-41d31cb77ac1@vodafonemail.de> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 63949 Cc: 63949@debbugs.gnu.org, manuel@ledu-giraud.fr X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Fri, 9 Jun 2023 22:27:37 +0200 > Cc: manuel@ledu-giraud.fr, 63949@debbugs.gnu.org > From: Jens Schmidt > > emacs -Q (from emacs-29) > > > ;; current buffer equals README > C-x v l > ;; current buffer equals *vc-change-log* > C-h v vc-parent-buffer > => # > > ;; current buffer equals *vc-change-log* > C-x v l > C-h v vc-parent-buffer > => # > > ;; current buffer equals *vc-change-log* > C-x v l > ;; git log of whole repository is displayed, not of README Thanks for the explanations. > Not all VC commands expose this problem. Why do you think it's a problem? I can justify this behavior, at least in some use cases. From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 10 11:44:56 2023 Received: (at 63949) by debbugs.gnu.org; 10 Jun 2023 15:44:56 +0000 Received: from localhost ([127.0.0.1]:36124 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q80ls-00083p-2g for submit@debbugs.gnu.org; Sat, 10 Jun 2023 11:44:56 -0400 Received: from mr3.vodafonemail.de ([145.253.228.163]:48786) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q80ln-00083Y-0n for 63949@debbugs.gnu.org; Sat, 10 Jun 2023 11:44:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vodafonemail.de; s=vfde-mb-mr2-21dec; t=1686411885; bh=BFyj3E2wmMiLgSUUJzs19OT3ley6CyeE2PBZmBk/f9Y=; h=Message-ID:Date:User-Agent:Subject:To:References:Content-Language: From:In-Reply-To:Content-Type:From; b=QXLLH7dGGH1hQwvME+z1AWgSQQA6rqlsHbIEX7RIGrGbrxfxUOQzPklNG+5AYbRjJ vvJZUN1+Deg/iAuBoDk9vO0G88SgLI0qFibRoHI6MSFLIEO3xmuV2vbCuKFBD9W3uI JhqNL5iq7iMVvN8y8MRbDkQJxGWsUZ2vbephfDLE= Received: from smtp.vodafone.de (unknown [10.0.0.2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by mr3.vodafonemail.de (Postfix) with ESMTPS id 4Qdj1n0Zszz210y; Sat, 10 Jun 2023 15:44:44 +0000 (UTC) Received: from [192.168.178.41] (port-92-194-236-191.dynamic.as20676.net [92.194.236.191]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp.vodafone.de (Postfix) with ESMTPSA id 4Qdj1Z2tk0z9sbZ; Sat, 10 Jun 2023 15:44:31 +0000 (UTC) Message-ID: Date: Sat, 10 Jun 2023 17:44:26 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: =?UTF-8?B?UmU6IGJ1ZyM2Mzk0OTogMzAuMC41MDsgYHZjLXByaW50LWxvZ8K0IGRv?= =?UTF-8?Q?es_not_erase_buffer_when_called_from_*vc-change-log*_buffer=2c_at?= =?UTF-8?Q?_least_for_CVS_logs?= To: Eli Zaretskii References: <8c62dd9a-3cad-b992-bfc4-64b2f1db4485@vodafonemail.de> <87fs729jxu.fsf@ledu-giraud.fr> <7bc0c78e-e4b5-0edc-0e9f-2f8fbafc352f@vodafonemail.de> <83y1kt180v.fsf@gnu.org> <8477db3b-b237-aa4b-b4aa-41d31cb77ac1@vodafonemail.de> <834jnf26v2.fsf@gnu.org> Content-Language: de-DE-frami, en-US From: Jens Schmidt In-Reply-To: <834jnf26v2.fsf@gnu.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-purgate-type: clean X-purgate: clean X-purgate-size: 3010 X-purgate-ID: 155817::1686411880-28FF84F8-170957F0/0/0 X-Spam-Score: -1.8 (-) X-Debbugs-Envelope-To: 63949 Cc: 63949@debbugs.gnu.org, manuel@ledu-giraud.fr X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.8 (--) On 2023-06-10 08:01, Eli Zaretskii wrote: > Why do you think it's a problem? I can justify this behavior, at > least in some use cases. Let's distinguish "VC-controlled buffers" like the buffer of a VC-controlled file or a *vc-dir* buffer or a dired buffer of VC-controlled directory. And "VC working buffers", like *vc-change-log*, *vc-log*, *vc-diff*. It is my understanding that `vc-parent-buffer' in a VC working buffer points to the VC-controlled buffer from which it originates. The rationale of that variable is to allow VC operations from a VC working buffer as if executed on the original VC-controlled buffer. So I can do C-x v l, pick a commit, do a C-x v ~ on that commit, then a C-x v =, and all these operations would automagically relate to the original VC-controlled buffer. At least I use that concept frequently. The documentation on `vc-parent-buffer', unfortunately, is out of date and does not necessarily support my understanding: ;; In a log entry buffer, this is a local variable ;; that points to the buffer for which it was made ;; (either a file, or a directory buffer). However, this has been working as described by me up to and including Emacs 27. So at least we can say that the fix fur bug#40967 has changed established behavior. And also the following code snippet from function `vc-deduce-fileset-1' seems to prove my point: ((and (buffer-live-p vc-parent-buffer) ;; FIXME: Why this test? --Stef (or (buffer-file-name vc-parent-buffer) (with-current-buffer vc-parent-buffer (or (derived-mode-p 'vc-dir-mode) (derived-mode-p 'dired-mode) (derived-mode-p 'diff-mode))))) (progn ;FIXME: Why not `with-current-buffer'? --Stef. (set-buffer vc-parent-buffer) (vc-deduce-fileset-1 not-state-changing allow-unregistered state-model-only-files))) Meaning: If the current buffer has a live vc-parent-buffer, this function switches to it and deduces the fileset from that. Plus it leaves the VC parent buffer current, which is important for follow-up code to keep the VC parent buffer unchanged. That logic used to work as intended (by me) up to Nathan's commit, which put a `with-current-buffer' around the whole function and rendered the `set-buffer' side effect pointless. Let's put it that way: The pre-28 logic of handling the VC parent buffer was not necessarily clean, as also pointed out by Stefan. But I think the concept of having a stable VC parent buffer across multiple VC operations is nice, and changing it midway according to rather unclear rules undesirable. Ideally, we would have a fix that handled indirect buffers and VC parent buffers (which are somewhat similar by concept) all consistently and nicely and in a stable way, at the same time fixing both issues that I have. I'll mediate about that... From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 10 11:55:23 2023 Received: (at 63949) by debbugs.gnu.org; 10 Jun 2023 15:55:23 +0000 Received: from localhost ([127.0.0.1]:36133 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q80vy-0008Pj-Rc for submit@debbugs.gnu.org; Sat, 10 Jun 2023 11:55:23 -0400 Received: from mr4.vodafonemail.de ([145.253.228.164]:34570) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q80vv-0008PO-Nh for 63949@debbugs.gnu.org; Sat, 10 Jun 2023 11:55:21 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vodafonemail.de; s=vfde-mb-mr2-21dec; t=1686412514; bh=3X9ssRrSApyXoiz01rkmRjyNtc9Fa7BUNILeKag6+Zo=; h=Message-ID:Date:User-Agent:Subject:Content-Language:From:To: References:In-Reply-To:Content-Type:From; b=NnL5sxp+qBD03VHe7TLnNaqWN7WZLVY6fSE26dkraPFpPSKInWLYMMvxwS0OqyC3e 6v/GfsA/ngNtzKDzq2vWHKUtK5p+6D2HnFcaQFAvyFxSYcPgXbccW84SZxpY+9LiXn u+J/d/nPFYF/VYCRXiLJrztMmC4yUAG//7RVEv+o= Received: from smtp.vodafone.de (unknown [10.0.0.2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by mr4.vodafonemail.de (Postfix) with ESMTPS id 4QdjFt27Hxz1y0r; Sat, 10 Jun 2023 15:55:14 +0000 (UTC) Received: from [192.168.178.41] (port-92-194-236-191.dynamic.as20676.net [92.194.236.191]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp.vodafone.de (Postfix) with ESMTPSA id 4QdjFl6HTszMkrw; Sat, 10 Jun 2023 15:55:04 +0000 (UTC) Message-ID: <810c40b2-77d3-c55d-6e50-4f253da9068d@vodafonemail.de> Date: Sat, 10 Jun 2023 17:55:04 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: =?UTF-8?B?UmU6IGJ1ZyM2Mzk0OTogMzAuMC41MDsgYHZjLXByaW50LWxvZ8K0IGRv?= =?UTF-8?Q?es_not_erase_buffer_when_called_from_*vc-change-log*_buffer=2c_at?= =?UTF-8?Q?_least_for_CVS_logs?= Content-Language: de-DE-frami, en-US From: Jens Schmidt To: Eli Zaretskii References: <8c62dd9a-3cad-b992-bfc4-64b2f1db4485@vodafonemail.de> <87fs729jxu.fsf@ledu-giraud.fr> <7bc0c78e-e4b5-0edc-0e9f-2f8fbafc352f@vodafonemail.de> <83y1kt180v.fsf@gnu.org> <8477db3b-b237-aa4b-b4aa-41d31cb77ac1@vodafonemail.de> <834jnf26v2.fsf@gnu.org> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-purgate-type: clean X-purgate: clean X-purgate-size: 44 X-purgate-ID: 155817::1686412514-5A7FB4D1-B8EEED31/0/0 X-Spam-Score: -1.8 (-) X-Debbugs-Envelope-To: 63949 Cc: 63949@debbugs.gnu.org, manuel@ledu-giraud.fr X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.8 (--) > I'll mediate about that... *meditate* From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 10 13:23:08 2023 Received: (at 63949) by debbugs.gnu.org; 10 Jun 2023 17:23:08 +0000 Received: from localhost ([127.0.0.1]:36194 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q82It-0002DH-PG for submit@debbugs.gnu.org; Sat, 10 Jun 2023 13:23:08 -0400 Received: from eggs.gnu.org ([209.51.188.92]:36864) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q82Ip-0002CX-6U for 63949@debbugs.gnu.org; Sat, 10 Jun 2023 13:23:05 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q82Ii-0008If-7f; Sat, 10 Jun 2023 13:22:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=U+DUBQ8YJ+yFqKKk7jTUNzXXgkqId9Y1FaCJASP7Mb4=; b=Fx++oiGiIBr7Sn5rVwsA eGKjHw48yUQ73Nx9xOvCJ89kNZciUZGBaoBJZe/PwlyfqVs1jIjdSs5c/17tt03xjMioFdLfpTF00 ToEIpIgRyKGFVV/vWrJaPot5vY44PCGB6ALipgC05/EQAcsx0JiSb5AOrw+maaHsJW2B++TZaZNJM /p+vYUdkax++vhGEJ8SbXKu/hm6PaAs/IpzKIL+y0cOFhH7679/2MItrhAjQL6Z+YZtMjvY85xqAh SrSU8I1WfD113xZPXbEjG+KBxbK4tT1+L8utc7lylLFKK2scCqSuojVJoUnhcHs2LeA9L/C3uNgnc WN9uCLVStMHgtg==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q82Ih-0003vU-OZ; Sat, 10 Jun 2023 13:22:56 -0400 Date: Sat, 10 Jun 2023 20:23:06 +0300 Message-Id: <83ilbvz0xx.fsf@gnu.org> From: Eli Zaretskii To: Jens Schmidt In-Reply-To: (message from Jens Schmidt on Sat, 10 Jun 2023 17:44:26 +0200) Subject: Re: bug#63949: 30.0.50; =?utf-8?Q?`vc-print-log=C2=B4?= does not erase buffer when called from *vc-change-log* buffer, at least for CVS logs References: <8c62dd9a-3cad-b992-bfc4-64b2f1db4485@vodafonemail.de> <87fs729jxu.fsf@ledu-giraud.fr> <7bc0c78e-e4b5-0edc-0e9f-2f8fbafc352f@vodafonemail.de> <83y1kt180v.fsf@gnu.org> <8477db3b-b237-aa4b-b4aa-41d31cb77ac1@vodafonemail.de> <834jnf26v2.fsf@gnu.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 63949 Cc: 63949@debbugs.gnu.org, manuel@ledu-giraud.fr X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Sat, 10 Jun 2023 17:44:26 +0200 > Cc: manuel@ledu-giraud.fr, 63949@debbugs.gnu.org > From: Jens Schmidt > > On 2023-06-10 08:01, Eli Zaretskii wrote: > > > Why do you think it's a problem? I can justify this behavior, at > > least in some use cases. > > Let's distinguish "VC-controlled buffers" like the buffer of a > VC-controlled file or a *vc-dir* buffer or a dired buffer of > VC-controlled directory. And "VC working buffers", like > *vc-change-log*, *vc-log*, *vc-diff*. First, let me clarify what I alluded to as "a problem": I meant the fact that "C-x v l" in a *vc-change-log* buffer shows the log for the entire repository. How this is accomplished by setting vc-parent-buffer is an implementation detail. > It is my understanding that `vc-parent-buffer' in a VC working buffer > points to the VC-controlled buffer from which it originates. The > rationale of that variable is to allow VC operations from a VC working > buffer as if executed on the original VC-controlled buffer. So I can do > C-x v l, pick a commit, do a C-x v ~ on that commit, then a C-x v =, and > all these operations would automagically relate to the original > VC-controlled buffer. At least I use that concept frequently. If the backend is a VCS that records changes per-file, what you want will happen automatically, since "C-x v l" and other operations must in general refer to a file with those VCSes. For backends that record changes per-repository, why does it make sense that typing "C-x v l" from a buffer that already shows a log should produce the same log again? > The documentation on `vc-parent-buffer', unfortunately, is out of date > and does not necessarily support my understanding: > > ;; In a log entry buffer, this is a local variable > ;; that points to the buffer for which it was made > ;; (either a file, or a directory buffer). We need to define what we want vc-parent-buffer to mean, and then we should adjust the documentation and keep our promises about that variable in the future. > However, this has been working as described by me up to and including > Emacs 27. So at least we can say that the fix fur bug#40967 has changed > established behavior. Probably because no one realized that this must be the established behavior. > That logic used to work as intended (by me) up to Nathan's commit, which > put a `with-current-buffer' around the whole function and rendered the > `set-buffer' side effect pointless. > > Let's put it that way: The pre-28 logic of handling the VC parent buffer > was not necessarily clean, as also pointed out by Stefan. But I think > the concept of having a stable VC parent buffer across multiple VC > operations is nice, and changing it midway according to rather unclear > rules undesirable. > > Ideally, we would have a fix that handled indirect buffers and VC parent > buffers (which are somewhat similar by concept) all consistently and > nicely and in a stable way, at the same time fixing both issues that I > have. I'll mediate about that... If you can suggest changes to make the treatment of vc-parent-buffer more consistent, that would be good, I think. I'd also like to hear Dmitry's views on these issues. He was until now silent in this discussion, AFAICT. From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 10 17:18:24 2023 Received: (at 63949) by debbugs.gnu.org; 10 Jun 2023 21:18:24 +0000 Received: from localhost ([127.0.0.1]:36399 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q85yZ-00007G-Qw for submit@debbugs.gnu.org; Sat, 10 Jun 2023 17:18:24 -0400 Received: from mr3.vodafonemail.de ([145.253.228.163]:50348) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q85yW-00006z-J8 for 63949@debbugs.gnu.org; Sat, 10 Jun 2023 17:18:22 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vodafonemail.de; s=vfde-mb-mr2-21dec; t=1686431895; bh=XnUWWzoMxj87zul7kfS4OweIsmNTZVodL0eK1bliboc=; h=Message-ID:Date:User-Agent:Subject:Content-Language:To:References: From:In-Reply-To:Content-Type:From; b=edEHb+5LgmmGvDT8NcSm35XbsChA9ALDEWwfm8lJ7blybRopFssg0uOxoip72VyBu bHhJRNzL1pHPDYFIexU818CFxYQE4uh1GZngfP3BQVRNrUuBqFiUkGrr8n21jXRYc7 rDhoQFwc6lRCOhpxIrugB16PCmgdEWjqfWyda6Nc= Received: from smtp.vodafone.de (unknown [10.0.0.2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by mr3.vodafonemail.de (Postfix) with ESMTPS id 4QdrQb1Bzpz218k; Sat, 10 Jun 2023 21:18:14 +0000 (UTC) Received: from [192.168.178.41] (port-92-194-236-191.dynamic.as20676.net [92.194.236.191]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp.vodafone.de (Postfix) with ESMTPSA id 4QdrQN4TTbzHnHT; Sat, 10 Jun 2023 21:18:01 +0000 (UTC) Message-ID: Date: Sat, 10 Jun 2023 23:18:01 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: =?UTF-8?B?UmU6IGJ1ZyM2Mzk0OTogMzAuMC41MDsgYHZjLXByaW50LWxvZ8K0IGRv?= =?UTF-8?Q?es_not_erase_buffer_when_called_from_*vc-change-log*_buffer=2c_at?= =?UTF-8?Q?_least_for_CVS_logs?= Content-Language: de-DE-frami, en-US To: Eli Zaretskii References: <8c62dd9a-3cad-b992-bfc4-64b2f1db4485@vodafonemail.de> <87fs729jxu.fsf@ledu-giraud.fr> <7bc0c78e-e4b5-0edc-0e9f-2f8fbafc352f@vodafonemail.de> <83y1kt180v.fsf@gnu.org> <8477db3b-b237-aa4b-b4aa-41d31cb77ac1@vodafonemail.de> <834jnf26v2.fsf@gnu.org> <83ilbvz0xx.fsf@gnu.org> From: Jens Schmidt In-Reply-To: <83ilbvz0xx.fsf@gnu.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-purgate-type: clean X-purgate: clean X-purgate-size: 1222 X-purgate-ID: 155817::1686431890-8C7D74F5-AEC52671/0/0 X-Spam-Score: -1.8 (-) X-Debbugs-Envelope-To: 63949 Cc: 63949@debbugs.gnu.org, manuel@ledu-giraud.fr X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.8 (--) On 2023-06-10 19:23, Eli Zaretskii wrote: > If the backend is a VCS that records changes per-file, what you want > will happen automatically, since "C-x v l" and other operations must > in general refer to a file with those VCSes. For backends that > record changes per-repository, why does it make sense that typing > "C-x v l" from a buffer that already shows a log should produce the > same log again? To get it updated, for example because I perform some operation outside of Emacs. One of these habits ... > If you can suggest changes to make the treatment of vc-parent-buffer > more consistent, that would be good, I think. Here is another minor ugliness I forgot to mention so far which also should be defined and fixed, then: Whenever the `vc-parent-buffer' goes "out of sync" (as far as I am concerned) in some VC working buffer, its mode line shows, e.g. *vc-change-log* Top 1 (Git-Log-View from *vc-change-log*) or *vc-diff [...] (Diff ws from *vc-diff*) since mode line variable `vc-parent-buffer-name' goes likewise out of sync. > I'd also like to hear Dmitry's views on these issues. He was until > now silent in this discussion, AFAICT. Agreed. From debbugs-submit-bounces@debbugs.gnu.org Sun Jun 11 01:06:31 2023 Received: (at 63949) by debbugs.gnu.org; 11 Jun 2023 05:06:31 +0000 Received: from localhost ([127.0.0.1]:36556 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q8DHb-0003iD-FH for submit@debbugs.gnu.org; Sun, 11 Jun 2023 01:06:31 -0400 Received: from eggs.gnu.org ([209.51.188.92]:43084) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q8DHZ-0003hx-AG for 63949@debbugs.gnu.org; Sun, 11 Jun 2023 01:06:30 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q8DHR-0007iY-QN; Sun, 11 Jun 2023 01:06:22 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=ax1kWONRZkJBBMOPIukVxer+zKCUhQUIZm4UjWIdChk=; b=Gc7Rk2ypBOhCAmmyU1MU 8TN1njUfkpYLqSoZX+Z2+xnj0WKqYLqB6twA1wnMxqYysTBUMWvHZOkxXSCzIQPqOs/abKfPdua4Z SllqafJDRRh6AZJrED9NpSD+zPOwNS5p2K6T0kKynHDK9gLV3Jqc9FxKTut/CzQCsoSLTqAKezW95 uK3+GoHMzbwZLFYaaX3Wm6sIFpEsB73cVgGYMrLKIX2+vBNX51oIGuuBa5sC32Fhug0sKy0ZqyMCA j/tdg8QIggj16RFl73R1SdFsaBlnM6v+ROt26Q7YSuNCpiNPQR7YfBXA8hNNu8kIpMr5p9U30KW6k k2VXWON/XKb0cQ==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q8DHE-0001Ka-2u; Sun, 11 Jun 2023 01:06:09 -0400 Date: Sun, 11 Jun 2023 08:06:21 +0300 Message-Id: <838rcqziya.fsf@gnu.org> From: Eli Zaretskii To: Jens Schmidt In-Reply-To: (message from Jens Schmidt on Sat, 10 Jun 2023 23:18:01 +0200) Subject: Re: bug#63949: 30.0.50; =?utf-8?Q?`vc-print-log=C2=B4?= does not erase buffer when called from *vc-change-log* buffer, at least for CVS logs References: <8c62dd9a-3cad-b992-bfc4-64b2f1db4485@vodafonemail.de> <87fs729jxu.fsf@ledu-giraud.fr> <7bc0c78e-e4b5-0edc-0e9f-2f8fbafc352f@vodafonemail.de> <83y1kt180v.fsf@gnu.org> <8477db3b-b237-aa4b-b4aa-41d31cb77ac1@vodafonemail.de> <834jnf26v2.fsf@gnu.org> <83ilbvz0xx.fsf@gnu.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 63949 Cc: 63949@debbugs.gnu.org, manuel@ledu-giraud.fr X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Sat, 10 Jun 2023 23:18:01 +0200 > Cc: manuel@ledu-giraud.fr, 63949@debbugs.gnu.org > From: Jens Schmidt > > On 2023-06-10 19:23, Eli Zaretskii wrote: > > > If the backend is a VCS that records changes per-file, what you want > > will happen automatically, since "C-x v l" and other operations must > > in general refer to a file with those VCSes. For backends that > > record changes per-repository, why does it make sense that typing > > "C-x v l" from a buffer that already shows a log should produce the > > same log again? > > To get it updated, for example because I perform some operation outside > of Emacs. One of these habits ... If there's more than one natural meaning of a command, the usual way we solve the dilemma is by using a prefix argument. From debbugs-submit-bounces@debbugs.gnu.org Fri Jun 16 15:33:56 2023 Received: (at 63949) by debbugs.gnu.org; 16 Jun 2023 19:33:56 +0000 Received: from localhost ([127.0.0.1]:50421 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qAFCm-0002Y1-DK for submit@debbugs.gnu.org; Fri, 16 Jun 2023 15:33:56 -0400 Received: from mr6.vodafonemail.de ([145.253.228.166]:34464) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qAFCk-0002Xp-Ob for 63949@debbugs.gnu.org; Fri, 16 Jun 2023 15:33:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vodafonemail.de; s=vfde-mb-mr2-21dec; t=1686944028; bh=lJQNxFBBkaf3aqv/ZnLhCe4D2fv+CsO5m3TZk1inZps=; h=Message-ID:Date:User-Agent:Subject:Content-Language:To:References: From:In-Reply-To:Content-Type:From; b=QikvPmDuJex4awEh8bKYmdtdHbE+RWHwsRlXPS+/+kMzKo+7p2ahD5JAeE9TlyIbD d/jf4r2SAUOpc29zF4rSy/8v/cd1+CDcILT6GysJfr9yzl2koEEfkfwRzwGt9J6fe4 Px50XoykD0WWo8szBpS3/jogmFIdtNYwqELHFwHA= Received: from smtp.vodafone.de (unknown [10.0.0.2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by mr6.vodafonemail.de (Postfix) with ESMTPS id 4QjTqJ4pY7z1yB7; Fri, 16 Jun 2023 19:33:48 +0000 (UTC) Received: from [192.168.178.41] (port-92-194-181-255.dynamic.as20676.net [92.194.181.255]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp.vodafone.de (Postfix) with ESMTPSA id 4QjTq6048xzHpxd; Fri, 16 Jun 2023 19:33:34 +0000 (UTC) Message-ID: <7fe39b49-8319-d7ab-99b3-afe10dc62177@vodafonemail.de> Date: Fri, 16 Jun 2023 21:33:34 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: =?UTF-8?B?UmU6IGJ1ZyM2Mzk0OTogMzAuMC41MDsgYHZjLXByaW50LWxvZ8K0IGRv?= =?UTF-8?Q?es_not_erase_buffer_when_called_from_*vc-change-log*_buffer=2c_at?= =?UTF-8?Q?_least_for_CVS_logs?= Content-Language: de-DE-frami, en-US To: Eli Zaretskii , Dmitry Gutov References: <8c62dd9a-3cad-b992-bfc4-64b2f1db4485@vodafonemail.de> <87fs729jxu.fsf@ledu-giraud.fr> <7bc0c78e-e4b5-0edc-0e9f-2f8fbafc352f@vodafonemail.de> <83y1kt180v.fsf@gnu.org> <8477db3b-b237-aa4b-b4aa-41d31cb77ac1@vodafonemail.de> <834jnf26v2.fsf@gnu.org> <83ilbvz0xx.fsf@gnu.org> From: Jens Schmidt In-Reply-To: <83ilbvz0xx.fsf@gnu.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-purgate-type: clean X-purgate: clean X-purgate-size: 368 X-purgate-ID: 155817::1686944024-E97FFD81-783C40A4/0/0 X-Spam-Score: -1.8 (-) X-Debbugs-Envelope-To: 63949 Cc: 63949@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.8 (--) On 2023-06-10 19:23, Eli Zaretskii wrote: > I'd also like to hear Dmitry's views on these issues. He was until > now silent in this discussion, AFAICT. @Dmitry: What's your view on these issues? Just making the handling of VC parent buffer more documented and "more consistent", whatever that means, or do you prefer some particular direction? Thanks From debbugs-submit-bounces@debbugs.gnu.org Fri Jun 16 23:15:26 2023 Received: (at 63949) by debbugs.gnu.org; 17 Jun 2023 03:15:26 +0000 Received: from localhost ([127.0.0.1]:50677 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qAMPO-0005W1-Je for submit@debbugs.gnu.org; Fri, 16 Jun 2023 23:15:26 -0400 Received: from wout1-smtp.messagingengine.com ([64.147.123.24]:39239) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qAMPL-0005Vk-UQ for 63949@debbugs.gnu.org; Fri, 16 Jun 2023 23:15:24 -0400 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id 0F62A320082A; Fri, 16 Jun 2023 23:15:17 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Fri, 16 Jun 2023 23:15:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm3; t= 1686971717; x=1687058117; bh=ThsaJuujtvg2XpT3B2JObyi1l1YacLCaIjd yyTH5ADA=; b=MdeNzVaavHXUm6GYzhrJk7VokVVzcdcViGL2IEOTZoGNP9yCdkV E+spZE7yKva/qlIWdYSHUbCg5o0u7TMb0ptoZPxhwYIAh5mWA2lxytYhDDmhw/bg ntlDusntLOZ99Xq6aInrCnGsGxZFagusOxue25w5YAuSz1Zwoxr0ps732+xDJ+7l nrgy3Iuj9emc0BKoa/PfvdvvIHHMNNq+VB0Sgmxg0EQCq3RKfVJw9Jefy6RaMraI LCapRSww0NbYvlmmV+u3seRioUp8gYFRSH4qZ1OGagtT2wqcoSXvGferfwpJG5+Q Ph+68dk6WUG1tziJ3udCD//fCXIHAuDecew== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1686971717; x=1687058117; bh=ThsaJuujtvg2XpT3B2JObyi1l1YacLCaIjd yyTH5ADA=; b=oB/ElZwXwbJZoc4xIEouJhhq+IjMfeKRPAtXQeKJGxZuNVz4+EC S/y0R4h0TsKd94VRQkNUftHcHR91zT6VBq32Bic8iaVMMoWBX6B6cnGCPT+odCYS hTM4h39TR0/2G8SrAuU9wHrLfz4fqVq/Em20aRdKr8VN6l+OICzmk1BMr7n2kXTJ YNYdC6JdReqRdq3DBDN2ZSeNMwHRSf5OMRvXIdk0y3W05eV1CJLW6fb2BhqLdkuk XhEAV21plL/2LRRLkGTPU7UJppXtcSpSmsjrqfR+mXVQEPlNtGLSwzxC/z3nOfK2 A8G0xKgYfxXbRovQ8QB++LF6Pn0GrMljAOQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrgedviedgfedtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepkfffgggfuffvvehfhfgjtgfgsehtkeertddtfeejnecuhfhrohhmpeffmhhi thhrhicuifhuthhovhcuoegumhhithhrhiesghhuthhovhdruggvvheqnecuggftrfgrth htvghrnhephfffheeljeffgeffueeghfekkedtfffgheejvdegjeettdduheeufffggfef jeehnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepug hmihhtrhihsehguhhtohhvrdguvghv X-ME-Proxy: Feedback-ID: i0e71465a:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 16 Jun 2023 23:15:16 -0400 (EDT) Message-ID: Date: Sat, 17 Jun 2023 06:15:14 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: =?UTF-8?B?UmU6IGJ1ZyM2Mzk0OTogMzAuMC41MDsgYHZjLXByaW50LWxvZ8K0IGRv?= =?UTF-8?Q?es_not_erase_buffer_when_called_from_*vc-change-log*_buffer=2c_at?= =?UTF-8?Q?_least_for_CVS_logs?= Content-Language: en-US To: Jens Schmidt , Eli Zaretskii References: <8c62dd9a-3cad-b992-bfc4-64b2f1db4485@vodafonemail.de> <87fs729jxu.fsf@ledu-giraud.fr> <7bc0c78e-e4b5-0edc-0e9f-2f8fbafc352f@vodafonemail.de> <83y1kt180v.fsf@gnu.org> <8477db3b-b237-aa4b-b4aa-41d31cb77ac1@vodafonemail.de> <834jnf26v2.fsf@gnu.org> <83ilbvz0xx.fsf@gnu.org> <7fe39b49-8319-d7ab-99b3-afe10dc62177@vodafonemail.de> From: Dmitry Gutov In-Reply-To: <7fe39b49-8319-d7ab-99b3-afe10dc62177@vodafonemail.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Score: -1.9 (-) X-Debbugs-Envelope-To: 63949 Cc: 63949@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.9 (--) On 16/06/2023 22:33, Jens Schmidt wrote: > On 2023-06-10  19:23, Eli Zaretskii wrote: > >> I'd also like to hear Dmitry's views on these issues.  He was until >> now silent in this discussion, AFAICT. > > @Dmitry: What's your view on these issues?  Just making the handling of > VC parent buffer more documented and "more consistent", whatever that > means, or do you prefer some particular direction? Sorry, been busy. I'll make sure to read the thread and comment on the issue tomorrow. From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 17 22:42:59 2023 Received: (at 63949) by debbugs.gnu.org; 18 Jun 2023 02:42:59 +0000 Received: from localhost ([127.0.0.1]:52866 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qAiNW-0003IX-NE for submit@debbugs.gnu.org; Sat, 17 Jun 2023 22:42:59 -0400 Received: from out3-smtp.messagingengine.com ([66.111.4.27]:39687) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qAiNT-0003IH-32 for 63949@debbugs.gnu.org; Sat, 17 Jun 2023 22:42:57 -0400 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 038C15C00CD; Sat, 17 Jun 2023 22:42:50 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Sat, 17 Jun 2023 22:42:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm3; t= 1687056169; x=1687142569; bh=1PfYCnWjUDDC6Sj6wkcWayQVnvVlCivZoiU wzfGPmHA=; b=W8yG6L7VUA/PsCffxQsC8psDtYm0YWS9gEp3AHBW2gqfEUS+cEj lRUGfsAoZwc/Xh3hMJOdAUlRls13Wquh1SUtXLk/kFwW1kTWX/cV+7KvDLQAunQx 2Rq+3thbDxQ4Qy9IRNSb5cJKvJtz5v5ajfiltXPgXLqkOEIQWIAaFu1CTGuIh9/+ oXG93ob4IlZi9kJGNaQhTBnrpP5AZx6PuB5EwAFTpuUIbvqVF2a8vfhT/RAyrUMj 3k+QMidvfV9LbUcIb9sXzPqTrCY9RDoUsGr4tgjVNXyP1TnOk8RP3zgrz4a1G5ac xiGmyNtNM7dCxUBolJooigt2NQt5yRfMA1w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1687056169; x=1687142569; bh=1PfYCnWjUDDC6Sj6wkcWayQVnvVlCivZoiU wzfGPmHA=; b=orYoklo8l0666kcklcHJ6fFwQPszZvneiAORei2VAvnpb70AY/O B2XSLSb2AtQjQVVWNIa6tHI5y3qWu1Xoqw039b+K/uilW1MQ3zn9StWkttIXMIsn pgQRTPfKFJI0N9veTpR3NTIzCrpAoOmnXNvBSzIVENsujeL1lW2mQls+WdfjJfk4 wAxbC4L+Dqw23DxFzMNN8ijOY5B5QZIb4hAbOWTCjjEK6wZuhN5OL2YFdjlD+Mr3 b4PO+hFgOpB+J77S0XxQfMO6bYUborBtE4/u+KZV1gJZM2EQ/NszAk87xjc9AAxZ ZqRa6oRFRGGytzgnA2tCkPIFDXprE4TiBkg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrgedvkedgiedvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepkfffgggfuffvvehfhfgjtgfgsehtkeertddtfeejnecuhfhrohhmpeffmhhi thhrhicuifhuthhovhcuoegumhhithhrhiesghhuthhovhdruggvvheqnecuggftrfgrth htvghrnhephfffheeljeffgeffueeghfekkedtfffgheejvdegjeettdduheeufffggfef jeehnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepug hmihhtrhihsehguhhtohhvrdguvghv X-ME-Proxy: Feedback-ID: i0e71465a:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 17 Jun 2023 22:42:48 -0400 (EDT) Message-ID: <1c00eecf-9285-3b9e-cf9f-4eba56461ae7@gutov.dev> Date: Sun, 18 Jun 2023 05:42:44 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: =?UTF-8?B?UmU6IGJ1ZyM2Mzk0OTogMzAuMC41MDsgYHZjLXByaW50LWxvZ8K0IGRv?= =?UTF-8?Q?es_not_erase_buffer_when_called_from_*vc-change-log*_buffer=2c_at?= =?UTF-8?Q?_least_for_CVS_logs?= Content-Language: en-US To: Jens Schmidt , Eli Zaretskii References: <8c62dd9a-3cad-b992-bfc4-64b2f1db4485@vodafonemail.de> <87fs729jxu.fsf@ledu-giraud.fr> <7bc0c78e-e4b5-0edc-0e9f-2f8fbafc352f@vodafonemail.de> <83y1kt180v.fsf@gnu.org> <8477db3b-b237-aa4b-b4aa-41d31cb77ac1@vodafonemail.de> <834jnf26v2.fsf@gnu.org> <83ilbvz0xx.fsf@gnu.org> <7fe39b49-8319-d7ab-99b3-afe10dc62177@vodafonemail.de> From: Dmitry Gutov In-Reply-To: <7fe39b49-8319-d7ab-99b3-afe10dc62177@vodafonemail.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Score: -1.9 (-) X-Debbugs-Envelope-To: 63949 Cc: 63949@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.9 (--) On 16/06/2023 22:33, Jens Schmidt wrote: > On 2023-06-10  19:23, Eli Zaretskii wrote: > >> I'd also like to hear Dmitry's views on these issues.  He was until >> now silent in this discussion, AFAICT. > > @Dmitry: What's your view on these issues?  Just making the handling of > VC parent buffer more documented and "more consistent", whatever that > means, or do you prefer some particular direction? I think the appropriate thing here is to back out of the change that caused the regression (d494833d47968fcd97ba549654a259d6fb6c2eee, as we've found out) and then try to re-fix it some other way (in master?). Or maybe adjust the current code such as when vc-deduce-fileset-1 does change the current buffer, vc-deduce-fileset retains that change. For example, using this ugly-ish (100% untested) patch: diff --git a/lisp/vc/vc.el b/lisp/vc/vc.el index 91d3f6f70d3..91aae40a677 100644 --- a/lisp/vc/vc.el +++ b/lisp/vc/vc.el @@ -1121,10 +1121,13 @@ vc-deduce-fileset the returned list. BEWARE: this function may change the current buffer." - (with-current-buffer (or (buffer-base-buffer) (current-buffer)) - (vc-deduce-fileset-1 not-state-changing - allow-unregistered - state-model-only-files))) + (let (new-buf) + (with-current-buffer (or (buffer-base-buffer) (current-buffer)) + (vc-deduce-fileset-1 not-state-changing + allow-unregistered + state-model-only-files) + (setq new-buf (current-buffer))) + (set-buffer new-buf))) (defun vc-deduce-fileset-1 (not-state-changing allow-unregistered The fact that some backends do call vc-setup-buffer inside vc-xx-print-log and some dont', also bears investigation. But the question I would like to have answered is, can we drop this call from all of them? Rather than trying to add it everywhere. From debbugs-submit-bounces@debbugs.gnu.org Sun Jun 18 01:35:45 2023 Received: (at 63949) by debbugs.gnu.org; 18 Jun 2023 05:35:45 +0000 Received: from localhost ([127.0.0.1]:52948 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qAl4i-0008CB-QR for submit@debbugs.gnu.org; Sun, 18 Jun 2023 01:35:45 -0400 Received: from eggs.gnu.org ([209.51.188.92]:33954) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qAl4d-0008Bu-BB for 63949@debbugs.gnu.org; Sun, 18 Jun 2023 01:35:42 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qAl4X-00023O-J9; Sun, 18 Jun 2023 01:35:33 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=Fnp001K78UR80HI6jt936YMiMH9Gpjvh2BVWKnVy4jM=; b=QrfUXI8Q95cE3U0ylFVW sugovD8wV6R99vs4922RbFQQDZ+bCvUfjL/WK4mMpIMq+mf1xktLHptf3l4Hivdftam9F1Kgb401r qtRc/8pQAb/lnbPthZR09/arWTrhrSTGf2P2Mq+Uyd7X1n5zLKAQMxrTGd/2j0wtvBsGpzX5Wlw+u T/VmYwbDeiUk69hLS+Y5d8+GXQMR2KUdGteoXs/Jmojlcl/Pg8GbzOjXA9yVV5c+gp4pVtTLiyhXy NIXtg8DnmrbBn6eiM+2sbvmIdRLU41eOJFUytV1cwQBLIT/cBPYxS4R2GO1pA5x+u5oylvRUatcf+ C+LG7QB1zQd02g==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qAl4W-0005AV-Vp; Sun, 18 Jun 2023 01:35:33 -0400 Date: Sun, 18 Jun 2023 08:35:34 +0300 Message-Id: <83jzw1pc2h.fsf@gnu.org> From: Eli Zaretskii To: Dmitry Gutov In-Reply-To: <1c00eecf-9285-3b9e-cf9f-4eba56461ae7@gutov.dev> (message from Dmitry Gutov on Sun, 18 Jun 2023 05:42:44 +0300) Subject: Re: bug#63949: 30.0.50; =?utf-8?Q?`vc-print-log=C2=B4?= does not erase buffer when called from *vc-change-log* buffer, at least for CVS logs References: <8c62dd9a-3cad-b992-bfc4-64b2f1db4485@vodafonemail.de> <87fs729jxu.fsf@ledu-giraud.fr> <7bc0c78e-e4b5-0edc-0e9f-2f8fbafc352f@vodafonemail.de> <83y1kt180v.fsf@gnu.org> <8477db3b-b237-aa4b-b4aa-41d31cb77ac1@vodafonemail.de> <834jnf26v2.fsf@gnu.org> <83ilbvz0xx.fsf@gnu.org> <7fe39b49-8319-d7ab-99b3-afe10dc62177@vodafonemail.de> <1c00eecf-9285-3b9e-cf9f-4eba56461ae7@gutov.dev> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 63949 Cc: 63949@debbugs.gnu.org, jschmidt4gnu@vodafonemail.de X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Sun, 18 Jun 2023 05:42:44 +0300 > Cc: 63949@debbugs.gnu.org > From: Dmitry Gutov > > On 16/06/2023 22:33, Jens Schmidt wrote: > > On 2023-06-10  19:23, Eli Zaretskii wrote: > > > >> I'd also like to hear Dmitry's views on these issues.  He was until > >> now silent in this discussion, AFAICT. > > > > @Dmitry: What's your view on these issues?  Just making the handling of > > VC parent buffer more documented and "more consistent", whatever that > > means, or do you prefer some particular direction? > > I think the appropriate thing here is to back out of the change that > caused the regression (d494833d47968fcd97ba549654a259d6fb6c2eee, as > we've found out) and then try to re-fix it some other way (in master?). > > Or maybe adjust the current code such as when vc-deduce-fileset-1 does > change the current buffer, vc-deduce-fileset retains that change. > > For example, using this ugly-ish (100% untested) patch: Whatever you decide, please do it soon, as I'd like to release another pretest of Emacs 29. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Sun Jun 18 05:11:55 2023 Received: (at 63949) by debbugs.gnu.org; 18 Jun 2023 09:11:55 +0000 Received: from localhost ([127.0.0.1]:53209 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qAoRv-0005lt-Ci for submit@debbugs.gnu.org; Sun, 18 Jun 2023 05:11:55 -0400 Received: from mr3.vodafonemail.de ([145.253.228.163]:50872) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qAoRs-0005ld-9p for 63949@debbugs.gnu.org; Sun, 18 Jun 2023 05:11:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vodafonemail.de; s=vfde-mb-mr2-21dec; t=1687079506; bh=n2G2b8NfR1mf5d9BqBOIkt0pm4r4EGb6LjE5ONzbe48=; h=Message-ID:Date:User-Agent:Subject:Content-Language:To:References: From:In-Reply-To:Content-Type:From; b=ZFI6G/T/dVyJhOO+wSSmwlyGyAvufKaRSDigAmpeT55HHY3VKApyXKNQv3ZIqWL2t rMjFEQiquegtGfvFm1/Mte3/eMITcvjDEVWP+I9E6ENC+Cr8bUB7zOH1T7mBw3aDpF 6D1MoeoPyxhtGIqOWjjURe+ckWFrSCyonoiwf8jA= Received: from smtp.vodafone.de (unknown [10.0.0.2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by mr3.vodafonemail.de (Postfix) with ESMTPS id 4QkRwf2BF0z215X; Sun, 18 Jun 2023 09:11:46 +0000 (UTC) Received: from [192.168.0.74] (p54a6dbed.dip0.t-ipconnect.de [84.166.219.237]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp.vodafone.de (Postfix) with ESMTPSA id 4QkRwR59NCz9s6q; Sun, 18 Jun 2023 09:11:32 +0000 (UTC) Message-ID: <1e7358a7-5446-6a89-3556-57e779b545ee@vodafonemail.de> Date: Sun, 18 Jun 2023 11:11:32 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: =?UTF-8?B?UmU6IGJ1ZyM2Mzk0OTogMzAuMC41MDsgYHZjLXByaW50LWxvZ8K0IGRv?= =?UTF-8?Q?es_not_erase_buffer_when_called_from_*vc-change-log*_buffer=2c_at?= =?UTF-8?Q?_least_for_CVS_logs?= Content-Language: de-DE-frami, en-US To: Eli Zaretskii , Dmitry Gutov References: <8c62dd9a-3cad-b992-bfc4-64b2f1db4485@vodafonemail.de> <87fs729jxu.fsf@ledu-giraud.fr> <7bc0c78e-e4b5-0edc-0e9f-2f8fbafc352f@vodafonemail.de> <83y1kt180v.fsf@gnu.org> <8477db3b-b237-aa4b-b4aa-41d31cb77ac1@vodafonemail.de> <834jnf26v2.fsf@gnu.org> <83ilbvz0xx.fsf@gnu.org> <7fe39b49-8319-d7ab-99b3-afe10dc62177@vodafonemail.de> <1c00eecf-9285-3b9e-cf9f-4eba56461ae7@gutov.dev> <83jzw1pc2h.fsf@gnu.org> From: Jens Schmidt In-Reply-To: <83jzw1pc2h.fsf@gnu.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-purgate-type: clean X-purgate: clean X-purgate-size: 414 X-purgate-ID: 155817::1687079502-B1FF9D22-A42825EA/0/0 X-Spam-Score: -1.8 (-) X-Debbugs-Envelope-To: 63949 Cc: 63949@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.8 (--) On 2023-06-18 07:35, Eli Zaretskii wrote: > Whatever you decide, please do it soon, as I'd like to release > another pretest of Emacs 29. No need to change anything for Emacs 29, I think. The issues that I encountered are not that serious, and whatever gets implemented to rectify them and commit d494833d47968fcd97ba549654a259d6fb6c2eee in a consistent way would be too much for Emacs 29, anyway. From debbugs-submit-bounces@debbugs.gnu.org Sun Jun 18 08:00:20 2023 Received: (at 63949) by debbugs.gnu.org; 18 Jun 2023 12:00:20 +0000 Received: from localhost ([127.0.0.1]:53450 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qAr4u-00077M-1K for submit@debbugs.gnu.org; Sun, 18 Jun 2023 08:00:20 -0400 Received: from wout1-smtp.messagingengine.com ([64.147.123.24]:33261) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qAr4s-00077A-NL for 63949@debbugs.gnu.org; Sun, 18 Jun 2023 08:00:19 -0400 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id B0359320092A; Sun, 18 Jun 2023 08:00:12 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Sun, 18 Jun 2023 08:00:12 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm3; t= 1687089612; x=1687176012; bh=rOUYOKfGlk9oCX0TPHLRsOQ/uwirsQz7z+l fg18YdVA=; b=3leTyNG9AfPQjnyFq/+aiZa5lUJJ+OCGVjp1GhYkczOvfeVjdnc bp/eoqYqiu+giH896X5FDXtc8A5cGVzcIOhvbeEQiq25W6/r7Y/3b9yGohq+AHIr DYkFYfYc+h0uOGpwjb4i3+q1361TxBqZvfenv5MRSx/SJiF80N/N6AfVO93IdpEb Vx0W3KVUIYD/geJfvXh8r3CGG7UQSdsjtviFcKf1J74j6JrTQzyQvi3Kx09rSiFs W05gwpTGZXZiE5KKLOnCmTME+tKcIt1a8wdU+iFLH3m5Jf4WrlbONYtPKmtQS/v8 Qal/pp0WK+ITfw/LuzF4b6Mz1AA4nuEZu6w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1687089612; x=1687176012; bh=rOUYOKfGlk9oCX0TPHLRsOQ/uwirsQz7z+l fg18YdVA=; b=JrI4gBWL94PTSscoitU90pvwq4Oxnjy0Do3sPtCG7aFb95Lta37 rb+FgYQbQssvG44DvgebK1sIxGmiYP9yKmOxh7mroflYO9qR9Rufm5sJSO7cwdI5 ZIy9cUhlEiBMh6P2C4IAqZp/UIr5m71yaTlEkBA1JacHN3wcK/SJ06kl6vg6vkWk U8MFVGCmQnFX3EDWK2TGSvnfRVQWX3ap55wFWFe3EySU4gcM5MrN1UFDXifgoHoW LTq4bgn1JXg/Mja83b2UDjc0xf+NsjtobMg74YUMWF9xuEa8VRSN35MT+rg87Qv6 Ax87sO5kBqMpMvZqqL8+H56g3gwaoXSnpFw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrgeeftddggeejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepkfffgggfuffvvehfhfgjtgfgsehtkeertddtfeejnecuhfhrohhmpeffmhhi thhrhicuifhuthhovhcuoegumhhithhrhiesghhuthhovhdruggvvheqnecuggftrfgrth htvghrnhephfffheeljeffgeffueeghfekkedtfffgheejvdegjeettdduheeufffggfef jeehnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepug hmihhtrhihsehguhhtohhvrdguvghv X-ME-Proxy: Feedback-ID: i0e71465a:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 18 Jun 2023 08:00:10 -0400 (EDT) Message-ID: Date: Sun, 18 Jun 2023 15:00:09 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: =?UTF-8?B?UmU6IGJ1ZyM2Mzk0OTogMzAuMC41MDsgYHZjLXByaW50LWxvZ8K0IGRv?= =?UTF-8?Q?es_not_erase_buffer_when_called_from_*vc-change-log*_buffer=2c_at?= =?UTF-8?Q?_least_for_CVS_logs?= Content-Language: en-US To: Jens Schmidt , Eli Zaretskii References: <8c62dd9a-3cad-b992-bfc4-64b2f1db4485@vodafonemail.de> <87fs729jxu.fsf@ledu-giraud.fr> <7bc0c78e-e4b5-0edc-0e9f-2f8fbafc352f@vodafonemail.de> <83y1kt180v.fsf@gnu.org> <8477db3b-b237-aa4b-b4aa-41d31cb77ac1@vodafonemail.de> <834jnf26v2.fsf@gnu.org> <83ilbvz0xx.fsf@gnu.org> <7fe39b49-8319-d7ab-99b3-afe10dc62177@vodafonemail.de> <1c00eecf-9285-3b9e-cf9f-4eba56461ae7@gutov.dev> <83jzw1pc2h.fsf@gnu.org> <1e7358a7-5446-6a89-3556-57e779b545ee@vodafonemail.de> From: Dmitry Gutov In-Reply-To: <1e7358a7-5446-6a89-3556-57e779b545ee@vodafonemail.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Score: -1.9 (-) X-Debbugs-Envelope-To: 63949 Cc: 63949@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.9 (--) On 18/06/2023 12:11, Jens Schmidt wrote: > On 2023-06-18  07:35, Eli Zaretskii wrote: > >> Whatever you decide, please do it soon, as I'd like to release another >> pretest of Emacs 29. > > No need to change anything for Emacs 29, I think.  The issues that I > encountered are not that serious, and whatever gets implemented to > rectify them and commit d494833d47968fcd97ba549654a259d6fb6c2eee in a > consistent way would be too much for Emacs 29, anyway. Could you test the patch I showed? From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 19 22:41:58 2023 Received: (at 63949) by debbugs.gnu.org; 20 Jun 2023 02:41:58 +0000 Received: from localhost ([127.0.0.1]:57685 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qBRJd-0005Bu-J1 for submit@debbugs.gnu.org; Mon, 19 Jun 2023 22:41:58 -0400 Received: from out3-smtp.messagingengine.com ([66.111.4.27]:54299) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qBRJb-0005Bf-9Y for 63949@debbugs.gnu.org; Mon, 19 Jun 2023 22:41:55 -0400 Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id 296035C0118; Mon, 19 Jun 2023 22:41:50 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Mon, 19 Jun 2023 22:41:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm3; t= 1687228910; x=1687315310; bh=ir4Uz2C5K4XzEfTNcFFmHTkvkT/0574jwkZ 1VvHWnKg=; b=P0mruua8rUMEuZ+S03SGDpT2ITho21OE/9ztumVtsLBqSOuNFX9 yw/WRntnpirdwvmjMOSvCvij1iLfsDUQwGrZNk1itwUzkEm/Nt5Z708/0YEWDLWw +ImQjDYj5bhyY6UFsCWFHCkt5Q7cfJvW7uXAMwvbA+gKHwRPaYO19hqonzyc5Zg5 QrXBQukcL1M7wLu1G1vnj64lej5TZqmfxhY90WXbp1B9Qs9yf2E0U/1KCA36YpU6 ya8G4QWkA0CjojE7vbJXhw146yn7dRI+b4VTi+7+q7Z/nXqzfqptmmMlhT3Koda5 Igm7zahhYfr76IIHtlncjCFjvat7CfWjOqQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1687228910; x=1687315310; bh=ir4Uz2C5K4XzEfTNcFFmHTkvkT/0574jwkZ 1VvHWnKg=; b=XWuC4PHZkf8KcGxWsvFvXN5AbWfodhPlGGvk83NG7UmX3BDRdJ2 jfi0VOF7Z6+WWdoscu+38rg/CvtOUR9PepGGwJMr2D+P8pN6SYGup5itg8ozwSN5 9row2KWn2XQHDS54ISHGpoyn1c2xXnxApWF2QwhrAZV4OcBMs45dkOzuwIKHTlux GREmJ3FDR05OYMtbqiDt182UQVmvjfMXpyQ9oAX8NfpF4YOnpjAJrdd0RmEk2rjO xALG7EQrT15eagILQ7hozmKMNvVmIbOWqNqmdgdXb9G3DzhPmlnmb3fPgD932RpR 3X0bGVmoeKXKJlLSqlHGEC9jcDsJVUustXw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrgeefgedgudelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepkfffgggfuffvfhevhfgjtgfgsehtkeertddtfeejnecuhfhrohhmpeffmhhi thhrhicuifhuthhovhcuoegumhhithhrhiesghhuthhovhdruggvvheqnecuggftrfgrth htvghrnhepveffuddtkefgffefieefhfehfeelieevieejfefgudfhkeevfedvgeffveel heejnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepug hmihhtrhihsehguhhtohhvrdguvghv X-ME-Proxy: Feedback-ID: i0e71465a:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 19 Jun 2023 22:41:48 -0400 (EDT) Message-ID: Date: Tue, 20 Jun 2023 05:41:47 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: =?UTF-8?B?UmU6IGJ1ZyM2Mzk0OTogMzAuMC41MDsgYHZjLXByaW50LWxvZ8K0IGRv?= =?UTF-8?Q?es_not_erase_buffer_when_called_from_*vc-change-log*_buffer=2c_at?= =?UTF-8?Q?_least_for_CVS_logs?= Content-Language: en-US To: Jens Schmidt References: <8c62dd9a-3cad-b992-bfc4-64b2f1db4485@vodafonemail.de> <87fs729jxu.fsf@ledu-giraud.fr> <7bc0c78e-e4b5-0edc-0e9f-2f8fbafc352f@vodafonemail.de> <83y1kt180v.fsf@gnu.org> <8477db3b-b237-aa4b-b4aa-41d31cb77ac1@vodafonemail.de> <834jnf26v2.fsf@gnu.org> <83ilbvz0xx.fsf@gnu.org> <7fe39b49-8319-d7ab-99b3-afe10dc62177@vodafonemail.de> <1c00eecf-9285-3b9e-cf9f-4eba56461ae7@gutov.dev> <83jzw1pc2h.fsf@gnu.org> <1e7358a7-5446-6a89-3556-57e779b545ee@vodafonemail.de> From: Dmitry Gutov In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Score: -1.9 (-) X-Debbugs-Envelope-To: 63949 Cc: 63949@debbugs.gnu.org, Eli Zaretskii X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.9 (--) (Please keep the bug address in Cc). On 18/06/2023 16:21, Jens Schmidt wrote: > On 2023-06-18  14:00, Dmitry Gutov wrote: > >> Could you test the patch I showed? > > Will do, pls just give me some time here... Thanks. If we can verify that the part broken by the bisected revision, is fixed here, we could push that to Emacs 29 and then clean up for Emacs 30 more thoroughly. In the meantime, here's the updated patch. The previous one discarded the return value :( diff --git a/lisp/vc/vc.el b/lisp/vc/vc.el index 91d3f6f70d3..c8b2b3ac11d 100644 --- a/lisp/vc/vc.el +++ b/lisp/vc/vc.el @@ -1121,10 +1121,15 @@ vc-deduce-fileset the returned list. BEWARE: this function may change the current buffer." - (with-current-buffer (or (buffer-base-buffer) (current-buffer)) - (vc-deduce-fileset-1 not-state-changing - allow-unregistered - state-model-only-files))) + (let (new-buf res) + (with-current-buffer (or (buffer-base-buffer) (current-buffer)) + (setq res + (vc-deduce-fileset-1 not-state-changing + allow-unregistered + state-model-only-files)) + (setq new-buf (current-buffer))) + (set-buffer new-buf) + res)) (defun vc-deduce-fileset-1 (not-state-changing allow-unregistered From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 21 09:04:03 2023 Received: (at 63949) by debbugs.gnu.org; 21 Jun 2023 13:04:03 +0000 Received: from localhost ([127.0.0.1]:60870 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qBxVD-0006dw-Lu for submit@debbugs.gnu.org; Wed, 21 Jun 2023 09:04:03 -0400 Received: from mr3.vodafonemail.de ([145.253.228.163]:41992) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qBxVB-0006dS-3U for 63949@debbugs.gnu.org; Wed, 21 Jun 2023 09:04:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vodafonemail.de; s=vfde-mb-mr2-21dec; t=1687352635; bh=QSlu7jlokjD2IKTJLGjlI3zHNt3HSps/O4dWEP1nx3Y=; h=Message-ID:Date:User-Agent:Subject:To:References:Content-Language: From:In-Reply-To:Content-Type:From; b=WXSa6xh+hZHmegapaKdQMG4riyb1IlD9PdB+WZ39hVGMe07J1PzNLBkYSmeolUm3K DK57xyzr1LmC1/tQCLE4R8S4q4804e9sTcgv0NGXe0XgPMrgdc6b/B4UIG5TAH2JcG H8a66uPZf7Qv2W8nsQ749Pyz9lX5u6np0WZhx4H8= Received: from smtp.vodafone.de (unknown [10.0.0.2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by mr3.vodafonemail.de (Postfix) with ESMTPS id 4QmNx75Vwbz21fh; Wed, 21 Jun 2023 13:03:55 +0000 (UTC) Received: from [192.168.178.41] (port-92-194-167-27.dynamic.as20676.net [92.194.167.27]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp.vodafone.de (Postfix) with ESMTPSA id 4QmNwx2HTrzHpxd; Wed, 21 Jun 2023 13:03:42 +0000 (UTC) Message-ID: <5b25044e-5d5c-fe15-4b87-b49bfe548daf@vodafonemail.de> Date: Wed, 21 Jun 2023 15:03:36 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: =?UTF-8?B?UmU6IGJ1ZyM2Mzk0OTogMzAuMC41MDsgYHZjLXByaW50LWxvZ8K0IGRv?= =?UTF-8?Q?es_not_erase_buffer_when_called_from_*vc-change-log*_buffer=2c_at?= =?UTF-8?Q?_least_for_CVS_logs?= To: Dmitry Gutov References: <8c62dd9a-3cad-b992-bfc4-64b2f1db4485@vodafonemail.de> <87fs729jxu.fsf@ledu-giraud.fr> <7bc0c78e-e4b5-0edc-0e9f-2f8fbafc352f@vodafonemail.de> <83y1kt180v.fsf@gnu.org> <8477db3b-b237-aa4b-b4aa-41d31cb77ac1@vodafonemail.de> <834jnf26v2.fsf@gnu.org> <83ilbvz0xx.fsf@gnu.org> <7fe39b49-8319-d7ab-99b3-afe10dc62177@vodafonemail.de> <1c00eecf-9285-3b9e-cf9f-4eba56461ae7@gutov.dev> <83jzw1pc2h.fsf@gnu.org> <1e7358a7-5446-6a89-3556-57e779b545ee@vodafonemail.de> Content-Language: de-DE-frami, en-US From: Jens Schmidt In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-purgate-type: clean X-purgate: clean X-purgate-size: 460 X-purgate-ID: 155817::1687352631-A8FFED81-6ACE2020/0/0 X-Spam-Score: -1.8 (-) X-Debbugs-Envelope-To: 63949 Cc: 63949@debbugs.gnu.org, Eli Zaretskii X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.8 (--) On 2023-06-20 04:41, Dmitry Gutov wrote: > (Please keep the bug address in Cc). Will do. > Thanks. If we can verify that the part broken by the bisected > revision, is fixed here, we could push that to Emacs 29 and then > clean up for Emacs 30 more thoroughly. Both of my issues (described on "Wed, 7 Jun 2023 23:04:50 +0200" and on "Fri, 9 Jun 2023 22:27:37 +0200") are fixed by your latest, second patch. Tested on emacs-29. Thanks! From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 21 10:38:06 2023 Received: (at 63949) by debbugs.gnu.org; 21 Jun 2023 14:38:06 +0000 Received: from localhost ([127.0.0.1]:33914 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qByyE-00061H-31 for submit@debbugs.gnu.org; Wed, 21 Jun 2023 10:38:06 -0400 Received: from out4-smtp.messagingengine.com ([66.111.4.28]:39065) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qByyC-00060l-J3 for 63949@debbugs.gnu.org; Wed, 21 Jun 2023 10:38:05 -0400 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id B15565C017D; Wed, 21 Jun 2023 10:37:58 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Wed, 21 Jun 2023 10:37:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm1; t= 1687358278; x=1687444678; bh=7MyTVXeeR0ohOLPIVIw0OyvPU89PJsM3EyM jQMryQQs=; b=JJ5wjk/dNYVa67aTLHG5EIAVx0iiYusOCBhRf7Fh18HSWuhnidW LLV5E8DgOPLUPznW7qYk1f9quQndLdqpOM+gTOHd+eSkEeCnkjzrt0lVqy9jo6k0 8fyk/9uS+ZpqnSr5MtVnXyhHNu582LS1dbxVXfGwH0dLvAEk3hAaeku6RixcAqR6 HeFQn1ZEWYHxSw+t5Aa3EpvZ9YbZ2CRKqHnD1bY/qlZq1PxCylQZlp7YHVkSHA6W bn5TCyqR9jnISxtUfjPoXgilzxTtqf0CgX+sISBwlmuT4++jq6wolDvhVjpaQb/j L22A6JFHe9CAyIJcpcqx+oHi9mjLhK4W17g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1687358278; x=1687444678; bh=7MyTVXeeR0ohOLPIVIw0OyvPU89PJsM3EyM jQMryQQs=; b=HD9gVUPovPCn/yp1fGzvhwIbjRK4P1ifo/IvjKT7/B/3mXA7dIo affMOxF+ccoRcrjOvIbWJ3ogcPwKkbtxl8t9z+kZs+cOyxjX0RDXUIFIySmMYMM9 u4q8AghalNA1gyxU1uy5ehHJGkMlHAZ0tnNEpfQG7dPSuMDRJMKTTFYcFnMQQpHI z5Wdfuw53tnmJduENLYbuuSVhjuCrprbMDfcX0S44beGd9rDSr8f2GQs8Kq74wp8 2s4QfCslNymXQ90D33GmOx32d3dWmKwPPCfTMt1La9WyUmveE46YTDHA7SVNOx9a 2VTAUOhtVyd0RmMGKYW94/JVwpA2Hvdfq6A== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrgeefkedghedvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepkfffgggfuffvvehfhfgjtgfgsehtkeertddtfeejnecuhfhrohhmpeffmhhi thhrhicuifhuthhovhcuoegumhhithhrhiesghhuthhovhdruggvvheqnecuggftrfgrth htvghrnhephfffheeljeffgeffueeghfekkedtfffgheejvdegjeettdduheeufffggfef jeehnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepug hmihhtrhihsehguhhtohhvrdguvghv X-ME-Proxy: Feedback-ID: i0e71465a:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 21 Jun 2023 10:37:57 -0400 (EDT) Message-ID: <56434485-eaff-0e57-c464-37d14aa201c4@gutov.dev> Date: Wed, 21 Jun 2023 17:37:55 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: =?UTF-8?B?UmU6IGJ1ZyM2Mzk0OTogMzAuMC41MDsgYHZjLXByaW50LWxvZ8K0IGRv?= =?UTF-8?Q?es_not_erase_buffer_when_called_from_*vc-change-log*_buffer=2c_at?= =?UTF-8?Q?_least_for_CVS_logs?= Content-Language: en-US To: Eli Zaretskii References: <8c62dd9a-3cad-b992-bfc4-64b2f1db4485@vodafonemail.de> <87fs729jxu.fsf@ledu-giraud.fr> <7bc0c78e-e4b5-0edc-0e9f-2f8fbafc352f@vodafonemail.de> <83y1kt180v.fsf@gnu.org> <8477db3b-b237-aa4b-b4aa-41d31cb77ac1@vodafonemail.de> <834jnf26v2.fsf@gnu.org> <83ilbvz0xx.fsf@gnu.org> <7fe39b49-8319-d7ab-99b3-afe10dc62177@vodafonemail.de> <1c00eecf-9285-3b9e-cf9f-4eba56461ae7@gutov.dev> <83jzw1pc2h.fsf@gnu.org> <1e7358a7-5446-6a89-3556-57e779b545ee@vodafonemail.de> <5b25044e-5d5c-fe15-4b87-b49bfe548daf@vodafonemail.de> From: Dmitry Gutov In-Reply-To: <5b25044e-5d5c-fe15-4b87-b49bfe548daf@vodafonemail.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Score: -1.8 (-) X-Debbugs-Envelope-To: 63949 Cc: 63949@debbugs.gnu.org, Jens Schmidt X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.8 (--) On 21/06/2023 16:03, Jens Schmidt wrote: > On 2023-06-20  04:41, Dmitry Gutov wrote: > >> (Please keep the bug address in Cc). > > Will do. > >> Thanks. If we can verify that the part broken by the bisected >> revision, is fixed here, we could push that to Emacs 29 and then clean >> up for Emacs 30 more thoroughly. > > Both of my issues (described on "Wed, 7 Jun 2023 23:04:50 +0200" and on > "Fri, 9 Jun 2023 22:27:37 +0200") are fixed by your latest, second patch. > > Tested on emacs-29. Excellent, thank you. Eli, I suggest we push it to emacs-29 now. There could be ways to make it prettier, but probably not by much -- at least I don't see any obvious ones if we're keeping the indirect buffer-related functionality. Anyway, we can look into that later in Emacs 30. From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 21 11:30:15 2023 Received: (at 63949) by debbugs.gnu.org; 21 Jun 2023 15:30:15 +0000 Received: from localhost ([127.0.0.1]:33983 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qBzmg-0001iN-P2 for submit@debbugs.gnu.org; Wed, 21 Jun 2023 11:30:15 -0400 Received: from eggs.gnu.org ([209.51.188.92]:50498) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qBzme-0001hh-QE for 63949@debbugs.gnu.org; Wed, 21 Jun 2023 11:30:13 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qBzmY-0002mx-W7; Wed, 21 Jun 2023 11:30:07 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=MFuvJcCBNAgZEz4EAlOA9icyAONmRr1dJNEb4vu2pbY=; b=FIQxqiWdnuWdJHA8DMCS oGOC4syo1reKy45qmZJxA+tohfZX4VWANZL+VXD6XyW0HM48TZvEN/Q97HxGnsIOY8qKqFeyNgdUM i+0qcT+YeZRIHDFywjlA4JgRmzUVB0jVwZTizvMnC0PTYqltkbYZXitxQXaHS0/7MjFeTp8v1V9qG P4nHfYbiciD46jcXmLxqMptCCFETk3En392fmPnSbOGCHO7/KMUxhFkczjqAcaoFj/pAx7nEE6Did d4qEzXvacyewDmP81NcizgL+0D+LXUDdWaNhhc/ihHnxesb9vuHfllcPNc+NhiFZqX+2yzx4pAHBT 1weRPMTPYPS0PA==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qBzmY-0005l2-FY; Wed, 21 Jun 2023 11:30:06 -0400 Date: Wed, 21 Jun 2023 18:30:15 +0300 Message-Id: <83ilbg4yuw.fsf@gnu.org> From: Eli Zaretskii To: Dmitry Gutov In-Reply-To: <56434485-eaff-0e57-c464-37d14aa201c4@gutov.dev> (message from Dmitry Gutov on Wed, 21 Jun 2023 17:37:55 +0300) Subject: Re: bug#63949: 30.0.50; =?utf-8?Q?`vc-print-log=C2=B4?= does not erase buffer when called from *vc-change-log* buffer, at least for CVS logs References: <8c62dd9a-3cad-b992-bfc4-64b2f1db4485@vodafonemail.de> <87fs729jxu.fsf@ledu-giraud.fr> <7bc0c78e-e4b5-0edc-0e9f-2f8fbafc352f@vodafonemail.de> <83y1kt180v.fsf@gnu.org> <8477db3b-b237-aa4b-b4aa-41d31cb77ac1@vodafonemail.de> <834jnf26v2.fsf@gnu.org> <83ilbvz0xx.fsf@gnu.org> <7fe39b49-8319-d7ab-99b3-afe10dc62177@vodafonemail.de> <1c00eecf-9285-3b9e-cf9f-4eba56461ae7@gutov.dev> <83jzw1pc2h.fsf@gnu.org> <1e7358a7-5446-6a89-3556-57e779b545ee@vodafonemail.de> <5b25044e-5d5c-fe15-4b87-b49bfe548daf@vodafonemail.de> <56434485-eaff-0e57-c464-37d14aa201c4@gutov.dev> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 63949 Cc: 63949@debbugs.gnu.org, jschmidt4gnu@vodafonemail.de X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Wed, 21 Jun 2023 17:37:55 +0300 > Cc: 63949@debbugs.gnu.org, Jens Schmidt > From: Dmitry Gutov > > On 21/06/2023 16:03, Jens Schmidt wrote: > > Tested on emacs-29. > > Excellent, thank you. > > Eli, I suggest we push it to emacs-29 now. Fine by me, thanks. > There could be ways to make it prettier, but probably not by much -- at > least I don't see any obvious ones if we're keeping the indirect > buffer-related functionality. Anyway, we can look into that later in > Emacs 30. Right. From debbugs-submit-bounces@debbugs.gnu.org Fri Jun 23 23:08:33 2023 Received: (at 63949) by debbugs.gnu.org; 24 Jun 2023 03:08:33 +0000 Received: from localhost ([127.0.0.1]:39755 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qCtdY-0004Rp-Si for submit@debbugs.gnu.org; Fri, 23 Jun 2023 23:08:33 -0400 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:42985) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qCtdW-0004RQ-8a for 63949@debbugs.gnu.org; Fri, 23 Jun 2023 23:08:31 -0400 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 3680A5C00BD; Fri, 23 Jun 2023 23:08:25 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Fri, 23 Jun 2023 23:08:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm1; t=1687576105; x=1687662505; bh=TB fKzXe9vM4DLenhRKX6Oq3Y40AQfeWD77Aag+EetkY=; b=dKDeYwhW/g1AUHnRzt unVSPrRqk3AIWYjoNMEy18Dyxj3tNgPXK6e/1yDTu+VBAw8Gv9ztZk0+RrAKS7Qj QCxStc6RtEiDGyhJTQt+fyeoXikFDuiQAjMuU7mjeZGPy6yD6V49fn486bF3znp/ urgekSPC/wW6JU3G27C8LxtkAIOZxWBxak2yjb6zee5yeKA63XvBtkVO5wwrpLA/ qhGndDb4gEww0IHhhf4I5f8ElG7OHnnkqeYppkWnOtBntcilKBrUCemhcRytmpyQ sYFY9OXvxZZP5tVslOF8YiYbzk8pr+QMdsSl5pVtRMluYg/xJbGQJiapMnKXgle/ AtBA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; t=1687576105; x=1687662505; bh=TBfKzXe9vM4DL enhRKX6Oq3Y40AQfeWD77Aag+EetkY=; b=ceDsPwRqnTrbxvvn5a/t+RfcTlj2Y rDuejZ2JXTJBBucTmsMCLVBvqyKr464/YdSLCknafCksgWjtZLena8Wv3Yxo2LeK 159xv7wW5Fu0Z/FGlFl9jTUFJF6joSJuFMVBpZgKMhruOX5Smv5AnlOkAA0xO4W1 85iFi2MAqryFHe+IcXZNg9UnCkCub5nx6Q36JUxL11FI2YBx62PmYW2xJd1e+YNn TZRDWFP3UhOLu8BOVoBuqYl3zXaYdW2xmV1xoUTsCKjoQTqhX/5f0n4y9rBimVmK ljaTnTdLlpg9iq2K/qOHqmLfZPIWF4mBEXGCcpeic4jNFWdvuCJxB9byg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrgeegiedgvdehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurheptgfkffggfgfuvfevfhfhjgesmhdtreertdefjeenucfhrhhomhepffhmihht rhihucfiuhhtohhvuceoughmihhtrhihsehguhhtohhvrdguvghvqeenucggtffrrghtth gvrhhnpeehteekgfetieeujeeuvddtvdelteffleejteduvdefffejieehheeuteffveei jeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegumh hithhrhiesghhuthhovhdruggvvh X-ME-Proxy: Feedback-ID: i0e71465a:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 23 Jun 2023 23:08:23 -0400 (EDT) Content-Type: multipart/mixed; boundary="------------6T2Q0bK3g5FtHnQ9F9tsgbPh" Message-ID: <72a22541-ba77-11b5-5bb6-3a5cd85586c6@gutov.dev> Date: Sat, 24 Jun 2023 06:08:22 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: =?UTF-8?B?UmU6IGJ1ZyM2Mzk0OTogMzAuMC41MDsgYHZjLXByaW50LWxvZ8K0IGRv?= =?UTF-8?Q?es_not_erase_buffer_when_called_from_*vc-change-log*_buffer=2c_at?= =?UTF-8?Q?_least_for_CVS_logs?= Content-Language: en-US To: Jens Schmidt References: <8c62dd9a-3cad-b992-bfc4-64b2f1db4485@vodafonemail.de> <87fs729jxu.fsf@ledu-giraud.fr> <7bc0c78e-e4b5-0edc-0e9f-2f8fbafc352f@vodafonemail.de> <83y1kt180v.fsf@gnu.org> <8477db3b-b237-aa4b-b4aa-41d31cb77ac1@vodafonemail.de> <834jnf26v2.fsf@gnu.org> <83ilbvz0xx.fsf@gnu.org> <7fe39b49-8319-d7ab-99b3-afe10dc62177@vodafonemail.de> <1c00eecf-9285-3b9e-cf9f-4eba56461ae7@gutov.dev> <83jzw1pc2h.fsf@gnu.org> <1e7358a7-5446-6a89-3556-57e779b545ee@vodafonemail.de> <5b25044e-5d5c-fe15-4b87-b49bfe548daf@vodafonemail.de> <56434485-eaff-0e57-c464-37d14aa201c4@gutov.dev> <83ilbg4yuw.fsf@gnu.org> From: Dmitry Gutov In-Reply-To: <83ilbg4yuw.fsf@gnu.org> X-Spam-Score: -1.8 (-) X-Debbugs-Envelope-To: 63949 Cc: 63949@debbugs.gnu.org, Eli Zaretskii X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.8 (--) This is a multi-part message in MIME format. --------------6T2Q0bK3g5FtHnQ9F9tsgbPh Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 21/06/2023 18:30, Eli Zaretskii wrote: >> Date: Wed, 21 Jun 2023 17:37:55 +0300 >> Cc:63949@debbugs.gnu.org, Jens Schmidt >> From: Dmitry Gutov >> >> On 21/06/2023 16:03, Jens Schmidt wrote: >>> Tested on emacs-29. >> Excellent, thank you. >> >> Eli, I suggest we push it to emacs-29 now. > Fine by me, thanks. And done. >> There could be ways to make it prettier, but probably not by much -- at >> least I don't see any obvious ones if we're keeping the indirect >> buffer-related functionality. Anyway, we can look into that later in >> Emacs 30. > Right. I'm attaching a patch which should work fine, though could be a tad risky for 29. Jens (and possibly others), could you try it out? --------------6T2Q0bK3g5FtHnQ9F9tsgbPh Content-Type: text/x-patch; charset=UTF-8; name="vc-deduce-fileset.diff" Content-Disposition: attachment; filename="vc-deduce-fileset.diff" Content-Transfer-Encoding: base64 ZGlmZiAtLWdpdCBhL2xpc3AvdmMvdmMuZWwgYi9saXNwL3ZjL3ZjLmVsCmluZGV4IDQxMGZl NWMwMWUxLi4yNGU3ODZlYjIxOCAxMDA2NDQKLS0tIGEvbGlzcC92Yy92Yy5lbAorKysgYi9s aXNwL3ZjL3ZjLmVsCkBAIC0xMTIxLDE5ICsxMTIxLDggQEAgdmMtZGVkdWNlLWZpbGVzZXQK IHRoZSByZXR1cm5lZCBsaXN0LgogCiBCRVdBUkU6IHRoaXMgZnVuY3Rpb24gbWF5IGNoYW5n ZSB0aGUgY3VycmVudCBidWZmZXIuIgotICAobGV0IChuZXctYnVmIHJlcykKLSAgICAod2l0 aC1jdXJyZW50LWJ1ZmZlciAob3IgKGJ1ZmZlci1iYXNlLWJ1ZmZlcikgKGN1cnJlbnQtYnVm ZmVyKSkKLSAgICAgIChzZXRxIHJlcwotICAgICAgICAgICAgKHZjLWRlZHVjZS1maWxlc2V0 LTEgbm90LXN0YXRlLWNoYW5naW5nCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICBhbGxvdy11bnJlZ2lzdGVyZWQKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg IHN0YXRlLW1vZGVsLW9ubHktZmlsZXMpKQotICAgICAgKHNldHEgbmV3LWJ1ZiAoY3VycmVu dC1idWZmZXIpKSkKLSAgICAoc2V0LWJ1ZmZlciBuZXctYnVmKQotICAgIHJlcykpCi0KLShk ZWZ1biB2Yy1kZWR1Y2UtZmlsZXNldC0xIChub3Qtc3RhdGUtY2hhbmdpbmcKLSAgICAgICAg ICAgICAgICAgICAgICAgICAgICBhbGxvdy11bnJlZ2lzdGVyZWQKLSAgICAgICAgICAgICAg ICAgICAgICAgICAgICBzdGF0ZS1tb2RlbC1vbmx5LWZpbGVzKQorICAod2hlbiAoYnVmZmVy LWJhc2UtYnVmZmVyKQorICAgIChzZXQtYnVmZmVyIChidWZmZXItYmFzZS1idWZmZXIpKSkK ICAgKGxldCAoYmFja2VuZCkKICAgICAoY29uZAogICAgICAoKGRlcml2ZWQtbW9kZS1wICd2 Yy1kaXItbW9kZSkKQEAgLTExNTgsNyArMTE0Nyw3IEBAIHZjLWRlZHVjZS1maWxlc2V0LTEK IAkJCQkgICAgICAoZGVyaXZlZC1tb2RlLXAgJ2RpZmYtbW9kZSkpKSkpCiAgICAgICAocHJv Z24gICAgICAgICAgICAgICAgICA7RklYTUU6IFdoeSBub3QgYHdpdGgtY3VycmVudC1idWZm ZXInPyAtLVN0ZWYuCiAJKHNldC1idWZmZXIgdmMtcGFyZW50LWJ1ZmZlcikKLQkodmMtZGVk dWNlLWZpbGVzZXQtMSBub3Qtc3RhdGUtY2hhbmdpbmcgYWxsb3ctdW5yZWdpc3RlcmVkIHN0 YXRlLW1vZGVsLW9ubHktZmlsZXMpKSkKKwkodmMtZGVkdWNlLWZpbGVzZXQgbm90LXN0YXRl LWNoYW5naW5nIGFsbG93LXVucmVnaXN0ZXJlZCBzdGF0ZS1tb2RlbC1vbmx5LWZpbGVzKSkp CiAgICAgICgoYW5kIChub3QgYnVmZmVyLWZpbGUtbmFtZSkKIAkgICAoc2V0cSBiYWNrZW5k ICh2Yy1yZXNwb25zaWJsZS1iYWNrZW5kIGRlZmF1bHQtZGlyZWN0b3J5KSkpCiAgICAgICAo bGlzdCBiYWNrZW5kIG5pbCkpCg== --------------6T2Q0bK3g5FtHnQ9F9tsgbPh-- From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 26 15:54:29 2023 Received: (at 63949) by debbugs.gnu.org; 26 Jun 2023 19:54:29 +0000 Received: from localhost ([127.0.0.1]:47112 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qDsI8-00052X-VD for submit@debbugs.gnu.org; Mon, 26 Jun 2023 15:54:29 -0400 Received: from mr3.vodafonemail.de ([145.253.228.163]:49482) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qDsI7-00052I-5G for 63949@debbugs.gnu.org; Mon, 26 Jun 2023 15:54:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vodafonemail.de; s=vfde-mb-mr2-21dec; t=1687809261; bh=7OD2m87TyURmPhAfowqqNAgVd+/4zvcEKw8wQlAS3gs=; h=Message-ID:Date:User-Agent:Subject:To:References:Content-Language: From:In-Reply-To:Content-Type:From; b=qJHBtFKURQUji8c3SUklOJ/VadGEc/SwdjUPA2vouQ4PayPEaIVJfDX0OTM6l4/US 1ksI7LYWRC0huKXfL2VEYjNa5tD9hSWpbelkaWG4gB67MGcXzs4lrg3qXsBmtrruKP CsTd0MDlRhwQ40P6bbG/LTILuH81jFCsFKMN3jj0= Received: from smtp.vodafone.de (unknown [10.0.0.2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by mr3.vodafonemail.de (Postfix) with ESMTPS id 4QqdpP0746z25KR; Mon, 26 Jun 2023 19:54:20 +0000 (UTC) Received: from [192.168.178.41] (port-92-194-122-109.dynamic.as20676.net [92.194.122.109]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp.vodafone.de (Postfix) with ESMTPSA id 4QqdpG2Y6vz9s83; Mon, 26 Jun 2023 19:54:11 +0000 (UTC) Message-ID: Date: Mon, 26 Jun 2023 21:54:06 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: =?UTF-8?B?UmU6IGJ1ZyM2Mzk0OTogMzAuMC41MDsgYHZjLXByaW50LWxvZ8K0IGRv?= =?UTF-8?Q?es_not_erase_buffer_when_called_from_*vc-change-log*_buffer=2c_at?= =?UTF-8?Q?_least_for_CVS_logs?= To: Dmitry Gutov References: <8c62dd9a-3cad-b992-bfc4-64b2f1db4485@vodafonemail.de> <87fs729jxu.fsf@ledu-giraud.fr> <7bc0c78e-e4b5-0edc-0e9f-2f8fbafc352f@vodafonemail.de> <83y1kt180v.fsf@gnu.org> <8477db3b-b237-aa4b-b4aa-41d31cb77ac1@vodafonemail.de> <834jnf26v2.fsf@gnu.org> <83ilbvz0xx.fsf@gnu.org> <7fe39b49-8319-d7ab-99b3-afe10dc62177@vodafonemail.de> <1c00eecf-9285-3b9e-cf9f-4eba56461ae7@gutov.dev> <83jzw1pc2h.fsf@gnu.org> <1e7358a7-5446-6a89-3556-57e779b545ee@vodafonemail.de> <5b25044e-5d5c-fe15-4b87-b49bfe548daf@vodafonemail.de> <56434485-eaff-0e57-c464-37d14aa201c4@gutov.dev> <83ilbg4yuw.fsf@gnu.org> <72a22541-ba77-11b5-5bb6-3a5cd85586c6@gutov.dev> Content-Language: de-DE-frami, en-US From: Jens Schmidt In-Reply-To: <72a22541-ba77-11b5-5bb6-3a5cd85586c6@gutov.dev> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-purgate-type: clean X-purgate: clean X-purgate-size: 151 X-purgate-ID: 155817::1687809260-A7FE1C59-3B6B7AC1/0/0 X-Spam-Score: -1.8 (-) X-Debbugs-Envelope-To: 63949 Cc: 63949@debbugs.gnu.org, Eli Zaretskii X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.8 (--) On 2023-06-24 05:08, Dmitry Gutov wrote: > Jens (and possibly others), could you try it out? Thanks, will do, might take some time again ... From debbugs-submit-bounces@debbugs.gnu.org Thu Jun 29 17:38:21 2023 Received: (at 63949) by debbugs.gnu.org; 29 Jun 2023 21:38:21 +0000 Received: from localhost ([127.0.0.1]:54175 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qEzLJ-0007cA-3Y for submit@debbugs.gnu.org; Thu, 29 Jun 2023 17:38:21 -0400 Received: from mr3.vodafonemail.de ([145.253.228.163]:37480) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qEzLG-0007bu-B2 for 63949@debbugs.gnu.org; Thu, 29 Jun 2023 17:38:20 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vodafonemail.de; s=vfde-mb-mr2-21dec; t=1688074692; bh=03oWURzHwpGAJ8dI7UhBm67VbOVt2LjQGs08bxnxiCI=; h=Message-ID:Date:User-Agent:Subject:Content-Language:To:References: From:In-Reply-To:Content-Type:From; b=iHrGllFJALHaiHDittqzoShgANe+2wcEcZ2omofcctIHeiy4aGHQA9rzMzyZGCAUA 4sbNoCQFnimcdQ+/sqzS2KnLIz71EO7Yyd6RXrD75wg4HfThIfbIDN3qZV01mzZYhk vZVavOm7FNrmVy23nUIHIqTRC5l4jhhyuNEljCNU= Received: from smtp.vodafone.de (unknown [10.0.0.2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by mr3.vodafonemail.de (Postfix) with ESMTPS id 4QsWyr2BCpz29JD; Thu, 29 Jun 2023 21:38:12 +0000 (UTC) Received: from [192.168.178.41] (port-83-236-59-70.dynamic.as20676.net [83.236.59.70]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp.vodafone.de (Postfix) with ESMTPSA id 4QsWyd4fYNzHnfp; Thu, 29 Jun 2023 21:37:58 +0000 (UTC) Message-ID: <441fca98-d15e-4286-d7a2-3050b3fabdba@vodafonemail.de> Date: Thu, 29 Jun 2023 23:37:58 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: =?UTF-8?B?UmU6IGJ1ZyM2Mzk0OTogMzAuMC41MDsgYHZjLXByaW50LWxvZ8K0IGRv?= =?UTF-8?Q?es_not_erase_buffer_when_called_from_*vc-change-log*_buffer=2c_at?= =?UTF-8?Q?_least_for_CVS_logs?= Content-Language: de-DE-frami, en-US To: Dmitry Gutov References: <8c62dd9a-3cad-b992-bfc4-64b2f1db4485@vodafonemail.de> <87fs729jxu.fsf@ledu-giraud.fr> <7bc0c78e-e4b5-0edc-0e9f-2f8fbafc352f@vodafonemail.de> <83y1kt180v.fsf@gnu.org> <8477db3b-b237-aa4b-b4aa-41d31cb77ac1@vodafonemail.de> <834jnf26v2.fsf@gnu.org> <83ilbvz0xx.fsf@gnu.org> <7fe39b49-8319-d7ab-99b3-afe10dc62177@vodafonemail.de> <1c00eecf-9285-3b9e-cf9f-4eba56461ae7@gutov.dev> <83jzw1pc2h.fsf@gnu.org> <1e7358a7-5446-6a89-3556-57e779b545ee@vodafonemail.de> <5b25044e-5d5c-fe15-4b87-b49bfe548daf@vodafonemail.de> <56434485-eaff-0e57-c464-37d14aa201c4@gutov.dev> <83ilbg4yuw.fsf@gnu.org> <72a22541-ba77-11b5-5bb6-3a5cd85586c6@gutov.dev> From: Jens Schmidt In-Reply-To: <72a22541-ba77-11b5-5bb6-3a5cd85586c6@gutov.dev> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-purgate-type: clean X-purgate: clean X-purgate-size: 660 X-purgate-ID: 155817::1688074688-12FFF0CB-F7E3F28B/0/0 X-Spam-Score: -1.8 (-) X-Debbugs-Envelope-To: 63949 Cc: 63949@debbugs.gnu.org, Eli Zaretskii X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.8 (--) On 2023-06-24 05:08, Dmitry Gutov wrote: > And done. Thanks. > I'm attaching a patch which should work fine, though could be a tad > risky for 29. I like the patch - I think it is more in line with what the function does/seems to do originally. > Jens (and possibly others), could you try it out? And it works, too. It covers my test cases. I also tried to run some tests with indirect buffers, and they came out as I would have expected them to come out. It would have been nice to have the opinion of the original author of commit d494833d47968fcd97ba549654a259d6fb6c2eee on this, but he doesn't seem to be active any longer. From debbugs-submit-bounces@debbugs.gnu.org Fri Jun 30 01:56:45 2023 Received: (at 63949) by debbugs.gnu.org; 30 Jun 2023 05:56:45 +0000 Received: from localhost ([127.0.0.1]:54374 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qF77c-000781-U6 for submit@debbugs.gnu.org; Fri, 30 Jun 2023 01:56:45 -0400 Received: from eggs.gnu.org ([209.51.188.92]:46714) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qF77a-00077i-U3 for 63949@debbugs.gnu.org; Fri, 30 Jun 2023 01:56:43 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qF77U-0004MT-Mk; Fri, 30 Jun 2023 01:56:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=xn3PTAlWST1Jh4/rMIQNrwY769mlLVwMP+hQTeu/o/4=; b=DTGOZ67OEdUW1+N9cijd gJ+FZccisL6sZcY5bOvcunMHcBK5dslXFWE/p3c6QtByEelgcWi1Vujz48kZRr40p5bXhQI/nQLvd 8v3XZJrKnEj762DTRfBnNPSJj7lt03e73WN1FXIl8+Ljky/GSNvR/vCcFLhJ/tkNtB2rAblM1H51D lL0l42MSN1T91o/Rlaq/b99q6j75GCmg1hQkR2MaMvS75fF0mRRPJcaXRxycRHdbnNW+JhK4LCf1C xHPQTSh+kCCstoMnUyuj8RtFjGPM2XrOwCKnytUiZI7feXNQvliCj1iv5rJQ7MEKUFAbmbzNU3itl 44Em4I3QNLAQww==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qF77U-0001Y8-6Z; Fri, 30 Jun 2023 01:56:36 -0400 Date: Fri, 30 Jun 2023 08:57:05 +0300 Message-Id: <83y1k1sdam.fsf@gnu.org> From: Eli Zaretskii To: Jens Schmidt , Nathan Moreau In-Reply-To: <441fca98-d15e-4286-d7a2-3050b3fabdba@vodafonemail.de> (message from Jens Schmidt on Thu, 29 Jun 2023 23:37:58 +0200) Subject: Re: bug#63949: 30.0.50; =?utf-8?Q?`vc-print-log=C2=B4?= does not erase buffer when called from *vc-change-log* buffer, at least for CVS logs References: <8c62dd9a-3cad-b992-bfc4-64b2f1db4485@vodafonemail.de> <87fs729jxu.fsf@ledu-giraud.fr> <7bc0c78e-e4b5-0edc-0e9f-2f8fbafc352f@vodafonemail.de> <83y1kt180v.fsf@gnu.org> <8477db3b-b237-aa4b-b4aa-41d31cb77ac1@vodafonemail.de> <834jnf26v2.fsf@gnu.org> <83ilbvz0xx.fsf@gnu.org> <7fe39b49-8319-d7ab-99b3-afe10dc62177@vodafonemail.de> <1c00eecf-9285-3b9e-cf9f-4eba56461ae7@gutov.dev> <83jzw1pc2h.fsf@gnu.org> <1e7358a7-5446-6a89-3556-57e779b545ee@vodafonemail.de> <5b25044e-5d5c-fe15-4b87-b49bfe548daf@vodafonemail.de> <56434485-eaff-0e57-c464-37d14aa201c4@gutov.dev> <83ilbg4yuw.fsf@gnu.org> <72a22541-ba77-11b5-5bb6-3a5cd85586c6@gutov.dev> <441fca98-d15e-4286-d7a2-3050b3fabdba@vodafonemail.de> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 63949 Cc: 63949@debbugs.gnu.org, dmitry@gutov.dev X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Thu, 29 Jun 2023 23:37:58 +0200 > Cc: 63949@debbugs.gnu.org, Eli Zaretskii > From: Jens Schmidt > > It would have been nice to have the opinion of the original author of > commit d494833d47968fcd97ba549654a259d6fb6c2eee on this, but he doesn't > seem to be active any longer. We never CC'ed him. Let's try harder: Nathan, any comments on this discussion and the proposed changes? From debbugs-submit-bounces@debbugs.gnu.org Mon Jul 17 15:53:50 2023 Received: (at 63949) by debbugs.gnu.org; 17 Jul 2023 19:53:50 +0000 Received: from localhost ([127.0.0.1]:50971 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qLUI1-0007GJ-PW for submit@debbugs.gnu.org; Mon, 17 Jul 2023 15:53:50 -0400 Received: from mr5.vodafonemail.de ([145.253.228.165]:56326) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qLUHy-0007G4-63 for 63949@debbugs.gnu.org; Mon, 17 Jul 2023 15:53:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vodafonemail.de; s=vfde-mb-mr2-21dec; t=1689623619; bh=qmWOOU/vltWuJrxy0huH7Oa2uevbPIjlJhmg6+WDC68=; h=Message-ID:Date:User-Agent:From:Subject:To:References: Content-Language:In-Reply-To:Content-Type:From; b=Qozbo/vpX+dfn4CRnG50yf87Ba/UQ+CxPF+UDNu2lTWXmiKSqwEHin1hqp0yRIK2j KxLWUy7JNmIHv8JxgFAW6qQ9/YTe0d0OgZWQFQst/csTvUo1s914yqgiL/5LVyTVqW WiE0ucESj+kFYgNnhqEkuiLqhAsW+AYNO4p/bsnA= Received: from smtp.vodafone.de (unknown [10.0.0.2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by mr5.vodafonemail.de (Postfix) with ESMTPS id 4R4Xnv5Vzdz1yLx; Mon, 17 Jul 2023 19:53:39 +0000 (UTC) Received: from [192.168.178.41] (port-92-194-195-71.dynamic.as20676.net [92.194.195.71]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp.vodafone.de (Postfix) with ESMTPSA id 4R4Xnf1Shmz9sPC; Mon, 17 Jul 2023 19:53:23 +0000 (UTC) Message-ID: <952bab0f-53e6-66d8-0c7b-2cf9ca593482@vodafonemail.de> Date: Mon, 17 Jul 2023 21:53:18 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 From: Jens Schmidt Subject: =?UTF-8?B?UmU6IGJ1ZyM2Mzk0OTogMzAuMC41MDsgYHZjLXByaW50LWxvZ8K0IGRv?= =?UTF-8?Q?es_not_erase_buffer_when_called_from_*vc-change-log*_buffer=2c_at?= =?UTF-8?Q?_least_for_CVS_logs?= To: Eli Zaretskii , Nathan Moreau References: <8c62dd9a-3cad-b992-bfc4-64b2f1db4485@vodafonemail.de> <7bc0c78e-e4b5-0edc-0e9f-2f8fbafc352f@vodafonemail.de> <83y1kt180v.fsf@gnu.org> <8477db3b-b237-aa4b-b4aa-41d31cb77ac1@vodafonemail.de> <834jnf26v2.fsf@gnu.org> <83ilbvz0xx.fsf@gnu.org> <7fe39b49-8319-d7ab-99b3-afe10dc62177@vodafonemail.de> <1c00eecf-9285-3b9e-cf9f-4eba56461ae7@gutov.dev> <83jzw1pc2h.fsf@gnu.org> <1e7358a7-5446-6a89-3556-57e779b545ee@vodafonemail.de> <5b25044e-5d5c-fe15-4b87-b49bfe548daf@vodafonemail.de> <56434485-eaff-0e57-c464-37d14aa201c4@gutov.dev> <83ilbg4yuw.fsf@gnu.org> <72a22541-ba77-11b5-5bb6-3a5cd85586c6@gutov.dev> <441fca98-d15e-4286-d7a2-3050b3fabdba@vodafonemail.de> <83y1k1sdam.fsf@gnu.org> Content-Language: de-DE-frami, en-US In-Reply-To: <83y1k1sdam.fsf@gnu.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-purgate-type: clean X-purgate: clean X-purgate-size: 694 X-purgate-ID: 155817::1689623615-297FF90D-F9169750/0/0 X-Spam-Score: -0.8 (/) X-Debbugs-Envelope-To: 63949 Cc: 63949@debbugs.gnu.org, dmitry@gutov.dev X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.8 (-) On 2023-06-30 07:57, Eli Zaretskii wrote: > We never CC'ed him. Actually, I contacted him off-list some weeks already before your mail, without getting any reply, either. To summarize: - Nathan's changes related to indirect buffers regressed some less-used scenarios in vc. - Dmitry provided a first fix for that which landed in emacs-29 and master already. - Plus a second, IMO more elegant and in Dmitry's opinion slightly more risky patch that also fixes the regression while keeping (AFAICT) Nathan's intended behavior: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=63949#86 Probably we could have that second patch at least in master? Thanks From debbugs-submit-bounces@debbugs.gnu.org Mon Jul 17 20:56:12 2023 Received: (at 63949-done) by debbugs.gnu.org; 18 Jul 2023 00:56:12 +0000 Received: from localhost ([127.0.0.1]:51244 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qLZ0d-0006FT-UJ for submit@debbugs.gnu.org; Mon, 17 Jul 2023 20:56:12 -0400 Received: from wout3-smtp.messagingengine.com ([64.147.123.19]:34591) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qLZ0a-0006FD-PP for 63949-done@debbugs.gnu.org; Mon, 17 Jul 2023 20:56:10 -0400 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id 990E03200916; Mon, 17 Jul 2023 20:56:02 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Mon, 17 Jul 2023 20:56:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm1; t= 1689641762; x=1689728162; bh=kh0B5Iho5LiHCIh1g81yoLJOe5XOfGo0bvI 4Wsk4aK4=; b=c1MGDTWSFg949afrUbM5/UMtUTVodBeqow9wq0qWt1bMzj3q3y+ nxkyTkFoJYpM9JFT7uEBaP7ADXu1mJYSrLj2CV3fJd6a8JOPdhqMBVi50zq7DWtr SxkLOaKmRnU9cCTbwGqstNw4eYo+WeZ+xXJ75WQPIRkrYOmo+En+rc5OI+hA1Xza B9FXk1hqi/22WNoS7HI+I1USisk+UbYKz8m7AVZCrT2657sS/wRa4jQNc0b1rudQ eLPHEfWs9+QU6P9ejlPL69UbKtvtHsJLshBiwnWrRAAF/sFywkHcsvAB66VdXsq9 BKQR7m0AeUN53zyoGf1Mefa6smbN6bbHviQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t= 1689641762; x=1689728162; bh=kh0B5Iho5LiHCIh1g81yoLJOe5XOfGo0bvI 4Wsk4aK4=; b=Eq0ziLog0HxMZYlatRm3r8dmEaxhpLMNF4sIZA/UutjsSsH8Bei WqfVFZZWZ889kzx3id0oAXWD2kRvPWd1sjnzGSjtb6/CGjzW67DZIZTbfxlBlvgE J2AJo0tBfqJkjWIbMCL7NosJ60XHAeXOPAK9SuodxeZhFDXzkcgLnr/QHcstAtm9 qx/8C/GpkqFzInUaNe57Y6y7Zp1epYImVvEQGfUNqUi41ESgeMAtaYGAkbpZ34I4 IK4d9rrpJKHZZ2EFsJJHnp7nCyRdRgfPrlApKXn7u7a7mEgkTprJ6bUPBRb95LeO SvM2S2qerR5/P1Y5QuIAdi86gTXpnqBuokw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedviedrgeefgdegudcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefkffggfgfuvfevfhfhjggtgfesthejredttdefjeenucfhrhhomhepffhmihht rhihucfiuhhtohhvuceoughmihhtrhihsehguhhtohhvrdguvghvqeenucggtffrrghtth gvrhhnpeeigfetveehveevffehledtueekieeikeeufeegudfgfeeghfdulefgfeevledv veenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegumh hithhrhiesghhuthhovhdruggvvh X-ME-Proxy: Feedback-ID: i0e71465a:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 17 Jul 2023 20:56:00 -0400 (EDT) Message-ID: <9e13e4ab-b2fc-0789-17ef-4d45d07cea6b@gutov.dev> Date: Tue, 18 Jul 2023 03:55:59 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: =?UTF-8?B?UmU6IGJ1ZyM2Mzk0OTogMzAuMC41MDsgYHZjLXByaW50LWxvZ8K0IGRv?= =?UTF-8?Q?es_not_erase_buffer_when_called_from_*vc-change-log*_buffer=2c_at?= =?UTF-8?Q?_least_for_CVS_logs?= Content-Language: en-US To: Jens Schmidt , Eli Zaretskii , Nathan Moreau References: <8c62dd9a-3cad-b992-bfc4-64b2f1db4485@vodafonemail.de> <7bc0c78e-e4b5-0edc-0e9f-2f8fbafc352f@vodafonemail.de> <83y1kt180v.fsf@gnu.org> <8477db3b-b237-aa4b-b4aa-41d31cb77ac1@vodafonemail.de> <834jnf26v2.fsf@gnu.org> <83ilbvz0xx.fsf@gnu.org> <7fe39b49-8319-d7ab-99b3-afe10dc62177@vodafonemail.de> <1c00eecf-9285-3b9e-cf9f-4eba56461ae7@gutov.dev> <83jzw1pc2h.fsf@gnu.org> <1e7358a7-5446-6a89-3556-57e779b545ee@vodafonemail.de> <5b25044e-5d5c-fe15-4b87-b49bfe548daf@vodafonemail.de> <56434485-eaff-0e57-c464-37d14aa201c4@gutov.dev> <83ilbg4yuw.fsf@gnu.org> <72a22541-ba77-11b5-5bb6-3a5cd85586c6@gutov.dev> <441fca98-d15e-4286-d7a2-3050b3fabdba@vodafonemail.de> <83y1k1sdam.fsf@gnu.org> <952bab0f-53e6-66d8-0c7b-2cf9ca593482@vodafonemail.de> From: Dmitry Gutov In-Reply-To: <952bab0f-53e6-66d8-0c7b-2cf9ca593482@vodafonemail.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.8 (/) X-Debbugs-Envelope-To: 63949-done Cc: 63949-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.8 (-) On 17/07/2023 22:53, Jens Schmidt wrote: > Probably we could have that second patch at least in master? Yes, of course. Now pushed to master. Thanks for the report, testing and the reminders. :-) Closing! Now if emacs-29 pretest ends up going on for several months more, we could consider backporting the second patch. Or maybe do that after, for 29.2... From debbugs-submit-bounces@debbugs.gnu.org Tue Jul 18 07:08:29 2023 Received: (at 63949) by debbugs.gnu.org; 18 Jul 2023 11:08:29 +0000 Received: from localhost ([127.0.0.1]:51684 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qLiZB-00065I-AD for submit@debbugs.gnu.org; Tue, 18 Jul 2023 07:08:29 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:50040) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qLiZA-000656-Cc for 63949@debbugs.gnu.org; Tue, 18 Jul 2023 07:08:28 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qLiZ3-0001Sf-Dk; Tue, 18 Jul 2023 07:08:21 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=OGmScBHGhQ8E6Du5mOnJTWF/CTG+yCgHADNk/6kSRIA=; b=bPcbxnEi2V9IBxUSfYiO YuAvEKulFZ6Zf9aK1SRGRlHAjx+wSQAtOm0PddoW5efoSdam3/loLeBYksqrza6ZvX3KL7SPFyK+o w23L+A1XLh3+xd6kc2u4Hzg/arqXnVtnZKUCcKuB40USY2yxYTwy1Wa/UUb+v4Bc3cSeTC/4Ac4kN vJ9I/V3OSMFQU6880dBqEFCmwP0brUQhdaPVhg87Y/CYN05KBi2Ns6xGMxfpuQtkxgkGKjWFcXWyj 5GNoNdFxcb3OwqV5IhbW3kCs+ZbuGP6AdZQE9QKJGvgWFkvAyEnTKKFMCdt9LRiu4RFzuUo5gbAJD JX4Kc+wPU8klgw==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qLiZ2-0005hk-Tz; Tue, 18 Jul 2023 07:08:21 -0400 Date: Tue, 18 Jul 2023 14:08:50 +0300 Message-Id: <83lefd79z1.fsf@gnu.org> From: Eli Zaretskii To: Dmitry Gutov In-Reply-To: <9e13e4ab-b2fc-0789-17ef-4d45d07cea6b@gutov.dev> (message from Dmitry Gutov on Tue, 18 Jul 2023 03:55:59 +0300) Subject: Re: bug#63949: 30.0.50; =?utf-8?Q?`vc-print-log=C2=B4?= does not erase buffer when called from *vc-change-log* buffer, at least for CVS logs References: <8c62dd9a-3cad-b992-bfc4-64b2f1db4485@vodafonemail.de> <7bc0c78e-e4b5-0edc-0e9f-2f8fbafc352f@vodafonemail.de> <83y1kt180v.fsf@gnu.org> <8477db3b-b237-aa4b-b4aa-41d31cb77ac1@vodafonemail.de> <834jnf26v2.fsf@gnu.org> <83ilbvz0xx.fsf@gnu.org> <7fe39b49-8319-d7ab-99b3-afe10dc62177@vodafonemail.de> <1c00eecf-9285-3b9e-cf9f-4eba56461ae7@gutov.dev> <83jzw1pc2h.fsf@gnu.org> <1e7358a7-5446-6a89-3556-57e779b545ee@vodafonemail.de> <5b25044e-5d5c-fe15-4b87-b49bfe548daf@vodafonemail.de> <56434485-eaff-0e57-c464-37d14aa201c4@gutov.dev> <83ilbg4yuw.fsf@gnu.org> <72a22541-ba77-11b5-5bb6-3a5cd85586c6@gutov.dev> <441fca98-d15e-4286-d7a2-3050b3fabdba@vodafonemail.de> <83y1k1sdam.fsf@gnu.org> <952bab0f-53e6-66d8-0c7b-2cf9ca593482@vodafonemail.de> <9e13e4ab-b2fc-0789-17ef-4d45d07cea6b@gutov.dev> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 63949 Cc: 63949@debbugs.gnu.org, nathan.moreau@m4x.org, jschmidt4gnu@vodafonemail.de X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Tue, 18 Jul 2023 03:55:59 +0300 > Cc: 63949-done@debbugs.gnu.org > From: Dmitry Gutov > > Now if emacs-29 pretest ends up going on for several months more I could do without salt on my wounds, thank you. From unknown Mon Jun 23 00:37:21 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 15 Aug 2023 11:24:08 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator