GNU bug report logs - #63947
Bug when building ocaml-dune-build-info for ocaml5.0

Previous Next

Full log

Message #11 received at 63947 <at> debbugs.gnu.org (full text, mbox):

From: pukkamustard <pukkamustard <at> posteo.net>
To: Benjamin <benjamin <at> uvy.fr>
Cc: Julien Lepiller <julien <at> lepiller.eu>, 63947 <at> debbugs.gnu.org
Subject: Re: Bug when building ocaml-dune-build-info for ocaml5.0
Date: Tue, 13 Jun 2023 05:08:11 +0000

[Message part 1 (text/plain, inline)]

Hi Benjamin,

Thanks for the report.

"Benjamin" <benjamin <at> uvy.fr> writes:

> Here is a minimal example to reproduce the bug :
>
> ---
> (use-modules
>   (gnu packages ocaml)
>   (guix build-system ocaml))
>
> ;ocaml-dune-build-info
> (package-with-ocaml5.0 ocaml-dune-build-info)
> ---
>
> Building the commented default version will create the expected package
> in /gnu/store/...ocaml-dune-build-info
>
> While building the ocaml5.0 version will build /gnu/store/...ocaml5.0-dune

Yes, this is a bug.

The reason is that the `(inherit dune)` in ocaml-dune-build-info
incorrectly inherits the package variant properties from dune. The OCaml
5.0 variant for ocaml-dune-build-info becomes ocaml5.0-dune.

I think the best way to fix this is to clear the package variant
properties in ocaml-dune-build-info by resetting the properties. Find
attached a patch that does exactly that. CC: Julien for review.

Your fix to inherit from `dune-bootstrap` has a similar effect as the
package variants are defined in `dune` but not `dune-bootstrap`. I
slightly prefer not inheriting from `dune-bootstrap` as it reduces
things that directly touch bootstrap stuff.

-pukkamustard

[0001-gnu-ocaml-dune-build-info-Clear-ocaml-variant-proper.patch (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.