From unknown Fri Jun 20 18:21:34 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#63947 <63947@debbugs.gnu.org> To: bug#63947 <63947@debbugs.gnu.org> Subject: Status: Bug when building ocaml-dune-build-info for ocaml5.0 Reply-To: bug#63947 <63947@debbugs.gnu.org> Date: Sat, 21 Jun 2025 01:21:34 +0000 retitle 63947 Bug when building ocaml-dune-build-info for ocaml5.0 reassign 63947 guix submitter 63947 "Benjamin" severity 63947 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 07 11:55:07 2023 Received: (at submit) by debbugs.gnu.org; 7 Jun 2023 15:55:07 +0000 Received: from localhost ([127.0.0.1]:54576 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q6vV5-0005fa-DT for submit@debbugs.gnu.org; Wed, 07 Jun 2023 11:55:07 -0400 Received: from lists.gnu.org ([209.51.188.17]:39168) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q6vV3-0005fT-Cz for submit@debbugs.gnu.org; Wed, 07 Jun 2023 11:55:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q6vV3-00051a-5X for bug-guix@gnu.org; Wed, 07 Jun 2023 11:55:05 -0400 Received: from mail.uvy.fr ([2001:41d0:304:200::4a2]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q6vV0-0004Rq-Tz for bug-guix@gnu.org; Wed, 07 Jun 2023 11:55:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=uvy.fr; s=202105; t=1686153299; bh=0Lx5HnLyo5I6oMzpAxdSHucDZwj8PxVMN7GTU6nBjWQ=; h=Date:Cc:Subject:From:To; b=Zo+f+rrCDqtHvuHdUJec7x92RTKwno8ey25t4xhqbb6EcbTIVtOGI4MppnfUYSb+8 YZlkE/UZugx+m2cF0Co5N+Fc/k0G3J7IoIE9jfiYHzpG9QEqnI/YYkHKQ1XRQe6iSk BVCX+t09+A7j4zlzvoe6a0WmrPQGjgBZWEnAHYms4yFzWyuQaCd/diKehI929fO3di Nb1l8jTy9ioejN18ImZt0L196ua9tWQDmmv16HcWqr3Aqixb8VlwTozJ24QvlgvnXq dPkmmMmdOGAJSLNjSSUhttHsuedEcOZf86Q8SK9JlGa8MRDLA9Lkd3jUa6Y3Ze0l/S i4/PIy4FsFJlQ== Content-Type: text/plain; charset=UTF-8 Date: Wed, 07 Jun 2023 17:55:21 +0200 Subject: Bug when building ocaml-dune-build-info for ocaml5.0 From: "Benjamin" To: Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 Message-Id: X-Mailer: aerc 0.14.0 Received-SPF: pass client-ip=2001:41d0:304:200::4a2; envelope-from=benjamin@uvy.fr; helo=mail.uvy.fr X-Spam_score_int: 12 X-Spam_score: 1.2 X-Spam_bar: + X-Spam_report: (1.2 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_SBL_CSS=3.335, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: 2.2 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Hello, While trying to work with guix and add the ocaml-lsp-server for ocaml@5.0 I think I faced a bug. I did not find the root cause, but I think this is due to the fact of using a combination of (inherit) and (package-with-ocaml5.0). Content analysis details: (2.2 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 3.6 RCVD_IN_SBL_CSS RBL: Received via a relay in Spamhaus SBL-CSS [2001:41d0:304:200:0:0:0:4a2 listed in] [zen.spamhaus.org] -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at https://www.dnswl.org/, medium trust [209.51.188.17 listed in list.dnswl.org] -0.0 SPF_HELO_PASS SPF: HELO matches SPF record 1.0 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) X-Debbugs-Envelope-To: submit Cc: pukkamustard , Julien Lepiller X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.2 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Hello, While trying to work with guix and add the ocaml-lsp-server for ocaml@5.0 I think I faced a bug. I did not find the root cause, but I think this is due to the fact of using a combination of (inherit) and (package-with-ocaml5.0). Content analysis details: (1.2 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 3.6 RCVD_IN_SBL_CSS RBL: Received via a relay in Spamhaus SBL-CSS [2001:41d0:304:200:0:0:0:4a2 listed in] [zen.spamhaus.org] -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at https://www.dnswl.org/, medium trust [209.51.188.17 listed in list.dnswl.org] -0.0 SPF_HELO_PASS SPF: HELO matches SPF record 1.0 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager Hello, While trying to work with guix and add the ocaml-lsp-server for ocaml@5.0 I think I faced a bug. I did not find the root cause, but I think this is due to the fact of using a combination of (inherit) and (package-with-ocaml5.0). Here is a minimal example to reproduce the bug : --- (use-modules (gnu packages ocaml) (guix build-system ocaml)) ;ocaml-dune-build-info (package-with-ocaml5.0 ocaml-dune-build-info) --- Building the commented default version will create the expected package in /gnu/store/...ocaml-dune-build-info While building the ocaml5.0 version will build /gnu/store/...ocaml5.0-dune I do not exactly know in which direction I should search to fix this issue but there might be a bug in "package-with-ocaml5.0" function Is this really a bug ? Or I did not use properly the package-withocaml5.0 function. Thanks Benjamin From debbugs-submit-bounces@debbugs.gnu.org Thu Jun 08 03:25:54 2023 Received: (at 63947) by debbugs.gnu.org; 8 Jun 2023 07:25:55 +0000 Received: from localhost ([127.0.0.1]:55570 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q7A1q-000477-Kn for submit@debbugs.gnu.org; Thu, 08 Jun 2023 03:25:54 -0400 Received: from mail.uvy.fr ([146.59.197.40]:44590) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q7A1n-00046p-9R for 63947@debbugs.gnu.org; Thu, 08 Jun 2023 03:25:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=uvy.fr; s=202105; t=1686209144; bh=TDMOxPKa636wFXWUbBkzWGDZbEWSkZnB4wAO2GsncfA=; h=Date:Subject:From:To:References:In-Reply-To; b=Ko5lgn+KlkKSVL4/LLEeUS1LR0lX+fKS1d1HemrFxpV4pi+TXAVM4iZXibekzaeHr ZFgJ7FLQ8mYtB6ielWTJyjj4sn1lgZtUXs9lOFFQiKSTXS+1yuhhqCuSYgWQpkobjL W296ECofIecu47S6OqHD/vPUDeGFRJVt2o0ywBkJEam3vQi3hOxVJNh6orj0pNgsLW gEQxQLJPM4irhLjrOH6Uku1aqNs7W5A/9DVQn/UKaSZtwu2OoNe1sBkIF1+BsZ/rxz nxFBQBVto6ANexmtvnwxd6P6I2EDf30koDEBLY+OuJGAFhCNUEOZe4VnBJiG9oTqqs 5GimgLhh1iqYQ== Content-Type: text/plain; charset=UTF-8 Date: Thu, 08 Jun 2023 09:26:07 +0200 Subject: Re: Bug when building ocaml-dune-build-info for ocaml5.0 From: "Benjamin" To: <63947@debbugs.gnu.org> Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 Message-Id: X-Mailer: aerc 0.14.0 References: In-Reply-To: X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 63947 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) After digging a bit more, I could fix this issue by modifying the definition of ocaml-dune-build-info with this patch. The problem might have come from the non standard definition of dune package using properties only. diff --git a/gnu/packages/ocaml.scm b/gnu/packages/ocaml.scm index f0b8f9e912..40a820b90e 100644 --- a/gnu/packages/ocaml.scm +++ b/gnu/packages/ocaml.scm @@ -9538,7 +9538,7 @@ (define-public ocaml-fix (define-public ocaml-dune-build-info (package - (inherit dune) + (inherit dune-bootstrap) (name "ocaml-dune-build-info") (build-system dune-build-system) (arguments From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 13 02:26:17 2023 Received: (at 63947) by debbugs.gnu.org; 13 Jun 2023 06:26:17 +0000 Received: from localhost ([127.0.0.1]:41191 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q8xTt-0007g4-72 for submit@debbugs.gnu.org; Tue, 13 Jun 2023 02:26:17 -0400 Received: from mout01.posteo.de ([185.67.36.65]:41845) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q8xTo-0007fl-L0 for 63947@debbugs.gnu.org; Tue, 13 Jun 2023 02:26:15 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 6D383240027 for <63947@debbugs.gnu.org>; Tue, 13 Jun 2023 08:26:06 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1686637566; bh=N8B1bOt+vNNftGKsRW+Rti6kcl0FvqmGC0pA6LHLB6Q=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:From; b=F0GJ5PNrpg2VZJdXb42W60D3hOF/L+yubY/gu9JmVRMX6bexchB/ZhIWK+rgmHHnN lDyaiToaRr5dxyG5fGRFO01/yLTN8jsxNNzQjkzkNpkyJeLxHTj2y0x02lIbNwwk8m AsiRuoNieakiQ2rMuLD9dSu1+EwnthxmDCvMcmgdIs8OprabvYyeFwiSBQrl8T8eCu h7VW0KMFYCAlqOmwJdGpaRBNkfOzjTYJPOAwO2cTshmEpD7xgc+TPlW5PCB9P8bmqc OxxyF9Oo0E5IEEpcFBtGOkJ4DLDUkC8glVHSSavR6s01xbpuSpTLTKQyhtUY2CFGYm OBQMh6ED4VtdQ== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4QgJTn3FZyz9rxK; Tue, 13 Jun 2023 08:26:05 +0200 (CEST) References: From: pukkamustard To: Benjamin Subject: Re: Bug when building ocaml-dune-build-info for ocaml5.0 Date: Tue, 13 Jun 2023 05:08:11 +0000 In-reply-to: Message-ID: <86r0qfvpxf.fsf@posteo.net> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 63947 Cc: Julien Lepiller , 63947@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) --=-=-= Content-Type: text/plain Hi Benjamin, Thanks for the report. "Benjamin" writes: > Here is a minimal example to reproduce the bug : > > --- > (use-modules > (gnu packages ocaml) > (guix build-system ocaml)) > > ;ocaml-dune-build-info > (package-with-ocaml5.0 ocaml-dune-build-info) > --- > > Building the commented default version will create the expected package > in /gnu/store/...ocaml-dune-build-info > > While building the ocaml5.0 version will build /gnu/store/...ocaml5.0-dune Yes, this is a bug. The reason is that the `(inherit dune)` in ocaml-dune-build-info incorrectly inherits the package variant properties from dune. The OCaml 5.0 variant for ocaml-dune-build-info becomes ocaml5.0-dune. I think the best way to fix this is to clear the package variant properties in ocaml-dune-build-info by resetting the properties. Find attached a patch that does exactly that. CC: Julien for review. Your fix to inherit from `dune-bootstrap` has a similar effect as the package variants are defined in `dune` but not `dune-bootstrap`. I slightly prefer not inheriting from `dune-bootstrap` as it reduces things that directly touch bootstrap stuff. -pukkamustard --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-gnu-ocaml-dune-build-info-Clear-ocaml-variant-proper.patch >From e9286b8552c2c4bed4dd7ddab4ccfeaedb03406c Mon Sep 17 00:00:00 2001 Message-Id: From: pukkamustard Date: Tue, 13 Jun 2023 08:13:48 +0200 Subject: [PATCH] gnu: ocaml-dune-build-info: Clear ocaml*-variant properties. * gnu/packages/ocaml.scm (ocaml-dune-build-info): Clear properties. Fixes . Reported by Benjamin . --- gnu/packages/ocaml.scm | 1 + 1 file changed, 1 insertion(+) diff --git a/gnu/packages/ocaml.scm b/gnu/packages/ocaml.scm index ab0aa0574a..06ef5796d9 100644 --- a/gnu/packages/ocaml.scm +++ b/gnu/packages/ocaml.scm @@ -9664,6 +9664,7 @@ (define-public ocaml-dune-build-info #:tests? #f)) (propagated-inputs (list ocaml-odoc)) + (properties '()) (synopsis "Embed build information inside an executable") (description "This package allows one to access information about how the executable was built, such as the version of the project at which it was built base-commit: 0433e7f3c200936fbf77f22aa3b433413d17d0fa -- 2.40.1 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 13 02:36:32 2023 Received: (at 63947) by debbugs.gnu.org; 13 Jun 2023 06:36:32 +0000 Received: from localhost ([127.0.0.1]:41212 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q8xdo-0007yW-6B for submit@debbugs.gnu.org; Tue, 13 Jun 2023 02:36:32 -0400 Received: from lepiller.eu ([89.234.186.109]:33672) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q8xdl-0007yK-LI for 63947@debbugs.gnu.org; Tue, 13 Jun 2023 02:36:31 -0400 Received: from lepiller.eu (localhost [127.0.0.1]) by lepiller.eu (OpenSMTPD) with ESMTP id 37c3b067; Tue, 13 Jun 2023 06:36:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=lepiller.eu; h=date:from :to:cc:subject:in-reply-to:references:message-id:mime-version :content-type:content-transfer-encoding; s=dkim; bh=6a7nu1L1g/+q nDKDx+X4hrwSE4ijO8YfWEynYiUlx5s=; b=JVX4z2vyxt7IptI03G/BM7DC/41Z Y+i33gt4buaxaLfFdRp5p5z5zpx/AbgxJsnZXhdcPdAblLRj6m14WRT8SgQz1KAw w0kr/ekklSJdN1iEjqRPbDKudHWwmoHVyaMtQi/1CSjPp09Ag8cQ0Z+k1gvhls16 WvJMPKCx35lO3knHMbPh+3RF3YZpgx87A2neKwcUmWZedWniAiLN1eg5f7OnyF5/ I9Ia6NcaTge8TuvoQpTaJhSrznNYrHAfPsNWLtpa3FoatIqcMAVJIBT/ViF2sdPL 8NBMTwt5yR3HcnPii++QnpxfqpOF4IjPhnpyCQtcuhG5E0Ov3Xte9Db/Ww== Received: by lepiller.eu (OpenSMTPD) with ESMTPSA id 09e90a2a (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Tue, 13 Jun 2023 06:36:26 +0000 (UTC) Date: Tue, 13 Jun 2023 08:36:22 +0200 From: Julien Lepiller To: pukkamustard , Benjamin Subject: Re: Bug when building ocaml-dune-build-info for ocaml5.0 User-Agent: K-9 Mail for Android In-Reply-To: <86r0qfvpxf.fsf@posteo.net> References: <86r0qfvpxf.fsf@posteo.net> Message-ID: <744DD02A-15C8-4CB9-90B8-9E7CF69021C4@lepiller.eu> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 63947 Cc: 63947@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Untested yet, but looks fine, thanks Le 13 juin 2023 07:08:11 GMT+02:00, pukkamustard a =C3=A9crit=C2=A0: > >Hi Benjamin, > >Thanks for the report=2E > >"Benjamin" writes: > >> Here is a minimal example to reproduce the bug : >> >> --- >> (use-modules >> (gnu packages ocaml) >> (guix build-system ocaml)) >> >> ;ocaml-dune-build-info >> (package-with-ocaml5=2E0 ocaml-dune-build-info) >> --- >> >> Building the commented default version will create the expected package >> in /gnu/store/=2E=2E=2Eocaml-dune-build-info >> >> While building the ocaml5=2E0 version will build /gnu/store/=2E=2E=2Eoc= aml5=2E0-dune > >Yes, this is a bug=2E > >The reason is that the `(inherit dune)` in ocaml-dune-build-info >incorrectly inherits the package variant properties from dune=2E The OCam= l >5=2E0 variant for ocaml-dune-build-info becomes ocaml5=2E0-dune=2E > >I think the best way to fix this is to clear the package variant >properties in ocaml-dune-build-info by resetting the properties=2E Find >attached a patch that does exactly that=2E CC: Julien for review=2E > >Your fix to inherit from `dune-bootstrap` has a similar effect as the >package variants are defined in `dune` but not `dune-bootstrap`=2E I >slightly prefer not inheriting from `dune-bootstrap` as it reduces >things that directly touch bootstrap stuff=2E > >-pukkamustard >