GNU bug report logs - #63900
[PATCH] gnu: Add emacs-fb2-reader.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#63900: closed ([PATCH] gnu: Add emacs-fb2-reader.)
Date: Sat, 10 Jun 2023 18:47:01 +0000

[Message part 1 (text/plain, inline)]

Your message dated Sat, 10 Jun 2023 20:46:45 +0200
with message-id <87zg57b1ey.fsf <at> nicolasgoaziou.fr>
and subject line Re: [bug#63900] [PATCH] gnu: Add emacs-fb2-reader.
has caused the debbugs.gnu.org bug report #63900,
regarding [PATCH] gnu: Add emacs-fb2-reader.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
63900: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=63900
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Adam Kandur <4164616d.4b616e647572 <at> gmail.com>
To: guix-patches <at> gnu.org
Cc: Adam Kandur <4164616d.4b616e647572 <at> gmail.com>
Subject: [PATCH] gnu: Add emacs-fb2-reader.
Date: Sun,  4 Jun 2023 19:30:21 +0300

* gnu/packages/emacs-xyz.scm (emacs-fb2-reader): New variable.
---
 gnu/packages/emacs-xyz.scm | 32 ++++++++++++++++++++++++++++++++
 1 file changed, 32 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index b77bd0aa83..f563063d7f 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -1632,6 +1632,38 @@ (define-public emacs-fzf
 purpose finder.")
       (license license:gpl3+))))
 
+(define-public emacs-fb2-reader
+  (let ((revision "0")
+        ;; named branch is outdated
+        (commit "9836db284749e0cef4c43c2cb5358c82ae9b8589"))
+    (package
+      (name "emacs-fb2-reader")
+      (version (git-version "0.1" revision commit))
+      (source
+       (origin
+	 (method git-fetch)
+	 (uri (git-reference
+	       (url "https://github.com/jumper047/fb2-reader")
+	       (commit commit)))
+	 (file-name (git-file-name name version))
+	 (sha256
+	  (base32 "0vx4b9wnmx1bng8wak5r7yryyvgib4m46l6b877xzkdhsjr3rbsi"))))
+      (build-system emacs-build-system)
+      (native-inputs
+       (list emacs-buttercup
+             emacs-dash
+             emacs-s
+             emacs-async))
+      (propagated-inputs
+       (list emacs-visual-fill-column
+             emacs-f
+             unzip))
+      (home-page "https://github.com/jumper047/fb2-reader")
+      (synopsis "Emacs plugin to read .fb2 and .fb2.zip ebooks")
+      (description "This package allows users to read fb2 books
+whithout quiting Emacs.")
+      (license license:gpl3))))
+
 (define-public emacs-minions
   (package
     (name "emacs-minions")
-- 
2.40.1

[Message part 3 (message/rfc822, inline)]

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Adam Kandur <4164616d.4b616e647572 <at> gmail.com>
Cc: 63900-done <at> debbugs.gnu.org
Subject: Re: [bug#63900] [PATCH] gnu: Add emacs-fb2-reader.
Date: Sat, 10 Jun 2023 20:46:45 +0200

Hello,

Adam Kandur <4164616d.4b616e647572 <at> gmail.com> writes:

> * gnu/packages/emacs-xyz.scm (emacs-fb2-reader): New variable.

Thank you. Applied, with the changes below.

> +(define-public emacs-fb2-reader
> +  (let ((revision "0")
> +        (commit "9836db284749e0cef4c43c2cb5358c82ae9b8589")) ; version bump
> +    (package
> +      (name "emacs-fb2-reader")
> +      (version (git-version "0.1.1" revision commit))

No need for `git-version' for version bumps.

> +      (native-inputs
> +       (list emacs-buttercup
> +             emacs-dash
> +             emacs-s
> +             emacs-async))
> +      (propagated-inputs
> +       (list emacs-visual-fill-column
> +             emacs-f))

I reordered inputs alphabetically.

Regards,
-- 
Nicolas Goaziou

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.