Subject: [bug#63900] [PATCH] gnu: Add emacs-fb2-reader.

From: Nicolas Goaziou <[email-masked]>
Date: Mon, 05 Jun 2023 18:15:47 +0200

Hello,

Adam Kandur <[email-masked]> writes:

> * gnu/packages/emacs-xyz.scm (emacs-fb2-reader): New variable.

Thank you. Some comments follow. 

> +(define-public emacs-fb2-reader
> +  (let ((revision "0")
> +        ;; named branch is outdated
> +        (commit "9836db284749e0cef4c43c2cb5358c82ae9b8589"))

This exactly matches version 0.1.1 so you should add "; version bump"
comment at the end of the line, and use 0.1.1 as the version.

> +      (native-inputs
> +       (list emacs-buttercup
> +             emacs-dash
> +             emacs-s
> +             emacs-async))

There are tests, could you try running them?

Note that inputs should be ordered alphabetically.

> +      (propagated-inputs
> +       (list emacs-visual-fill-column
> +             emacs-f
> +             unzip))

Likewise.

Also, unzip should be an input rather than a propagated input, and
"fb2-reader.el" should be patched accordingly (i.e., replacing

  "unzip"

with

  (search-input-files inputs "/bin/unzip"))

> +      (home-page "https://github.com/jumper047/fb2-reader")
> +      (synopsis "Emacs plugin to read .fb2 and .fb2.zip ebooks")

I suggest:

  Emacs plugin to read FictionBook2 ebooks

> +      (description "This package allows users to read fb2 books
> +whithout quiting Emacs.")

What about:

  FB2 Reader provides a major mode for reading FictionBook2 (@file{.fb2}
  and @file{.fb2.zip} files) ebooks.

> +      (license license:gpl3))))

License is actually gpl3+, as mentioned in the main file.

Could you send an updated patch?

Regards,
-- 
Nicolas Goaziou