From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 05 00:56:37 2023 Received: (at submit) by debbugs.gnu.org; 5 Jun 2023 04:56:37 +0000 Received: from localhost ([127.0.0.1]:47762 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q62Gj-0004py-Bt for submit@debbugs.gnu.org; Mon, 05 Jun 2023 00:56:37 -0400 Received: from lists.gnu.org ([209.51.188.17]:43310) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <4164616d.4b616e647572@gmail.com>) id 1q5qcs-0006xt-4b for submit@debbugs.gnu.org; Sun, 04 Jun 2023 12:30:42 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <4164616d.4b616e647572@gmail.com>) id 1q5qcr-0001eO-LJ for guix-patches@gnu.org; Sun, 04 Jun 2023 12:30:41 -0400 Received: from mail-lf1-x12d.google.com ([2a00:1450:4864:20::12d]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from <4164616d.4b616e647572@gmail.com>) id 1q5qcp-0008WC-JX for guix-patches@gnu.org; Sun, 04 Jun 2023 12:30:41 -0400 Received: by mail-lf1-x12d.google.com with SMTP id 2adb3069b0e04-4f6170b1486so2376046e87.0 for ; Sun, 04 Jun 2023 09:30:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1685896237; x=1688488237; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=Rvbe2bggMUX0qmbbE8VwJrbdyxxuQJTh4naxC9Ingz8=; b=Ep5lOx8XCVkAJLWEDjNVA2jDLqjSWR8VKUEKvvzmPRWeqk9iBo5BCTkbee3XzLJUCc XTbmIzvf3Ks6gkg1quxbqA17M1ifeyDyQim9oGysqXdeJCTUOZ1nFNCDd1OKo1GYjnVR a9Au1nyQpPxl25JH9JBhriX3NXRFEYDCLMofNu6hXRv/AIn8H9QEzQiMeEvTmF8pe902 mVpEazfkXc8GL8zAxCC3yhdynhaCNAoC7ciWAXEy3FZEqXcGtvSvqT2ONI8YwMcIDQ+2 iGUWertfZoK6+txBCdyi7Yj7a8zpqiwGHClGmcAGLXNNtPkn3E9Jbwkq0J/Mz5SAqAFu 0Nmw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685896237; x=1688488237; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Rvbe2bggMUX0qmbbE8VwJrbdyxxuQJTh4naxC9Ingz8=; b=DZ0SOhFP9jd4+nmRuz+Dm4ommEWGc5SzJA8FRB8q3nLVW3SFJ/sz64DWjsIjB5gy/O a7AiSne5sltxZRa4ihUeuGfJctrmrpFFXgU4ufSQ0kAdRXKIAuAYKN+Sp/5azldLjsCc 5eDk+4pcnXjFS8DkveM54CeYPCrfpp8Q8eTihBCf9r3BOQ2JnAqdgeiY/rNOlsqTLhva M2d3Ih0Mmei+OMKCimtWscdNzVc0UPMSwxkYoy8apekmFMkfXlbFMakMK/yv7pBAD8tl k4fld85KpbpG94RoQyfwpvBgSgXAFCo8lXxELpWSiRfKKpSetcIHqW9TYvWaxyZXaAsd RqkA== X-Gm-Message-State: AC+VfDyvw6mgPb+TuVtAbK0wgg1F01f1iSaM+w1QDBrO+tUEpr5aWiQq oA1p3OQH9Cc/nuYn4dVRmAoWfFaZjKs= X-Google-Smtp-Source: ACHHUZ77zGrC2Qk0ZMIYX94IsXj6P9QnuCDK6VcVFbkrhZwt4z87Pia+AKZ03F9yJpK8uOAqEg7Mag== X-Received: by 2002:a05:6512:3502:b0:4f3:7974:2f32 with SMTP id h2-20020a056512350200b004f379742f32mr2672484lfs.9.1685896236922; Sun, 04 Jun 2023 09:30:36 -0700 (PDT) Received: from localhost.localdomain ([2a00:1370:8188:4fd4:6f92:f7fc:1ccb:7278]) by smtp.googlemail.com with ESMTPSA id q19-20020a19a413000000b004f6275f672fsm174022lfc.226.2023.06.04.09.30.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 04 Jun 2023 09:30:36 -0700 (PDT) From: Adam Kandur <4164616d.4b616e647572@gmail.com> To: guix-patches@gnu.org Subject: [PATCH] gnu: Add emacs-fb2-reader. Date: Sun, 4 Jun 2023 19:30:21 +0300 Message-Id: <20230604163021.5163-1-4164616d.4b616e647572@gmail.com> X-Mailer: git-send-email 2.40.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2a00:1450:4864:20::12d; envelope-from=4164616d.4b616e647572@gmail.com; helo=mail-lf1-x12d.google.com X-Spam_score_int: -10 X-Spam_score: -1.1 X-Spam_bar: - X-Spam_report: (-1.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, FROM_LOCAL_HEX=0.006, FROM_STARTS_WITH_NUMS=0.738, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: -0.2 (/) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Mon, 05 Jun 2023 00:56:30 -0400 Cc: Adam Kandur <4164616d.4b616e647572@gmail.com> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.2 (-) * gnu/packages/emacs-xyz.scm (emacs-fb2-reader): New variable. --- gnu/packages/emacs-xyz.scm | 32 ++++++++++++++++++++++++++++++++ 1 file changed, 32 insertions(+) diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm index b77bd0aa83..f563063d7f 100644 --- a/gnu/packages/emacs-xyz.scm +++ b/gnu/packages/emacs-xyz.scm @@ -1632,6 +1632,38 @@ (define-public emacs-fzf purpose finder.") (license license:gpl3+)))) +(define-public emacs-fb2-reader + (let ((revision "0") + ;; named branch is outdated + (commit "9836db284749e0cef4c43c2cb5358c82ae9b8589")) + (package + (name "emacs-fb2-reader") + (version (git-version "0.1" revision commit)) + (source + (origin + (method git-fetch) + (uri (git-reference + (url "https://github.com/jumper047/fb2-reader") + (commit commit))) + (file-name (git-file-name name version)) + (sha256 + (base32 "0vx4b9wnmx1bng8wak5r7yryyvgib4m46l6b877xzkdhsjr3rbsi")))) + (build-system emacs-build-system) + (native-inputs + (list emacs-buttercup + emacs-dash + emacs-s + emacs-async)) + (propagated-inputs + (list emacs-visual-fill-column + emacs-f + unzip)) + (home-page "https://github.com/jumper047/fb2-reader") + (synopsis "Emacs plugin to read .fb2 and .fb2.zip ebooks") + (description "This package allows users to read fb2 books +whithout quiting Emacs.") + (license license:gpl3)))) + (define-public emacs-minions (package (name "emacs-minions") -- 2.40.1 From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 05 12:15:59 2023 Received: (at 63900) by debbugs.gnu.org; 5 Jun 2023 16:15:59 +0000 Received: from localhost ([127.0.0.1]:50132 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q6CsB-000479-6e for submit@debbugs.gnu.org; Mon, 05 Jun 2023 12:15:59 -0400 Received: from relay9-d.mail.gandi.net ([217.70.183.199]:39311) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q6Cs8-00046s-3j for 63900@debbugs.gnu.org; Mon, 05 Jun 2023 12:15:56 -0400 X-GND-Sasl: mail@nicolasgoaziou.fr X-GND-Sasl: mail@nicolasgoaziou.fr Received: by mail.gandi.net (Postfix) with ESMTPSA id 7728DFF809; Mon, 5 Jun 2023 16:15:49 +0000 (UTC) From: Nicolas Goaziou To: Adam Kandur <4164616d.4b616e647572@gmail.com> Subject: Re: [bug#63900] [PATCH] gnu: Add emacs-fb2-reader. References: <20230604163021.5163-1-4164616d.4b616e647572@gmail.com> Date: Mon, 05 Jun 2023 18:15:47 +0200 In-Reply-To: <20230604163021.5163-1-4164616d.4b616e647572@gmail.com> (Adam Kandur's message of "Sun, 4 Jun 2023 19:30:21 +0300") Message-ID: <87zg5ddgwc.fsf@nicolasgoaziou.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 63900 Cc: 63900@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hello, Adam Kandur <4164616d.4b616e647572@gmail.com> writes: > * gnu/packages/emacs-xyz.scm (emacs-fb2-reader): New variable. Thank you. Some comments follow. > +(define-public emacs-fb2-reader > + (let ((revision "0") > + ;; named branch is outdated > + (commit "9836db284749e0cef4c43c2cb5358c82ae9b8589")) This exactly matches version 0.1.1 so you should add "; version bump" comment at the end of the line, and use 0.1.1 as the version. > + (native-inputs > + (list emacs-buttercup > + emacs-dash > + emacs-s > + emacs-async)) There are tests, could you try running them? Note that inputs should be ordered alphabetically. > + (propagated-inputs > + (list emacs-visual-fill-column > + emacs-f > + unzip)) Likewise. Also, unzip should be an input rather than a propagated input, and "fb2-reader.el" should be patched accordingly (i.e., replacing "unzip" with (search-input-files inputs "/bin/unzip")) > + (home-page "https://github.com/jumper047/fb2-reader") > + (synopsis "Emacs plugin to read .fb2 and .fb2.zip ebooks") I suggest: Emacs plugin to read FictionBook2 ebooks > + (description "This package allows users to read fb2 books > +whithout quiting Emacs.") What about: FB2 Reader provides a major mode for reading FictionBook2 (@file{.fb2} and @file{.fb2.zip} files) ebooks. > + (license license:gpl3)))) License is actually gpl3+, as mentioned in the main file. Could you send an updated patch? Regards, -- Nicolas Goaziou From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 06 16:35:34 2023 Received: (at 63900) by debbugs.gnu.org; 6 Jun 2023 20:35:34 +0000 Received: from localhost ([127.0.0.1]:53124 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q6dOv-0004PK-Oq for submit@debbugs.gnu.org; Tue, 06 Jun 2023 16:35:34 -0400 Received: from mail-oi1-f176.google.com ([209.85.167.176]:42300) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <4164616d.4b616e647572@gmail.com>) id 1q6dOr-0004P2-JH for 63900@debbugs.gnu.org; Tue, 06 Jun 2023 16:35:32 -0400 Received: by mail-oi1-f176.google.com with SMTP id 5614622812f47-39aa8a055ecso2238360b6e.1 for <63900@debbugs.gnu.org>; Tue, 06 Jun 2023 13:35:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1686083724; x=1688675724; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=ZnrM2CbgTm1HroT+v/ll7RM9Zm6tFu+aVJlFrXM3xUQ=; b=VTaDXIbOazyHEZLz1gosUGo3yryG6DPT4NikOE7jaYiKWyDNixGveKRstX6akDBByp OvrCebQN7ifPqmt8IxzpXadsZmC//mfz+n5bJxF5qq/wb9BMnfMTi1zEDpfgBpHVhprO 7zb9A7wmhwYUg+cI+sXpCFL3rjxpwQfgahEHDIBVu8eJe6kauQUuz0I9DCToWus6WzIT KpVsMu0nZ6KtG1kHcwMGMHhWbjwJg4oK0JhvxhPqb7WO4gRkTEfuZu5rg8/XUTTkWIno AGme/el+Hr7qzGAwDN+8deOxgO3HPesCslDdEe9C0bDTGLGdFpshcfHNE5oANs9m1ri9 McRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686083724; x=1688675724; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ZnrM2CbgTm1HroT+v/ll7RM9Zm6tFu+aVJlFrXM3xUQ=; b=G5sGY7KB+smF3uEuWhK6CC0OMJfK6DcRQExFDXDzfY2Jsdv29C68qaBd68yu5Ku/4P Y7xA7LwMyFHGGaVFVNdIPd2zwJwmh2zGXC5uP1GasU9eSgTfX0VnRVPU0fxIE+4EZDuI 5Fr0gFjWK19TlrO4hmp+x5kZxkzVjOvDIfcFatDV+75J0xUGpBToBQGTPD1XkAm/2nK/ IUC9TuR1X60UdzYReORKb2S26AEC454G4W91NBTKh9LYpNStCWqdM4RBBRWbnlvH8C64 GD6C+zRY3uF2yovYRxMcEDJtlmi9semJvtSid+QXIkGKUEyduX2SZYPwdCKuuRrtSPZA +VHg== X-Gm-Message-State: AC+VfDyUZZJ3bZ+ZWFihKa1JBcX4DUI4ZnU2WX+CpRtJxvYGx35dOAEm 3bdSPUi0v4k42toB0VJPQBZE5Wg8GpxJMFSHwqO66Lxwd0w= X-Google-Smtp-Source: ACHHUZ7WTC4GO92zNiRSQQ5a0VeF2h56nmz+UF9gRwFdHH55gjCQ9C+5zlNm/QHhoiRW49P8UQJWJguFIWZ2e48jmXo= X-Received: by 2002:aca:3d54:0:b0:39a:6685:1e15 with SMTP id k81-20020aca3d54000000b0039a66851e15mr5599333oia.15.1686083723791; Tue, 06 Jun 2023 13:35:23 -0700 (PDT) MIME-Version: 1.0 References: <20230604163021.5163-1-4164616d.4b616e647572@gmail.com> <87zg5ddgwc.fsf@nicolasgoaziou.fr> In-Reply-To: <87zg5ddgwc.fsf@nicolasgoaziou.fr> From: Adam <4164616d.4b616e647572@gmail.com> Date: Tue, 6 Jun 2023 23:35:12 +0300 Message-ID: Subject: Re: [bug#63900] [PATCH] gnu: Add emacs-fb2-reader. To: Nicolas Goaziou Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 1.1 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Sure, I will try make a new patch this week On Mon, Jun 5, 2023 at 7:15 PM Nicolas Goaziou wrote: > > Hello, > > Adam Kandur writes: > > > * gnu/packages/emacs-xyz.scm (emacs-fb2-reader): New variable. > > Thank you. Some comments follow. [...] Content analysis details: (1.1 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.6 FROM_STARTS_WITH_NUMS From: starts with several numbers 0.3 FROM_LOCAL_HEX From: localpart has long hexadecimal sequence 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (4164616d.4b616e647572[at]gmail.com) 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record 0.2 FREEMAIL_ENVFROM_END_DIGIT Envelope-from freemail username ends in digit (4164616d.4b616e647572[at]gmail.com) -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.167.176 listed in wl.mailspike.net] -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.167.176 listed in list.dnswl.org] X-Debbugs-Envelope-To: 63900 Cc: 63900@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.1 (/) Sure, I will try make a new patch this week On Mon, Jun 5, 2023 at 7:15=E2=80=AFPM Nicolas Goaziou wrote: > > Hello, > > Adam Kandur <4164616d.4b616e647572@gmail.com> writes: > > > * gnu/packages/emacs-xyz.scm (emacs-fb2-reader): New variable. > > Thank you. Some comments follow. > > > +(define-public emacs-fb2-reader > > + (let ((revision "0") > > + ;; named branch is outdated > > + (commit "9836db284749e0cef4c43c2cb5358c82ae9b8589")) > > This exactly matches version 0.1.1 so you should add "; version bump" > comment at the end of the line, and use 0.1.1 as the version. > > > + (native-inputs > > + (list emacs-buttercup > > + emacs-dash > > + emacs-s > > + emacs-async)) > > There are tests, could you try running them? > > Note that inputs should be ordered alphabetically. > > > + (propagated-inputs > > + (list emacs-visual-fill-column > > + emacs-f > > + unzip)) > > Likewise. > > Also, unzip should be an input rather than a propagated input, and > "fb2-reader.el" should be patched accordingly (i.e., replacing > > "unzip" > > with > > (search-input-files inputs "/bin/unzip")) > > > + (home-page "https://github.com/jumper047/fb2-reader") > > + (synopsis "Emacs plugin to read .fb2 and .fb2.zip ebooks") > > I suggest: > > Emacs plugin to read FictionBook2 ebooks > > > + (description "This package allows users to read fb2 books > > +whithout quiting Emacs.") > > What about: > > FB2 Reader provides a major mode for reading FictionBook2 (@file{.fb2} > and @file{.fb2.zip} files) ebooks. > > > + (license license:gpl3)))) > > License is actually gpl3+, as mentioned in the main file. > > Could you send an updated patch? > > Regards, > -- > Nicolas Goaziou From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 10 06:38:55 2023 Received: (at 63900) by debbugs.gnu.org; 10 Jun 2023 10:38:56 +0000 Received: from localhost ([127.0.0.1]:33324 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q7vzj-0005JP-KS for submit@debbugs.gnu.org; Sat, 10 Jun 2023 06:38:55 -0400 Received: from mail-lj1-f173.google.com ([209.85.208.173]:50617) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <4164616d.4b616e647572@gmail.com>) id 1q7vzf-0005JA-ID for 63900@debbugs.gnu.org; Sat, 10 Jun 2023 06:38:53 -0400 Received: by mail-lj1-f173.google.com with SMTP id 38308e7fff4ca-2b1badb8f9bso29675451fa.1 for <63900@debbugs.gnu.org>; Sat, 10 Jun 2023 03:38:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1686393525; x=1688985525; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=dCvUi18HLqkXrYUJJsP/ESm9CqQeUZJUtTB3ae1GisA=; b=be/lWdaI/OLWjX9vkPPGXj8QiqRpRiARjfgT1O9nqZr05FXuZVsA1TfYPGleE9d5Vb 6PHpcupofHUHrDwwJh+pNvmwuo63SEa8NFDOxMdtyrWhr6dRdZsEl3H/7QTiU8sxirik DqRHAiecHU7f7TpNEZnUS4ffKjDPB83iEdlYO+WwlqA9Q4gu4wzfTM4euCqe5zInsx/V PvtqR5mKadUOn9siWfW2Z5mgKET/Qf7q4zGRync+ASkloJXgQ1x1njRCgLegIKHZWcJG HrX8x6Tfp7QZAhxKmPhXYQ5XFUOshEe8ROW+lynPSIt2uHC+8gdbvoDaMbkR4E0rPXVV L4yQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686393525; x=1688985525; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=dCvUi18HLqkXrYUJJsP/ESm9CqQeUZJUtTB3ae1GisA=; b=hMCze0o0UH5lpDjoBBYoldHSzhqdQ4EbHaWIi4gC9Qy7Yz3/9dRqKJU44N4xxfc1HL 3ytV4IhZsJs0L+N4M+rHCZzs+CWmmHRfmq/Suhh7n9iy4MdCsn+4VvgEu/92w5bzxFQA xsi6XJ53i03mhvyrLg92Y2UfEmX6fXvMGOi701Fz4asTY8z5nTA/a0nDlPszW4Ox/7TL rtmqOkVcP8GgUsUD1MgKpnTKrbMxOdgR0hMOJGNuE9P6JioHoa1ByuawC9XkuNoeBf2E DpRxZi0zwzGP0+aKj/46W00HcLT06ccj7cvbgZDkNWWeWUhHRrCeEu3zfHnr1GeRxRRc KiuQ== X-Gm-Message-State: AC+VfDyHS9JNNtsToB2K+cag6Sq/VtRYjps8ve7iZo43nh4wm6ewd+bM 4AG2f336aZqwZ70HmG1qPdE= X-Google-Smtp-Source: ACHHUZ5WJx4Zl+QaBjgMIzwIydXj65Xz2zngBNop43p0jJdowI/GLQeAgBAdo87okRJF2LAXD785cw== X-Received: by 2002:a2e:9f0d:0:b0:2af:1844:6fdb with SMTP id u13-20020a2e9f0d000000b002af18446fdbmr400711ljk.5.1686393524980; Sat, 10 Jun 2023 03:38:44 -0700 (PDT) Received: from localhost.localdomain ([2a00:1370:8188:4fd4:6f92:f7fc:1ccb:7278]) by smtp.googlemail.com with ESMTPSA id e16-20020a2e8190000000b002b1e74bb1bcsm788825ljg.53.2023.06.10.03.38.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 10 Jun 2023 03:38:44 -0700 (PDT) From: Adam Kandur <4164616d.4b616e647572@gmail.com> To: mail@nicolasgoaziou.fr Subject: [PATCH] gnu: Add emacs-fb2-reader. Date: Sat, 10 Jun 2023 13:38:34 +0300 Message-Id: <20230610103834.2753-1-4164616d.4b616e647572@gmail.com> X-Mailer: git-send-email 2.40.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: 1.1 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: * gnu/packages/emacs-xyz.scm (emacs-fb2-reader): New variable. --- gnu/packages/emacs-xyz.scm | 44 ++++++++++++++++++++++++++++++++++++++ 1 file changed, 44 insertions(+) diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm index b77bd0a..5335b3f 100644 --- a/gnu/packages/emacs-xyz.scm +++ b/gnu/packages/emacs-xyz.scm @@ -2365,6 +2365,50 @@ (define-publ [...] Content analysis details: (1.1 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.6 FROM_STARTS_WITH_NUMS From: starts with several numbers 0.3 FROM_LOCAL_HEX From: localpart has long hexadecimal sequence 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (4164616d.4b616e647572[at]gmail.com) 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.208.173 listed in list.dnswl.org] -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.208.173 listed in wl.mailspike.net] -0.0 SPF_PASS SPF: sender matches SPF record 0.2 FREEMAIL_ENVFROM_END_DIGIT Envelope-from freemail username ends in digit (4164616d.4b616e647572[at]gmail.com) X-Debbugs-Envelope-To: 63900 Cc: Adam Kandur <4164616d.4b616e647572@gmail.com>, 63900@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.1 (/) * gnu/packages/emacs-xyz.scm (emacs-fb2-reader): New variable. --- gnu/packages/emacs-xyz.scm | 44 ++++++++++++++++++++++++++++++++++++++ 1 file changed, 44 insertions(+) diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm index b77bd0a..5335b3f 100644 --- a/gnu/packages/emacs-xyz.scm +++ b/gnu/packages/emacs-xyz.scm @@ -2365,6 +2365,50 @@ (define-public emacs-flycheck provides an optional IDE-like error list.") (license license:gpl3+))) ;+GFDLv1.3+ for the manual +(define-public emacs-fb2-reader + (let ((revision "0") + (commit "9836db284749e0cef4c43c2cb5358c82ae9b8589")) ; version bump + (package + (name "emacs-fb2-reader") + (version (git-version "0.1.1" revision commit)) + (source + (origin + (method git-fetch) + (uri (git-reference + (url "https://github.com/jumper047/fb2-reader") + (commit commit))) + (file-name (git-file-name name version)) + (sha256 + (base32 "0vx4b9wnmx1bng8wak5r7yryyvgib4m46l6b877xzkdhsjr3rbsi")))) + (build-system emacs-build-system) + (arguments + (list + #:tests? #t + #:test-command + #~(list "emacs" "-Q" "--batch" "-L" "." + "--eval" "(load-file \"tests/test-fb2-reader.el\")") + #:phases + #~(modify-phases %standard-phases + (add-after 'unpack 'qualify-paths + (lambda* (#:key inputs #:allow-other-keys) + (let ((unzip (search-input-file inputs "/bin/unzip"))) + (substitute* "fb2-reader.el" + (("unzip") unzip)))))))) + (inputs (list unzip)) + (native-inputs + (list emacs-buttercup + emacs-dash + emacs-s + emacs-async)) + (propagated-inputs + (list emacs-visual-fill-column + emacs-f)) + (home-page "https://github.com/jumper047/fb2-reader") + (synopsis "Emacs plugin to read FictionBook2 ebooks") + (description "FB2 Reader provides a major mode for reading FictionBook2 (@file{.fb2} +and @file{.fb2.zip} files) ebooks.") + (license license:gpl3+)))) + (define-public emacs-flymake-collection (package (name "emacs-flymake-collection") -- 2.40.1 From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 10 14:46:57 2023 Received: (at 63900-done) by debbugs.gnu.org; 10 Jun 2023 18:46:57 +0000 Received: from localhost ([127.0.0.1]:36297 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q83c0-0004YV-QB for submit@debbugs.gnu.org; Sat, 10 Jun 2023 14:46:57 -0400 Received: from relay5-d.mail.gandi.net ([217.70.183.197]:56557) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q83bz-0004YF-JB for 63900-done@debbugs.gnu.org; Sat, 10 Jun 2023 14:46:55 -0400 X-GND-Sasl: mail@nicolasgoaziou.fr X-GND-Sasl: mail@nicolasgoaziou.fr Received: by mail.gandi.net (Postfix) with ESMTPSA id D1A741C0002; Sat, 10 Jun 2023 18:46:49 +0000 (UTC) From: Nicolas Goaziou To: Adam Kandur <4164616d.4b616e647572@gmail.com> Subject: Re: [bug#63900] [PATCH] gnu: Add emacs-fb2-reader. References: <20230604163021.5163-1-4164616d.4b616e647572@gmail.com> <20230610103834.2753-1-4164616d.4b616e647572@gmail.com> Date: Sat, 10 Jun 2023 20:46:45 +0200 In-Reply-To: <20230610103834.2753-1-4164616d.4b616e647572@gmail.com> (Adam Kandur's message of "Sat, 10 Jun 2023 13:38:34 +0300") Message-ID: <87zg57b1ey.fsf@nicolasgoaziou.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 63900-done Cc: 63900-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hello, Adam Kandur <4164616d.4b616e647572@gmail.com> writes: > * gnu/packages/emacs-xyz.scm (emacs-fb2-reader): New variable. Thank you. Applied, with the changes below. > +(define-public emacs-fb2-reader > + (let ((revision "0") > + (commit "9836db284749e0cef4c43c2cb5358c82ae9b8589")) ; version bump > + (package > + (name "emacs-fb2-reader") > + (version (git-version "0.1.1" revision commit)) No need for `git-version' for version bumps. > + (native-inputs > + (list emacs-buttercup > + emacs-dash > + emacs-s > + emacs-async)) > + (propagated-inputs > + (list emacs-visual-fill-column > + emacs-f)) I reordered inputs alphabetically. Regards, -- Nicolas Goaziou From unknown Sat Jun 21 10:38:58 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 09 Jul 2023 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator