Subject: bug#63867: closed (Re: bug#63867: 29.0.91; typescript-ts-mode does not highlight function signature overloads)

From: [email-masked] (GNU bug Tracking System)
Date: Sat, 03 Jun 2023 12:02:02 +0000

Your bug report

#63867: 29.0.91; typescript-ts-mode does not highlight function signature overloads

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
63867: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=63867
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: bug#63867: 29.0.91; typescript-ts-mode does not highlight function signature overloads
From: Dmitry Gutov <[email-masked]>
To: Eli Zaretskii <[email-masked]>, Jimmy Yuen Ho Wong <[email-masked]>, Jostein Kjonigsen <[email-masked]>, Theodor Thornhill <[email-masked]>, Yuan Fu <[email-masked]>
Cc: [email-masked]
Date: Sat, 3 Jun 2023 15:01:28 +0300
List-Id: <debbugs-submit.debbugs.gnu.org>

On 03/06/2023 12:47, Eli Zaretskii wrote:
>> From: Jimmy Yuen Ho Wong<[email-masked]>
>> Date: Sat, 03 Jun 2023 10:37:07 +0100
>>
>>
>> Reproduction:
>>
>> 1. C-x C-f test.ts
>> 2. Insert:
>>
>> ```typescript
>> function fn():void;
>> function fn(arg1?:number, arg2?:string):void {
>> }
>> ```
>>
>> 3. Observe the fn in the overload signature isn't highlighted as a
>> function name
>>
>> Expectation:
>>
>> Function signature overloads should highlight the function names.
> Thanks.
> 
> Guys, could you please look into fixing this?

I've pushed a fix to emacs-29, rev 583ba1db7ee.

Subject: 29.0.91; typescript-ts-mode does not highlight function signature overloads
From: Jimmy Yuen Ho Wong <[email-masked]>
To: [email-masked]
Date: Sat, 03 Jun 2023 10:37:07 +0100
List-Id: <debbugs-submit.debbugs.gnu.org>

Reproduction:

1. C-x C-f test.ts
2. Insert:

```typescript
function fn():void;
function fn(arg1?:number, arg2?:string):void {
}
```

3. Observe the fn in the overload signature isn't highlighted as a
function name

Expectation:

Function signature overloads should highlight the function names.