From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 03 05:37:16 2023 Received: (at submit) by debbugs.gnu.org; 3 Jun 2023 09:37:16 +0000 Received: from localhost ([127.0.0.1]:41563 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q5NhE-0007kV-3U for submit@debbugs.gnu.org; Sat, 03 Jun 2023 05:37:16 -0400 Received: from lists.gnu.org ([209.51.188.17]:36772) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q5NhC-0007kN-0v for submit@debbugs.gnu.org; Sat, 03 Jun 2023 05:37:15 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q5NhB-0005U8-Nw for bug-gnu-emacs@gnu.org; Sat, 03 Jun 2023 05:37:13 -0400 Received: from mail-wr1-x42c.google.com ([2a00:1450:4864:20::42c]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1q5NhA-0000Wb-4J for bug-gnu-emacs@gnu.org; Sat, 03 Jun 2023 05:37:13 -0400 Received: by mail-wr1-x42c.google.com with SMTP id ffacd0b85a97d-30ae61354fbso2784248f8f.3 for ; Sat, 03 Jun 2023 02:37:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1685785030; x=1688377030; h=mime-version:message-id:date:subject:to:from:from:to:cc:subject :date:message-id:reply-to; bh=QZB3PTwO4L9CQzY87SmkCG7XzIPhB9lCtxXyqeUIegE=; b=qH6M3PbMZnZlGwpQr3ULQ1XaFnDQ0o2nZKxuUxPTzisT1XKP6hJdmdBquTo9lWnrF8 8xOKfpbN8l8SBh3LLUM4+ZtlUZi0hyrzOeCoPLz0OVgXTUBKH5RrsAPUAMSns2DHcYbE 85LdZf3bw0XmafzxnFd266VFGKPMth/5AxCy2zlehob7FbK2yMVOEi0nvKHLtizXQHik nu1eK+ZRUXrn9MyXZtx8XT0QfdTPU+iOycBf/NU1z7pNlCFvaneWuKot47bRMEa4LOaL AHOpIB+0J7K7THu1E9jDFsgPewF/We65tZV2K3WkLoHy+3fEqKLc+3I4an3Qe4jJa/p5 ZHWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685785030; x=1688377030; h=mime-version:message-id:date:subject:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=QZB3PTwO4L9CQzY87SmkCG7XzIPhB9lCtxXyqeUIegE=; b=Ks6WCrOa5LKewgbauL3OIpE2lwMmT8145AoRo5eptlzXDnCiUUEx5Txm8o7ejT08TE tr2SWb9F9pOxjFjmZj/isxc0iSoY8WhI4GA0Vo5YjrndrvEnd97LRox7ywqUwJebqMLy apgp+rVYaMwZil+nObyVQEmmnq8/wsgxyKUvajr3xnrf8bagdh8P6so6K2Tfzi4vBRc5 UXkf36wmX+l6ffMFFLzb+yyBIftoFGPBy9lFnTlzdCbIxHQsZMbVEyXi1+zNG0Eogxw2 Jqjjh3kxRMvHAgHiaqaQDgPjxoMymgBjnkMNYgYqdU6tkHBaxyQ8GEb2b9Zy8AFPeop8 E8LA== X-Gm-Message-State: AC+VfDy3RRJnRKl8sWzck9AdI2f1boSx5tXOfg5XXgSwJykjtjN5/eyJ qIqZmhw4pMB5012r3Lnkl4MgJc8afWs= X-Google-Smtp-Source: ACHHUZ45dfR57gI1pQpxj/fSHl46YExpsYIDNpx/AB/wSV8HmEb9rfX5RODcNYAnkuAqHgEYXVBLAQ== X-Received: by 2002:a5d:58e3:0:b0:309:31ac:6663 with SMTP id f3-20020a5d58e3000000b0030931ac6663mr1629362wrd.16.1685785029710; Sat, 03 Jun 2023 02:37:09 -0700 (PDT) Received: from MobileCat.localdomain ([2a01:4b00:89a0:2400:4515:dead:dad2:1c1a]) by smtp.gmail.com with ESMTPSA id h9-20020adfe989000000b00307a86a4bcesm3986276wrm.35.2023.06.03.02.37.08 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Sat, 03 Jun 2023 02:37:08 -0700 (PDT) From: Jimmy Yuen Ho Wong To: bug-gnu-emacs@gnu.org Subject: 29.0.91; typescript-ts-mode does not highlight function signature overloads Date: Sat, 03 Jun 2023 10:37:07 +0100 Message-ID: MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2a00:1450:4864:20::42c; envelope-from=wyuenho@gmail.com; helo=mail-wr1-x42c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) Reproduction: 1. C-x C-f test.ts 2. Insert: ```typescript function fn():void; function fn(arg1?:number, arg2?:string):void { } ``` 3. Observe the fn in the overload signature isn't highlighted as a function name Expectation: Function signature overloads should highlight the function names. From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 03 05:46:43 2023 Received: (at 63867) by debbugs.gnu.org; 3 Jun 2023 09:46:43 +0000 Received: from localhost ([127.0.0.1]:41577 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q5NqN-0007zS-7m for submit@debbugs.gnu.org; Sat, 03 Jun 2023 05:46:43 -0400 Received: from eggs.gnu.org ([209.51.188.92]:56068) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q5NqL-0007zE-Ht for 63867@debbugs.gnu.org; Sat, 03 Jun 2023 05:46:42 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q5NqF-0004jS-Pa; Sat, 03 Jun 2023 05:46:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=bYDBMuRCUAZocxo+6z3haDZFmYto7twYZ/WFrFwY+X8=; b=aaiiuvXX8lVi AVMXlwy/sNAT4MJJ2pQOMkcKu7qVTOvIDuxOU0MHtNbwLvcJDxrBv4HtYWNOJqnd5IVhFFuu5tteJ R4u57x6psgnllhsWo+zYE+3NZ59NZcqtb+TR8axhklcQ9gisB7ITxzCxwMzuZIyc9xH+VdESc2O5o SW7jcMi44vQ6mM3TuEtSMwaMYdhbptIkRx66ZFNPP+VnyUx70d8VF263lTxnEZy5HV+VC14NT9Ggd U5IlEe34CngSTRFf5JZ9i0ciO61uElHjMemlnyyBka9W108DexCuvZRMpAsKH+jpEGVfkSaesqsez 8ZHt/rHwScpDZ3MeTSW53Q==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q5NqF-0007Pj-9m; Sat, 03 Jun 2023 05:46:35 -0400 Date: Sat, 03 Jun 2023 12:47:25 +0300 Message-Id: <83y1l098sy.fsf@gnu.org> From: Eli Zaretskii To: Jimmy Yuen Ho Wong , Jostein Kjonigsen , Theodor Thornhill , Yuan Fu In-Reply-To: (message from Jimmy Yuen Ho Wong on Sat, 03 Jun 2023 10:37:07 +0100) Subject: Re: bug#63867: 29.0.91; typescript-ts-mode does not highlight function signature overloads References: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 63867 Cc: 63867@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Jimmy Yuen Ho Wong > Date: Sat, 03 Jun 2023 10:37:07 +0100 > > > Reproduction: > > 1. C-x C-f test.ts > 2. Insert: > > ```typescript > function fn():void; > function fn(arg1?:number, arg2?:string):void { > } > ``` > > 3. Observe the fn in the overload signature isn't highlighted as a > function name > > Expectation: > > Function signature overloads should highlight the function names. Thanks. Guys, could you please look into fixing this? From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 03 08:01:52 2023 Received: (at 63867-done) by debbugs.gnu.org; 3 Jun 2023 12:01:52 +0000 Received: from localhost ([127.0.0.1]:41736 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q5Pwz-0008P7-Tc for submit@debbugs.gnu.org; Sat, 03 Jun 2023 08:01:52 -0400 Received: from out4-smtp.messagingengine.com ([66.111.4.28]:56609) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q5Pww-0008Oj-Ow for 63867-done@debbugs.gnu.org; Sat, 03 Jun 2023 08:01:40 -0400 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 8E6D05C006E; Sat, 3 Jun 2023 08:01:33 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Sat, 03 Jun 2023 08:01:33 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm3; t= 1685793693; x=1685880093; bh=sJ9s2II1ByRlupkoBUfFUIdDdKjFco2vEWO 1JoQ5U6Y=; b=OPL3aG3RHfuF6D5Gps6O/5Gf8kKAjUzjYXqxHf+ZErC/xYIzUxd ljNk+ptISAX8JuMuS3f44q1LvdCnPmRKWtFj43o1yPgL+B+eJXcsql1USYKGLv9C CSwcyq3k3PsHTHkXKxjw/d7moML9Dl5Mjb6pinIYox9MCABYxU5ydCFZnGpgH/zA zrQ4p8xnSdNQQlfO4X+j055puefLR+/qW+3FZI93QnIb6yLzZKLqhFb8OamehpUv VqyU8GUmMgHJqKFWrUIjpYhLAPKe+o7Btd49GJeWH0D5SFTK3IA/BKScFbrK15P5 +aeC6ICq27M8GuBEMid22rsfvfZnTltJlnw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1685793693; x=1685880093; bh=sJ9s2II1ByRlupkoBUfFUIdDdKjFco2vEWO 1JoQ5U6Y=; b=eRWtneA+PZFtlBrV9VZpza/+OmqWMnsx6yfonwsjZnkmymrsxP4 yeYOm18eKDQOIZ3l9uqCG9U3UJSYb4ScOPiX9wmxUNk8vKHdDjEkHbEQQqMVTT+D Mc6Gk0O4r0JfHy+BxXyriSNfNk1b5tGM0ytkFJQbmNWZZJisUFWPTlxtpOdCYnaw XbwRE5JntpNuYas+QFC8GiQEDmL5v/Y1WN7+93ICFKc5icq/MLetgW8m+hIcohKs MsJHvEjSoA2fruVu7MrOcyAt3nQRx8o1PUVm4/mpRuA0aalqdrT0bsa71EIY/kYf 77CwypD5tMLXR5CBKtXqkGZalmQ9KMe6GpA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrfeelhedggeejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepkfffgggfuffvvehfhfgjtgfgsehtjeertddtfeejnecuhfhrohhmpeffmhhi thhrhicuifhuthhovhcuoegumhhithhrhiesghhuthhovhdruggvvheqnecuggftrfgrth htvghrnhepiefgteevheevveffheeltdeukeeiieekueefgedugfefgefhudelgfefveel vdevnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepug hmihhtrhihsehguhhtohhvrdguvghv X-ME-Proxy: Feedback-ID: i0e71465a:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 3 Jun 2023 08:01:31 -0400 (EDT) Message-ID: <213224c6-5d92-f16c-b542-a827935917b3@gutov.dev> Date: Sat, 3 Jun 2023 15:01:28 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: bug#63867: 29.0.91; typescript-ts-mode does not highlight function signature overloads Content-Language: en-US To: Eli Zaretskii , Jimmy Yuen Ho Wong , Jostein Kjonigsen , Theodor Thornhill , Yuan Fu References: <83y1l098sy.fsf@gnu.org> From: Dmitry Gutov In-Reply-To: <83y1l098sy.fsf@gnu.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -1.8 (-) X-Debbugs-Envelope-To: 63867-done Cc: 63867-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.1 (--) On 03/06/2023 12:47, Eli Zaretskii wrote: >> From: Jimmy Yuen Ho Wong >> Date: Sat, 03 Jun 2023 10:37:07 +0100 >> >> >> Reproduction: >> >> 1. C-x C-f test.ts >> 2. Insert: >> >> ```typescript >> function fn():void; >> function fn(arg1?:number, arg2?:string):void { >> } >> ``` >> >> 3. Observe the fn in the overload signature isn't highlighted as a >> function name >> >> Expectation: >> >> Function signature overloads should highlight the function names. > Thanks. > > Guys, could you please look into fixing this? I've pushed a fix to emacs-29, rev 583ba1db7ee. From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 03 08:19:40 2023 Received: (at 63867-done) by debbugs.gnu.org; 3 Jun 2023 12:19:40 +0000 Received: from localhost ([127.0.0.1]:41759 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q5QEK-0000Q7-Jn for submit@debbugs.gnu.org; Sat, 03 Jun 2023 08:19:40 -0400 Received: from eggs.gnu.org ([209.51.188.92]:36918) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q5QEG-0000Ps-Ay for 63867-done@debbugs.gnu.org; Sat, 03 Jun 2023 08:19:35 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q5QEA-0004d1-8r; Sat, 03 Jun 2023 08:19:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=xCyEGmWQLzbwX7w0UTzjh8GgSn+Ly3DzBuh1izE03qQ=; b=eVbctH5mZqoX onDh9FiMA7BHaNF3SmvA1ljEGbsy+YJzbx3vT89BVCWgWa6+UDUAupC6UHolwt2fRlT2ePKEX84IG 4SVsI/p9D4Bx97xbIZTZq7azVdbmxuYGSwogp8sHNsE8Y7pbZ7QDg9s1Ah75xhhKyqJkvecz1otq4 vQ9Li5hgsMu8zK0lrjEsky6t+olVXISpGLVlDT0KF16/qT0s7KGpTQo3wCoa/AS7shjh8K2kQre4F F9ZckrXdNgispxJLzp0d6oFgnO3T6qtVwPAveQ8kxaDuE/fuSH5ECPnvVrrNkHXf/CFmeJfL9zrHB +1B+AB8OeV91UxEV7170sQ==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q5QE8-00049k-6X; Sat, 03 Jun 2023 08:19:25 -0400 Date: Sat, 03 Jun 2023 15:20:13 +0300 Message-Id: <83pm6c91qa.fsf@gnu.org> From: Eli Zaretskii To: Dmitry Gutov In-Reply-To: <213224c6-5d92-f16c-b542-a827935917b3@gutov.dev> (message from Dmitry Gutov on Sat, 3 Jun 2023 15:01:28 +0300) Subject: Re: bug#63867: 29.0.91; typescript-ts-mode does not highlight function signature overloads References: <83y1l098sy.fsf@gnu.org> <213224c6-5d92-f16c-b542-a827935917b3@gutov.dev> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 63867-done Cc: theo@thornhill.no, casouri@gmail.com, jostein@kjonigsen.net, wyuenho@gmail.com, 63867-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Sat, 3 Jun 2023 15:01:28 +0300 > Cc: 63867-done@debbugs.gnu.org > From: Dmitry Gutov > > On 03/06/2023 12:47, Eli Zaretskii wrote: > >> From: Jimmy Yuen Ho Wong > >> Date: Sat, 03 Jun 2023 10:37:07 +0100 > >> > >> > >> Reproduction: > >> > >> 1. C-x C-f test.ts > >> 2. Insert: > >> > >> ```typescript > >> function fn():void; > >> function fn(arg1?:number, arg2?:string):void { > >> } > >> ``` > >> > >> 3. Observe the fn in the overload signature isn't highlighted as a > >> function name > >> > >> Expectation: > >> > >> Function signature overloads should highlight the function names. > > Thanks. > > > > Guys, could you please look into fixing this? > > I've pushed a fix to emacs-29, rev 583ba1db7ee. Thanks. From unknown Fri Jun 20 07:28:23 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 02 Jul 2023 11:24:08 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator