GNU bug report logs - #63860
[PATCH] Shepherd: Add Bash completion file.

Previous Next

Full log

Message #31 received at 63860-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Oleg Pykhalov <go.wigust <at> gmail.com>
Cc: 63860-done <at> debbugs.gnu.org,
 Liliana Marie Prikler <liliana.prikler <at> gmail.com>
Subject: Re: bug#63860: [PATCH] Shepherd: Add Bash completion file.
Date: Mon, 05 Jun 2023 14:03:32 +0200

[Message part 1 (text/plain, inline)]

Hello,

Oleg Pykhalov <go.wigust <at> gmail.com> skribis:

> * etc/completion/bash/herd: New file.
> * Makefile.am (dist_bashcompletion_DATA): New variable.
> * configure.ac: Add --with-bash-completion-dir.

Excellent!  Applied with the changes below.

Thank you & thanks Liliana for reviewing!

Ludo’.

[Message part 2 (text/x-patch, inline)]

diff --git a/NEWS b/NEWS
index d6c2fc0..b644adb 100644
--- a/NEWS
+++ b/NEWS
@@ -13,6 +13,11 @@ Please send Shepherd bug reports to bug-guix <at> gnu.org.
 
 * Changes in 0.10.2
 
+** New Bash completion
+
+A Bash completion file is now installed, providing tab completion for the
+‘herd’ command.
+
 ** ‘herd’ shows a hint when the service and action are likely swapped
 
 The hint is printed for instance when typing ‘herd foobar start’.
diff --git a/etc/completion/bash/herd b/etc/completion/bash/herd
index f006b86..74e7a24 100644
--- a/etc/completion/bash/herd
+++ b/etc/completion/bash/herd
@@ -44,8 +44,8 @@ _herd_complete_3()
     local command="${COMP_WORDS[2]}"
     case "$command" in
         guix-daemon)
-            complitions="on off"
-            mapfile -t COMPREPLY < <(compgen -W "$complitions" -- "${COMP_WORDS[$COMP_CWORD]}")
+            completions="on off"
+            mapfile -t COMPREPLY < <(compgen -W "$completions" -- "${COMP_WORDS[$COMP_CWORD]}")
             ;;
         *)
             ;;

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.