GNU bug report logs - #63850
cp fails for files > 2 GB if copy offload is unsupported

Previous Next

Full log

View this message in rfc822 format

From: Mike Gilbert <floppym <at> gentoo.org>
To: Paul Eggert <eggert <at> cs.ucla.edu>, sam <at> gentoo.org, P <at> draigbrady.com, 63850 <at> debbugs.gnu.org
Subject: bug#63850: cp fails for files > 2 GB if copy offload is unsupported
Date: Sat, 3 Jun 2023 09:54:55 -0400

On Fri, Jun 02, 2023 at 11:05:24PM -0700, Paul Eggert wrote:
> On 2023-06-02 09:31, Pádraig Brady wrote:
> > I'm not sure it was working correctly before 9.3 either.
> > Before 9.3 we would have switched from copy_file_range() to read()/write()
> 
> Actually, cp shouldn't have been using copy_file_range at all, as the 
> code is supposed to never use copy_file_range unless the Linux kernel 
> version is 5.3 or later. See m4/copy-file-range.m4 and 
> lib/copy-file-range.c.
> 
> Since the bug is being reported against kernel 4.19, someone needs to 
> investigate why the Gentoo build is using the copy_file_range syscall on 
> that kernel. Either the Gentoo build isn't properly compiling the 
> replacement function in coreutils/lib/copy-file-range.c, or the 
> replacement function is incorrectly deciding that the kernel is new 
> enough, or something like that.
> 
> We shouldn't need to fiddle with src/copy.c on this.

The macro in copy-file-range.m4 performs a build time version check
against the installed linux headers (/usr/include/linux).

In this case, headers from linux-6.1 are being used at build time.
However, the code is being run on a linux-4.19 kernel.

Generally speaking, syscall checks must be done at run time on Linux,
not build time.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.