GNU bug report logs - #63844
30.0.50; [PATCH] Revert Python mode multiline font-lock

Previous Next

Full log

View this message in rfc822 format

From: Eli Zaretskii <eliz <at> gnu.org>
To: kobarity <kobarity <at> gmail.com>
Cc: 63844 <at> debbugs.gnu.org
Subject: bug#63844: 30.0.50; [PATCH] Revert Python mode multiline font-lock
Date: Sat, 03 Jun 2023 10:12:42 +0300

> Date: Fri, 02 Jun 2023 23:22:34 +0900
> From: kobarity <kobarity <at> gmail.com>
> Cc: Eli Zaretskii <eliz <at> gnu.org>
> 
> I'm sorry, but I would like to revert my following fix:
> 
> "Enhance Python font-lock to support multilines"
> commit 4915ca5dd4245a909c046e6691e8d4a1919890c8
> 
> I have found that there are performance issues when editing a large
> file.  The issue can be reproduced as follows:
> 
> 1. emacs -Q
> 2. Open large Python file (e.g. turtle.py in Python)
> 3. Near the top of the buffer, enter open paren and some characters.
> 
> The above commit extends the region to be font-locked using
> `python-nav-end-of-statement'.  However, if there are unbalanced
> parens, it may move point to the end of the buffer.  This causes
> almost the entire buffer to be font-locked, which is not acceptable
> for large files.
> 
> Attached is a patch to revert the commit in emacs-29 branch.

Thanks, installed on the emacs-29 branch.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.