GNU bug report logs - #63839
[PATCH] gnu: riscv-pk: don't target riscv64-linux-gnu when current system is riscv64.

Previous Next

Full log

Message #8 received at 63839 <at> debbugs.gnu.org (full text, mbox):

From: Josselin Poiret <dev <at> jpoiret.xyz>
To: Z572 <873216071 <at> qq.com>, 63839 <at> debbugs.gnu.org
Subject: Re: [bug#63839] [PATCH] gnu: riscv-pk: don't target
 riscv64-linux-gnu when current system is riscv64.
Date: Tue, 06 Jun 2023 17:48:40 +0200

[Message part 1 (text/plain, inline)]

Hi,

Z572 via Guix-patches via <guix-patches <at> gnu.org> writes:


> +      ;; riscv-pk can only be built for riscv64.
> +      (if (string-prefix? "riscv64" (%current-system))
> +          '()
> +          (list
> +           #:target "riscv64-linux-gnu"))

I don't think that's a good idea, in general, consumers of the package
should be the ones specifying for which arch this package builds.  For
that purpose, there's the supported-systems field of the package record
type.  It's not good in general to hardcode targets in package
definitions.

Best,
-- 
Josselin Poiret

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.