GNU bug report logs - #63839
[PATCH] gnu: riscv-pk: don't target riscv64-linux-gnu when current system is riscv64.

Previous Next

Full log

View this message in rfc822 format

From: Z572 <873216071 <at> qq.com>
To: Josselin Poiret <dev <at> jpoiret.xyz>
Cc: 63839 <at> debbugs.gnu.org
Subject: [bug#63839] [PATCH] gnu: riscv-pk: don't target riscv64-linux-gnu when current system is riscv64.
Date: Sun, 11 Jun 2023 22:48:20 +0800

Josselin Poiret via Guix-patches via <guix-patches <at> gnu.org> writes:

> [[PGP Signed Part:Undecided]]
> Hi,
>
> Z572 via Guix-patches via <guix-patches <at> gnu.org> writes:
>
>
>> +      ;; riscv-pk can only be built for riscv64.
>> +      (if (string-prefix? "riscv64" (%current-system))
>> +          '()
>> +          (list
>> +           #:target "riscv64-linux-gnu"))
>
> I don't think that's a good idea, in general, consumers of the package
> should be the ones specifying for which arch this package builds.  For
> that purpose, there's the supported-systems field of the package record
> type.  It's not good in general to hardcode targets in package
> definitions.
look it's name.

because it doesn't make sense to target other targets, like `u-boot-sifive-unmatched' or `opensbi-generic'.

>
> Best,


-- 
over

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.