GNU bug report logs - #63829
29.0.90; project-find-file's future history breaks with common-parent-directory

Previous Next

Full log

View this message in rfc822 format

From: Dmitry Gutov <dmitry <at> gutov.dev>
To: Juri Linkov <juri <at> linkov.net>, Spencer Baugh <sbaugh <at> janestreet.com>
Cc: sbaugh <at> catern.com, 63829 <at> debbugs.gnu.org
Subject: bug#63829: 29.0.90; project-find-file's future history breaks with common-parent-directory
Date: Mon, 21 Aug 2023 04:15:56 +0300

On 20/08/2023 20:16, Juri Linkov wrote:
>> +  (if-let (filename-proj (and project-current-directory-override
>> +                            (project-current nil default-directory)))
>> +      ;; file-name-concat requires Emacs 28+
>> +      (concat (file-name-as-directory (project-root project))
>> +              (file-relative-name filename (project-root filename-proj)))
>> +    filename))
> 
> I wonder why you prepend (file-name-as-directory (project-root project))?
> This is unnecessary because the project root is already displayed
> in the prompt, so only a relative file name is sufficient in the minibuffer:
> 
>    Find file in /project/root/: relative/file.name

The absolute name is required down in the callee because that 
distinguishes it from a file name fragment picked up by things-at-point.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.