GNU bug report logs - #63829
29.0.90; project-find-file's future history breaks with common-parent-directory

Previous Next

Full log

Message #77 received at 63829 <at> debbugs.gnu.org (full text, mbox):

From: Juri Linkov <juri <at> linkov.net>
To: Spencer Baugh <sbaugh <at> janestreet.com>
Cc: Dmitry Gutov <dmitry <at> gutov.dev>, 63829 <at> debbugs.gnu.org, sbaugh <at> catern.com
Subject: Re: bug#63829: 29.0.90; project-find-file's future history breaks
 with common-parent-directory
Date: Sun, 20 Aug 2023 20:16:23 +0300

> +  (if-let (filename-proj (and project-current-directory-override
> +                            (project-current nil default-directory)))
> +      ;; file-name-concat requires Emacs 28+
> +      (concat (file-name-as-directory (project-root project))
> +              (file-relative-name filename (project-root filename-proj)))
> +    filename))

I wonder why you prepend (file-name-as-directory (project-root project))?
This is unnecessary because the project root is already displayed
in the prompt, so only a relative file name is sufficient in the minibuffer:

  Find file in /project/root/: relative/file.name

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.