GNU bug report logs - #63825
29.0.90; The header line should be hidden when empty

Previous Next

Full log

View this message in rfc822 format

From: Eshel Yaron <me <at> eshelyaron.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: sbaugh <at> janestreet.com, 63825 <at> debbugs.gnu.org
Subject: bug#63825: 29.0.90; The header line should be hidden when empty
Date: Fri, 02 Jun 2023 21:53:45 +0300

[Message part 1 (text/plain, inline)]

Eli Zaretskii <eliz <at> gnu.org> writes:

>> The way I read Eli's above message, it boils down to extending the C
>> function `window_wants_mode_line` with a couple of special cases.
>> Something like the following (mildly tested):

> Thanks, this is an elegant solution.  A few minor comments:


Thanks for reviewing, I'm attaching an updated patch below.

Regarding this comment:

>> +/**
>> + * null_header_line_format:
>> + *
>> + * Return 1 when header line format F indicates that the header line
>> + * should not be displayed at all.

> We usually say "Return non-zero", not 1.

I've changed the wording accordingly, note that some other functions
that return `bool` in src/window.c currently say "Return 1",
e.g. `window_wants_header_line`.

> And finally, please accompany the change with a suitable commit log
> message, an entry in NEWS, and a change for the ELisp manual.

Sure, here's the new patch:

[0001-Avoid-header-line-with-some-empty-non-nil-formats.patch (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.