From unknown Sat Aug 16 11:38:01 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#63817 <63817@debbugs.gnu.org> To: bug#63817 <63817@debbugs.gnu.org> Subject: Status: [PATCH] substitute: Delete cached narinfos more than two-month old. Reply-To: bug#63817 <63817@debbugs.gnu.org> Date: Sat, 16 Aug 2025 18:38:01 +0000 retitle 63817 [PATCH] substitute: Delete cached narinfos more than two-mont= h old. reassign 63817 guix-patches submitter 63817 Ludovic Court=C3=A8s severity 63817 normal tag 63817 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Wed May 31 17:22:24 2023 Received: (at submit) by debbugs.gnu.org; 31 May 2023 21:22:24 +0000 Received: from localhost ([127.0.0.1]:36428 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q4TGx-0004vI-UT for submit@debbugs.gnu.org; Wed, 31 May 2023 17:22:24 -0400 Received: from lists.gnu.org ([209.51.188.17]:58126) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q4TGs-0004v6-LM for submit@debbugs.gnu.org; Wed, 31 May 2023 17:22:22 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q4TGs-0000Mr-CG for guix-patches@gnu.org; Wed, 31 May 2023 17:22:18 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q4TGr-0003Gp-SN; Wed, 31 May 2023 17:22:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:Subject:To:From:in-reply-to: references; bh=ZpXyQedbaUf3DpqB29SL3N6KJBA5Nd4oWwakE7qNvHY=; b=HkP0iTmrMQSHbc uQu/2t7GfPYgObk1cj0SsJc5Kg7YXOu869zFd2obSUQWQNhPUlzEHaV0+JfNmS/SkFkzzoEgCGoU5 V8mYBh2vpxmSCilMpxIwXnntfn3fYA6I9XRDCygkZ9V6fnUH0GlyHskOpJ/Jo/EDvL7eHsnjNcc/G JgBMb8KoivfFiP0zYVHihChh0xQrzLS9xDEd4JlIPuamYVMmGa+zE/wEcfrEEy0O0/taxdqfSdl1h Gg7GOhm98+6m1W+wm+ue2emQDmraHVXPoHnn5s9eYUNe7bcp8YdLlU+vdFzGZJxArf85EgxDOizqM GBXKQ2zlYdM5aqj9d7Wg==; Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (helo=gnu.org) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q4TGr-0003IW-FP; Wed, 31 May 2023 17:22:17 -0400 From: =?UTF-8?q?Ludovic=20Court=C3=A8s?= To: guix-patches@gnu.org Subject: [PATCH] substitute: Delete cached narinfos more than two-month old. Date: Wed, 31 May 2023 23:22:01 +0200 Message-Id: X-Mailer: git-send-email 2.40.1 MIME-Version: 1.0 X-Debbugs-Cc: Christopher Baines , Josselin Poiret , Ludovic Courtès , Mathieu Othacehe , Ricardo Wurmus , Simon Tournier , Tobias Geerinckx-Rice Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: submit Cc: =?UTF-8?q?Ludovic=20Court=C3=A8s?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) This allows 'guix substitute' to shrink the cache a bit more, which saves space and improves performance of cache-cleanup phases since fewer entries need to be traversed. * guix/scripts/substitute.scm (cached-narinfo-expiration-time): Define 'max-ttl' and use it as an upper bound. --- guix/scripts/substitute.scm | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) Hi! You might have noticed that /var/guix/substitute/cache tends to grow. On my laptop I have: --8<---------------cut here---------------start------------->8--- $ du -hs /var/guix/substitute/cache/ 152M /var/guix/substitute/cache/ $ du /var/guix/substitute/cache/ |sort -k1 -n [...] 16196 /var/guix/substitute/cache/kzwjeblndsbkjzmjailrt4bnhguil7tqjmewzcyw22hgajbhfy3q 136216 /var/guix/substitute/cache/4refhwxbjmeua2kwg2nmzhv4dg4d3dorpjefq7kiciw2pfhaf26a 155364 /var/guix/substitute/cache/ --8<---------------cut here---------------end--------------->8--- This full of old entries that I’m unlikely to need: --8<---------------cut here---------------start------------->8--- $ ls -lt /var/guix/substitute/cache/4refhwxbjmeua2kwg2nmzhv4dg4d3dorpjefq7kiciw2pfhaf26a |tail -10 -rw------- 1 root root 1187 Nov 30 18:49 xlxgm0lzg25fsz99qql8wp8y4l0ijvy6 -rw------- 1 root root 3182 Nov 30 18:49 yqdklfzzxx2zm2vvx11pm5my2jzlzwmy -rw------- 1 root root 1180 Nov 30 18:49 18pzv1gjw9mi3bzkvb2ms9am37kd960i -rw------- 1 root root 1484 Nov 30 18:49 qqpc6n1q5jz29zzwf1jn8srq3a5ysy86 -rw------- 1 root root 1060 Nov 30 18:27 9r6w8hrw2bpm2sjp03ynl1aifjkcn9wi -rw------- 1 root root 1056 Nov 30 18:27 ghdwy0xa2h9xi5qh2picb19fhhk0fzhp -rw------- 1 root root 2108 Nov 30 18:27 ixp9xd4cbs774yh5qkvywmjk1606s8i8 -rw------- 1 root root 1052 Nov 30 18:27 laawrywlbx1y76sdribiw8aygcvadili -rw------- 1 root root 1092 Nov 30 18:27 m72pfbhqhbhi7gj8kvy66lr99v7hvk7z -rw------- 1 root root 1070 Nov 30 18:27 ym69k8mzmxbw1ar76nzghl38h4g7g8v4 --8<---------------cut here---------------end--------------->8--- That six-month old because that’s the TTL and ci.guix.gnu.org has been advertising for some time now. Long story short: we’d rather trim the cache more aggressively. Thoughts? Ludo’. diff --git a/guix/scripts/substitute.scm b/guix/scripts/substitute.scm index 3626832dda..92935268b3 100755 --- a/guix/scripts/substitute.scm +++ b/guix/scripts/substitute.scm @@ -167,6 +167,12 @@ (define (lookup-narinfo caches path authorized?) (define (cached-narinfo-expiration-time file) "Return the expiration time for FILE, which is a cached narinfo." + (define max-ttl + ;; Higher bound on the TTL used to avoid keeping around cached narinfos + ;; for too long, which makes the cache bigger and more expensive to + ;; traverse. + (* 2 30 24 60 60)) ;2 months + (catch 'system-error (lambda () (call-with-input-file file @@ -174,10 +180,10 @@ (define (cached-narinfo-expiration-time file) (match (read port) (('narinfo ('version 2) ('cache-uri uri) ('date date) ('ttl ttl) ('value #f)) - (+ date ttl)) + (+ date (min ttl max-ttl))) (('narinfo ('version 2) ('cache-uri uri) ('date date) ('ttl ttl) ('value value)) - (+ date ttl)) + (+ date (min ttl max-ttl))) (x 0))))) (lambda args base-commit: 77f52db416a13e195d090cad4e9e7658feb2e86b -- 2.40.1 From debbugs-submit-bounces@debbugs.gnu.org Thu Jun 08 17:50:04 2023 Received: (at 63817-done) by debbugs.gnu.org; 8 Jun 2023 21:50:04 +0000 Received: from localhost ([127.0.0.1]:57825 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q7NW8-0007Fs-IO for submit@debbugs.gnu.org; Thu, 08 Jun 2023 17:50:04 -0400 Received: from eggs.gnu.org ([209.51.188.92]:36142) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q7NW6-0007En-Vj for 63817-done@debbugs.gnu.org; Thu, 08 Jun 2023 17:50:03 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q7NVx-0005jp-Ia; Thu, 08 Jun 2023 17:49:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=s5Xgs5lSumovTvLTjfEvOpoEekFql0KJDWt/+Ro/CkE=; b=km9g9ipReelGSRWg7yik BWecEp5jKwUjax9BEKWism16mxcuH4+NscV5KAB0AMvyDJ4E/j35WcS1zELKqufwa2OwmecEIif2g gwil0W8cLca1riOFOkKDSIP6lS4H/tyxXqfmr5pbB9i14XhNjONRpg+9TCTsrUZQkkCsJEeEDq5dm dmW8LI+IviEBHgl1eNlDkuV0OCmgWNcY69dHo65sopg7RO1cMzFrEDSifcKmomShNlG+eyY2U9RDY vfJsRm2WYCLyYmXQfVracusF1FG3U12VBnPCnUtL8/NkC/hk5DdXuZ01dD462LPsfiJVabcQYj6sQ NSz0w0C++r0TIg==; Received: from 91-160-117-201.subs.proxad.net ([91.160.117.201] helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q7NVv-0007Ou-SR; Thu, 08 Jun 2023 17:49:53 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: 63817-done@debbugs.gnu.org Subject: Re: bug#63817: [PATCH] substitute: Delete cached narinfos more than two-month old. References: Date: Thu, 08 Jun 2023 23:49:50 +0200 In-Reply-To: ("Ludovic =?utf-8?Q?Court=C3=A8s=22's?= message of "Wed, 31 May 2023 23:22:01 +0200") Message-ID: <87h6rhy681.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 63817-done Cc: Josselin Poiret , Tobias Geerinckx-Rice , Simon Tournier , Mathieu Othacehe , Christopher Baines , Ricardo Wurmus X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Ludovic Court=C3=A8s skribis: > This allows 'guix substitute' to shrink the cache a bit more, which > saves space and improves performance of cache-cleanup phases since fewer > entries need to be traversed. > > * guix/scripts/substitute.scm (cached-narinfo-expiration-time): Define > 'max-ttl' and use it as an upper bound. Pushed as 3f5e14182931f123c10513a3e1e2abaebfb52279. Ludo'. From unknown Sat Aug 16 11:38:01 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 07 Jul 2023 11:24:06 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator