From unknown Sat Jun 21 05:04:23 2025 X-Loop: help-debbugs@gnu.org Subject: bug#63810: 29.0.91; typescript-ts-mode grammar missing the "is" keyword Resent-From: Jimmy Yuen Ho Wong Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 31 May 2023 07:31:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 63810 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 63810@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.168551822520669 (code B ref -1); Wed, 31 May 2023 07:31:02 +0000 Received: (at submit) by debbugs.gnu.org; 31 May 2023 07:30:25 +0000 Received: from localhost ([127.0.0.1]:34779 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q4GHp-0005NJ-1o for submit@debbugs.gnu.org; Wed, 31 May 2023 03:30:25 -0400 Received: from lists.gnu.org ([209.51.188.17]:58328) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q4GHl-0005NA-Ri for submit@debbugs.gnu.org; Wed, 31 May 2023 03:30:24 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q4GHk-0000fU-U8 for bug-gnu-emacs@gnu.org; Wed, 31 May 2023 03:30:20 -0400 Received: from mail-wm1-x330.google.com ([2a00:1450:4864:20::330]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1q4GHi-0006ET-VC for bug-gnu-emacs@gnu.org; Wed, 31 May 2023 03:30:20 -0400 Received: by mail-wm1-x330.google.com with SMTP id 5b1f17b1804b1-3f6e72a1464so39753615e9.1 for ; Wed, 31 May 2023 00:30:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1685518216; x=1688110216; h=mime-version:message-id:date:subject:to:from:from:to:cc:subject :date:message-id:reply-to; bh=ctbQlxQE296Wn6YDHud8TQw5zQB4gLLRR34EGK/TFzM=; b=GxCspeC+R+MP7wGGaM6ElyPXqV+xMsRzcEbvYxWQlXDHeENCs+hATZWcjHQbDr/ceF ukLFQLCxatpKjBNUKamR3kZnfK0rKPQy+QpqUgWxmv++sr0YY8VLyOwtJYex7S61Bd6S UWi2f98oS43XnjnC0BT70lOCp0bJWYs1HASP/BAZT84g9i256n7JxU2MSWciOPjdKF4c I+7MgqfcBeNzbtna2c9YdGebeIrfL6UaMN0fdgLlROokYGZbg7xaYqYh1+CHqUjLLXlP yDFQcjoqJCIx6d/RWiWGj3UTMb2uvEsdwQZgCxEZzdJDHnQXbuWT36dViutV5yeuDTA8 hvVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685518216; x=1688110216; h=mime-version:message-id:date:subject:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=ctbQlxQE296Wn6YDHud8TQw5zQB4gLLRR34EGK/TFzM=; b=D/4GlBqkP1RajR1yEdaTUtZihbaV0p8JesFzrXnsMYsZbpqdxSd/zVwPTmbsaMEsMe geSBPAvNgGm94tgqRhe4gui20hPhTTD+NcunoFJvbM8FlsLJcXRofadcw2EO4Jyq15oH GqEd+eAeL+9jP3U8TcJGzDT7axHRAZdwjZXBbGyJDg+ynAP3enMkfNuluL1yRd3H5k5S m3Rp9MnupgZq9H+jObgH4XUZQPidpYLOujg7Ukww1vdNAhY+MikVlYSSKjf14cGIEBvw 7HuodGaMc6bPH/8gpNlkzOgZKciheJhB/Afq9Xv5Y9XUXBKcIQf7w9kRD5eY2pRzOqQ9 vVig== X-Gm-Message-State: AC+VfDxkvlfvvUDh3O4b8brz5wt/syxXA0aGpSA3CqITPh6ifr2eHzX3 uIqriGsg0zZqzSJMtASvS5vJCVh8iWI= X-Google-Smtp-Source: ACHHUZ52SpIfs+fpFRC0IKS6mSVsQ//ytDF4BiGHsWdmc8zqf86gZLMN/PUDOGR6Ib/gpCq6X9HoDA== X-Received: by 2002:a7b:c3c8:0:b0:3f5:ff24:27de with SMTP id t8-20020a7bc3c8000000b003f5ff2427demr3434264wmj.32.1685518216285; Wed, 31 May 2023 00:30:16 -0700 (PDT) Received: from MobileCat.localdomain ([2a01:4b00:89a0:2400:c171:24f8:20e6:fa9f]) by smtp.gmail.com with ESMTPSA id z1-20020a05600c220100b003f508115b25sm19916675wml.4.2023.05.31.00.30.15 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 31 May 2023 00:30:15 -0700 (PDT) From: Jimmy Yuen Ho Wong Date: Wed, 31 May 2023 08:30:14 +0100 Message-ID: MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2a00:1450:4864:20::330; envelope-from=wyuenho@gmail.com; helo=mail-wm1-x330.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) Reproduction: 1. C-x C-f test.ts 2. Insert ```typescript function isFish(pet: Fish | Bird): pet is Fish { return (pet as Fish).swim !== undefined; } ``` 3. Observe the `is` keyword isn't highlighted. Expectation: TypeScript has a concept called type predicates, which introduces a keyword called `is`. [Reference](https://www.typescriptlang.org/docs/handbook/2/narrowing.html#using-type-predicates) From unknown Sat Jun 21 05:04:23 2025 X-Loop: help-debbugs@gnu.org Subject: bug#63810: 29.0.91; typescript-ts-mode grammar missing the "is" keyword Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 31 May 2023 12:22:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63810 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Jimmy Yuen Ho Wong , Theodor Thornhill , Jostein Kjonigsen , Yuan Fu Cc: 63810@debbugs.gnu.org Received: via spool by 63810-submit@debbugs.gnu.org id=B63810.168553567926762 (code B ref 63810); Wed, 31 May 2023 12:22:01 +0000 Received: (at 63810) by debbugs.gnu.org; 31 May 2023 12:21:19 +0000 Received: from localhost ([127.0.0.1]:34989 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q4KpL-0006xa-6l for submit@debbugs.gnu.org; Wed, 31 May 2023 08:21:19 -0400 Received: from eggs.gnu.org ([209.51.188.92]:51536) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q4KpI-0006xK-1R for 63810@debbugs.gnu.org; Wed, 31 May 2023 08:21:18 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q4KpA-0000mu-BB; Wed, 31 May 2023 08:21:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=zXUds8PvUCK9w8FasWHea8lNYdy2l4c0K8Gv5gSCjL0=; b=Uiy3etlz1nDZ kfD15dJtlg4VRxQZdzewE6mPXifoXL4aD7g+2foU2vHVYZPWP9k3KZ0l+4Qe8/5OINSv+onuxCYiH qgjqbdaRrwoeak83QKO/hzDfKtfaiNYSYQKPMnv5Y6Rufcwe7P8Bfl4KvcXZcDvzBgZc3oOS0kVbL Bfp6qZs+pLHwRrCNKlW8Ky2Ktr2ej1VkkRrTuoTNd4Gx6Yh6scfTPKslOdWP9KYEEsCcQPclxO0lk J3hYnzPTKcbNPtxTSthYNGLq3ScAzgf+a5PsoUPDRh+0N2slEg50CKzA5h8AxboHI+gFrbdQlfrNO 4qOXsHkiSvDQpo2vRitIrg==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q4Kp8-00008J-TP; Wed, 31 May 2023 08:21:07 -0400 Date: Wed, 31 May 2023 15:21:50 +0300 Message-Id: <83ilc8g081.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: (message from Jimmy Yuen Ho Wong on Wed, 31 May 2023 08:30:14 +0100) References: X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Jimmy Yuen Ho Wong > Date: Wed, 31 May 2023 08:30:14 +0100 > > 1. C-x C-f test.ts > 2. Insert > ```typescript > function isFish(pet: Fish | Bird): pet is Fish { > return (pet as Fish).swim !== undefined; > } > ``` > 3. Observe the `is` keyword isn't highlighted. > > Expectation: > > TypeScript has a concept called type predicates, which introduces a > keyword called `is`. Thanks. Can you guys please look into this? From unknown Sat Jun 21 05:04:23 2025 X-Loop: help-debbugs@gnu.org Subject: bug#63810: 29.0.91; typescript-ts-mode grammar missing the "is" keyword Resent-From: Theodor Thornhill Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 31 May 2023 13:24:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63810 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii , Jimmy Yuen Ho Wong , Jostein Kjonigsen , Yuan Fu Cc: 63810@debbugs.gnu.org Received: via spool by 63810-submit@debbugs.gnu.org id=B63810.16855394171314 (code B ref 63810); Wed, 31 May 2023 13:24:01 +0000 Received: (at 63810) by debbugs.gnu.org; 31 May 2023 13:23:37 +0000 Received: from localhost ([127.0.0.1]:35117 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q4Lnc-0000L7-U4 for submit@debbugs.gnu.org; Wed, 31 May 2023 09:23:37 -0400 Received: from out-40.mta1.migadu.com ([95.215.58.40]:60745) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q4LnX-0000Kt-HR for 63810@debbugs.gnu.org; Wed, 31 May 2023 09:23:35 -0400 Date: Wed, 31 May 2023 15:20:00 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=thornhill.no; s=key1; t=1685539410; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=FUsVzYDreEob93+gCJUzpOzqmcEpjajxJg8JcbXCjfk=; b=asskQruWxYMbhSZvHVb30vUxZaIf9bAURWHTPnB6MT+YY2+czPJpxC8aOPoJVoCEhogVZp 6tJDrv3kKtpKwAV0AvkWswQ486nLRA0z4AHjLPfdy53PjazpYXFjIMNSg+mq7Mu8RD3Cef UPYt2hGtiMLn+WL3s/y3WhirnFdizISwubAzWL2m4zA11ktLomKWc744iTp2TfiH3Q2Lfu 7M8XiC/XOTYviDjkR+EqdWCYEGJJe8wIFMGA5nneuntjKSeNChQF29asfs/8FwvL3utG5O ocZROaUGpOQE9haszAv0AEZ4IvE0DoW/iQLZCWz6HZnw/3WZWlPvdCtIXRH/xg== X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Theodor Thornhill In-Reply-To: <83ilc8g081.fsf@gnu.org> References: <83ilc8g081.fsf@gnu.org> Message-ID: <6493F258-D06F-40A9-9B9E-777311207CE6@thornhill.no> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Migadu-Flow: FLOW_OUT X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 31 May 2023 14:21:50 CEST, Eli Zaretskii wrote: >> From: Jimmy Yuen Ho Wong >> Date: Wed, 31 May 2023 08:30:14 +0100 >>=20 >> 1=2E C-x C-f test=2Ets >> 2=2E Insert >> ```typescript >> function isFish(pet: Fish | Bird): pet is Fish { >> return (pet as Fish)=2Eswim !=3D=3D undefined; >> } >> ``` >> 3=2E Observe the `is` keyword isn't highlighted=2E >>=20 >> Expectation: >>=20 >> TypeScript has a concept called type predicates, which introduces a >> keyword called `is`=2E > >Thanks=2E > >Can you guys please look into this? Thanks for the ping=2E Will look into it this evening=2E Theo From unknown Sat Jun 21 05:04:23 2025 X-Loop: help-debbugs@gnu.org Subject: bug#63810: 29.0.91; typescript-ts-mode grammar missing the "is" keyword Resent-From: Theodor Thornhill Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 31 May 2023 18:53:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63810 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii , Jimmy Yuen Ho Wong , Jostein Kjonigsen , Yuan Fu Cc: 63810@debbugs.gnu.org Received: via spool by 63810-submit@debbugs.gnu.org id=B63810.16855591264222 (code B ref 63810); Wed, 31 May 2023 18:53:01 +0000 Received: (at 63810) by debbugs.gnu.org; 31 May 2023 18:52:06 +0000 Received: from localhost ([127.0.0.1]:36335 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q4QvW-000162-Hc for submit@debbugs.gnu.org; Wed, 31 May 2023 14:52:06 -0400 Received: from out-43.mta0.migadu.com ([91.218.175.43]:39184) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q4QvS-00015a-0E for 63810@debbugs.gnu.org; Wed, 31 May 2023 14:52:05 -0400 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=thornhill.no; s=key1; t=1685559120; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=YuP0uNAU7kOhP55CTj83g2olgyYxJi116VYZtbgzAYI=; b=gEBzHgvqesBc9DxYg+xPS3w9QXEM07LRRuxL+/S9fbWwrJIOkahL6HAPUcWDzj/Bo0JDKW uyZ+oGqbC3jO1tBa3FnW9wWqwdidAomYgiaxIP3dByQ+SqHydXY9Pi5W6Qm2LAV0ypcvp3 syAPueQdDnMhx6SHaJeB9iWeR72UHsvihAItvYIAExPu/YXTyHHo6kNRhPuib9u6UmwaUT PdaRagxy7qryV0tuLP0gz1P4vjCNEXaAbERd7f3HFYcdHJajnjDEDrXxXEhh4YEyJxoIOY MxQoH35KauALDzBExrPAyxXbDcgat9VtX5tbRqOM4HYEbxemS/mjfywJTkD/+Q== From: Theodor Thornhill In-Reply-To: <6493F258-D06F-40A9-9B9E-777311207CE6@thornhill.no> References: <83ilc8g081.fsf@gnu.org> <6493F258-D06F-40A9-9B9E-777311207CE6@thornhill.no> Date: Wed, 31 May 2023 20:51:59 +0200 Message-ID: <875y88wcz4.fsf@thornhill.no> MIME-Version: 1.0 Content-Type: text/plain X-Migadu-Flow: FLOW_OUT X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Theodor Thornhill writes: > On 31 May 2023 14:21:50 CEST, Eli Zaretskii wrote: >>> From: Jimmy Yuen Ho Wong >>> Date: Wed, 31 May 2023 08:30:14 +0100 >>> >>> 1. C-x C-f test.ts >>> 2. Insert >>> ```typescript >>> function isFish(pet: Fish | Bird): pet is Fish { >>> return (pet as Fish).swim !== undefined; >>> } >>> ``` >>> 3. Observe the `is` keyword isn't highlighted. >>> >>> Expectation: >>> >>> TypeScript has a concept called type predicates, which introduces a >>> keyword called `is`. >> >>Thanks. >> >>Can you guys please look into this? > > Thanks for the ping. Will look into it this evening. > > Theo Now fixed on emacs-29. Thanks again for the ping :) Theo From unknown Sat Jun 21 05:04:23 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Jimmy Yuen Ho Wong Subject: bug#63810: closed (Re: bug#63810: 29.0.91; typescript-ts-mode grammar missing the "is" keyword) Message-ID: References: <83fs7bcs1z.fsf@gnu.org> X-Gnu-PR-Message: they-closed 63810 X-Gnu-PR-Package: emacs Reply-To: 63810@debbugs.gnu.org Date: Thu, 01 Jun 2023 11:59:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1685620742-8255-1" This is a multi-part message in MIME format... ------------=_1685620742-8255-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #63810: 29.0.91; typescript-ts-mode grammar missing the "is" keyword which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 63810@debbugs.gnu.org. --=20 63810: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D63810 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1685620742-8255-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 63810-done) by debbugs.gnu.org; 1 Jun 2023 11:58:11 +0000 Received: from localhost ([127.0.0.1]:37191 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q4gwV-000281-Gr for submit@debbugs.gnu.org; Thu, 01 Jun 2023 07:58:11 -0400 Received: from eggs.gnu.org ([209.51.188.92]:40470) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q4gwT-00027n-4v for 63810-done@debbugs.gnu.org; Thu, 01 Jun 2023 07:58:09 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q4gwN-0001w4-9R; Thu, 01 Jun 2023 07:58:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=6JREOikf/1m4uoax+6tW//wpzTl/HAssltojLMXCVBY=; b=jCfnNtbb2UO4 H3yz8TPilaov4D3ApGrx6P8pX5hdtn0XHrZi5aL6FeUwW+fYq3IMdLwcOE/TPsjzxzcCxWvvGxc7b yGGq5i0XBKrjyn30DrTsp/0eCTaS5J2aq5Qqlnfs4ml2YRl2mfvk72a7mBSThdzZUp6khxyj+SC/u nIIuPdm9N/csJUhNNWI1tsalTRJxt6Eo9UT96xdUG7WURjU3ZpOF8XuNFu4vHVLZ71+CHQASZFXi2 HaFIsGw1eEWO9wauCXi3MaJcL5gaTrO8xbbuI8NCHSqpZR0XPNIq4dlkODlkIs34tWFHSXpS5pMvz bDyy8QVUjTIj/WnTqMetiQ==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q4gwM-0006Ky-Ng; Thu, 01 Jun 2023 07:58:03 -0400 Date: Thu, 01 Jun 2023 14:58:48 +0300 Message-Id: <83fs7bcs1z.fsf@gnu.org> From: Eli Zaretskii To: Theodor Thornhill In-Reply-To: <875y88wcz4.fsf@thornhill.no> (message from Theodor Thornhill on Wed, 31 May 2023 20:51:59 +0200) Subject: Re: bug#63810: 29.0.91; typescript-ts-mode grammar missing the "is" keyword References: <83ilc8g081.fsf@gnu.org> <6493F258-D06F-40A9-9B9E-777311207CE6@thornhill.no> <875y88wcz4.fsf@thornhill.no> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 63810-done Cc: 63810-done@debbugs.gnu.org, casouri@gmail.com, jostein@kjonigsen.net, wyuenho@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Theodor Thornhill > Cc: 63810@debbugs.gnu.org > Date: Wed, 31 May 2023 20:51:59 +0200 > > Now fixed on emacs-29. Thanks, closing. ------------=_1685620742-8255-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 31 May 2023 07:30:25 +0000 Received: from localhost ([127.0.0.1]:34779 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q4GHp-0005NJ-1o for submit@debbugs.gnu.org; Wed, 31 May 2023 03:30:25 -0400 Received: from lists.gnu.org ([209.51.188.17]:58328) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q4GHl-0005NA-Ri for submit@debbugs.gnu.org; Wed, 31 May 2023 03:30:24 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q4GHk-0000fU-U8 for bug-gnu-emacs@gnu.org; Wed, 31 May 2023 03:30:20 -0400 Received: from mail-wm1-x330.google.com ([2a00:1450:4864:20::330]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1q4GHi-0006ET-VC for bug-gnu-emacs@gnu.org; Wed, 31 May 2023 03:30:20 -0400 Received: by mail-wm1-x330.google.com with SMTP id 5b1f17b1804b1-3f6e72a1464so39753615e9.1 for ; Wed, 31 May 2023 00:30:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1685518216; x=1688110216; h=mime-version:message-id:date:subject:to:from:from:to:cc:subject :date:message-id:reply-to; bh=ctbQlxQE296Wn6YDHud8TQw5zQB4gLLRR34EGK/TFzM=; b=GxCspeC+R+MP7wGGaM6ElyPXqV+xMsRzcEbvYxWQlXDHeENCs+hATZWcjHQbDr/ceF ukLFQLCxatpKjBNUKamR3kZnfK0rKPQy+QpqUgWxmv++sr0YY8VLyOwtJYex7S61Bd6S UWi2f98oS43XnjnC0BT70lOCp0bJWYs1HASP/BAZT84g9i256n7JxU2MSWciOPjdKF4c I+7MgqfcBeNzbtna2c9YdGebeIrfL6UaMN0fdgLlROokYGZbg7xaYqYh1+CHqUjLLXlP yDFQcjoqJCIx6d/RWiWGj3UTMb2uvEsdwQZgCxEZzdJDHnQXbuWT36dViutV5yeuDTA8 hvVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685518216; x=1688110216; h=mime-version:message-id:date:subject:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=ctbQlxQE296Wn6YDHud8TQw5zQB4gLLRR34EGK/TFzM=; b=D/4GlBqkP1RajR1yEdaTUtZihbaV0p8JesFzrXnsMYsZbpqdxSd/zVwPTmbsaMEsMe geSBPAvNgGm94tgqRhe4gui20hPhTTD+NcunoFJvbM8FlsLJcXRofadcw2EO4Jyq15oH GqEd+eAeL+9jP3U8TcJGzDT7axHRAZdwjZXBbGyJDg+ynAP3enMkfNuluL1yRd3H5k5S m3Rp9MnupgZq9H+jObgH4XUZQPidpYLOujg7Ukww1vdNAhY+MikVlYSSKjf14cGIEBvw 7HuodGaMc6bPH/8gpNlkzOgZKciheJhB/Afq9Xv5Y9XUXBKcIQf7w9kRD5eY2pRzOqQ9 vVig== X-Gm-Message-State: AC+VfDxkvlfvvUDh3O4b8brz5wt/syxXA0aGpSA3CqITPh6ifr2eHzX3 uIqriGsg0zZqzSJMtASvS5vJCVh8iWI= X-Google-Smtp-Source: ACHHUZ52SpIfs+fpFRC0IKS6mSVsQ//ytDF4BiGHsWdmc8zqf86gZLMN/PUDOGR6Ib/gpCq6X9HoDA== X-Received: by 2002:a7b:c3c8:0:b0:3f5:ff24:27de with SMTP id t8-20020a7bc3c8000000b003f5ff2427demr3434264wmj.32.1685518216285; Wed, 31 May 2023 00:30:16 -0700 (PDT) Received: from MobileCat.localdomain ([2a01:4b00:89a0:2400:c171:24f8:20e6:fa9f]) by smtp.gmail.com with ESMTPSA id z1-20020a05600c220100b003f508115b25sm19916675wml.4.2023.05.31.00.30.15 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 31 May 2023 00:30:15 -0700 (PDT) From: Jimmy Yuen Ho Wong To: bug-gnu-emacs@gnu.org Subject: 29.0.91; typescript-ts-mode grammar missing the "is" keyword Date: Wed, 31 May 2023 08:30:14 +0100 Message-ID: MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2a00:1450:4864:20::330; envelope-from=wyuenho@gmail.com; helo=mail-wm1-x330.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) Reproduction: 1. C-x C-f test.ts 2. Insert ```typescript function isFish(pet: Fish | Bird): pet is Fish { return (pet as Fish).swim !== undefined; } ``` 3. Observe the `is` keyword isn't highlighted. Expectation: TypeScript has a concept called type predicates, which introduces a keyword called `is`. [Reference](https://www.typescriptlang.org/docs/handbook/2/narrowing.html#using-type-predicates) ------------=_1685620742-8255-1--