From unknown Sat Aug 16 15:57:02 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#63807 <63807@debbugs.gnu.org> To: bug#63807 <63807@debbugs.gnu.org> Subject: Status: bug in compose-gstring-for-terminal? Reply-To: bug#63807 <63807@debbugs.gnu.org> Date: Sat, 16 Aug 2025 22:57:02 +0000 retitle 63807 bug in compose-gstring-for-terminal? reassign 63807 emacs submitter 63807 Mattias Engdeg=C3=A5rd severity 63807 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Tue May 30 16:36:26 2023 Received: (at submit) by debbugs.gnu.org; 30 May 2023 20:36:26 +0000 Received: from localhost ([127.0.0.1]:34315 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q464w-0001zt-Dy for submit@debbugs.gnu.org; Tue, 30 May 2023 16:36:26 -0400 Received: from lists.gnu.org ([209.51.188.17]:51506) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q464s-0001zh-Ny for submit@debbugs.gnu.org; Tue, 30 May 2023 16:36:25 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q464s-00078h-HP for bug-gnu-emacs@gnu.org; Tue, 30 May 2023 16:36:22 -0400 Received: from mail-lf1-x130.google.com ([2a00:1450:4864:20::130]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1q464r-0004gN-2Y for bug-gnu-emacs@gnu.org; Tue, 30 May 2023 16:36:22 -0400 Received: by mail-lf1-x130.google.com with SMTP id 2adb3069b0e04-4f4f3ac389eso4268504e87.1 for ; Tue, 30 May 2023 13:36:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1685478979; x=1688070979; h=to:date:message-id:subject:mime-version:content-transfer-encoding :from:sender:from:to:cc:subject:date:message-id:reply-to; bh=LyAfgU+dE9rAZEdwmwpHirxCf+vO3xHeyo/7u59epRE=; b=qtB3WuYCtQQeeA+LWrIPrg1ns++pNafidVlfq50bbmUi+YS9i4nZ5zN95s1iTreEZa 4OOzNNL8m0wppE9AnV3qX19ulJSKeTHiaq6OD2taImjD8jSOKw0J9wbpmcixiKNmU2qZ eZqWyT3VAjJPQVxDoLQAzYsTQVrfV95/9fh2dVhEu+UHDDTT2jZhJMn7Abp8p484TdAZ 2pSwwxCy9vBbsBwnXRSsl/5uqyJG3RKMHVc28b4ffgPZsvEd95HdsfcEqwOFIhGQrC6h L9GTIwaslXJOsjcuLEd5KBtYlgh4Ie8I0AzNYRH0j+YdOQnQwnTnq7qwoMG/HaN8roio YbIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685478979; x=1688070979; h=to:date:message-id:subject:mime-version:content-transfer-encoding :from:sender:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=LyAfgU+dE9rAZEdwmwpHirxCf+vO3xHeyo/7u59epRE=; b=TieF59tVlE/iNvN22+vz02hSOfpSOui+NXNjKZA56nvGJCqvKlZP92v5jGMcmq1gQ+ B88N1RbyGKchbWSu9pi2DgFtXAY9NuoCVBIAz2XkO4HtuSD4PZXjeSJPrEbRvtlZ9T/r Zjr51gFS+iWcfqUFlwe4JLJIT8gPlrWexToLFHyEtPc6SCnMuXCa2BBRCD+cCzww4sff ZUhbSg1aOx+IsDHyTVz0UZk/o4lYKHD8gc5/B4mlVJqo2J9DVttnj8sGPBlWZmDTaJWg ZNM9jZ7CGqDrmwh7+iUPdZmT94A0bD/jwuhy4rZKrNWBRqiXTcV7AUZSTuMwlzi9xOTH HxQg== X-Gm-Message-State: AC+VfDyH/ArwUNHzi8nTRcZmn95ikTHrjmmfuSCwgrKFahmgiWwpMi1r 2GGXADGpk2FJkckUMkAmyVZVEiTOWDw= X-Google-Smtp-Source: ACHHUZ6fncUAtHOLd4rMhb3+kZZIBhcMCr4nP2xswBtRgtX3rE7W+jgMkYu03OrqOh+krT+NYKaBwQ== X-Received: by 2002:ac2:5335:0:b0:4f4:c909:cddf with SMTP id f21-20020ac25335000000b004f4c909cddfmr1288604lfh.44.1685478979148; Tue, 30 May 2023 13:36:19 -0700 (PDT) Received: from smtpclient.apple (c188-150-165-235.bredband.tele2.se. [188.150.165.235]) by smtp.gmail.com with ESMTPSA id x17-20020a19f611000000b004f27cecb68asm443122lfe.166.2023.05.30.13.36.18 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 30 May 2023 13:36:18 -0700 (PDT) From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.15\)) Subject: bug in compose-gstring-for-terminal? Message-Id: Date: Tue, 30 May 2023 22:36:18 +0200 To: Emacs Bug Report X-Mailer: Apple Mail (2.3654.120.0.1.15) Received-SPF: pass client-ip=2a00:1450:4864:20::130; envelope-from=mattias.engdegard@gmail.com; helo=mail-lf1-x130.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) There is what appears to be a little code accident in = compose-gstring-for-terminal, at composite.el:821: (setq i (+ 2))) but someone who knows the character composition code better should have = a look. The remedy seems obvious, though. From debbugs-submit-bounces@debbugs.gnu.org Wed May 31 09:01:56 2023 Received: (at 63807) by debbugs.gnu.org; 31 May 2023 13:01:56 +0000 Received: from localhost ([127.0.0.1]:35062 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q4LSe-0008BC-FD for submit@debbugs.gnu.org; Wed, 31 May 2023 09:01:56 -0400 Received: from eggs.gnu.org ([209.51.188.92]:35282) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q4LSc-0008Am-HV for 63807@debbugs.gnu.org; Wed, 31 May 2023 09:01:55 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q4LSX-0008QG-Au; Wed, 31 May 2023 09:01:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=1iaVWXzYoIS78EjGjUQxEEY2aPVG+GVpZTAQs/ucTkg=; b=YWaOavLrFZa+zUFSrhXY 4DtM+4XWUG2i1a04G/bkIQo9btGwfCQEo8V62Le4t8DwNSeVB5LshYnkjFN7D+TaNTYqqWk/zfWYy sbMUekzkSnn9BqYGMpBDup1UWVWhIdPJPqa0A7UCgiV5ucsNrRDvsrODSKH6N+SKL+yOyjaiwraMH LW4MCFHgdaLgU0VR1d706TIOEFUCV2CI5mdZ5ML50PE/lkVaJnq2XMgpXgsZezLVy4HCekw+0gPxO 2jjkaup2ghmVTZzqjeT9QOgwS6AcLbVDWiWtyZyJUJi4G2/IkmQ6W1fdYcpCAf6v86sc+LAq3j6jO TiWpFnwCKeqsoA==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q4LSW-00059g-QN; Wed, 31 May 2023 09:01:49 -0400 Date: Wed, 31 May 2023 16:02:31 +0300 Message-Id: <83a5xkfyc8.fsf@gnu.org> From: Eli Zaretskii To: Mattias =?utf-8?Q?Engdeg=C3=A5rd?= In-Reply-To: (message from Mattias =?utf-8?Q?Engdeg=C3=A5rd?= on Tue, 30 May 2023 22:36:18 +0200) Subject: Re: bug#63807: bug in compose-gstring-for-terminal? References: MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 63807 Cc: 63807@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Mattias Engdegård > Date: Tue, 30 May 2023 22:36:18 +0200 > > There is what appears to be a little code accident in compose-gstring-for-terminal, at composite.el:821: > > (setq i (+ 2))) > > but someone who knows the character composition code better should have a look. The remedy seems obvious, though. Why do you think it could be a bug? Setting i to 2 is correct there, AFAICT. If you want to remove the redundant '+', be my guest, but I very much hope the new warnings on master will not suddenly start warn about such code: it's completely legit. From debbugs-submit-bounces@debbugs.gnu.org Wed May 31 09:49:35 2023 Received: (at 63807) by debbugs.gnu.org; 31 May 2023 13:49:35 +0000 Received: from localhost ([127.0.0.1]:35162 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q4MCl-00012h-FQ for submit@debbugs.gnu.org; Wed, 31 May 2023 09:49:35 -0400 Received: from mail-lf1-f46.google.com ([209.85.167.46]:45561) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q4MCh-00012R-Cp for 63807@debbugs.gnu.org; Wed, 31 May 2023 09:49:33 -0400 Received: by mail-lf1-f46.google.com with SMTP id 2adb3069b0e04-4f3b39cea1eso6628788e87.3 for <63807@debbugs.gnu.org>; Wed, 31 May 2023 06:49:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1685540965; x=1688132965; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:from:to:cc:subject :date:message-id:reply-to; bh=pzCTj2UriqRyFKI7XV6ZP5Esy6Jvv9gzd1CfvdBveG8=; b=Fy29AiX13z3uwcY+NO/f39QRkqn2SZ7nGr9i8xSAEg/spJaSxHi2SPpYP/RfsWNfpq gyexiAfoZJuO66ACLb2s3rs6q3KuuHzRUMkA1vV6lclj1XfwmhC++RTButIIjtJNJvK3 k9MZzqvGkPw3L+MdvZQsqPg5fLVPvZmeFno0VMJXd3sLWQx3hk+x68lo4WNoqPkG0Q2o 2qY4gKz47s2kgP3Xcny0lRpCnFHYmkLJBEkGLZWs8/36P3cNtaY0OaN7iha1kjs61xza jArwuKYlo53MoHoXJhI3pGcc5PG72+rpdeaIkFmglvoFar9KBmOF6blj9wYSikf/yVM6 5gzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685540965; x=1688132965; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=pzCTj2UriqRyFKI7XV6ZP5Esy6Jvv9gzd1CfvdBveG8=; b=IS7YckyZ0hHPX7cazZeJWHUwM3406kmq9t9dD7OLCCNmxRClHXjqfh0wYkrPiJu4HN +W2vTHuCoiiE8B8eQ5+D575hrDm/N53leaZNKmJOUDR1syQzCb4EIbkt4GD0Wh6QZxZc QB2yVx8yHyfRAz3xhHgYso1YLfNj7HcZrBml9AQ/DlVoHlyuklZE5cnW7BgVqOTMTYgl 9dXQYItWpBD0YbfXlZwX5b0TkbioBokwuh6RXkOg2bnQyyFtw4R/1nbFtG3wteAx4mc5 gBdUb51svawscuVpMmWHHBAC5TZqXAX/Z32sGMTQlP7ONzhYttFd4CQv8844M5lF+KfR Vg8A== X-Gm-Message-State: AC+VfDx6b0gFwmmo/gyFyIi18uHFHoIOw4RMoQDOHVRk2Ku5Q1d5He+s eduXKQVjW9oOR0Rdn1vw/ck= X-Google-Smtp-Source: ACHHUZ5ReYm0IuAGrjsyUnsMEnDwnbfMCCyfSNNBsRBRcRzAhid89bSEt+juZr1X+D5fvvMYB/I4Vw== X-Received: by 2002:a05:6512:3763:b0:4e8:43e2:a8 with SMTP id z3-20020a056512376300b004e843e200a8mr3029413lft.8.1685540965037; Wed, 31 May 2023 06:49:25 -0700 (PDT) Received: from smtpclient.apple (c188-150-165-235.bredband.tele2.se. [188.150.165.235]) by smtp.gmail.com with ESMTPSA id m8-20020ac24ac8000000b004f11eb32f20sm734366lfp.13.2023.05.31.06.49.24 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 31 May 2023 06:49:24 -0700 (PDT) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.15\)) Subject: Re: bug#63807: bug in compose-gstring-for-terminal? From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= In-Reply-To: <83a5xkfyc8.fsf@gnu.org> Date: Wed, 31 May 2023 15:49:23 +0200 Content-Transfer-Encoding: quoted-printable Message-Id: <559C2D0F-D71E-433B-AE1A-888EBBD134CD@gmail.com> References: <83a5xkfyc8.fsf@gnu.org> To: Eli Zaretskii X-Mailer: Apple Mail (2.3654.120.0.1.15) X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 63807 Cc: 63807@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) 31 maj 2023 kl. 15.02 skrev Eli Zaretskii : > Setting i to 2 is correct there Would you explain why to someone who doesn't know how this is supposed = to work? There may be external invariants rescuing the mistake from having = serious consequences so that the code is correct in a narrow sense but = relying that is generally poor style. It looks quite obvious that the intent is to increment i by 2; compare = with the other clause, (progn ;; Compose Cf (format) control characters by ;; replacing with a space. (lglyph-set-char glyph 32) (lglyph-set-width glyph 1) (setq i (1+ i))) where a character is replaced with a space and we step to the next. In = the (non-Cf) clause under scrutiny, we insert a space and, presumably, = step past both characters: ;; Compose by prepending a space. (setq gstring (lgstring-insert-glyph gstring i (lglyph-copy glyph)) nglyphs (lgstring-glyph-len gstring)) (setq glyph (lgstring-glyph gstring i)) (lglyph-set-char glyph 32) (lglyph-set-width glyph 1) (setq i (+ 2)) The main question is whether changing the last assignment to (setq i (+ = i 2)) would have unintended consequences. As far as I've been able to = determine, testing and inspection say no, it should be completely safe. From debbugs-submit-bounces@debbugs.gnu.org Wed May 31 10:29:51 2023 Received: (at 63807) by debbugs.gnu.org; 31 May 2023 14:29:51 +0000 Received: from localhost ([127.0.0.1]:36139 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q4Mpi-0002E2-Na for submit@debbugs.gnu.org; Wed, 31 May 2023 10:29:51 -0400 Received: from eggs.gnu.org ([209.51.188.92]:35910) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q4Mpg-0002Dn-UW for 63807@debbugs.gnu.org; Wed, 31 May 2023 10:29:49 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q4Mpb-0003zg-Ej; Wed, 31 May 2023 10:29:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=SeAFvTsOpAy3jKRxj54+hyF2bCL0t0jMephlOif1a2g=; b=phZnr3xcb1LwcsqkR0n/ jMhR9gDAn9eBbDNtpGR2uIMIg+Xj14rf0FHu5OMUbil/XpFS+wHe02H5wTQaDdX78IBySQlMRKF83 6I2qtZX/pe8cTgCRmWmZe45jmtvQiT8qjNH9MC2S1rF9iBS+UFSBlArA1kwWW6hzGjdEeCEnh0QgL t7NBAnjURaLgjQiZC1OS7AOqNyPVe30fWRfuHdGKsnjZOKxcdufYWpC6cxWW7FkhUzszSI8ti/oA8 zIZRqgDzzFeyAA2q98MGpfLiMFhbQsh5pvX4B0KE1wqWXf7ov35du0beh4b1lHcpnoJILZ9h0n3m6 HDLpbvV3KloAWA==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q4MpZ-0000Hq-Dc; Wed, 31 May 2023 10:29:43 -0400 Date: Wed, 31 May 2023 17:30:25 +0300 Message-Id: <83sfbcefpa.fsf@gnu.org> From: Eli Zaretskii To: Mattias =?utf-8?Q?Engdeg=C3=A5rd?= In-Reply-To: <559C2D0F-D71E-433B-AE1A-888EBBD134CD@gmail.com> (message from Mattias =?utf-8?Q?Engdeg=C3=A5rd?= on Wed, 31 May 2023 15:49:23 +0200) Subject: Re: bug#63807: bug in compose-gstring-for-terminal? References: <83a5xkfyc8.fsf@gnu.org> <559C2D0F-D71E-433B-AE1A-888EBBD134CD@gmail.com> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 63807 Cc: 63807@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Mattias Engdegård > Date: Wed, 31 May 2023 15:49:23 +0200 > Cc: 63807@debbugs.gnu.org > > 31 maj 2023 kl. 15.02 skrev Eli Zaretskii : > > > Setting i to 2 is correct there > > Would you explain why to someone who doesn't know how this is supposed to work? We basically concoct a glyph-string "by hand": > ;; Compose by prepending a space. > (setq gstring (lgstring-insert-glyph gstring i > (lglyph-copy glyph)) > nglyphs (lgstring-glyph-len gstring)) > (setq glyph (lgstring-glyph gstring i)) > (lglyph-set-char glyph 32) > (lglyph-set-width glyph 1) > The main question is whether changing the last assignment to (setq i (+ i 2)) would have unintended consequences. As far as I've been able to determine, testing and inspection say no, it should be completely safe. If we agree that replacing (+ 2) with (+ i 2) is "completely safe", then we basically agree that this code runs only when i == zero, right? Or did I misunderstand what you were saying? From debbugs-submit-bounces@debbugs.gnu.org Wed May 31 11:09:11 2023 Received: (at 63807) by debbugs.gnu.org; 31 May 2023 15:09:11 +0000 Received: from localhost ([127.0.0.1]:36186 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q4NRm-0003I2-S3 for submit@debbugs.gnu.org; Wed, 31 May 2023 11:09:11 -0400 Received: from mail-lf1-f47.google.com ([209.85.167.47]:50510) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q4NRi-0003HU-0X for 63807@debbugs.gnu.org; Wed, 31 May 2023 11:09:09 -0400 Received: by mail-lf1-f47.google.com with SMTP id 2adb3069b0e04-4f3baf04f0cso6852515e87.1 for <63807@debbugs.gnu.org>; Wed, 31 May 2023 08:09:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1685545740; x=1688137740; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:from:to:cc:subject :date:message-id:reply-to; bh=56gDhYWq7knTbZ8M8sc90lKIo4IxP57DNPuyDEJVMeE=; b=irLrJCqnOoNA87f4xix9MkGKdjDbKaLWcZ45ITqqkXThdhuHaman1qtyXGofshUycf ++yTQoPtuIi/Km1/536iqWYo0K3OhbfnSePfdgsqF+ZmQFuxndLyAN0RuBpA5v1JtkWx N4ujsXJKc6/m2YXmFB9PGP20QIQVH7N8L/+ensgh7vvgZIi3OLV2fnt+d5H2FrtdX2iZ mg20j62EaiotRuNontPXYGyC2qFhuMsfCbxu6V0qNGQ3qrQ944YO+kJoUq21iL2CBTuL 8tdSJLK6K795kaEUWdzAT32dWCqfqS7/Hts+cwX+zCXzwdEyFCV+8UIRiaAlIuuU9ZfE qkNA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685545740; x=1688137740; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=56gDhYWq7knTbZ8M8sc90lKIo4IxP57DNPuyDEJVMeE=; b=awqPcDFC+dsb3FLU15S53DKKmfLX0e7srCT5doMfApq/RPavcTQjYdmYgYd4dw5Xn7 WQNu/mMkiGNYlKblkKy7ru03zTUsk0ZzO0zwME9QQrIYu0NforXAXp6e+sCR07sha2H0 mw76sAUqpsOL543c6ZTLQ8rXmxzBsWvFkbGG1qA31Zm8Xb+/s/Y/78jYHmB1FIaZuQyB nWHsze8brTxzN3goJ5u9vUhs4HLfPJiEGUabBsiHzbexvCgcSC1njbvFn/NHp+JSx98p a7eqL0y1qXeoo/Lho3wteUBThd/mZ99rWIo1AfrTC4QT8t8Rei5xcTcwsJa4p++H4Rlk jMiw== X-Gm-Message-State: AC+VfDzfQSMWy+zHyNFvngIzelRrxeyP+Tz2Jq5bqMXOpSqTkG9lQ2ZR kyq0biNHu0ZvTX1KoMPKteEngp4LG4c= X-Google-Smtp-Source: ACHHUZ5KkZi+jAXU2lQDdvhdpTM0um8SV0PcdxrNDtnLCYP3pGbsp7/os5hBaCUuV6XjvG2p5T3Qxw== X-Received: by 2002:a2e:9cd8:0:b0:2a8:ac69:bfe with SMTP id g24-20020a2e9cd8000000b002a8ac690bfemr2990039ljj.42.1685545739651; Wed, 31 May 2023 08:08:59 -0700 (PDT) Received: from smtpclient.apple (c188-150-165-235.bredband.tele2.se. [188.150.165.235]) by smtp.gmail.com with ESMTPSA id p5-20020a2e8045000000b002ac8164d77fsm3358545ljg.86.2023.05.31.08.08.58 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 31 May 2023 08:08:59 -0700 (PDT) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.15\)) Subject: Re: bug#63807: bug in compose-gstring-for-terminal? From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= In-Reply-To: <83sfbcefpa.fsf@gnu.org> Date: Wed, 31 May 2023 17:08:58 +0200 Content-Transfer-Encoding: quoted-printable Message-Id: References: <83a5xkfyc8.fsf@gnu.org> <559C2D0F-D71E-433B-AE1A-888EBBD134CD@gmail.com> <83sfbcefpa.fsf@gnu.org> To: Eli Zaretskii X-Mailer: Apple Mail (2.3654.120.0.1.15) X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 63807 Cc: 63807@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) 31 maj 2023 kl. 16.30 skrev Eli Zaretskii : > If we agree that replacing (+ 2) with (+ i 2) is "completely safe", > then we basically agree that this code runs only when i =3D=3D zero, > right? Yes -- that is, if we trust external invariants to enforce that it = indeed only runs when i is 0. Otherwise, the current code is incorrect = and changing it would fix a bug. Either way, changing it should do no = harm and has the possibility of improving correctness. I was unable to provoke that particular code to run for strings longer = than 1 chars but that could just be my own ineptitude, and in any case = it seems unsafe to rely on it. Maybe you could come up with an example? (And to answer your question that I edited out in haste: there are no = plans to warn about unary applications of `+`. This was just something I = stumbled upon while researching something else.) From debbugs-submit-bounces@debbugs.gnu.org Wed May 31 12:15:02 2023 Received: (at 63807) by debbugs.gnu.org; 31 May 2023 16:15:02 +0000 Received: from localhost ([127.0.0.1]:36242 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q4OTW-00051y-04 for submit@debbugs.gnu.org; Wed, 31 May 2023 12:15:02 -0400 Received: from eggs.gnu.org ([209.51.188.92]:43688) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q4OTR-00051A-TD for 63807@debbugs.gnu.org; Wed, 31 May 2023 12:15:01 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q4OTL-0001pj-Pr; Wed, 31 May 2023 12:14:52 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=nGp9NITcZqXVeCqoDUReTItIA1JmtRzjkwsIQJI9IEQ=; b=IIcg4LeJB2bhpIOnH2Gw aJbyW68nAh6vmzdndyD1d05F/hqMyzmyQpZcLSBAKK+InoO6KPt+5fkaS/6RB+YBaZvqoCgu7cK3F 8+96QFCOBheTC6jh7M+sF6AX3KIeW37AhmNWY5FnrUrZCjMIYakSMYJSI6od5hqZ0XL3SCkCdILiy HNMR8YZuCNcRmqN3/6oDaAY50Hyt5kS84og0cR/1BgtzvdwtNOgWrbDMdRUHHsjm9XHahP/uq0Li9 i4xVw/G2ZGYLv62REYpvk8n5w6FwkzvOAanDtr33VVAiMSbBgiV3/uGp61RpkQW9SbvsLLltxqD+A 4zO/seYhycNlxw==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q4OTH-0000nD-SD; Wed, 31 May 2023 12:14:49 -0400 Date: Wed, 31 May 2023 19:15:30 +0300 Message-Id: <83jzwoeau5.fsf@gnu.org> From: Eli Zaretskii To: Mattias =?utf-8?Q?Engdeg=C3=A5rd?= In-Reply-To: (message from Mattias =?utf-8?Q?Engdeg=C3=A5rd?= on Wed, 31 May 2023 17:08:58 +0200) Subject: Re: bug#63807: bug in compose-gstring-for-terminal? References: <83a5xkfyc8.fsf@gnu.org> <559C2D0F-D71E-433B-AE1A-888EBBD134CD@gmail.com> <83sfbcefpa.fsf@gnu.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 63807 Cc: 63807@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Mattias Engdegård > Date: Wed, 31 May 2023 17:08:58 +0200 > Cc: 63807@debbugs.gnu.org > > I was unable to provoke that particular code to run for strings longer than 1 chars but that could just be my own ineptitude, and in any case it seems unsafe to rely on it. Maybe you could come up with an example? I don't think such examples exist, because then we wouldn't need to prepend a space (the character would compose with the preceding one). Anyway, if you feel safer to add to i, fine by me (on master, please). From debbugs-submit-bounces@debbugs.gnu.org Wed May 31 13:24:04 2023 Received: (at 63807-done) by debbugs.gnu.org; 31 May 2023 17:24:04 +0000 Received: from localhost ([127.0.0.1]:36283 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q4PYJ-0006ys-Sm for submit@debbugs.gnu.org; Wed, 31 May 2023 13:24:04 -0400 Received: from mail-lf1-f46.google.com ([209.85.167.46]:51505) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q4PY9-0006yE-RP for 63807-done@debbugs.gnu.org; Wed, 31 May 2023 13:24:02 -0400 Received: by mail-lf1-f46.google.com with SMTP id 2adb3069b0e04-4f3edc05aa5so7088623e87.3 for <63807-done@debbugs.gnu.org>; Wed, 31 May 2023 10:23:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1685553828; x=1688145828; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:from:to:cc:subject :date:message-id:reply-to; bh=1nNcrNB1DpPbIZDFiAaPLHUBxUi87InFcP65b+8PAMc=; b=lHAHG9gFMd+xT4E9qj55a93UEEzu1nlG3XAKRS1dKDdYqCrEgtp8UPvlHcME4gxPL9 sKo26vKUYMp5W2IrQ34q1YGO1O/jxhq9lSFKwmTsVo8BsF6LHY6wnQavP441zU5z7/KG jHbZWCXE3SJqXo1TiGDRNe45ibL3+ncqSyZdRnBVb9O+BOXSMpRpcMbsJN9ovZJfp+m2 ujMg9E/h0qqPr+GG9U27azNazvsjpqtNHHnX8YBbfvhqmvp651Vr1XRJEWS38vCwKFk+ vrWoVypAiVVxWtT3u5j8/qrKRif4y5+chY45LQy+Lhdfz85DoY/kjbs5cQVn8qfkFKOa Z0aw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685553828; x=1688145828; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=1nNcrNB1DpPbIZDFiAaPLHUBxUi87InFcP65b+8PAMc=; b=iVBGrbboLvk1H9ADNldgmZ8WyYURHYZ3Pe15rsbJHEb37d0wZ2dEcnFHsOYDawXyNi tNg+WEspIP3oc/5YRh/T3g6qPlrwAjIN49gBqO6uWfmKU983CesyFj1kfYNjELtKmWpt 1lC5mR0d4IibkmRekd3g0z3I7x/Mr6KiZp0ANejIvjagwNBrDHQJD+pn0IHOOsBcAtXR nGG+FOI+14FXlKKIQC8oz5Kfan95T5fbZd9ASR1PZTjDd5pzYxlrVY8UYZA2GJ0+fX80 2zz06RdLpVsF0PdzZPkgd9dzCkHRXjbFNZLuCnKREUwpo/GFNAc8sw3iIXJ7oQMmBwWY caJQ== X-Gm-Message-State: AC+VfDxfZ+Xx+wkLzDfczHQR567W6XKkf0Oftk4RdJKY1Mih5IxMem5M jFuXtmdLDwmV+CYqxF9Ix6s= X-Google-Smtp-Source: ACHHUZ7Q5zZty2aL0LxD4Tkg1WINGXIBY4r2CtW92rtmGbjdE8DD1/eQzpTinrHmPrPBnYgqrWJKew== X-Received: by 2002:ac2:43ac:0:b0:4e9:74a8:134c with SMTP id t12-20020ac243ac000000b004e974a8134cmr3082726lfl.43.1685553827353; Wed, 31 May 2023 10:23:47 -0700 (PDT) Received: from smtpclient.apple (c188-150-165-235.bredband.tele2.se. [188.150.165.235]) by smtp.gmail.com with ESMTPSA id q13-20020a19a40d000000b004f4d5844b48sm791414lfc.279.2023.05.31.10.23.46 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 31 May 2023 10:23:46 -0700 (PDT) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.15\)) Subject: Re: bug#63807: bug in compose-gstring-for-terminal? From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= In-Reply-To: <83jzwoeau5.fsf@gnu.org> Date: Wed, 31 May 2023 19:23:46 +0200 Content-Transfer-Encoding: quoted-printable Message-Id: <48CD3569-59E9-46E8-9072-A8573D248692@gmail.com> References: <83a5xkfyc8.fsf@gnu.org> <559C2D0F-D71E-433B-AE1A-888EBBD134CD@gmail.com> <83sfbcefpa.fsf@gnu.org> <83jzwoeau5.fsf@gnu.org> To: Eli Zaretskii X-Mailer: Apple Mail (2.3654.120.0.1.15) X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 63807-done Cc: 63807-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) 31 maj 2023 kl. 18.15 skrev Eli Zaretskii : > I don't think such examples exist, because then we wouldn't need to > prepend a space (the character would compose with the preceding one). Yes, that could very well be the case, but it would take more time and = effort to prove it. > Anyway, if you feel safer to add to i, fine by me (on master, please). I'll do that, on master naturally. Thank you. From unknown Sat Aug 16 15:57:02 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 29 Jun 2023 11:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator