From unknown Tue Jun 17 22:28:44 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#63801] [PATCH] gnu: Add yle-dl Resent-From: Saku Laesvuori Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 30 May 2023 09:26:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 63801 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 63801@debbugs.gnu.org Cc: Saku Laesvuori X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.168543871023516 (code B ref -1); Tue, 30 May 2023 09:26:02 +0000 Received: (at submit) by debbugs.gnu.org; 30 May 2023 09:25:10 +0000 Received: from localhost ([127.0.0.1]:60071 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q3vbJ-00067D-Un for submit@debbugs.gnu.org; Tue, 30 May 2023 05:25:10 -0400 Received: from lists.gnu.org ([209.51.188.17]:37742) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q3vbF-000670-AZ for submit@debbugs.gnu.org; Tue, 30 May 2023 05:25:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q3vbD-0001Jh-Uy for guix-patches@gnu.org; Tue, 30 May 2023 05:25:03 -0400 Received: from vmi571514.contaboserver.net ([75.119.130.101] helo=mail.laesvuori.fi) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q3vb7-0004T0-92 for guix-patches@gnu.org; Tue, 30 May 2023 05:25:02 -0400 Received: from X-kone.lan (88-113-24-127.elisa-laajakaista.fi [88.113.24.127]) by mail.laesvuori.fi (Postfix) with ESMTPSA id D421934246F; Tue, 30 May 2023 11:25:04 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=laesvuori.fi; s=mail; t=1685438705; bh=nDD51eQ8WES+vYAcWgjPhmmKd+ecK4NQ85+S3UaIlwY=; h=From:To:Cc:Subject:Date; b=G/9Df3vFb/ySTT19BofmBERgKhb830ds3U51u7nRhZib2m/bQBn4kdurhxT1VF+SP lbsAO0mB7uPR2qnsrIgUZUuYdjS6FElDh96dt2j/mrd/nuY+9SsV296Zy5/E1hYHg3 1JSFMNT5HY0EN4RLmrC2tmE2Lb9Zs9xQ8SZWQtLI= From: Saku Laesvuori Date: Tue, 30 May 2023 12:22:54 +0300 Message-Id: <20230530092254.16603-1-saku@laesvuori.fi> X-Mailer: git-send-email 2.40.1 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=75.119.130.101; envelope-from=saku@laesvuori.fi; helo=mail.laesvuori.fi X-Spam_score_int: -10 X-Spam_score: -1.1 X-Spam_bar: - X-Spam_report: (-1.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FORGED_SPF_HELO=1, SPF_HELO_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01, T_SPF_TEMPERROR=0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) * gnu/packages/video.scm (yle-dl): New variable. * gnu/packages/video.scm: Import (gnu packages python-build). --- gnu/packages/video.scm | 52 ++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 52 insertions(+) diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm index ab19c2dd8c..a41fa59552 100644 --- a/gnu/packages/video.scm +++ b/gnu/packages/video.scm @@ -65,6 +65,7 @@ ;;; Copyright © 2022 Andy Tai ;;; Copyright © 2023 Ott Joon ;;; Copyright © 2023 Dominik Delgado Steuter +;;; Copyright © 2023 Saku Laesvuori ;;; ;;; This file is part of GNU Guix. ;;; @@ -179,6 +180,7 @@ (define-module (gnu packages video) #:use-module (gnu packages protobuf) #:use-module (gnu packages pulseaudio) #:use-module (gnu packages python) + #:use-module (gnu packages python-build) #:use-module (gnu packages python-crypto) #:use-module (gnu packages python-web) #:use-module (gnu packages python-xyz) @@ -2468,6 +2470,56 @@ (define-public orf-dl to download videos from Austria's national television broadcaster.") (license license:gpl2+)))) +(define-public yle-dl + (package + (name "yle-dl") + (version "20221231") + (source (origin + ;; PyPI release doesn't include tests + (method git-fetch) + (uri + (git-reference + (url "https://github.com/aajanki/yle-dl.git") + (commit "c2a4d2f3926056496f520e289334d345889b51c4"))) + (sha256 + (base32 + "08pw6x2rc2mv3yrd7qwf2lx9c87ypn0900dfy9nh42b4hyx2jwc6")))) + (build-system pyproject-build-system) + (propagated-inputs + (list + python-attrs + python-configargparse + python-lxml + python-requests + python-xattr)) + (inputs + (list + ffmpeg-5 + wget)) + (native-inputs + (list + python-flit-core + python-pytest + python-pytest-runner)) + (arguments + (list + #:phases + #~(modify-phases %standard-phases + (add-after 'wrap 'wrap-path + (lambda _ + (wrap-program (string-append #$output "/bin/yle-dl") + `("PATH" = (,(string-append #$ffmpeg "/bin") + ,(string-append #$wget "/bin")))))) + ;; Integration tests require internet access + (add-before 'check 'remove-integration-tests + (lambda _ + (delete-file-recursively "tests/integration")))))) + (home-page "https://aajanki.github.io/yle-dl/") + (synopsis "Download videos from Yle servers") + (description "Yle-dl is a command line program for downloading media files from +the video streaming services of the Finnish national broadcasting company Yle.") + (license license:gpl3+))) + (define-public youtube-dl (package (name "youtube-dl") base-commit: 3807876af4b53babdbc2f1d730e4763ff651f316 -- 2.40.1 From unknown Tue Jun 17 22:28:44 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#63801] [PATCH] gnu: Add yle-dl Resent-From: Nicolas Goaziou Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 01 Jul 2023 11:24:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63801 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 63801@debbugs.gnu.org Cc: Saku Laesvuori , 63801-done@debbugs.gnu.org X-Debbugs-Original-To: Saku Laesvuori via Guix-patches via Received: via spool by submit@debbugs.gnu.org id=B.168821059417087 (code B ref -1); Sat, 01 Jul 2023 11:24:01 +0000 Received: (at submit) by debbugs.gnu.org; 1 Jul 2023 11:23:14 +0000 Received: from localhost ([127.0.0.1]:56806 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qFYh8-0004RX-7t for submit@debbugs.gnu.org; Sat, 01 Jul 2023 07:23:14 -0400 Received: from lists.gnu.org ([209.51.188.17]:41860) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qFYh6-0004RQ-IH for submit@debbugs.gnu.org; Sat, 01 Jul 2023 07:23:12 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qFYh4-0003cl-4x for guix-patches@gnu.org; Sat, 01 Jul 2023 07:23:11 -0400 Received: from relay3-d.mail.gandi.net ([2001:4b98:dc4:8::223]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qFYh2-0006Zq-6d for guix-patches@gnu.org; Sat, 01 Jul 2023 07:23:09 -0400 X-GND-Sasl: mail@nicolasgoaziou.fr X-GND-Sasl: mail@nicolasgoaziou.fr X-GND-Sasl: mail@nicolasgoaziou.fr Received: by mail.gandi.net (Postfix) with ESMTPSA id B136160002; Sat, 1 Jul 2023 11:22:57 +0000 (UTC) From: Nicolas Goaziou References: <20230530092254.16603-1-saku@laesvuori.fi> Date: Sat, 01 Jul 2023 13:22:48 +0200 In-Reply-To: <20230530092254.16603-1-saku@laesvuori.fi> (Saku Laesvuori via Guix-patches via's message of "Tue, 30 May 2023 12:22:54 +0300") Message-ID: <87ttunj2pj.fsf@nicolasgoaziou.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2001:4b98:dc4:8::223; envelope-from=mail@nicolasgoaziou.fr; helo=relay3-d.mail.gandi.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.6 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.6 (--) Hello, Saku Laesvuori via Guix-patches via writes: > * gnu/packages/video.scm (yle-dl): New variable. Applied with the changes below. Thank you. > * gnu/packages/video.scm: Import (gnu packages python-build). This information is not necessary in the commit message. > +(define-public yle-dl > + (package Indentation is off. You may want to run "guix style" command prior to sending a patch (I don't, but I'm opinionated about indentation) > + (name "yle-dl") > + (version "20221231") > + (source (origin > + ;; PyPI release doesn't include tests > + (method git-fetch) > + (uri > + (git-reference > + (url "https://github.com/aajanki/yle-dl.git") We usually remove ".git" suffix from URL. > + (commit "c2a4d2f3926056496f520e289334d345889b51c4"))) We don't use raw hash commits there. The project tags its releases, so it should be: (commit version) > + (add-after 'wrap 'wrap-path > + (lambda _ > + (wrap-program (string-append #$output "/bin/yle-dl") > + `("PATH" = (,(string-append #$ffmpeg "/bin") > + ,(string-append #$wget "/bin")))))) "#$ffmpeg" and "#$wget" would prevent package transformations. You should prefer, e.g., (string-append #$(this-package-input "ffmpeg") "/bin") Regards, -- Nicolas Goaziou From unknown Tue Jun 17 22:28:44 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Saku Laesvuori Subject: bug#63801: closed (Re: [bug#63801] [PATCH] gnu: Add yle-dl) Message-ID: References: <87ttunj2pj.fsf@nicolasgoaziou.fr> <20230530092254.16603-1-saku@laesvuori.fi> X-Gnu-PR-Message: they-closed 63801 X-Gnu-PR-Package: guix-patches X-Gnu-PR-Keywords: patch Reply-To: 63801@debbugs.gnu.org Date: Sat, 01 Jul 2023 11:24:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1688210642-17417-1" This is a multi-part message in MIME format... ------------=_1688210642-17417-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #63801: [PATCH] gnu: Add yle-dl which was filed against the guix-patches package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 63801@debbugs.gnu.org. --=20 63801: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D63801 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1688210642-17417-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 63801-done) by debbugs.gnu.org; 1 Jul 2023 11:23:07 +0000 Received: from localhost ([127.0.0.1]:56803 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qFYh0-0004RD-TK for submit@debbugs.gnu.org; Sat, 01 Jul 2023 07:23:07 -0400 Received: from relay3-d.mail.gandi.net ([217.70.183.195]:41837) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qFYgy-0004QU-1m for 63801-done@debbugs.gnu.org; Sat, 01 Jul 2023 07:23:05 -0400 X-GND-Sasl: mail@nicolasgoaziou.fr X-GND-Sasl: mail@nicolasgoaziou.fr X-GND-Sasl: mail@nicolasgoaziou.fr Received: by mail.gandi.net (Postfix) with ESMTPSA id B136160002; Sat, 1 Jul 2023 11:22:57 +0000 (UTC) From: Nicolas Goaziou To: Saku Laesvuori via Guix-patches via Subject: Re: [bug#63801] [PATCH] gnu: Add yle-dl References: <20230530092254.16603-1-saku@laesvuori.fi> Date: Sat, 01 Jul 2023 13:22:48 +0200 In-Reply-To: <20230530092254.16603-1-saku@laesvuori.fi> (Saku Laesvuori via Guix-patches via's message of "Tue, 30 May 2023 12:22:54 +0300") Message-ID: <87ttunj2pj.fsf@nicolasgoaziou.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 63801-done Cc: Saku Laesvuori , 63801-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hello, Saku Laesvuori via Guix-patches via writes: > * gnu/packages/video.scm (yle-dl): New variable. Applied with the changes below. Thank you. > * gnu/packages/video.scm: Import (gnu packages python-build). This information is not necessary in the commit message. > +(define-public yle-dl > + (package Indentation is off. You may want to run "guix style" command prior to sending a patch (I don't, but I'm opinionated about indentation) > + (name "yle-dl") > + (version "20221231") > + (source (origin > + ;; PyPI release doesn't include tests > + (method git-fetch) > + (uri > + (git-reference > + (url "https://github.com/aajanki/yle-dl.git") We usually remove ".git" suffix from URL. > + (commit "c2a4d2f3926056496f520e289334d345889b51c4"))) We don't use raw hash commits there. The project tags its releases, so it should be: (commit version) > + (add-after 'wrap 'wrap-path > + (lambda _ > + (wrap-program (string-append #$output "/bin/yle-dl") > + `("PATH" = (,(string-append #$ffmpeg "/bin") > + ,(string-append #$wget "/bin")))))) "#$ffmpeg" and "#$wget" would prevent package transformations. You should prefer, e.g., (string-append #$(this-package-input "ffmpeg") "/bin") Regards, -- Nicolas Goaziou ------------=_1688210642-17417-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 30 May 2023 09:25:10 +0000 Received: from localhost ([127.0.0.1]:60071 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q3vbJ-00067D-Un for submit@debbugs.gnu.org; Tue, 30 May 2023 05:25:10 -0400 Received: from lists.gnu.org ([209.51.188.17]:37742) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q3vbF-000670-AZ for submit@debbugs.gnu.org; Tue, 30 May 2023 05:25:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q3vbD-0001Jh-Uy for guix-patches@gnu.org; Tue, 30 May 2023 05:25:03 -0400 Received: from vmi571514.contaboserver.net ([75.119.130.101] helo=mail.laesvuori.fi) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q3vb7-0004T0-92 for guix-patches@gnu.org; Tue, 30 May 2023 05:25:02 -0400 Received: from X-kone.lan (88-113-24-127.elisa-laajakaista.fi [88.113.24.127]) by mail.laesvuori.fi (Postfix) with ESMTPSA id D421934246F; Tue, 30 May 2023 11:25:04 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=laesvuori.fi; s=mail; t=1685438705; bh=nDD51eQ8WES+vYAcWgjPhmmKd+ecK4NQ85+S3UaIlwY=; h=From:To:Cc:Subject:Date; b=G/9Df3vFb/ySTT19BofmBERgKhb830ds3U51u7nRhZib2m/bQBn4kdurhxT1VF+SP lbsAO0mB7uPR2qnsrIgUZUuYdjS6FElDh96dt2j/mrd/nuY+9SsV296Zy5/E1hYHg3 1JSFMNT5HY0EN4RLmrC2tmE2Lb9Zs9xQ8SZWQtLI= From: Saku Laesvuori To: guix-patches@gnu.org Subject: [PATCH] gnu: Add yle-dl Date: Tue, 30 May 2023 12:22:54 +0300 Message-Id: <20230530092254.16603-1-saku@laesvuori.fi> X-Mailer: git-send-email 2.40.1 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=75.119.130.101; envelope-from=saku@laesvuori.fi; helo=mail.laesvuori.fi X-Spam_score_int: -10 X-Spam_score: -1.1 X-Spam_bar: - X-Spam_report: (-1.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FORGED_SPF_HELO=1, SPF_HELO_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01, T_SPF_TEMPERROR=0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit Cc: Saku Laesvuori X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) * gnu/packages/video.scm (yle-dl): New variable. * gnu/packages/video.scm: Import (gnu packages python-build). --- gnu/packages/video.scm | 52 ++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 52 insertions(+) diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm index ab19c2dd8c..a41fa59552 100644 --- a/gnu/packages/video.scm +++ b/gnu/packages/video.scm @@ -65,6 +65,7 @@ ;;; Copyright © 2022 Andy Tai ;;; Copyright © 2023 Ott Joon ;;; Copyright © 2023 Dominik Delgado Steuter +;;; Copyright © 2023 Saku Laesvuori ;;; ;;; This file is part of GNU Guix. ;;; @@ -179,6 +180,7 @@ (define-module (gnu packages video) #:use-module (gnu packages protobuf) #:use-module (gnu packages pulseaudio) #:use-module (gnu packages python) + #:use-module (gnu packages python-build) #:use-module (gnu packages python-crypto) #:use-module (gnu packages python-web) #:use-module (gnu packages python-xyz) @@ -2468,6 +2470,56 @@ (define-public orf-dl to download videos from Austria's national television broadcaster.") (license license:gpl2+)))) +(define-public yle-dl + (package + (name "yle-dl") + (version "20221231") + (source (origin + ;; PyPI release doesn't include tests + (method git-fetch) + (uri + (git-reference + (url "https://github.com/aajanki/yle-dl.git") + (commit "c2a4d2f3926056496f520e289334d345889b51c4"))) + (sha256 + (base32 + "08pw6x2rc2mv3yrd7qwf2lx9c87ypn0900dfy9nh42b4hyx2jwc6")))) + (build-system pyproject-build-system) + (propagated-inputs + (list + python-attrs + python-configargparse + python-lxml + python-requests + python-xattr)) + (inputs + (list + ffmpeg-5 + wget)) + (native-inputs + (list + python-flit-core + python-pytest + python-pytest-runner)) + (arguments + (list + #:phases + #~(modify-phases %standard-phases + (add-after 'wrap 'wrap-path + (lambda _ + (wrap-program (string-append #$output "/bin/yle-dl") + `("PATH" = (,(string-append #$ffmpeg "/bin") + ,(string-append #$wget "/bin")))))) + ;; Integration tests require internet access + (add-before 'check 'remove-integration-tests + (lambda _ + (delete-file-recursively "tests/integration")))))) + (home-page "https://aajanki.github.io/yle-dl/") + (synopsis "Download videos from Yle servers") + (description "Yle-dl is a command line program for downloading media files from +the video streaming services of the Finnish national broadcasting company Yle.") + (license license:gpl3+))) + (define-public youtube-dl (package (name "youtube-dl") base-commit: 3807876af4b53babdbc2f1d730e4763ff651f316 -- 2.40.1 ------------=_1688210642-17417-1--