From markus.triska@gmx.at Fri Aug 1 04:55:37 2008 X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02 (2007-08-08) on rzlab.ucr.edu X-Spam-Level: X-Spam-Status: No, score=-6.6 required=4.0 tests=AWL,BAYES_00,FOURLA,NUMONLY, RCVD_IN_DNSWL_MED autolearn=ham version=3.2.3-bugs.debian.org_2005_01_02 Received: (at submit) by emacsbugs.donarmstrong.com; 1 Aug 2008 11:55:38 +0000 Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m71BtYOL012786 for ; Fri, 1 Aug 2008 04:55:35 -0700 Received: from mx10.gnu.org ([199.232.76.166]:56749) by fencepost.gnu.org with esmtp (Exim 4.67) (envelope-from ) id 1KOtDS-0004C9-5i for emacs-pretest-bug@gnu.org; Fri, 01 Aug 2008 07:54:38 -0400 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1KOtEH-0001Sg-0S for emacs-pretest-bug@gnu.org; Fri, 01 Aug 2008 07:55:33 -0400 Received: from mail.gmx.net ([213.165.64.20]:47102) by monty-python.gnu.org with smtp (Exim 4.60) (envelope-from ) id 1KOtEG-0001SB-9K for emacs-pretest-bug@gnu.org; Fri, 01 Aug 2008 07:55:28 -0400 Received: (qmail invoked by alias); 01 Aug 2008 11:55:26 -0000 Received: from pnsgw1-client097.demo.tuwien.ac.at (EHLO pnsgw1-client097.demo.tuwien.ac.at) [128.131.200.97] by mail.gmx.net (mp068) with SMTP; 01 Aug 2008 13:55:26 +0200 X-Authenticated: #4064391 X-Provags-ID: V01U2FsdGVkX19AzLkT5XdA0I02Xxo6U9s4L18jasODRc5Deumj8k fOQVYuyx/3y57g Received: by mt-computer.local (Postfix, from userid 502) id 587D8A0641F; Fri, 1 Aug 2008 13:55:22 +0200 (CEST) From: Markus Triska To: emacs-pretest-bug@gnu.org Subject: 23.0.60; read-char evaluates to unexpected non-character value Date: Fri, 01 Aug 2008 13:55:22 +0200 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Y-GMX-Trusted: 0 X-FuHaFi: 0.54 X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. When I do: $ emacs -Q --eval "(insert (format \"%s\" (read-char nil nil 0.1))))" The content of *scratch* is: 7340161 whereas it is "nil" in Emacs 22.2. In GNU Emacs 23.0.60.3 (i386-apple-darwin8.11.1, GTK+ Version 2.12.9) of 2008-07-25 on pnsgw3-client030.demo.tuwien.ac.at Windowing system distributor `The XFree86 Project, Inc', version 11.0.40400000 Important settings: value of $LC_ALL: nil value of $LC_COLLATE: nil value of $LC_CTYPE: nil value of $LC_MESSAGES: nil value of $LC_MONETARY: nil value of $LC_NUMERIC: nil value of $LC_TIME: nil value of $LANG: en.UTF-8 value of $XMODIFIERS: nil locale-coding-system: nil default-enable-multibyte-characters: t From gebp-emacs-pretest-bug@m.gmane.org Fri Aug 1 05:50:07 2008 X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02 (2007-08-08) on rzlab.ucr.edu X-Spam-Level: X-Spam-Status: No, score=-7.4 required=4.0 tests=AWL,BAYES_00,FOURLA, HAS_BUG_NUMBER,IMPRONONCABLE_2,MURPHY_DRUGS_REL8,RCVD_IN_DNSWL_MED autolearn=ham version=3.2.3-bugs.debian.org_2005_01_02 Received: (at submit) by emacsbugs.donarmstrong.com; 1 Aug 2008 12:50:08 +0000 Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m71Co2nA026745 for ; Fri, 1 Aug 2008 05:50:04 -0700 Received: from mx10.gnu.org ([199.232.76.166]:35125) by fencepost.gnu.org with esmtp (Exim 4.67) (envelope-from ) id 1KOu4A-0003aX-A6 for emacs-pretest-bug@gnu.org; Fri, 01 Aug 2008 08:49:06 -0400 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1KOu4z-0002y5-9q for emacs-pretest-bug@gnu.org; Fri, 01 Aug 2008 08:50:01 -0400 Received: from main.gmane.org ([80.91.229.2]:34792 helo=ciao.gmane.org) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1KOu4y-0002wi-N5 for emacs-pretest-bug@gnu.org; Fri, 01 Aug 2008 08:49:57 -0400 Received: from list by ciao.gmane.org with local (Exim 4.43) id 1KOu4s-00054Z-Mx for emacs-pretest-bug@gnu.org; Fri, 01 Aug 2008 12:49:50 +0000 Received: from lamacq.ph.ed.ac.uk ([129.215.72.156]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Fri, 01 Aug 2008 12:49:50 +0000 Received: from wence by lamacq.ph.ed.ac.uk with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Fri, 01 Aug 2008 12:49:50 +0000 X-Injected-Via-Gmane: http://gmane.org/ Mail-Followup-To: emacs-pretest-bug@gnu.org To: emacs-pretest-bug@gnu.org From: Lawrence Mitchell Subject: Re: bug#638: 23.0.60; read-char evaluates to unexpected non-character value Date: Fri, 01 Aug 2008 13:49:35 +0100 Organization: funfunfun Lines: 55 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: lamacq.ph.ed.ac.uk Mail-Copies-To: nobody User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) Cancel-Lock: sha1:tUNzlprV4Mj+T0L/gwnBQvpEvLY= Sender: news Cc: bug-gnu-emacs@gnu.org X-detected-kernel: by monty-python.gnu.org: Linux 2.6, seldom 2.4 (older, 4) Markus Triska wrote: > When I do: > $ emacs -Q --eval "(insert (format \"%s\" (read-char nil nil 0.1))))" > The content of *scratch* is: > 7340161 This is due to the following change: 2008-03-05 Kenichi Handa * lread.c (Fread_char): Resolve modifiers. (Fread_char_exclusive): Likewise. It unconditionally resolves modifiers even if read_filtered_event returns nil. The following patch fixes things, I think. 2008-08-01 Lawrence Mitchell * lread.c (Fread_char, Fread_char_exclusive): If no character event is read before timeout is reached, return nil, rather than converting to a number. diff --git a/src/lread.c b/src/lread.c index f36162b..97b22d5 100644 --- a/src/lread.c +++ b/src/lread.c @@ -796,6 +796,8 @@ floating-point value. */) if (! NILP (prompt)) message_with_string ("%s", prompt, 0); val = read_filtered_event (1, 1, 1, ! NILP (inherit_input_method), seconds); + if ( NILP (val) ) + return Qnil; c = XINT (val); return make_number (char_resolve_modifier_mask (c)); } @@ -841,6 +843,8 @@ floating-point value. */) if (! NILP (prompt)) message_with_string ("%s", prompt, 0); val = read_filtered_event (1, 1, 0, ! NILP (inherit_input_method), seconds); + if ( NILP (val) ) + return Qnil; c = XINT (val); return make_number (char_resolve_modifier_mask (c)); } -- 1.5.6.GIT -- Lawrence Mitchell From cyd@stupidchicken.com Thu Aug 14 12:26:41 2008 X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02 (2007-08-08) on rzlab.ucr.edu X-Spam-Level: X-Spam-Status: No, score=-3.4 required=4.0 tests=AWL,BAYES_00, MURPHY_DRUGS_REL8 autolearn=ham version=3.2.3-bugs.debian.org_2005_01_02 Received: (at 638-done) by emacsbugs.donarmstrong.com; 14 Aug 2008 19:26:41 +0000 Received: from cyd (CYD.MIT.EDU [18.115.2.24]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m7EJQcCQ019118 for <638-done@emacsbugs.donarmstrong.com>; Thu, 14 Aug 2008 12:26:39 -0700 Received: by cyd (Postfix, from userid 1000) id AFF9C57E323; Thu, 14 Aug 2008 15:27:19 -0400 (EDT) From: Chong Yidong To: Lawrence Mitchell Cc: 638-done@debbugs.gnu.org Subject: Re: 23.0.60; read-char evaluates to unexpected non-character value Date: Thu, 14 Aug 2008 15:27:19 -0400 Message-ID: <87fxp7s8h4.fsf@stupidchicken.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Lawrence Mitchell wrote: > > When I do: > > > > $ emacs -Q --eval "(insert (format \"%s\" (read-char nil nil 0.1))))" > > > > The content of *scratch* is: > > > > 7340161 > > This is due to the following change: > > 2008-03-05 Kenichi Handa > > * lread.c (Fread_char): Resolve modifiers. > (Fread_char_exclusive): Likewise. > > It unconditionally resolves modifiers even if read_filtered_event > returns nil. The following patch fixes things, I think. I've checked your patch into CVS. Thanks for debugging and fixing this. From unknown Mon Aug 11 18:15:22 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: $requester Subject: Internal Control Message-Id: bug archived. Date: Fri, 12 Sep 2008 14:24:07 +0000 User-Agent: Fakemail v42.6.9 # A New Hope # A log time ago, in a galaxy far, far away # something happened. # # Magically this resulted in the following # action being taken, but this fake control # message doesn't tell you why it happened # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator