GNU bug report logs - #63798
[PATCH] Fix Erlang package substitutions

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#63798: closed ([PATCH] Fix Erlang package substitutions)
Date: Sat, 01 Jul 2023 10:08:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Sat, 01 Jul 2023 12:07:18 +0200
with message-id <875y74kkrt.fsf <at> nicolasgoaziou.fr>
and subject line Re: [bug#63798] [PATCH] Fix Erlang package substitutions
has caused the debbugs.gnu.org bug report #63798,
regarding [PATCH] Fix Erlang package substitutions
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
63798: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=63798
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: wrobell <wrobell <at> riseup.net>
To: guix-patches <at> gnu.org
Cc: wrobell <wrobell <at> riseup.net>
Subject: [PATCH] Fix Erlang package substitutions
Date: Mon, 29 May 2023 23:22:24 +0100

Both `dirname` and `basename` need to be substituted. There is no need
for `sed` substitution in Erlag 25.3.
---
 gnu/packages/erlang.scm | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/erlang.scm b/gnu/packages/erlang.scm
index 7564c2a560..b6e82e0109 100644
--- a/gnu/packages/erlang.scm
+++ b/gnu/packages/erlang.scm
@@ -8,6 +8,7 @@
 ;;; Copyright © 2021 Oskar Köök <oskar <at> maatriks.ee>
 ;;; Copyright © 2021 Cees de Groot <cg <at> evrl.com>
 ;;; Copyright © 2022 jgart <jgart <at> dismail.de>
+;;; Copyright © 2023 wrobell <wrobell <at> riseup.net>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -168,7 +169,8 @@ (define-public erlang
            (lambda* (#:key outputs #:allow-other-keys)
              (let ((out (assoc-ref outputs "out")))
                (substitute* (string-append out "/bin/erl")
-                 (("sed") (which "sed"))))))
+                 (("basename") (which "basename"))
+                 (("dirname") (which "dirname"))))))
          (add-after 'install 'install-doc
            (lambda* (#:key inputs outputs #:allow-other-keys)
              (let* ((out (assoc-ref outputs "out"))

base-commit: 7b400e7f8751e6b0cc6e66d3f7ecfb7f5bd51309
-- 
2.40.1

[Message part 3 (message/rfc822, inline)]

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: wrobell <wrobell <at> riseup.net>
Cc: 63798-done <at> debbugs.gnu.org
Subject: Re: [bug#63798] [PATCH] Fix Erlang package substitutions
Date: Sat, 01 Jul 2023 12:07:18 +0200

Hello,

wrobell <wrobell <at> riseup.net> writes:

> Both `dirname` and `basename` need to be substituted. There is no need
> for `sed` substitution in Erlag 25.3.

Applied, with a proper commit message. Thank you.

Regards,
-- 
Nicolas Goaziou

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.