Subject: bug#63798: closed (Re: [bug#63798] [PATCH] Fix Erlang package substitutions)

From: [email-masked] (GNU bug Tracking System)
Date: Sat, 01 Jul 2023 10:08:02 +0000

Your bug report

#63798: [PATCH] Fix Erlang package substitutions

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
63798: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=63798
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: [bug#63798] [PATCH] Fix Erlang package substitutions
From: Nicolas Goaziou <[email-masked]>
To: wrobell <[email-masked]>
Cc: [email-masked]
Date: Sat, 01 Jul 2023 12:07:18 +0200
List-Id: <debbugs-submit.debbugs.gnu.org>

Hello,

wrobell <[email-masked]> writes:

> Both `dirname` and `basename` need to be substituted. There is no need
> for `sed` substitution in Erlag 25.3.

Applied, with a proper commit message. Thank you.

Regards,
-- 
Nicolas Goaziou

Subject: [PATCH] Fix Erlang package substitutions
From: wrobell <[email-masked]>
To: [email-masked]
Cc: wrobell <[email-masked]>
Date: Mon, 29 May 2023 23:22:24 +0100
List-Id: <debbugs-submit.debbugs.gnu.org>

Both `dirname` and `basename` need to be substituted. There is no need
for `sed` substitution in Erlag 25.3.
---
 gnu/packages/erlang.scm | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/erlang.scm b/gnu/packages/erlang.scm
index 7564c2a560..b6e82e0109 100644
--- a/gnu/packages/erlang.scm
+++ b/gnu/packages/erlang.scm
@@ -8,6 +8,7 @@
 ;;; Copyright © 2021 Oskar Köök <[email-masked]>
 ;;; Copyright © 2021 Cees de Groot <[email-masked]>
 ;;; Copyright © 2022 jgart <[email-masked]>
+;;; Copyright © 2023 wrobell <[email-masked]>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -168,7 +169,8 @@ (define-public erlang
            (lambda* (#:key outputs #:allow-other-keys)
              (let ((out (assoc-ref outputs "out")))
                (substitute* (string-append out "/bin/erl")
-                 (("sed") (which "sed"))))))
+                 (("basename") (which "basename"))
+                 (("dirname") (which "dirname"))))))
          (add-after 'install 'install-doc
            (lambda* (#:key inputs outputs #:allow-other-keys)
              (let* ((out (assoc-ref outputs "out"))

base-commit: 7b400e7f8751e6b0cc6e66d3f7ecfb7f5bd51309
-- 
2.40.1