GNU bug report logs - #63793
[PATCH] gnu: sbsigntools: Update to 0.9.5.

Previous Next

Full log

Message #23 received at 63793-done <at> debbugs.gnu.org (full text, mbox):

From: kiasoc5 <kiasoc5 <at> disroot.org>
To: Josselin Poiret <dev <at> jpoiret.xyz>, 63793-done <at> debbugs.gnu.org
Cc: Felix Lechner <felix.lechner <at> lease-up.com>
Subject: Re: [bug#63793] [PATCH] gnu: sbsigntools: Update to 0.9.5.
Date: Sun, 4 Jun 2023 09:54:52 -0400

Hi Josselin,

On 6/4/23 05:41, Josselin Poiret wrote:

> Thanks for your patch!  Pushed as
> f72f3a909a41dce5dc4512c30d4cd0673bc6560f with the following best
> practices modifications (importantly, note cc-for-target and
> search-input-file for bash).

Thanks for merging!

What is the difference between this

> -                 (lambda _
> -                   (substitute* "lib/ccan.git/tools/create-ccan-tree"
> -                     (("#!/bin/bash")
> -                      (string-append "#!"
> -                                     #$(this-package-native-input "bash")
> -                                     "/bin/bash")))))

and this?

> +            (lambda* (#:key inputs native-inputs #:allow-other-keys)
> +              (substitute* "lib/ccan.git/tools/create-ccan-tree"
> +                (("#!/bin/bash")
> +                 (string-append "#!"
> +                                (search-input-file (or native-inputs inputs)
> +                                                   "/bin/bash"))))))

I meant to search for bash as a native input but I guess they are different.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.