From unknown Wed Aug 20 05:18:06 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#6378 <6378@debbugs.gnu.org> To: bug#6378 <6378@debbugs.gnu.org> Subject: Status: all-completions Segfault Reply-To: bug#6378 <6378@debbugs.gnu.org> Date: Wed, 20 Aug 2025 12:18:06 +0000 retitle 6378 all-completions Segfault reassign 6378 emacs submitter 6378 Nathan Weizenbaum severity 6378 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 08 11:47:04 2010 Received: (at submit) by debbugs.gnu.org; 8 Jun 2010 15:47:04 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OM116-0005KB-1s for submit@debbugs.gnu.org; Tue, 08 Jun 2010 11:47:04 -0400 Received: from mx10.gnu.org ([199.232.76.166]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OM114-0005Jo-KD for submit@debbugs.gnu.org; Tue, 08 Jun 2010 11:47:02 -0400 Received: from lists.gnu.org ([199.232.76.165]:54111) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1OM10z-0001F9-Pi for submit@debbugs.gnu.org; Tue, 08 Jun 2010 11:46:57 -0400 Received: from [140.186.70.92] (port=36437 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OM10u-0004JB-Gu for bug-gnu-emacs@gnu.org; Tue, 08 Jun 2010 11:46:57 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.3 required=5.0 tests=BAYES_00, FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,HTML_MESSAGE,T_DKIM_INVALID, T_TO_NO_BRKTS_FREEMAIL autolearn=no version=3.3.1 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OM10s-0007CK-Al for bug-gnu-emacs@gnu.org; Tue, 08 Jun 2010 11:46:52 -0400 Received: from mail-gy0-f169.google.com ([209.85.160.169]:36387) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OM10s-0007C0-8a for bug-gnu-emacs@gnu.org; Tue, 08 Jun 2010 11:46:50 -0400 Received: by gyg4 with SMTP id 4so3945341gyg.0 for ; Tue, 08 Jun 2010 08:46:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:received:date:message-id :subject:from:to:content-type; bh=AVYWqOfg+t3CSSOIV6gxm9f/VKjv33GOFCf7brrvgvw=; b=Ontr6bcGvIB3d5VuMVV3YM70gqpfPaQnWlboqJAa+QSkZ+0Txpw7k5cuOx6dpKVIKe dalV6CaWI/GPHKXknoRRl5rebMlUKRpZVX+xnDg/aWiWC+cMa6VX3fEadjaTXGzcBOKp CK+eC5Fx0v6UCo4Jl7wYe+WdP32QVoMvjd1nU= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:date:message-id:subject:from:to:content-type; b=n8V2wKCo3OugWCFzDOx44vb1zqyZIPxkKILeYh+xzS0EoslPaAhVs0MA2Ul+IrMDsa Z5iZkWSYXHNttdx/ugafBB78KLDDA7OrAzdDjHwgIjsiuGBrLMCPh1g0MmKv0e9gmCf7 iVwxuNtcEKC+D734SSVEhTRGqGesSuepj3Yw0= MIME-Version: 1.0 Received: by 10.91.152.12 with SMTP id e12mr7979089ago.73.1276012007827; Tue, 08 Jun 2010 08:46:47 -0700 (PDT) Received: by 10.90.25.9 with HTTP; Tue, 8 Jun 2010 08:46:47 -0700 (PDT) Date: Tue, 8 Jun 2010 08:46:47 -0700 Message-ID: Subject: all-completions Segfault From: Nathan Weizenbaum To: bug-gnu-emacs@gnu.org Content-Type: multipart/alternative; boundary=0016e64611ec74a893048886b223 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-Spam-Score: -4.8 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.0 (-----) --0016e64611ec74a893048886b223 Content-Type: text/plain; charset=ISO-8859-1 This segfaults me on GNU Emacs 24.0.50.1 (i686-pc-linux-gnu, GTK+ Version 2.16.1) of 2010-05-09: (all-completions "" []) I think the problem is on line 1593 of src/minibuf.c, but my Emacs-innards-fu isn't good enough to attempt a fix. --0016e64611ec74a893048886b223 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable This segfaults me on GNU Emacs 24.0.50.1 (i686-pc-linux-gnu, GTK+ Version 2= .16.1) of 2010-05-09:

=A0 (all-completions "" [])

I= think the problem is on line 1593 of src/minibuf.c, but my Emacs-innards-f= u isn't good enough to attempt a fix.
--0016e64611ec74a893048886b223-- From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 08 12:40:38 2010 Received: (at submit) by debbugs.gnu.org; 8 Jun 2010 16:40:38 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OM1qw-0005iy-7l for submit@debbugs.gnu.org; Tue, 08 Jun 2010 12:40:38 -0400 Received: from mx10.gnu.org ([199.232.76.166]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OM1qu-0005ip-Eb for submit@debbugs.gnu.org; Tue, 08 Jun 2010 12:40:37 -0400 Received: from lists.gnu.org ([199.232.76.165]:57071) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1OM1qp-0002Ye-Tl for submit@debbugs.gnu.org; Tue, 08 Jun 2010 12:40:31 -0400 Received: from [140.186.70.92] (port=49992 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OM1qo-0000PU-GG for bug-gnu-emacs@gnu.org; Tue, 08 Jun 2010 12:40:31 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM, T_RP_MATCHES_RCVD, T_TO_NO_BRKTS_FREEMAIL autolearn=unavailable version=3.3.1 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OM1qm-00021j-V2 for bug-gnu-emacs@gnu.org; Tue, 08 Jun 2010 12:40:30 -0400 Received: from lo.gmane.org ([80.91.229.12]:41575) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OM1qm-00021U-GE for bug-gnu-emacs@gnu.org; Tue, 08 Jun 2010 12:40:28 -0400 Received: from list by lo.gmane.org with local (Exim 4.69) (envelope-from ) id 1OM1qh-0004Dk-74 for bug-gnu-emacs@gnu.org; Tue, 08 Jun 2010 18:40:23 +0200 Received: from garnet.epcc.ed.ac.uk ([129.215.56.222]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Tue, 08 Jun 2010 18:40:23 +0200 Received: from wence by garnet.epcc.ed.ac.uk with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Tue, 08 Jun 2010 18:40:23 +0200 X-Injected-Via-Gmane: http://gmane.org/ To: bug-gnu-emacs@gnu.org connect(): No such file or directory From: Lawrence Mitchell Subject: Re: bug#6378: all-completions Segfault Date: Tue, 08 Jun 2010 17:37:47 +0100 Lines: 70 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Complaints-To: usenet@dough.gmane.org X-Gmane-NNTP-Posting-Host: garnet.epcc.ed.ac.uk User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (usg-unix-v) Cancel-Lock: sha1:rpaLk5v7RMpvqRC61vsKhOUbOiE= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-Spam-Score: -4.8 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.9 (----) Nathan Weizenbaum wrote: > This segfaults me on GNU Emacs 24.0.50.1 (i686-pc-linux-gnu, GTK+ Version > 2.16.1) of 2010-05-09: > (all-completions "" []) > I think the problem is on line 1593 of src/minibuf.c, but my > Emacs-innards-fu isn't good enough to attempt a fix. I think this patch should fix things diff --git a/src/minibuf.c b/src/minibuf.c index ad81bfd..1d93901 100644 --- a/src/minibuf.c +++ b/src/minibuf.c @@ -1590,7 +1590,7 @@ with a space are ignored unless STRING itself starts with a space. */) if (type == 2) { obsize = XVECTOR (collection)->size; - bucket = XVECTOR (collection)->contents[index]; + bucket = obsize == 0 ? zero : XVECTOR (collection)->contents[index]; } while (1) Although I don't understand why the code-path for the vector version can't be simplified as in the following patch, which also fixes the problem AFAICT: diff --git a/src/minibuf.c b/src/minibuf.c index ad81bfd..c6aae27 100644 --- a/src/minibuf.c +++ b/src/minibuf.c @@ -1610,22 +1610,14 @@ with a space are ignored unless STRING itself starts with a space. */) } else if (type == 2) { - if (!EQ (bucket, zero)) - { - elt = bucket; - eltstring = elt; - if (XSYMBOL (bucket)->next) - XSETSYMBOL (bucket, XSYMBOL (bucket)->next); - else - XSETFASTINT (bucket, 0); - } - else if (++index >= obsize) - break; - else - { - bucket = XVECTOR (collection)->contents[index]; - continue; - } + if ( index < obsize ) + { + elt = bucket; + eltstring = elt; + bucket = XVECTOR (collection)->contents[++index]; + } + else + break; } else /* if (type == 3) */ { Cheers, Lawrence -- Lawrence Mitchell From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 08 12:41:35 2010 Received: (at 6378) by debbugs.gnu.org; 8 Jun 2010 16:41:35 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OM1rr-0005ja-Ia for submit@debbugs.gnu.org; Tue, 08 Jun 2010 12:41:35 -0400 Received: from mail-fx0-f44.google.com ([209.85.161.44]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OM1rp-0005jT-Qv for 6378@debbugs.gnu.org; Tue, 08 Jun 2010 12:41:34 -0400 Received: by fxm13 with SMTP id 13so954238fxm.3 for <6378@debbugs.gnu.org>; Tue, 08 Jun 2010 09:41:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:mime-version:received:in-reply-to :references:from:date:message-id:subject:to:cc:content-type :content-transfer-encoding; bh=OuozRXfFBcr9L48VNR6Rmb79G61F1tZ0mB29ENwWtmg=; b=GmedPKL0Ce3IGPP6yr+H3Yolu2U6ffn7OCx8yTFT0tzPqMgr/t2/r5ODqz6HYpV8Ds RUEITYLi8+e84QkIPtPhzVVm7Zbrck8gmyy4jqwy0TbbT3z4BzGgepEVlayARdIzC7XK ZW+E6OwTjeb+CAotfXWqNdUgAdaSBHIvunUVQ= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:content-transfer-encoding; b=R685Zr2fXL02gubSSuUGHlk9lcRouLpoYlbNNKfNVuzVdl2bp9s4r+7DlAu0PwkMIH 7tgDO986vsawsWBOOIai1QrdFEtwQCQ1TFXYkLtGSF6NICPhW7qHaQnOZJ52VAXHrF2R +IkbUgWJtWzpMyuwTTX/QXCAUzdR3gZ3TfHb0= Received: by 10.204.47.21 with SMTP id l21mr8016923bkf.134.1276015287406; Tue, 08 Jun 2010 09:41:27 -0700 (PDT) MIME-Version: 1.0 Received: by 10.204.32.5 with HTTP; Tue, 8 Jun 2010 09:41:07 -0700 (PDT) In-Reply-To: References: From: Juanma Barranquero Date: Tue, 8 Jun 2010 18:41:07 +0200 Message-ID: Subject: Re: bug#6378: all-completions Segfault To: Nathan Weizenbaum Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.8 (--) X-Debbugs-Envelope-To: 6378 Cc: 6378@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.8 (--) On Tue, Jun 8, 2010 at 17:46, Nathan Weizenbaum wrote: > =C2=A0 (all-completions "" []) > > I think the problem is on line 1593 of src/minibuf.c, but my > Emacs-innards-fu isn't good enough to attempt a fix. minibuf.c:1617, at this code: if (XSYMBOL (bucket)->next) because bucket has been assigned random junk from the nonexistent item at position 0 in COLLECTION. It should be fixed with the attached patch. Juanma 2010-06-08 Juanma Barranquero * minibuf.c (Fall_completions): Check COLLECTION's size. (Bug#6378) =3D=3D=3D modified file 'src/minibuf.c' --- src/minibuf.c 2010-01-13 08:35:10 +0000 +++ src/minibuf.c 2010-06-08 16:34:41 +0000 @@ -1591,5 +1591,5 @@ { obsize =3D XVECTOR (collection)->size; - bucket =3D XVECTOR (collection)->contents[index]; + bucket =3D obsize ? XVECTOR (collection)->contents[index] : zero; } From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 08 12:53:59 2010 Received: (at 6378-done) by debbugs.gnu.org; 8 Jun 2010 16:53:59 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OM23q-0005oz-R6 for submit@debbugs.gnu.org; Tue, 08 Jun 2010 12:53:59 -0400 Received: from mail-fx0-f44.google.com ([209.85.161.44]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OM23o-0005ou-La for 6378-done@debbugs.gnu.org; Tue, 08 Jun 2010 12:53:57 -0400 Received: by fxm13 with SMTP id 13so964464fxm.3 for <6378-done@debbugs.gnu.org>; Tue, 08 Jun 2010 09:53:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:mime-version:received:in-reply-to :references:from:date:message-id:subject:to:cc:content-type; bh=Tk4EplsbPnTArtnV0RGlFUAAtUKGHeAZdqqEpcW9rKQ=; b=mqmRAK4FhUG1ESEat7oLby6bMt3QaQmUgzuqqsTAgomuzn7BciKOCkfmCFVIYyyIUe hQHBgbKuWn38FGC5xKSfHdq9ddzu67e8LHdvRfuegmngkvdX0BjgPGYnzeWtdINwY3Bz 1sZ5QmJ4/LvPCaaVHBgs0f1sBT6o3lF4lMME0= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; b=FMaSkLTc3DqE3gDl88gl4lPObOUG/Pf7HrPUR24f0QeZYUdny4aMqVuIKXNcD/m7V7 6H90h3OpE7WE7dOZetWu802sQt4TAK/33zjYd5zkoHQdNdRF61GKCvIpIgLciTRSg0Gy 8P8aDQaSwnJmllNojTzmMCawkTBshVA4qjrc8= Received: by 10.204.83.225 with SMTP id g33mr1135396bkl.37.1276016028241; Tue, 08 Jun 2010 09:53:48 -0700 (PDT) MIME-Version: 1.0 Received: by 10.204.32.5 with HTTP; Tue, 8 Jun 2010 09:53:28 -0700 (PDT) In-Reply-To: References: From: Juanma Barranquero Date: Tue, 8 Jun 2010 18:53:28 +0200 Message-ID: Subject: Re: bug#6378: all-completions Segfault To: Nathan Weizenbaum Content-Type: text/plain; charset=UTF-8 X-Spam-Score: -2.8 (--) X-Debbugs-Envelope-To: 6378-done Cc: 6378-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.8 (--) I've installed the fix on the emacs-23 branch. Juanma From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 08 14:58:41 2010 Received: (at 6378) by debbugs.gnu.org; 8 Jun 2010 18:58:42 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OM40X-0006fz-Oe for submit@debbugs.gnu.org; Tue, 08 Jun 2010 14:58:41 -0400 Received: from mail-yw0-f196.google.com ([209.85.211.196]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OM40V-0006fp-1o; Tue, 08 Jun 2010 14:58:39 -0400 Received: by ywh34 with SMTP id 34so4759559ywh.30 for ; Tue, 08 Jun 2010 11:58:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:mime-version:received:in-reply-to :references:from:date:message-id:subject:to:cc:content-type; bh=0Zz5406ZDClPJNZRGXgeIR16UerLArq3AL2CZc8QAT0=; b=UsLRza7fPaXXpSi6JkVZWIJoZRy5xVnRvqeoK73k8KzXitqydXrtYPb6Vf7PrnXbfO B9ZdpTz/0hAhbfnyWtUjuvpmd+cZ/MViUvczKyJLSActU9h8jNcTzS2dKMIoumyXF0B4 mFnOn09gpO6+5nfgHcvnYY0Nw2sYXEmMz6y2o= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; b=O8ubzohuDLDcDGm2W2P44LVI2ynMyGwX4jKT3k90vEubdEXtFgPIpvKZdvnvSWJuZY eL1KRgmJRa6EFlwThvYfpAK/6Z0ZljRuFKaX2XY2YkHS3U5bpIiSwlZZhOtb7QJzNn1k T7AljU4KWztiM1k2Z2AqfCOik5swcwHsMJeO8= Received: by 10.100.236.5 with SMTP id j5mr16765115anh.202.1276023510216; Tue, 08 Jun 2010 11:58:30 -0700 (PDT) MIME-Version: 1.0 Received: by 10.100.154.15 with HTTP; Tue, 8 Jun 2010 11:58:10 -0700 (PDT) In-Reply-To: References: From: Lennart Borgman Date: Tue, 8 Jun 2010 20:58:10 +0200 Message-ID: Subject: Re: bug#6378: all-completions Segfault To: 6378@debbugs.gnu.org, lekktu@gmail.com Content-Type: text/plain; charset=UTF-8 X-Spam-Score: -2.9 (--) X-Debbugs-Envelope-To: 6378 Cc: Nathan Weizenbaum , 6378-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.9 (--) On Tue, Jun 8, 2010 at 6:53 PM, Juanma Barranquero wrote: > I've installed the fix on the emacs-23 branch. Isn't there a similar case in Ftry_completion? From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 08 15:08:42 2010 Received: (at 6378) by debbugs.gnu.org; 8 Jun 2010 19:08:43 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OM4AE-0006qU-7v for submit@debbugs.gnu.org; Tue, 08 Jun 2010 15:08:42 -0400 Received: from mail-fx0-f44.google.com ([209.85.161.44]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OM4AC-0006qJ-3Q; Tue, 08 Jun 2010 15:08:40 -0400 Received: by fxm13 with SMTP id 13so1063745fxm.3 for ; Tue, 08 Jun 2010 12:08:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:mime-version:received:in-reply-to :references:from:date:message-id:subject:to:cc:content-type; bh=MsM7qeL2KtQwx56h8qBNL05RE7vdC96sm9KvTmYv8r4=; b=Y6UBPOTvznrVcPlB49BtI4iKhePyBCSx0HvJtNgVIpgY33BEZ/z/Y1gozVM2qkrB5H YMsRSVJZ/d1BXlq404EoubVKFtgPMsnPhLpXgBsj9Ca7ePnhjbefJ10riuZgVc/NOrWz pbbuiNj2o6PJJ6k+8lSh8DKXf8sqrBLtKeXiE= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; b=K+bBPGr/mF8P2qy6+agwZjw+zStUtSQTHCjk2V/DTF/ynUzOCMSX1glrZ4E+OekXoH FAcjgJJIOsdLQacBpbPkcA4n7k1hlD1gesS+sTHw52bH4qMq1pklxdxP51Pfx7Qjkh2N 9CP4iRe5PRBGlLoNP6HDtq0IwqA0uBjIEdZdw= Received: by 10.204.46.230 with SMTP id k38mr8134984bkf.116.1276024114703; Tue, 08 Jun 2010 12:08:34 -0700 (PDT) MIME-Version: 1.0 Received: by 10.204.32.5 with HTTP; Tue, 8 Jun 2010 12:08:13 -0700 (PDT) In-Reply-To: References: From: Juanma Barranquero Date: Tue, 8 Jun 2010 21:08:13 +0200 Message-ID: Subject: Re: bug#6378: all-completions Segfault To: Lennart Borgman Content-Type: text/plain; charset=UTF-8 X-Spam-Score: -2.8 (--) X-Debbugs-Envelope-To: 6378 Cc: Nathan Weizenbaum , 6378@debbugs.gnu.org, 6378-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.8 (--) On Tue, Jun 8, 2010 at 20:58, Lennart Borgman wrote: > Isn't there a similar case in Ftry_completion? Apparently no. ELISP> (try-completion "" []) *** Eval error *** Wrong type argument: vectorp, [] ELISP> (try-completion "" [[]]) *** Eval error *** Bad data in guts of obarray ELISP> (try-completion "" [0]) nil ELISP> (try-completion "" [a]) "" ELISP> Juanma From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 08 15:32:39 2010 Received: (at 6378) by debbugs.gnu.org; 8 Jun 2010 19:32:39 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OM4XO-00073D-TW for submit@debbugs.gnu.org; Tue, 08 Jun 2010 15:32:39 -0400 Received: from mail-gy0-f172.google.com ([209.85.160.172]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OM4XM-00072z-B0; Tue, 08 Jun 2010 15:32:36 -0400 Received: by gyh4 with SMTP id 4so3426881gyh.3 for ; Tue, 08 Jun 2010 12:32:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:mime-version:received:in-reply-to :references:from:date:message-id:subject:to:cc:content-type :content-transfer-encoding; bh=dFsVzu1LEIon3oVX7Hv6IHRIR4GkJO2GdPdjuRUPz5E=; b=RVWRBjxmc1DuHqxl4jyFEp1dpzsQynRVR320C0lkTkzVSU8QA4hqKEGlAKO0pgNQjL lnb9qcuvkwAke3iPrk+JqRO5ctdBClUiRVs9Yu5GyTwGoiYY6ZZ78IiJYl7KlluuHPvO qvTw8zIknBOdT4YWdUfRW5o2/g8ItwnRdR/00= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:content-transfer-encoding; b=FTFTZwfSdlFO9y+xCtS55flbAOVJq3aq3nCNQV/eiAQ2WUOIJe4v3C9U78hzqnputQ BDFMoxsY/24lpOmharjnC1DZKrp/nJapr8YzoHHSH0KHz2uJr0GG7HmqJvJQP2QiaXO7 VEUyZfzSq2EtfwldtKzEviL18eLMuIarJIjsU= Received: by 10.101.2.34 with SMTP id e34mr16760897ani.123.1276025551393; Tue, 08 Jun 2010 12:32:31 -0700 (PDT) MIME-Version: 1.0 Received: by 10.100.154.15 with HTTP; Tue, 8 Jun 2010 12:32:11 -0700 (PDT) In-Reply-To: References: From: Lennart Borgman Date: Tue, 8 Jun 2010 21:32:11 +0200 Message-ID: Subject: Re: bug#6378: all-completions Segfault To: Juanma Barranquero Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.9 (--) X-Debbugs-Envelope-To: 6378 Cc: Nathan Weizenbaum , 6378@debbugs.gnu.org, 6378-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.9 (--) On Tue, Jun 8, 2010 at 9:08 PM, Juanma Barranquero wrote= : > On Tue, Jun 8, 2010 at 20:58, Lennart Borgman = wrote: > >> Isn't there a similar case in Ftry_completion? > > Apparently no. > > ELISP> (try-completion "" []) > *** Eval error *** =C2=A0Wrong type argument: vectorp, [] > ELISP> (try-completion "" [[]]) > *** Eval error *** =C2=A0Bad data in guts of obarray > ELISP> (try-completion "" [0]) > nil > ELISP> (try-completion "" [a]) > "" > ELISP> > > =C2=A0 =C2=A0Juanma So the thing protecting it is that an obarray can't have length 0? Can one be sure that does not break someday? From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 08 15:58:22 2010 Received: (at 6378) by debbugs.gnu.org; 8 Jun 2010 19:58:23 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OM4wI-0007F8-F3 for submit@debbugs.gnu.org; Tue, 08 Jun 2010 15:58:22 -0400 Received: from mail-bw0-f44.google.com ([209.85.214.44]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OM4wG-0007F3-I5 for 6378@debbugs.gnu.org; Tue, 08 Jun 2010 15:58:21 -0400 Received: by bwz6 with SMTP id 6so342098bwz.3 for <6378@debbugs.gnu.org>; Tue, 08 Jun 2010 12:58:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:mime-version:received:in-reply-to :references:from:date:message-id:subject:to:cc:content-type; bh=bUOjHw8+4m+lNkdrNEYXuA8QgbixVMT51o5NhlnzdLg=; b=wy3RRLonkdtQDGuSMhJxBRWeqdj+AKo4KOXBaYKN++/tNTRBtdP0l7fVWXt6gb+WHn NBSmN68gGZaLoObQS1xhZ881Qoy5t4Z/PX5cXjzg/kUBz9NMxBN4tnyCvKUWAGbV58rB v/8Dglu0n1Dj1rug1fzzRF9CnXNB3X1po1E2M= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; b=Ul1OtUDoNvW7LCtc/nRl3RScDXY5V1U9vKN5uq1iZ1cVV7zJS9a9TwbpLWcSXBYX0v Hu0vjaaIp1EZoBIRwXmRuH3JL87i0kHfNnSRpXFYqKwsLaJBQn6EZ4THB6DywPpYExaU PxU4SE+E8irSpi62as97PU2AiMPdnx3oq5k+Y= Received: by 10.204.74.29 with SMTP id s29mr8183228bkj.97.1276027090215; Tue, 08 Jun 2010 12:58:10 -0700 (PDT) MIME-Version: 1.0 Received: by 10.204.32.5 with HTTP; Tue, 8 Jun 2010 12:57:50 -0700 (PDT) In-Reply-To: References: From: Juanma Barranquero Date: Tue, 8 Jun 2010 21:57:50 +0200 Message-ID: Subject: Re: bug#6378: all-completions Segfault To: Lennart Borgman Content-Type: text/plain; charset=UTF-8 X-Spam-Score: -2.8 (--) X-Debbugs-Envelope-To: 6378 Cc: Nathan Weizenbaum , 6378@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.8 (--) On Tue, Jun 8, 2010 at 21:32, Lennart Borgman wrote: > So the thing protecting it is that an obarray can't have length 0? Can > one be sure that does not break someday? Meaning? Juanma From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 08 16:31:27 2010 Received: (at submit) by debbugs.gnu.org; 8 Jun 2010 20:31:27 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OM5SJ-0007Uf-A4 for submit@debbugs.gnu.org; Tue, 08 Jun 2010 16:31:27 -0400 Received: from mail.gnu.org ([199.232.76.166] helo=mx10.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OM5S8-0007UW-Rd for submit@debbugs.gnu.org; Tue, 08 Jun 2010 16:31:26 -0400 Received: from lists.gnu.org ([199.232.76.165]:45804) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1OM5S2-0007Gw-6c for submit@debbugs.gnu.org; Tue, 08 Jun 2010 16:31:10 -0400 Received: from [140.186.70.92] (port=54898 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OM5Rv-0001Hv-US for bug-gnu-emacs@gnu.org; Tue, 08 Jun 2010 16:31:09 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,T_RP_MATCHES_RCVD autolearn=unavailable version=3.3.1 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OM5Ro-00050y-EA for bug-gnu-emacs@gnu.org; Tue, 08 Jun 2010 16:30:57 -0400 Received: from chene.dit.umontreal.ca ([132.204.246.20]:51015) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OM5Ro-00050r-9x for bug-gnu-emacs@gnu.org; Tue, 08 Jun 2010 16:30:56 -0400 Received: from faina.iro.umontreal.ca (faina.iro.umontreal.ca [132.204.26.177]) by chene.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id o58KUq5n007690; Tue, 8 Jun 2010 16:30:52 -0400 Received: by faina.iro.umontreal.ca (Postfix, from userid 20848) id 19A2970365; Tue, 8 Jun 2010 16:30:52 -0400 (EDT) From: Stefan Monnier To: Lawrence Mitchell Subject: Re: bug#6378: all-completions Segfault Message-ID: References: Date: Tue, 08 Jun 2010 16:30:52 -0400 In-Reply-To: (Lawrence Mitchell's message of "Tue, 08 Jun 2010 17:37:47 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV3552=0 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit Cc: bug-gnu-emacs@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.0 (----) > Although I don't understand why the code-path for the vector > version can't be simplified as in the following patch, which also > fixes the problem AFAICT: > diff --git a/src/minibuf.c b/src/minibuf.c > index ad81bfd..c6aae27 100644 > --- a/src/minibuf.c > +++ b/src/minibuf.c > @@ -1610,22 +1610,14 @@ with a space are ignored unless STRING itself starts with a space. */) > } > else if (type == 2) > { > - if (!EQ (bucket, zero)) > - { > - elt = bucket; > - eltstring = elt; > - if (XSYMBOL (bucket)->next) > - XSETSYMBOL (bucket, XSYMBOL (bucket)->next); > - else > - XSETFASTINT (bucket, 0); > - } > - else if (++index >= obsize) > - break; > - else > - { > - bucket = XVECTOR (collection)->contents[index]; > - continue; > - } > + if ( index < obsize ) > + { > + elt = bucket; > + eltstring = elt; > + bucket = XVECTOR (collection)->contents[++index]; > + } > + else > + break; > } > else /* if (type == 3) */ > { IIUC this would only loop through all the buckets, without looping through each bucket's linked list. Compare (length obarray) and (let ((i 0)) (mapatoms (lambda (_) (incf i)) obarray) i) Stefan From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 09 01:17:14 2010 Received: (at submit) by debbugs.gnu.org; 9 Jun 2010 05:17:14 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OMDf8-0003ic-0y for submit@debbugs.gnu.org; Wed, 09 Jun 2010 01:17:14 -0400 Received: from mx10.gnu.org ([199.232.76.166]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OMDf5-0003iU-61 for submit@debbugs.gnu.org; Wed, 09 Jun 2010 01:17:12 -0400 Received: from lists.gnu.org ([199.232.76.165]:48760) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1OMDf1-0006Fg-2G for submit@debbugs.gnu.org; Wed, 09 Jun 2010 01:17:07 -0400 Received: from [140.186.70.92] (port=49278 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OMDeu-0003hv-LY for bug-gnu-emacs@gnu.org; Wed, 09 Jun 2010 01:17:05 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM, T_RP_MATCHES_RCVD, T_TO_NO_BRKTS_FREEMAIL autolearn=unavailable version=3.3.1 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OMDeo-0008Ce-MO for bug-gnu-emacs@gnu.org; Wed, 09 Jun 2010 01:17:00 -0400 Received: from lo.gmane.org ([80.91.229.12]:47071) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OMDeo-0008CT-C4 for bug-gnu-emacs@gnu.org; Wed, 09 Jun 2010 01:16:54 -0400 Received: from list by lo.gmane.org with local (Exim 4.69) (envelope-from ) id 1OMDen-0002Uc-1A for bug-gnu-emacs@gnu.org; Wed, 09 Jun 2010 07:16:53 +0200 Received: from 178.211.85-79.rev.gaoland.net ([79.85.211.178]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 09 Jun 2010 07:16:53 +0200 Received: from thierry.volpiatto by 178.211.85-79.rev.gaoland.net with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 09 Jun 2010 07:16:53 +0200 X-Injected-Via-Gmane: http://gmane.org/ To: bug-gnu-emacs@gnu.org connect(): No such file or directory From: Thierry Volpiatto Subject: Re: bug#6378: all-completions Segfault Date: Wed, 09 Jun 2010 07:13:31 +0200 Organization: ThierryVolpiatto Lines: 58 Message-ID: <874ohcbxfo.fsf@tux.homenetwork> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Complaints-To: usenet@dough.gmane.org X-Gmane-NNTP-Posting-Host: 178.211.85-79.rev.gaoland.net User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) Cancel-Lock: sha1:Ca4niTW36Xqf0ZP5ULFxKWxnDeI= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-Spam-Score: -5.5 (-----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.5 (-----) Stefan Monnier writes: >> Although I don't understand why the code-path for the vector >> version can't be simplified as in the following patch, which also >> fixes the problem AFAICT: > >> diff --git a/src/minibuf.c b/src/minibuf.c >> index ad81bfd..c6aae27 100644 >> --- a/src/minibuf.c >> +++ b/src/minibuf.c >> @@ -1610,22 +1610,14 @@ with a space are ignored unless STRING itself starts with a space. */) >> } >> else if (type == 2) >> { >> - if (!EQ (bucket, zero)) >> - { >> - elt = bucket; >> - eltstring = elt; >> - if (XSYMBOL (bucket)->next) >> - XSETSYMBOL (bucket, XSYMBOL (bucket)->next); >> - else >> - XSETFASTINT (bucket, 0); >> - } >> - else if (++index >= obsize) >> - break; >> - else >> - { >> - bucket = XVECTOR (collection)->contents[index]; >> - continue; >> - } >> + if ( index < obsize ) >> + { >> + elt = bucket; >> + eltstring = elt; >> + bucket = XVECTOR (collection)->contents[++index]; >> + } >> + else >> + break; >> } >> else /* if (type == 3) */ >> { > > IIUC this would only loop through all the buckets, without looping > through each bucket's linked list. > Compare (length obarray) > and (let ((i 0)) (mapatoms (lambda (_) (incf i)) obarray) i) Don't know if that related but (completing-read "test: " [1 2 3 23 24 34 26 40 28]) test: 2 ==> TAB instead of failing crash emacs. -- Thierry Volpiatto Gpg key: http://pgp.mit.edu/ From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 09 02:13:40 2010 Received: (at submit) by debbugs.gnu.org; 9 Jun 2010 06:13:40 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OMEXk-000446-Jf for submit@debbugs.gnu.org; Wed, 09 Jun 2010 02:13:40 -0400 Received: from mx10.gnu.org ([199.232.76.166]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OMEXj-000441-JV for submit@debbugs.gnu.org; Wed, 09 Jun 2010 02:13:39 -0400 Received: from lists.gnu.org ([199.232.76.165]:49073) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1OMEXg-0006qp-0v for submit@debbugs.gnu.org; Wed, 09 Jun 2010 02:13:36 -0400 Received: from [140.186.70.92] (port=41154 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OMEXe-0007jy-Lh for bug-gnu-emacs@gnu.org; Wed, 09 Jun 2010 02:13:35 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,T_DKIM_INVALID autolearn=unavailable version=3.3.1 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OMEXd-00067G-JJ for bug-gnu-emacs@gnu.org; Wed, 09 Jun 2010 02:13:34 -0400 Received: from mail-gw0-f41.google.com ([74.125.83.41]:44233) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OMEXd-000677-DF for bug-gnu-emacs@gnu.org; Wed, 09 Jun 2010 02:13:33 -0400 Received: by gwb19 with SMTP id 19so1510142gwb.0 for ; Tue, 08 Jun 2010 23:13:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:mime-version:received:in-reply-to :references:from:date:message-id:subject:to:cc:content-type; bh=pFE94Fm8mm611MzqoTzP8q5TXDFdlIfQqVo5YN0X6/c=; b=sfJf0ydJwGcB+2/JKWo3rrSzVHVj9OfGV8c7J6pkddJUi2pf5/reJ+sectfzQ/lYUe vBT8q8gBsiW3cqz86fveQ/3DX47Bgxo60FoFN4R/3o1Tegifq7x8F8eDlOWe6ZXArSK7 FJvfgxFpXKHpAUtJFSbM81tczcUq0IT0qFxik= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; b=p/Lr8j3lI3B/pxXb7CuszD827AnAxYteOqjzg8a1j4CdVVvLEm9a2DrCPrnzTFOKo8 g1ne65zd7llzkhprFskidijTww/4VClbxeHx7v5bcVtTBJGv6VoN1pprYYavNR55EuT2 wP/PO5qeDPlmGT1uQjOT7giG4kXi5GQF+pe1w= Received: by 10.100.236.5 with SMTP id j5mr17365756anh.202.1276064012343; Tue, 08 Jun 2010 23:13:32 -0700 (PDT) MIME-Version: 1.0 Received: by 10.100.154.15 with HTTP; Tue, 8 Jun 2010 23:13:12 -0700 (PDT) In-Reply-To: <874ohcbxfo.fsf@tux.homenetwork> References: <874ohcbxfo.fsf@tux.homenetwork> From: Lennart Borgman Date: Wed, 9 Jun 2010 08:13:12 +0200 Message-ID: Subject: Re: bug#6378: all-completions Segfault To: Thierry Volpiatto Content-Type: text/plain; charset=UTF-8 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-Spam-Score: -4.6 (----) X-Debbugs-Envelope-To: submit Cc: bug-gnu-emacs@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.6 (----) On Wed, Jun 9, 2010 at 7:13 AM, Thierry Volpiatto wrote: > (completing-read "test: " [1 2 3 23 24 34 26 40 28]) Does not that crash just because only symbols or strings can be keys in the collection? From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 09 02:22:06 2010 Received: (at submit) by debbugs.gnu.org; 9 Jun 2010 06:22:06 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OMEfu-00048W-Ab for submit@debbugs.gnu.org; Wed, 09 Jun 2010 02:22:06 -0400 Received: from mail.gnu.org ([199.232.76.166] helo=mx10.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OMEfr-000488-Hu for submit@debbugs.gnu.org; Wed, 09 Jun 2010 02:22:04 -0400 Received: from lists.gnu.org ([199.232.76.165]:44709) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1OMEfo-0006zn-7y for submit@debbugs.gnu.org; Wed, 09 Jun 2010 02:22:00 -0400 Received: from [140.186.70.92] (port=58775 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OMEfm-0003AP-RE for bug-gnu-emacs@gnu.org; Wed, 09 Jun 2010 02:21:59 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM, T_RP_MATCHES_RCVD, T_TO_NO_BRKTS_FREEMAIL autolearn=unavailable version=3.3.1 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OMEfh-0007JF-Vj for bug-gnu-emacs@gnu.org; Wed, 09 Jun 2010 02:21:58 -0400 Received: from lo.gmane.org ([80.91.229.12]:33393) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OMEfh-0007J7-Lk for bug-gnu-emacs@gnu.org; Wed, 09 Jun 2010 02:21:53 -0400 Received: from list by lo.gmane.org with local (Exim 4.69) (envelope-from ) id 1OMEfe-0007u4-I5 for bug-gnu-emacs@gnu.org; Wed, 09 Jun 2010 08:21:50 +0200 Received: from 178.211.85-79.rev.gaoland.net ([79.85.211.178]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 09 Jun 2010 08:21:50 +0200 Received: from thierry.volpiatto by 178.211.85-79.rev.gaoland.net with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 09 Jun 2010 08:21:50 +0200 X-Injected-Via-Gmane: http://gmane.org/ To: bug-gnu-emacs@gnu.org connect(): No such file or directory From: Thierry Volpiatto Subject: Re: bug#6378: all-completions Segfault Date: Wed, 09 Jun 2010 08:18:27 +0200 Organization: ThierryVolpiatto Lines: 63 Message-ID: <87iq5sloek.fsf@tux.homenetwork> References: <874ohcbxfo.fsf@tux.homenetwork> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Complaints-To: usenet@dough.gmane.org X-Gmane-NNTP-Posting-Host: 178.211.85-79.rev.gaoland.net User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) Cancel-Lock: sha1:tVFzhq8rfOaA4akPtm4gm4/UcAY= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-Spam-Score: -5.5 (-----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.5 (-----) Thierry Volpiatto writes: > Stefan Monnier writes: > >>> Although I don't understand why the code-path for the vector >>> version can't be simplified as in the following patch, which also >>> fixes the problem AFAICT: >> >>> diff --git a/src/minibuf.c b/src/minibuf.c >>> index ad81bfd..c6aae27 100644 >>> --- a/src/minibuf.c >>> +++ b/src/minibuf.c >>> @@ -1610,22 +1610,14 @@ with a space are ignored unless STRING itself starts with a space. */) >>> } >>> else if (type == 2) >>> { >>> - if (!EQ (bucket, zero)) >>> - { >>> - elt = bucket; >>> - eltstring = elt; >>> - if (XSYMBOL (bucket)->next) >>> - XSETSYMBOL (bucket, XSYMBOL (bucket)->next); >>> - else >>> - XSETFASTINT (bucket, 0); >>> - } >>> - else if (++index >= obsize) >>> - break; >>> - else >>> - { >>> - bucket = XVECTOR (collection)->contents[index]; >>> - continue; >>> - } >>> + if ( index < obsize ) >>> + { >>> + elt = bucket; >>> + eltstring = elt; >>> + bucket = XVECTOR (collection)->contents[++index]; >>> + } >>> + else >>> + break; >>> } >>> else /* if (type == 3) */ >>> { >> >> IIUC this would only loop through all the buckets, without looping >> through each bucket's linked list. >> Compare (length obarray) >> and (let ((i 0)) (mapatoms (lambda (_) (incf i)) obarray) i) > > Don't know if that related but > > (completing-read "test: " [1 2 3 23 24 34 26 40 28]) > > test: 2 ==> TAB > > instead of failing crash emacs. Program received signal SIGSEGV, Segmentation fault. 0x08151015 in Fall_completions () -- Thierry Volpiatto Gpg key: http://pgp.mit.edu/ From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 09 03:26:53 2010 Received: (at submit) by debbugs.gnu.org; 9 Jun 2010 07:26:54 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OMFgb-0004cV-LK for submit@debbugs.gnu.org; Wed, 09 Jun 2010 03:26:53 -0400 Received: from mail.gnu.org ([199.232.76.166] helo=mx10.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OMFgY-0004cP-SX for submit@debbugs.gnu.org; Wed, 09 Jun 2010 03:26:51 -0400 Received: from lists.gnu.org ([199.232.76.165]:51582) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1OMFgV-00087w-T7 for submit@debbugs.gnu.org; Wed, 09 Jun 2010 03:26:47 -0400 Received: from [140.186.70.92] (port=44046 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OMFgU-000586-F1 for bug-gnu-emacs@gnu.org; Wed, 09 Jun 2010 03:26:47 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM, T_RP_MATCHES_RCVD, T_TO_NO_BRKTS_FREEMAIL autolearn=unavailable version=3.3.1 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OMFgT-0000eL-CV for bug-gnu-emacs@gnu.org; Wed, 09 Jun 2010 03:26:46 -0400 Received: from lo.gmane.org ([80.91.229.12]:44448) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OMFgT-0000do-2Q for bug-gnu-emacs@gnu.org; Wed, 09 Jun 2010 03:26:45 -0400 Received: from list by lo.gmane.org with local (Exim 4.69) (envelope-from ) id 1OMFgR-0002V3-Dt for bug-gnu-emacs@gnu.org; Wed, 09 Jun 2010 09:26:43 +0200 Received: from 178.211.85-79.rev.gaoland.net ([79.85.211.178]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 09 Jun 2010 09:26:43 +0200 Received: from thierry.volpiatto by 178.211.85-79.rev.gaoland.net with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 09 Jun 2010 09:26:43 +0200 X-Injected-Via-Gmane: http://gmane.org/ To: bug-gnu-emacs@gnu.org connect(): No such file or directory From: Thierry Volpiatto Subject: Re: bug#6378: all-completions Segfault Date: Wed, 09 Jun 2010 09:23:22 +0200 Organization: ThierryVolpiatto Lines: 17 Message-ID: <87d3w0k6tx.fsf@tux.homenetwork> References: <874ohcbxfo.fsf@tux.homenetwork> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Complaints-To: usenet@dough.gmane.org X-Gmane-NNTP-Posting-Host: 178.211.85-79.rev.gaoland.net User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) Cancel-Lock: sha1:6X3sCUmnfRbJnJ6HPiy0RPANgFg= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-Spam-Score: -5.5 (-----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.5 (-----) Lennart Borgman writes: > On Wed, Jun 9, 2010 at 7:13 AM, Thierry Volpiatto > wrote: >> (completing-read "test: " [1 2 3 23 24 34 26 40 28]) > > Does not that crash just because only symbols or strings can be keys > in the collection? I thought but it's worst, because: (completing-read "test: " ["1" "2" "23" "24" "25" "34" "45" "56"]) Also crash emacs. -- Thierry Volpiatto Gpg key: http://pgp.mit.edu/ From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 09 04:51:30 2010 Received: (at submit) by debbugs.gnu.org; 9 Jun 2010 08:51:30 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OMH0T-0005De-PB for submit@debbugs.gnu.org; Wed, 09 Jun 2010 04:51:30 -0400 Received: from mx10.gnu.org ([199.232.76.166]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OMH0R-0005DY-MM for submit@debbugs.gnu.org; Wed, 09 Jun 2010 04:51:28 -0400 Received: from lists.gnu.org ([199.232.76.165]:36602) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1OMH0O-0001Ob-MI for submit@debbugs.gnu.org; Wed, 09 Jun 2010 04:51:24 -0400 Received: from [140.186.70.92] (port=51212 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OMH0M-0006Wz-PW for bug-gnu-emacs@gnu.org; Wed, 09 Jun 2010 04:51:24 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,T_DKIM_INVALID autolearn=unavailable version=3.3.1 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OMH0L-0008Ba-Co for bug-gnu-emacs@gnu.org; Wed, 09 Jun 2010 04:51:22 -0400 Received: from mail-gw0-f41.google.com ([74.125.83.41]:35389) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OMH0L-0008BU-Am for bug-gnu-emacs@gnu.org; Wed, 09 Jun 2010 04:51:21 -0400 Received: by gwb19 with SMTP id 19so1563750gwb.0 for ; Wed, 09 Jun 2010 01:51:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:mime-version:received:in-reply-to :references:from:date:message-id:subject:to:cc:content-type; bh=mcvtgLiZXsNmeBarxUkWa6NWsQy0fxjPpFwK10j3dAo=; b=Rk3yYCWbdwJzO6YyfAKIHRVyJQPSALhHx93mrgMw/fk0VIfKg5sfIMfmu3K3ZzdEJ2 1yPOlfROayFVEPaTWZ09KjDIHC7dw/BSUX0vJFoQELJClVoWfn9Oa3d6UVVP3YjoMkFJ t8rdUCJMRFypQ8p8edsCCq/GPK2NhMoYMP/8Q= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; b=N1bpWoCIF5w0/tCSduIZcGATSz+SaLBKAyJ40tt285S1gA0uCILQ7JhRJ5PRzpnegb Z7iV11Q/96C38aWZxIWAr9EI5QKrSiWVRN8owN3wHHVzWagdrxlquH1ZZpQGlU53QWC3 3BuLtnXy5/RV/3FOSHR1jwCNcKVo5x94gYks4= Received: by 10.100.236.5 with SMTP id j5mr17486515anh.202.1276073480502; Wed, 09 Jun 2010 01:51:20 -0700 (PDT) MIME-Version: 1.0 Received: by 10.100.154.15 with HTTP; Wed, 9 Jun 2010 01:51:00 -0700 (PDT) In-Reply-To: <87d3w0k6tx.fsf@tux.homenetwork> References: <874ohcbxfo.fsf@tux.homenetwork> <87d3w0k6tx.fsf@tux.homenetwork> From: Lennart Borgman Date: Wed, 9 Jun 2010 10:51:00 +0200 Message-ID: Subject: Re: bug#6378: all-completions Segfault To: Thierry Volpiatto Content-Type: text/plain; charset=UTF-8 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-Spam-Score: -4.6 (----) X-Debbugs-Envelope-To: submit Cc: bug-gnu-emacs@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.6 (----) On Wed, Jun 9, 2010 at 9:23 AM, Thierry Volpiatto wrote: > Lennart Borgman writes: > >> On Wed, Jun 9, 2010 at 7:13 AM, Thierry Volpiatto >> wrote: >>> (completing-read "test: " [1 2 3 23 24 34 26 40 28]) >> >> Does not that crash just because only symbols or strings can be keys >> in the collection? > I thought but it's worst, because: > > (completing-read "test: " ["1" "2" "23" "24" "25" "34" "45" "56"]) > > Also crash emacs. Yes, it expects an obarray, not a plain vector. From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 09 05:12:58 2010 Received: (at submit) by debbugs.gnu.org; 9 Jun 2010 09:12:58 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OMHLG-0005NX-3a for submit@debbugs.gnu.org; Wed, 09 Jun 2010 05:12:58 -0400 Received: from mx10.gnu.org ([199.232.76.166]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OMHLE-0005NS-OP for submit@debbugs.gnu.org; Wed, 09 Jun 2010 05:12:57 -0400 Received: from lists.gnu.org ([199.232.76.165]:48547) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1OMHLB-0001lg-RA for submit@debbugs.gnu.org; Wed, 09 Jun 2010 05:12:53 -0400 Received: from [140.186.70.92] (port=36933 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OMHL7-0000sJ-60 for bug-gnu-emacs@gnu.org; Wed, 09 Jun 2010 05:12:53 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM, T_RP_MATCHES_RCVD, T_TO_NO_BRKTS_FREEMAIL autolearn=unavailable version=3.3.1 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OMHL2-0003I9-1X for bug-gnu-emacs@gnu.org; Wed, 09 Jun 2010 05:12:48 -0400 Received: from lo.gmane.org ([80.91.229.12]:60480) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OMHL1-0003Ho-RC for bug-gnu-emacs@gnu.org; Wed, 09 Jun 2010 05:12:44 -0400 Received: from list by lo.gmane.org with local (Exim 4.69) (envelope-from ) id 1OMHKz-0000MK-JC for bug-gnu-emacs@gnu.org; Wed, 09 Jun 2010 11:12:41 +0200 Received: from garnet.epcc.ed.ac.uk ([129.215.56.222]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 09 Jun 2010 11:12:41 +0200 Received: from wence by garnet.epcc.ed.ac.uk with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 09 Jun 2010 11:12:41 +0200 X-Injected-Via-Gmane: http://gmane.org/ To: bug-gnu-emacs@gnu.org connect(): No such file or directory From: Lawrence Mitchell Subject: Re: bug#6378: all-completions Segfault Date: Wed, 09 Jun 2010 10:09:59 +0100 Lines: 14 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Complaints-To: usenet@dough.gmane.org X-Gmane-NNTP-Posting-Host: garnet.epcc.ed.ac.uk User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (usg-unix-v) Cancel-Lock: sha1:ECcwLU+JRcm/lEGQwWoC9mZDusc= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.1 (-----) Stefan Monnier wrote: [...] > IIUC this would only loop through all the buckets, without looping > through each bucket's linked list. > Compare (length obarray) > and (let ((i 0)) (mapatoms (lambda (_) (incf i)) obarray) i) That makes sense, thanks. Lawrence -- Lawrence Mitchell From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 09 06:08:54 2010 Received: (at submit) by debbugs.gnu.org; 9 Jun 2010 10:08:54 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OMIDO-0005nR-9i for submit@debbugs.gnu.org; Wed, 09 Jun 2010 06:08:54 -0400 Received: from mail.gnu.org ([199.232.76.166] helo=mx10.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OMIDM-0005nM-KE for submit@debbugs.gnu.org; Wed, 09 Jun 2010 06:08:53 -0400 Received: from lists.gnu.org ([199.232.76.165]:44296) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1OMIDJ-00036O-N9 for submit@debbugs.gnu.org; Wed, 09 Jun 2010 06:08:49 -0400 Received: from [140.186.70.92] (port=46816 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OMIDG-0006Z0-Vo for bug-gnu-emacs@gnu.org; Wed, 09 Jun 2010 06:08:48 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM, T_RP_MATCHES_RCVD, T_TO_NO_BRKTS_FREEMAIL autolearn=unavailable version=3.3.1 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OMIDB-0005Dh-0l for bug-gnu-emacs@gnu.org; Wed, 09 Jun 2010 06:08:46 -0400 Received: from lo.gmane.org ([80.91.229.12]:49463) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OMIDA-0005Cx-MH for bug-gnu-emacs@gnu.org; Wed, 09 Jun 2010 06:08:40 -0400 Received: from list by lo.gmane.org with local (Exim 4.69) (envelope-from ) id 1OMID9-0002V7-5T for bug-gnu-emacs@gnu.org; Wed, 09 Jun 2010 12:08:39 +0200 Received: from 178.211.85-79.rev.gaoland.net ([79.85.211.178]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 09 Jun 2010 12:08:39 +0200 Received: from thierry.volpiatto by 178.211.85-79.rev.gaoland.net with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 09 Jun 2010 12:08:39 +0200 X-Injected-Via-Gmane: http://gmane.org/ To: bug-gnu-emacs@gnu.org connect(): No such file or directory From: Thierry Volpiatto Subject: Re: bug#6378: all-completions Segfault Date: Wed, 09 Jun 2010 12:05:15 +0200 Organization: ThierryVolpiatto Lines: 26 Message-ID: <878w6ojzc4.fsf@tux.homenetwork> References: <874ohcbxfo.fsf@tux.homenetwork> <87d3w0k6tx.fsf@tux.homenetwork> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Complaints-To: usenet@dough.gmane.org X-Gmane-NNTP-Posting-Host: 178.211.85-79.rev.gaoland.net User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) Cancel-Lock: sha1:WskqxFuyExe1oYef/n3Q/VXrs0o= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-Spam-Score: -5.6 (-----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.6 (-----) Lennart Borgman writes: > On Wed, Jun 9, 2010 at 9:23 AM, Thierry Volpiatto > wrote: >> Lennart Borgman writes: >> >>> On Wed, Jun 9, 2010 at 7:13 AM, Thierry Volpiatto >>> wrote: >>>> (completing-read "test: " [1 2 3 23 24 34 26 40 28]) >>> >>> Does not that crash just because only symbols or strings can be keys >>> in the collection? >> I thought but it's worst, because: >> >> (completing-read "test: " ["1" "2" "23" "24" "25" "34" "45" "56"]) >> >> Also crash emacs. > > Yes, it expects an obarray, not a plain vector. Anyway if completing-read is not able to handle a vector it should return an error and not crashing emacs. -- Thierry Volpiatto Gpg key: http://pgp.mit.edu/ From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 09 07:45:52 2010 Received: (at submit) by debbugs.gnu.org; 9 Jun 2010 11:45:52 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OMJjE-00073P-1k for submit@debbugs.gnu.org; Wed, 09 Jun 2010 07:45:52 -0400 Received: from mail.gnu.org ([199.232.76.166] helo=mx10.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OMJjC-00073F-Ek for submit@debbugs.gnu.org; Wed, 09 Jun 2010 07:45:51 -0400 Received: from lists.gnu.org ([199.232.76.165]:37054) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1OMJj7-0004J6-5z for submit@debbugs.gnu.org; Wed, 09 Jun 2010 07:45:45 -0400 Received: from [140.186.70.92] (port=45063 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OMJgh-00071n-JJ for bug-gnu-emacs@gnu.org; Wed, 09 Jun 2010 07:43:20 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE autolearn=unavailable version=3.3.1 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OMJgg-0002ax-CX for bug-gnu-emacs@gnu.org; Wed, 09 Jun 2010 07:43:15 -0400 Received: from mail-out.m-online.net ([212.18.0.10]:49802) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OMJgg-0002Zr-7m for bug-gnu-emacs@gnu.org; Wed, 09 Jun 2010 07:43:14 -0400 Received: from frontend1.mail.m-online.net (unknown [192.168.8.180]) by mail-out.m-online.net (Postfix) with ESMTP id 758D41C0061D; Wed, 9 Jun 2010 13:43:06 +0200 (CEST) Received: from hase.home (ppp-88-217-109-91.dynamic.mnet-online.de [88.217.109.91]) by mail.mnet-online.de (Postfix) with ESMTP id 347731C000AF; Wed, 9 Jun 2010 13:43:06 +0200 (CEST) From: Andreas Schwab To: Thierry Volpiatto Subject: Re: bug#6378: all-completions Segfault References: <874ohcbxfo.fsf@tux.homenetwork> <87d3w0k6tx.fsf@tux.homenetwork> <878w6ojzc4.fsf@tux.homenetwork> X-Yow: Is there something I should be DOING with a GLAZED DONUT?? Date: Wed, 09 Jun 2010 13:43:05 +0200 In-Reply-To: <878w6ojzc4.fsf@tux.homenetwork> (Thierry Volpiatto's message of "Wed, 09 Jun 2010 12:05:15 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-Spam-Score: -4.6 (----) X-Debbugs-Envelope-To: submit Cc: bug-gnu-emacs@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.6 (----) Thierry Volpiatto writes: > Anyway if completing-read is not able to handle a vector > it should return an error and not crashing emacs. This is already fixed in emacs-23. Andreas. -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different." From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 09 08:13:40 2010 Received: (at submit) by debbugs.gnu.org; 9 Jun 2010 12:13:40 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OMKA8-0007GE-Fn for submit@debbugs.gnu.org; Wed, 09 Jun 2010 08:13:40 -0400 Received: from mail.gnu.org ([199.232.76.166] helo=mx10.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OMKA6-0007G9-FI for submit@debbugs.gnu.org; Wed, 09 Jun 2010 08:13:39 -0400 Received: from lists.gnu.org ([199.232.76.165]:59281) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1OMKA1-0005GY-5C for submit@debbugs.gnu.org; Wed, 09 Jun 2010 08:13:33 -0400 Received: from [140.186.70.92] (port=49124 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OMK9v-0007LJ-S8 for bug-gnu-emacs@gnu.org; Wed, 09 Jun 2010 08:13:32 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM, T_DKIM_INVALID autolearn=unavailable version=3.3.1 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OMK9u-0001Bv-L2 for bug-gnu-emacs@gnu.org; Wed, 09 Jun 2010 08:13:27 -0400 Received: from mail-wy0-f169.google.com ([74.125.82.169]:59494) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OMK9u-0001Be-Gs for bug-gnu-emacs@gnu.org; Wed, 09 Jun 2010 08:13:26 -0400 Received: by wyf28 with SMTP id 28so20685wyf.0 for ; Wed, 09 Jun 2010 05:13:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:from:to:cc:subject :organization:references:date:in-reply-to:message-id:user-agent :mime-version:content-type; bh=kdu0UCrwlpVGE4nmdXQcvOx6RPubVNojnd/K6QEt5Wk=; b=CqLCvmijROrDC5nOPlIIvgrqRC5g87g7xi1PkfEt72iYeytRhuhejzBW9sBirNuTtr 9pbRDaoFgWLWlHPQIdNctJgY4xEKdRI23pblqmeuv4r4lt37/F56vm4Uf1ys8rinx6f7 yzQxitl3NTqJ0HAywh7WJ5gKYJ95zdIUN7+MQ= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:cc:subject:organization:references:date:in-reply-to :message-id:user-agent:mime-version:content-type; b=BnLlinfrvE82Z28DnPzksNA5ed4IhfjjGiQU+4U6A+IueMPtC2qrW3dY6FuMe6bCuX DB8q99WeBIkbVymFzGrw++dlsYyMQIhE8TcpC7+IzqFw9k+dPpFT/b4lpzH8zyLHtM48 zDXRCsHRT/haVhlU2EwOCNJ14agXyn/A5DhQc= Received: by 10.227.157.198 with SMTP id c6mr2730618wbx.173.1276085108543; Wed, 09 Jun 2010 05:05:08 -0700 (PDT) Received: from tux.homenetwork ([79.85.211.178]) by mx.google.com with ESMTPS id b17sm12641931wbd.13.2010.06.09.05.05.07 (version=TLSv1/SSLv3 cipher=RC4-MD5); Wed, 09 Jun 2010 05:05:07 -0700 (PDT) From: Thierry Volpiatto To: Andreas Schwab Subject: Re: bug#6378: all-completions Segfault Organization: ThierryVolpiatto References: <874ohcbxfo.fsf@tux.homenetwork> <87d3w0k6tx.fsf@tux.homenetwork> <878w6ojzc4.fsf@tux.homenetwork> Date: Wed, 09 Jun 2010 14:01:52 +0200 In-Reply-To: (Andreas Schwab's message of "Wed, 09 Jun 2010 13:43:05 +0200") Message-ID: <87zkz4tnwv.fsf@tux.homenetwork> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-Spam-Score: -5.6 (-----) X-Debbugs-Envelope-To: submit Cc: bug-gnu-emacs@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.6 (-----) Andreas Schwab writes: > Thierry Volpiatto writes: > >> Anyway if completing-read is not able to handle a vector >> it should return an error and not crashing emacs. > > This is already fixed in emacs-23. I don't understand, it is fixed in emacs-23 and not in emacs-24? I am speaking of: GNU Emacs 24.0.50.1 (i686-pc-linux-gnu, GTK+ Version 2.18.9) of 2010-06-08 on tux -- Thierry Volpiatto Gpg key: http://pgp.mit.edu/ From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 09 08:14:05 2010 Received: (at submit) by debbugs.gnu.org; 9 Jun 2010 12:14:05 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OMKAW-0007Gl-T7 for submit@debbugs.gnu.org; Wed, 09 Jun 2010 08:14:05 -0400 Received: from mail.gnu.org ([199.232.76.166] helo=mx10.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OMKAU-0007GL-Hq for submit@debbugs.gnu.org; Wed, 09 Jun 2010 08:14:03 -0400 Received: from lists.gnu.org ([199.232.76.165]:59615) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1OMKAP-0005Gq-CS for submit@debbugs.gnu.org; Wed, 09 Jun 2010 08:13:57 -0400 Received: from [140.186.70.92] (port=49263 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OMKAK-0007ZV-AZ for bug-gnu-emacs@gnu.org; Wed, 09 Jun 2010 08:13:56 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE autolearn=unavailable version=3.3.1 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OMKAJ-0001HS-2A for bug-gnu-emacs@gnu.org; Wed, 09 Jun 2010 08:13:52 -0400 Received: from mail-out.m-online.net ([212.18.0.10]:34580) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OMKAI-0001H9-Pi for bug-gnu-emacs@gnu.org; Wed, 09 Jun 2010 08:13:51 -0400 Received: from frontend1.mail.m-online.net (unknown [192.168.8.180]) by mail-out.m-online.net (Postfix) with ESMTP id 7665E1C00612; Wed, 9 Jun 2010 14:13:49 +0200 (CEST) Received: from hase.home (ppp-88-217-109-91.dynamic.mnet-online.de [88.217.109.91]) by mail.mnet-online.de (Postfix) with ESMTP id 366D41C001E0; Wed, 9 Jun 2010 14:13:49 +0200 (CEST) From: Andreas Schwab To: Thierry Volpiatto Subject: Re: bug#6378: all-completions Segfault References: <874ohcbxfo.fsf@tux.homenetwork> <87d3w0k6tx.fsf@tux.homenetwork> <878w6ojzc4.fsf@tux.homenetwork> <87zkz4tnwv.fsf@tux.homenetwork> X-Yow: It's OKAY --- I'm an INTELLECTUAL, too. Date: Wed, 09 Jun 2010 14:13:48 +0200 In-Reply-To: <87zkz4tnwv.fsf@tux.homenetwork> (Thierry Volpiatto's message of "Wed, 09 Jun 2010 14:01:52 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-Spam-Score: -4.7 (----) X-Debbugs-Envelope-To: submit Cc: bug-gnu-emacs@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.7 (----) Thierry Volpiatto writes: > I don't understand, it is fixed in emacs-23 and not in emacs-24? Because nobody merged it yet. Andreas. -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different." From unknown Wed Aug 20 05:18:06 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 08 Jul 2010 11:24:03 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator