GNU bug report logs - #63778
[PATCH] Use comint-pager in eshell

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Jim Porter <jporterbugs <at> gmail.com>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#63778: closed ([PATCH] Use comint-pager in eshell)
Date: Wed, 23 Aug 2023 23:59:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Wed, 23 Aug 2023 16:58:07 -0700
with message-id <c28180d8-d64e-c529-4ab0-f66f150f4793 <at> gmail.com>
and subject line Re: bug#63778: [PATCH] Use comint-pager in eshell
has caused the debbugs.gnu.org bug report #63778,
regarding [PATCH] Use comint-pager in eshell
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
63778: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=63778
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Morgan Smith <Morgan.J.Smith <at> outlook.com>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Use comint-pager in eshell
Date: Sun, 28 May 2023 18:45:22 -0400

[Message part 3 (text/plain, inline)]

Hello!

I know many people set PAGER=cat for eshell so I wanted to add support
to eshell for this recent feature that was added (comint-pager).

[0001-Use-comint-pager-in-eshell.patch (text/x-patch, attachment)]

[Message part 5 (text/plain, inline)]

Thanks,

Morgan

[Message part 6 (message/rfc822, inline)]

From: Jim Porter <jporterbugs <at> gmail.com>
To: Morgan Smith <Morgan.J.Smith <at> outlook.com>
Cc: 63778-done <at> debbugs.gnu.org
Subject: Re: bug#63778: [PATCH] Use comint-pager in eshell
Date: Wed, 23 Aug 2023 16:58:07 -0700

Version: 30.1

On 5/29/2023 10:14 PM, Jim Porter wrote:
> There's probably a nice way to do this, but it might involve some tweaks 
> to how Eshell handles variable aliases in general. I'll look into it more.

Sorry for completely forgetting about this bug for a few months; I had 
some trouble getting a patch to work, then got busy with other things, 
and never picked it back up.

I've now merged an updated version of this patch as 08901e93797, so 
marking this done.

This implementation should be 100% backwards compatible, since users 
have to opt in to setting the new 'comint-pager' option, and even if you 
do that, it's easy enough to opt back out for just Eshell (set 
'comint-pager' buffer-locally to nil in 'eshell-mode-hook' or similar).

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.