From debbugs-submit-bounces@debbugs.gnu.org Sun May 28 18:49:44 2023 Received: (at submit) by debbugs.gnu.org; 28 May 2023 22:49:44 +0000 Received: from localhost ([127.0.0.1]:55098 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q3PCq-0005N8-0Y for submit@debbugs.gnu.org; Sun, 28 May 2023 18:49:44 -0400 Received: from lists.gnu.org ([209.51.188.17]:40950) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q3PCo-0005N0-Qk for submit@debbugs.gnu.org; Sun, 28 May 2023 18:49:43 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q3PCo-0006bO-Bz for bug-gnu-emacs@gnu.org; Sun, 28 May 2023 18:49:42 -0400 Received: from mail-dm6nam11olkn2082b.outbound.protection.outlook.com ([2a01:111:f400:7eaa::82b] helo=NAM11-DM6-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q3PCm-0007uU-LJ for bug-gnu-emacs@gnu.org; Sun, 28 May 2023 18:49:42 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OVXbfKK8z/ga45EJ2cgo1KfQ9pBDvRzrSDGqWjPJQSaJB8C+DqEFqq/PnGKfLRqQRGPP+4Z+kaeRBumzHIeQwsqfHdwphmq2rG9kcY/03KALzGSIdC/TZ41wQq54GWz/MudKLvSoCm8GTWv6uXj49EpMMQ7uKozh/MYagHPpg+W8bdaB3+L2rytcdCTrtwziinKUgGawjPScxibYiSMCB47pNfKpD64Afa+KgDDV3yi4W++OaM1UAyHIPNVWTAPj+GL7tymr5m9ABkR4TtvLRZUrNayOKt/eLIDiTzQJGkSABoJGZoM57IAqy42aU/JKEYHeeM55Jqi0qyYQVZ25UA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ih4Hup0m/Vf/roWgDGVT3/rMd9q1m3mQT7OYFZkA0yc=; b=eI41cHpm7CnAreEpUHx1UXfVvqrPZDS/L76gTOaFQpQf+55z8YiqmnSFdSTJtjx5tM14BEilBHbuPtxA4IzzuW7tzeHvwJDM0llBc0GzYJTUcIeKWYVzy8X/+5tFMQmPs2XN0f4LXhLmiQidHYt+2UknCmqLNLwaWZMpD43qE6NkVq/bAaSg6Lu7vXhI6ZyQwQrNPRxUvrbWd/oIKa5yxQj2Y036bIY3DhFtxmF0FGobQHOMHnXG1YHY/qm3tqeRvXjkzJUAkkjLGP7oGt3+pokrZ0X465cGqpIEFGr5o6Wy/73UaZeJ4EVpU1fqnPKp9hjpnd5+IOulMu6QYIDOhw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ih4Hup0m/Vf/roWgDGVT3/rMd9q1m3mQT7OYFZkA0yc=; b=TkgxzWC0vlS0thksJb2wjcEaliwdDsVVH0nI2Jm0MkISTYU54Sn0bR246kbK6If/ncoxZCGOYiT6xsgnij4Q8lDuRWDQZbutgyqYLKfj87Oef8JrKEQOtgXe4cwr/ILgkpo9izVOCOJzG45+cU4dxH0X6o4fmflrl3b5s4ktGLdxJGPJqTRuSxP3n/PD6LwD8MHb50WpgKSoE65as4An20hbSCIHTbrazEvSn4p3aNi+tWBKsEB290w1QS6NNlnIOZ/7Vo/d9MTXO/0PYKqwUn6LnoqwhgdEVwKEEGSLCgyGX9Ip3P02pGxYmQ5Oxnf845KgOqjSfA6sBu47H/VfrA== Received: from DM5PR03MB3163.namprd03.prod.outlook.com (2603:10b6:4:40::24) by DM4PR03MB6030.namprd03.prod.outlook.com (2603:10b6:5:391::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6433.19; Sun, 28 May 2023 22:44:37 +0000 Received: from DM5PR03MB3163.namprd03.prod.outlook.com ([fe80::d561:bdf5:3af9:b03e]) by DM5PR03MB3163.namprd03.prod.outlook.com ([fe80::d561:bdf5:3af9:b03e%4]) with mapi id 15.20.6433.022; Sun, 28 May 2023 22:44:37 +0000 From: Morgan Smith To: bug-gnu-emacs@gnu.org Subject: [PATCH] Use comint-pager in eshell X-Hashcash: 1:20:230528:bug-gnu-emacs@gnu.org::n3r3gaqf3g31hXZg:5jXS Date: Sun, 28 May 2023 18:45:22 -0400 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Content-Type: multipart/mixed; boundary="=-=-=" X-TMN: [Spa5ooKrkOU6xcSv1gt8e4jhV5e+zGYB] X-ClientProxiedBy: YQBPR0101CA0161.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c01:e::34) To DM5PR03MB3163.namprd03.prod.outlook.com (2603:10b6:4:40::24) X-Microsoft-Original-Message-ID: <87r0r0nkhp.fsf@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM5PR03MB3163:EE_|DM4PR03MB6030:EE_ X-MS-Office365-Filtering-Correlation-Id: a5376dbc-5105-4928-dee7-08db5fcd1d49 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: PtRY/1NrYP0bqmIPEpuvgvYu8lAfwcqAj7yL7DJNPRVnTrK74wPk8Pm5C+vDHg1lmbfZURnUsWYn+NR6JprSqus8e3bzkpsklu2Ol7MrVbBk5E6BSu0RbtwaFTV9muHtiu69+wMV1GOTLeO+HUovAl82Z+zxwLTqRHAPMPZ6LJawuHZQfbQzLB2IohbkKkqblGWKFH/ftsNYONAv/swe0ZX2SI0KzVz4xvoLY8iU2dCIHHWD70kRH1f0rzOph0lZsp8YVQ5/jow6xIdFNvqwgWW9+9z+Cr2nIzxBHUojT5wg1MLuKoPu5qwtARA+ILkwjsIBNTWJ3/rxNQgMhooAVamGFctx6Z9oHurDgt7szGCMbG55haxek5XPQJ42pSu/LicoP/HnbzpcqWJ9dgIgVeIdxkCsH3YerkJgF8VxuqB62/SvwWfFJJKuYyiKK3fD4pkAZZxHfYGmhvNLmwVlkjLF969NiP5knG+G+3fhP3cZpKUhsPEkDgrcWtgT+xPf6yK6mHjfg25cPfCSj18gtljQ5fdBpcrE7kPS1llAM6a+t0e+QINwRtaVTtYTNUZG X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?z78aVBw/7+Kz51hBUocg+Q9Yyi9ECaNB76evZ5dBHNH2ZV8Ym0ZSBedbkElJ?= =?us-ascii?Q?a8Oq2eq1X8nMwWuCxwonQdhdoRE8Bl6DnUyFdGf0TjR/CPVkIaiBrdSGwtjr?= =?us-ascii?Q?a7sjTQO4gH29uAILHpmeEPFZ2k35TUChvYpfwabc08J41rcSCopsenIXWLZS?= =?us-ascii?Q?jtPZRiWdHJIEpkSE7IOLc5KKFsKRsQNFyLb3L3bRYIMScCSnn6ZZkkSxQWzi?= =?us-ascii?Q?YMdgdbArIACbHkrci+ymyQrxNcJixr0GiSGyW9Z6qjbZq2XG7uTeplOKanR/?= =?us-ascii?Q?sy+/5avCkkILM9GVQQ0v4oeRyvPLUfhX7smx8kmZkb2vw0OPX5wEpkndLPNu?= =?us-ascii?Q?hGZZn7Ff9WsR4Xe4epOSj+i+5e51yGLf+j2rL+izC1jJvHRmSi/xIQpyIuQi?= =?us-ascii?Q?uU6pGmxymaD+Tz9zoVYVh6ByTRq8SJJSL4miiQY0a72MGPkWJAKSfRh2HUuy?= =?us-ascii?Q?oyZDSByJ6PgXcFOqGk8/AV+BcYD9W69WZrFA5dKmkv74CJuPhffpG15Z7S8G?= =?us-ascii?Q?ygmR9ApkOQEei0ZbL7Ml+Ic+OLW8XmCe7QTo1mSorkrYxd5ijFUbT9OpTqvg?= =?us-ascii?Q?29PRHIe4lKE9H4/KGwphV/FSmBKpYGxlHgd5htO1eIE3kQnocLh/ZcmQso+a?= =?us-ascii?Q?Fm0ahNo1Ag/26FsCu6gEtyyXvRkvcVTNQxtRMBZZZ0SeADbRSsGtH6jd7eiU?= =?us-ascii?Q?guhPOzPp0TXkNTUagjySzgx3fMDDbsPTwpdPjevo5WILj5WhX9sOEa2RKCYJ?= =?us-ascii?Q?gcrwrLH+8m0NtPcLh2offsRcQLArA12SAXldWw54xhRVHoPSV7OTitBlj3pW?= =?us-ascii?Q?ytV1zdgkynPeKf+Od4VvahWZ+iK718BZLtHvwHS10ZRJAexIHOarSnjwjn2+?= =?us-ascii?Q?rMUxnGUWqcPHXxFmFMmz3ob/TXqwrkp3Y5kTE1dzVVFjTMG8bIt/oNZ170jP?= =?us-ascii?Q?TDN4B8D+Bcx4QqLuY0s8LpFwiZD8Z/HYseNq6acBxn2M37XSsff8uqQqhbYJ?= =?us-ascii?Q?JgrHsAYOT+jCSEgQHXY2egNrqaoCdy8kPENg4P7DmrWWhqxDPevpf1rpVu1E?= =?us-ascii?Q?UzTU/oXpfA0FZuCOVLI+b5U2BhoCk+sTIUe4zNRxPcjH+b2fuwdZwY0O8obK?= =?us-ascii?Q?/rGoITEMIgjn9qxUKADSvmVvZRfi99nUH+PyyoCxbvWycqfSid+mHJKm8VLt?= =?us-ascii?Q?wseLWS0joczsLQDpjVIpNNJnOHfu3lBINP2EHZNEC3ElsjqgwvX3KwXsOg4?= =?us-ascii?Q?=3D?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: a5376dbc-5105-4928-dee7-08db5fcd1d49 X-MS-Exchange-CrossTenant-AuthSource: DM5PR03MB3163.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 May 2023 22:44:37.1862 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR03MB6030 Received-SPF: pass client-ip=2a01:111:f400:7eaa::82b; envelope-from=Morgan.J.Smith@outlook.com; helo=NAM11-DM6-obe.outbound.protection.outlook.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) --=-=-= Content-Type: text/plain Hello! I know many people set PAGER=cat for eshell so I wanted to add support to eshell for this recent feature that was added (comint-pager). --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Use-comint-pager-in-eshell.patch >From 9c22f6cc362d3ddb9fedffe4def4d80ddbe96598 Mon Sep 17 00:00:00 2001 From: Morgan Smith Date: Sun, 28 May 2023 18:40:49 -0400 Subject: [PATCH] Use comint-pager in eshell * lisp/eshell/esh-var.el (eshell-variable-aliases-list): Set $PAGER environment variable from comint-pager variable --- lisp/eshell/esh-var.el | 1 + 1 file changed, 1 insertion(+) diff --git a/lisp/eshell/esh-var.el b/lisp/eshell/esh-var.el index 7dcaff1e24f..fd2f92a0c31 100644 --- a/lisp/eshell/esh-var.el +++ b/lisp/eshell/esh-var.el @@ -162,6 +162,7 @@ if they are quoted with a backslash." ("COLUMNS" ,(lambda () (window-body-width nil 'remap)) t t) ("LINES" ,(lambda () (window-body-height nil 'remap)) t t) ("INSIDE_EMACS" eshell-inside-emacs t) + ("PAGER" comint-pager t) ("UID" ,(lambda () (file-user-uid)) nil t) ;; for esh-ext.el -- 2.40.1 --=-=-= Content-Type: text/plain Thanks, Morgan --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sun May 28 19:06:28 2023 Received: (at 63778) by debbugs.gnu.org; 28 May 2023 23:06:28 +0000 Received: from localhost ([127.0.0.1]:55585 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q3PT2-0005pp-60 for submit@debbugs.gnu.org; Sun, 28 May 2023 19:06:28 -0400 Received: from mail-pf1-f174.google.com ([209.85.210.174]:57673) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q3PT0-0005pc-Af for 63778@debbugs.gnu.org; Sun, 28 May 2023 19:06:27 -0400 Received: by mail-pf1-f174.google.com with SMTP id d2e1a72fcca58-64d3fdcadb8so1965835b3a.3 for <63778@debbugs.gnu.org>; Sun, 28 May 2023 16:06:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1685315181; x=1687907181; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to; bh=HF1mUSk6sC5LgdGRjlZ+o7U78BW6VYMmfGliIqlamkU=; b=PYqxX9IrvZDwmzfnSMGY/BEYrtvJWSgVybgr0KYBc18M/mFoik4eFhIWGra6ck+k7y CwoS+CBUqv03ZbItriVHR69lRSp0TniEEa0k9Qi99A6iB09a0EiP3r5MhsOMTkaH49AF zXBtOoLnGK0pEAiCezTXG6Mg/0jMWGvqmYXcH5WSu5bTcLwPJnDXa9+TvG3ns/lauXpD hA3wQ1Z0QwU4O3yp62DmDHCvswAUlOm0C8hEwqkHXDkI64q18mbJ5pbYTFzTLG2YPjOu RJGihdPrRyuVeIU7PbMiGMKcx1vIDSGcBTSe59JlDJubBvd7hKLtvWNixVJjvsg3XgEV tZ5g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685315181; x=1687907181; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=HF1mUSk6sC5LgdGRjlZ+o7U78BW6VYMmfGliIqlamkU=; b=B8JND3MWQy0eOBWwfyiSWZrbElw4zuluXRikcrYn1SUVWby1zWHKuqQX7S/JxueD5j qQS5Lm4/FB7tUtpDi5iN7P9R1AohK3A0c6bfHs4pMwvshhGeqF1+HIVo11zbLR/bw4yb OgHu18t9trukNRuaThK34TAJxZM9EVGAEfj6O3bTMkFHv+CNAd2jRBwfcPDvMDVUDlBs OsKRdXBRno5GRK9y2sRezSE0u61CoDCfNOFHIn2eCcZVOGdN5I1aNtUzwZk5SpyL0RDc ADOwN4YXBZRrid/3IIqnF/t6abMoONuyZrE3ComJlPOM0//QOZZ/eJ4EJ8NYK5+5Mlcx 4o8A== X-Gm-Message-State: AC+VfDzoVrMYgfuKY/CU+1qGkAT7IbyS7/FdNSJeGowvm56yxSzNDu15 9Rt9OGfSU5tswe0+JOmitaM= X-Google-Smtp-Source: ACHHUZ4Da8m8p9enmrpGWanYs/0kBsqPRMTBuMo2TQld5n31E1+4Rlv5LM8phVZgmkRK5BQv5P46pQ== X-Received: by 2002:a17:903:1112:b0:1af:b2d3:c6f4 with SMTP id n18-20020a170903111200b001afb2d3c6f4mr13070012plh.14.1685315180614; Sun, 28 May 2023 16:06:20 -0700 (PDT) Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id v5-20020a170902b7c500b001ae5fe602c3sm4824770plz.159.2023.05.28.16.06.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 28 May 2023 16:06:20 -0700 (PDT) Message-ID: <36a8613a-7601-14d5-c659-3bd86708b63b@gmail.com> Date: Sun, 28 May 2023 16:06:18 -0700 MIME-Version: 1.0 Subject: Re: bug#63778: [PATCH] Use comint-pager in eshell Content-Language: en-US To: Morgan Smith , 63778@debbugs.gnu.org References: From: Jim Porter In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 63778 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 5/28/2023 3:45 PM, Morgan Smith wrote: > I know many people set PAGER=cat for eshell so I wanted to add support > to eshell for this recent feature that was added (comint-pager). Thanks for the patch. While I'd use this myself, I'm not sure it should be the default though. Eshell lets you define visual commands ('eshell-visual-commands', 'eshell-visual-subcommands') that will open up in M-x term. That way, you can use "less" (or whatever your default pager is) as usual. If you set PAGER to "cat" or something similar, then you likely wouldn't get the benefit of this visual command support. Maybe we could do something where we set PAGER like in your patch, but only if Eshell doesn't think the command is visual? Perhaps you could keep the definition of PAGER in esh-var.el as you've done here, but then in em-term.el, add an appropriate override for it? That way, a user who disables the eshell-term module will always get PAGER=cat. Users who do use eshell-term would get a behavior compatible with visual commands. From debbugs-submit-bounces@debbugs.gnu.org Sun May 28 22:25:44 2023 Received: (at 63778) by debbugs.gnu.org; 29 May 2023 02:25:44 +0000 Received: from localhost ([127.0.0.1]:56717 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q3SZr-0002jj-Oq for submit@debbugs.gnu.org; Sun, 28 May 2023 22:25:44 -0400 Received: from mail-bn8nam04olkn2085.outbound.protection.outlook.com ([40.92.47.85]:3645 helo=NAM04-BN8-obe.outbound.protection.outlook.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q3SZq-0002jV-EE for 63778@debbugs.gnu.org; Sun, 28 May 2023 22:25:43 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OnyMK8g+y+lwvPFThUA+QGtrjSMMlz0bFJcptTRbREwe03uz5ghVEAhJNcd8wADnVbmq61VN4t4sKgOEf5jzyckjx1DHYEuUbzTX8tuLDPGT0EQSsf/Mu4WYFnEapTe5HotBarUOdaZOn8Q5tua5dQJ/NeKGu9m03KXkySOFj4achgm2/UfiCXHl2pbPeDumF4a7ziWAGTuSF0wexgmqgD3XBChHd18HU3NHuBAKiZyvIe8aR6fvxFM41n09zg9/wPXgOQisp6itkkXijAvVsyAqOrGF7d9R4MEQVJnhaiLTrjAbDUiz6Ukc+l1piHXdlw9YiQflyMxFNZwYHzjlNg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=qRPQ7spgchv8NyYkFlF+RN+Juh7gdpriVn0K9U6YJVY=; b=DaZdTX8X3WVQs/AkzN6hJBMPZJ9wyqVXAvse7GorGOaFhr0JVux+SH7W0vmPOO5g8zSCODLpfj7+0ECOiVDT+zjfnvKtRDdyrUpEtll90goaN7kFPFnkQK3tYa9r43XTjnvefJ2D6GZj6EHiTX0/9WsIdeFZU5IMjSzmDwkFXWTMH93w8kYsNfAmgfYEYOn+qIiZm+vhmyM4eZrw+X4MGIq5tWDUs5a5YJommpONEX5ahEq7e3SqQ6Mujs556b2lGbpSVRhZSZkZwRdrZqgWTYFtnHwNU/aSPOzFthizUytkXSZkJkDJefKw4x3yQnFRnUV871EHGEF/o7pMMuAYng== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qRPQ7spgchv8NyYkFlF+RN+Juh7gdpriVn0K9U6YJVY=; b=pohgPCyD9h+oqSh2DsqPuD0WpmIsJlTN4bUmNcbOomoOb//UowKqILqwHENc5FQisVCnJwW40g6UJ4mhRlQuYV6gIoTOJGvt/DPxuPA24mXN94qSHSUFx6tPs3Si6uz/N8+vJt2c4gtYEVBJNbQ+VE5Utkcp9V3LsFOS0jvTBdeio80rwsg164Bey8JgiS/W3ERYJNWPdwWTtS5pV0f1BarXL/IRuGPMMYHgBhksofvmuTXJ98s4Zehtv0B5cRtVJdlBJ2HXwoLb/C6CDzjM4DG+p9u2exQcTmoGXaPdpVv5rvpa4lMuOsm6UWU9SyDG/tDCHzCt05o/gEpkUGTVHQ== Received: from DM5PR03MB3163.namprd03.prod.outlook.com (2603:10b6:4:40::24) by DM6PR03MB5180.namprd03.prod.outlook.com (2603:10b6:5:1::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6433.22; Mon, 29 May 2023 02:25:36 +0000 Received: from DM5PR03MB3163.namprd03.prod.outlook.com ([fe80::d561:bdf5:3af9:b03e]) by DM5PR03MB3163.namprd03.prod.outlook.com ([fe80::d561:bdf5:3af9:b03e%4]) with mapi id 15.20.6433.022; Mon, 29 May 2023 02:25:35 +0000 From: Morgan Smith To: Jim Porter , 63778@debbugs.gnu.org Subject: Re: bug#63778: [PATCH] Use comint-pager in eshell In-Reply-To: (Morgan Smith's message of "Sun, 28 May 2023 22:09:52 -0400") References: <36a8613a-7601-14d5-c659-3bd86708b63b@gmail.com> X-Hashcash: 1:20:230529:jporterbugs@gmail.com::MPzg4XOif4g7MdjD:QN4 X-Hashcash: 1:20:230529:63778@debbugs.gnu.org::Iy45CTWLtmGERUxZ:1agq Date: Sun, 28 May 2023 22:26:14 -0400 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Content-Type: text/plain X-TMN: [6FNXUidKxocCqpGFRU5zsB2CkGylHBus] X-ClientProxiedBy: YQBPR01CA0125.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c01:1::25) To DM5PR03MB3163.namprd03.prod.outlook.com (2603:10b6:4:40::24) X-Microsoft-Original-Message-ID: <87353fna9l.fsf@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM5PR03MB3163:EE_|DM6PR03MB5180:EE_ X-MS-Office365-Filtering-Correlation-Id: 0a34319f-5861-416b-e710-08db5febfc10 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: X9BkU5ClXHhvOUlDNuiRwAGCRWY0eJAf4wiKOv5DZ3ENCSMBQi4M+ynOSinWosHrl75ZC8MDiNphSVqDpgDF71cyR/5WFcC+1dCUkVrwhaXi4ZzI8QsVT/7t5ECHwHCoPadz+XJwnxEEVp+w9WU2ds2nixqA14I62QYxvy3Gyqm/CIuPIZolYAZ6eGQUor/BK+eIA8M3SZwzhYV+l5BmfEuCqYQFPX84Bc6LFJqHperO6jvv28cjzDoJCLCXDGkSEJ4aG4jq5hA/K3SWYLH7aSpfusdJHDJGeHww/9nyP7Bgw7PtLBKZM/dHUxLhNVf4ZOxC9zg6C7/LL+QAySRCzRlq8PhQnwFwjzfXIsJ1PNJD/ZiYUVpl5qg7IN6T/9gTuuVrlM2RhoF5qYD/UGn4ty+1mhLZoCnw6nVb/LmX+/hKQqZkcK2+tnIk2N41GQej2bTSex/lqwVzdULN7ikqCaEy3ufZf7XmUn63FFOSMzFHQ6ub3GapCLPR4M9GRVOQUY5O6kp09r9tZ0AujsJHbp/YlqRR7T8DLoYB8HiwBPhMyeERb3i9cjz8psTYO0i37rYP+fP7hmeWIApE5R+Pn06wyDUp7YH5sVMDynpcV93juRzTxYGSs9mnBT/eW4SC X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?dC7jlNuX/idcLyqVJoj5KdDNemTEPCyzrYw7W1qX8LRLm85UoT+JhKPh0zIs?= =?us-ascii?Q?PZCePwNGWyEyUJSOcPz/lAeiBxFXdVGoTygHI6Qi0BDeWg1pv0M7ka6539Sj?= =?us-ascii?Q?jBEwHZVIFnb7oCl2V7sBFvw2hXoHNE4Gf0i+M62YxyOfw+/NfZSBlSK3cLPR?= =?us-ascii?Q?BFjLzlmdQHxTT2DtQNssWRNVCXb4mFb8SKy/lpAG+cMpiolQVfwvxHghpQWC?= =?us-ascii?Q?lfe2vd0yUs4WNLtR5Q6KvY9yHL+VD4ksqbpBzB91i7XRkWKNigE4xsHvSayB?= =?us-ascii?Q?lQlsKDC2L80w30U6xTnjsFXfI1W0b8wfxtuM5EbP72HojAbTsDq2QSD0Eqes?= =?us-ascii?Q?07EpVqgT2wFXrWZryos2pAt7WvKUMBr/HNl/pa8oaC72H9E6mrN8F6+XbryU?= =?us-ascii?Q?hz3AwvjhPQNurtikn8txiT6MyOfJyuVppCjdF2X9dcTOAvu7MiSw7FZKuYoI?= =?us-ascii?Q?4dI5YW4bSL/KbaMiajCJgCTxjfBQgCBv0YzuCTDmFN60jUV97cCvLzF73LHo?= =?us-ascii?Q?kJHsYKGGPoMx2Dx7lXxw39FDCOpVgF5UnQQSo6wPmsLJ6TRAl88FW4PzRkJw?= =?us-ascii?Q?vEVfx/0x7EGOQe/8CMMe6h9/5QGY0k9nNvy8+ouVTxk/oRjaD0ujVCp4JE4w?= =?us-ascii?Q?aLn6zKlsaTyae0eIOGEvDPEgPsFN9hrqIULDQ5bgycbZXRLeRlRSynD0v66S?= =?us-ascii?Q?MbWCHGYlRkAQ1oLUH7EUdxdrp41KjA339OHndN+1Q5sd0vLyU95iC11pO8kq?= =?us-ascii?Q?UjVfmZ/v4rzdivKxbyWxhQ01eQh1llNyOZqlTrrvry7WGEb6NSTXET1QCFNA?= =?us-ascii?Q?8Dlh64i0ZtvtILbP/S5BtrRb6/O/go0EsMhsO9cXVTD875a+Weotd2hxRV3n?= =?us-ascii?Q?KFG+ozKd4ocP7ZEcs5nDvsQU+1IadyJufTtBQ4YRmG4GOqLQ4XCXo7Phvkdc?= =?us-ascii?Q?+rj8qDbUMpPdUcSwR+KlLU+ph74wVUvsA69f59ReW+Sj+XcdWKgBsXRHKZWo?= =?us-ascii?Q?NnONFDSs/lJwwdK8v+3qiSDAaCabwnbqSjR2R7+/0wU38u26OPMbRYP8cI5n?= =?us-ascii?Q?Nq0jzPQwIgujIjjAg+Wwg6M0bCtUa0EnYIkoPGYptMJrS8ccUhC9u5D+rqJk?= =?us-ascii?Q?rQx8/VLAgrDxiPCfb9nrLimYOjvovCpl9iXj3/RrUaWOotxu1Ah05+0MfhAz?= =?us-ascii?Q?DiNQvoXuearYkfCjiwFvqzxJwqzALeHin0E0qghLmQUM5OwNiWu4XD4JTv8?= =?us-ascii?Q?=3D?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0a34319f-5861-416b-e710-08db5febfc10 X-MS-Exchange-CrossTenant-AuthSource: DM5PR03MB3163.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 May 2023 02:25:35.7531 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB5180 X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 63778 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) This is my very official petition to change gnus defaults. I have added this to my config to avoid future mess-ups. (keymap-set gnus-summary-mode-map "R" #'gnus-summary-very-wide-reply-with-original) Morgan Smith writes: > Jim Porter writes: > >> On 5/28/2023 3:45 PM, Morgan Smith wrote: >>> I know many people set PAGER=cat for eshell so I wanted to add support >>> to eshell for this recent feature that was added (comint-pager). >> >> Thanks for the patch. While I'd use this myself, I'm not sure it should be the >> default though. Eshell lets you define visual commands >> ('eshell-visual-commands', 'eshell-visual-subcommands') that will open up in >> M-x term. That way, you can use "less" (or whatever your default pager is) as >> usual. If you set PAGER to "cat" or something similar, then you likely wouldn't >> get the benefit of this visual command support. >> >> Maybe we could do something where we set PAGER like in your patch, but only if >> Eshell doesn't think the command is visual? Perhaps you could keep the >> definition of PAGER in esh-var.el as you've done here, but then in em-term.el, >> add an appropriate override for it? That way, a user who disables the >> eshell-term module will always get PAGER=cat. Users who do use eshell-term >> would get a behavior compatible with visual commands. >> > > I haven't the time left in the day to investigate the conflict between > visual commands and this patch (which I will do) but I would like to > comment that I believe most users will use one or the other, not both. > Unless pagers offer features I'm unaware of, I believe it is a better > user experience to simply dump everything into the current buffer and > use Emacs as a pager. For very visual command like pulsemixer that use > ncurses stuff I don't believe having $PAGER set would really affect > anything. So I would like to ask, does anyone actually want to use the > visual command stuff just for paging stuff? > > I would also like to point out that the default value for comint-pager > is nil so people would have to turn this on manually. If the usecase > for comint-pager is significantly different between eshell and other > comint stuff we could consider a new variable specifically for eshell. > Personally I don't see a big difference between say ielm and eshell so I > would like to avoid this but I'll bring it up regardless. From debbugs-submit-bounces@debbugs.gnu.org Sun May 28 22:41:49 2023 Received: (at 63778) by debbugs.gnu.org; 29 May 2023 02:41:49 +0000 Received: from localhost ([127.0.0.1]:56727 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q3SpQ-0003Ct-Rn for submit@debbugs.gnu.org; Sun, 28 May 2023 22:41:49 -0400 Received: from mail-pg1-f182.google.com ([209.85.215.182]:42281) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q3SpP-0003CV-0s for 63778@debbugs.gnu.org; Sun, 28 May 2023 22:41:47 -0400 Received: by mail-pg1-f182.google.com with SMTP id 41be03b00d2f7-53f70f5ef60so606995a12.1 for <63778@debbugs.gnu.org>; Sun, 28 May 2023 19:41:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1685328101; x=1687920101; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to; bh=lbj0qt9z/dFSfJBerLhFPUb0rpWPgQmDVtaRtCAC2q8=; b=HRWjxGroUj9nUVqhyWDkU1UL4jvfmbvkxLTvROjDXIoS6ZyXYd4k7fXbSJ5mKskoro Z5PaLD9p2ZQtfSgCsn8+a5/stA5taxsrBq8RNdCyCBT6ZIrdCjGzmXOBqtMth+U96cqp WpLeLrsAUuRfvVxRhc3mRFQZiNhHuKex/K2mhjctENmyO2lAtNO5fCsmWjdKVccHm6ta tPtk+Xlq1312eJ8pb85wEZSLzIKSmes1Jv/h4XAMNZQffTYtUmmPnDUmWgL/dgeJYUvi GFx/+2hcrDyLiv1D46elvqsxdFcR+xw8Bmw5A+LAXlj91xI31kakAmuQTEd/CsFAJmP0 ZGwA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685328101; x=1687920101; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=lbj0qt9z/dFSfJBerLhFPUb0rpWPgQmDVtaRtCAC2q8=; b=DLVvmOSU7dgi214NFe1r/xqDoM9sOiV2MKJr4E3qwSOu6Y8n2EXDKjhgKEDXurkkgH Jb1wKWSTChOcf3yyrZDtct2HouLbFTV4QFpDblEiMnDqKKh7//2qV7HFwm/b03uys3St HPlShyWgKe906b5dJWTfvge3VkTkEdBwahyGqsRy8OHHofm6aMOI0HbjgvH90iJtTnZw HvZ0spgPd4v8tlJ6QwYT1Mt8cRlOLU9baGc5AyIbD21r4dcy8MO20QeR9MCY9bw70hsS YmnnW+q3H3yqr9GutGrl63UYSb6NQfNGC7TNyr4p5nPyUaIiH2iXLG6Qy6xrJinxVya7 kRjg== X-Gm-Message-State: AC+VfDzKglj0lR9RJDqxCFDsrRtRk3jBkjjB2avRARjlq5/v0JsINWiq UNYRFSWQi1l4Be3C0snJZ7c= X-Google-Smtp-Source: ACHHUZ5wO6MlnszqeJbR0bUrZWvN67bWHlM+lC5Jt9KvsNYXQjWbcsGsWH9l78IGQaNSHcNcMzZsyw== X-Received: by 2002:a17:902:ecc2:b0:1ac:750e:33d6 with SMTP id a2-20020a170902ecc200b001ac750e33d6mr7522210plh.23.1685328100809; Sun, 28 May 2023 19:41:40 -0700 (PDT) Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id p4-20020a1709028a8400b001acae9734c0sm1635997plo.266.2023.05.28.19.41.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 28 May 2023 19:41:40 -0700 (PDT) Message-ID: Date: Sun, 28 May 2023 19:41:40 -0700 MIME-Version: 1.0 Subject: Re: bug#63778: [PATCH] Use comint-pager in eshell Content-Language: en-US To: Morgan Smith , 63778@debbugs.gnu.org References: <36a8613a-7601-14d5-c659-3bd86708b63b@gmail.com> From: Jim Porter In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 63778 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 5/28/2023 7:26 PM, Morgan Smith wrote: >> I haven't the time left in the day to investigate the conflict between >> visual commands and this patch (which I will do) but I would like to >> comment that I believe most users will use one or the other, not both. >> Unless pagers offer features I'm unaware of, I believe it is a better >> user experience to simply dump everything into the current buffer and >> use Emacs as a pager. For very visual command like pulsemixer that use >> ncurses stuff I don't believe having $PAGER set would really affect >> anything. So I would like to ask, does anyone actually want to use the >> visual command stuff just for paging stuff? I'm not personally a fan of visual commands in Eshell, but the docstring for 'eshell-visual-subcommands' suggests adding the various Git subcommands that invoke a pager into that list, so it seems that Eshell *assumes* people would want this, at least... >> I would also like to point out that the default value for comint-pager >> is nil so people would have to turn this on manually. If the usecase >> for comint-pager is significantly different between eshell and other >> comint stuff we could consider a new variable specifically for eshell. >> Personally I don't see a big difference between say ielm and eshell so I >> would like to avoid this but I'll bring it up regardless. Ah, in that case, then I think you'd want to change the logic in esh-var.el so that, when 'comint-pager' is nil, $PAGER returns the real value of PAGER from the environment. Since this behavior is opt-in, I think it would be enough to just make this fix (and ignore the visual command stuff), though special handling for visual commands would still be nice to have. From debbugs-submit-bounces@debbugs.gnu.org Mon May 29 02:23:13 2023 Received: (at 63778) by debbugs.gnu.org; 29 May 2023 06:23:13 +0000 Received: from localhost ([127.0.0.1]:56931 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q3WHh-0000s5-2T for submit@debbugs.gnu.org; Mon, 29 May 2023 02:23:13 -0400 Received: from mail-bn7nam10olkn2044.outbound.protection.outlook.com ([40.92.40.44]:24929 helo=NAM10-BN7-obe.outbound.protection.outlook.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q3WHe-0000rs-KG for 63778@debbugs.gnu.org; Mon, 29 May 2023 02:23:11 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mCBJw8Nwdv/lY+i2LDi5lbQJk5dbD0pYLMsDhqNIkubbcY8dYPvxFip2Ob9pxvlhON2mkPs9yt9Dyks+y7jh7tC0uCab8PydK72V68+7T6kcmhhX10esiBEBMbmM6vmZUqGPl3kaT/NjZ63XfOXWk13EO3mG33DNVLzU0+jRhVRHfQ1Y3a0rE4XGj9epKHRhXiF8gaijCfsidSUd/YEZFqKl5I5Nyd3VMBX6ISqW4TP+VQcD+4ok7KgQWtcBLrqJP0I2vzTvWr8atMLdNI0alnmipcbz38OAKJ1IwohRFhi26/xyrJo9rNhFThu8/hz3DVi1hkVqcG7SkihiMzsoIw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=u7SkPuEFE2Qg5ftxxk8btK5PlKVJgLVUlY8JwErLbnc=; b=DyB5aOKOaP0RDR5e0D4hq05t535rlTBCWZQOyXeWGzxDKMelxHayh7ufN2kpgTcYOEiXdyz+x9kwADe1zyY+1tAh8topCIM8KiGsMdsQN87Rt1cp5tSJWST3vhXzKHWUAgjd7u9RFq8ai7WS4Uy2WTph9antvJzvxul8ii2IwzQswD4bH+1BfpZcCik2VW+qSEKhfU6MDTofKUs1gGEYAcnZ4LgM+LQGBV9vXbVKQ7ShHpsx3KNLBLw983BQWIGTVqn9Mpd4L0wVboIQgwM023bc8qAlfze2kjtoEUH0KbUUfarw1oxNKmIF8HJIYelPA5maSHJ/dBlr2FrmUPf8vg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=u7SkPuEFE2Qg5ftxxk8btK5PlKVJgLVUlY8JwErLbnc=; b=CtWojGVc+tL9QCtFKLBlyNj0fm8bwyhkjf31ZikWCyPp05vZJORQs9OLtdemZf4R65eqng/JHIu17p1ms//aC8CcZNgYQMCWr2rRdL40b0eFt+3RaHJHCkiz/5iP6PygRAC2C3dyYkbDeqNkT1nk4gkuGHW9XvJ00wzhLCxqO1PhU8fR/OrA2yk5NYcyrCxUJXUnHJ5rK1iEssm7bw+9NrvZeHUnIT/7xnDqQHNcSi4gBgHBk32UTygngeZL56flYzJ3P4vUtFc73sWq27e9UswsB8dvsdg+hUGh6rPyeT4yYA01dSYVRAzSAMl64Rcw1Yn6zhlwYrDtlA25qyCcwA== Received: from DM5PR03MB3163.namprd03.prod.outlook.com (2603:10b6:4:40::24) by CO6PR03MB6260.namprd03.prod.outlook.com (2603:10b6:5:355::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6433.23; Mon, 29 May 2023 06:23:04 +0000 Received: from DM5PR03MB3163.namprd03.prod.outlook.com ([fe80::d561:bdf5:3af9:b03e]) by DM5PR03MB3163.namprd03.prod.outlook.com ([fe80::d561:bdf5:3af9:b03e%4]) with mapi id 15.20.6433.022; Mon, 29 May 2023 06:23:03 +0000 From: Morgan Smith To: Jim Porter Subject: Re: bug#63778: [PATCH] Use comint-pager in eshell In-Reply-To: (Jim Porter's message of "Sun, 28 May 2023 19:41:40 -0700") References: <36a8613a-7601-14d5-c659-3bd86708b63b@gmail.com> X-Hashcash: 1:20:230529:63778@debbugs.gnu.org::2Kdnv1H282vEWlEl:5Y/H X-Hashcash: 1:20:230529:jporterbugs@gmail.com::Z1HH1Mtj4m16g6Hv:Csll Date: Mon, 29 May 2023 02:23:31 -0400 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Content-Type: multipart/mixed; boundary="=-=-=" X-TMN: [g+07Goc8DBcWeYhItFucCjN/vus4AvOD] X-ClientProxiedBy: YQBPR0101CA0164.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c01:f::7) To DM5PR03MB3163.namprd03.prod.outlook.com (2603:10b6:4:40::24) X-Microsoft-Original-Message-ID: <87a5xnk658.fsf@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM5PR03MB3163:EE_|CO6PR03MB6260:EE_ X-MS-Office365-Filtering-Correlation-Id: 16ba4ea0-db05-41fe-5023-08db600d281e X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: BZBpZCbyvuOdCCPNicFV1yO89uI9FZ9OwnsrapjFiKaW3PawEGwwWnmzV2aXfVPfFV1Ye/CJcAa9+U59dMMTIvWExe2tTtD8EBuAE32pnJGIF71yDHHPmynKWCS8g0rV9GntkbM9ii7mV2185yCZOAvXp9q+RAiVgrQ1tMSkYGSpOgALP4VU4Yzo1GAin++XIwiRoiFiQWDT/5G656Ut0K9GZrY3JtH+ZwjA8U8fal2HNxu9Pd75XwHQm0FSra2t5IZONJBbdI55u5ANC4ANHralWZvusSrh7r5oqhHPahX8Uz9ZrM5LIxCbJmUgoOc6Bde6LE49dqiQmfx3ReBdKG36niSdo71OM7t7xZFNRO9xGyE8KcFCiIjil8t9QIJuJgJ7jyAG9kOd3YOJXRCw/RXDrCWJIO5zWZTNZ5AZu75RIbGVgACngFGECtnsz+lYmRW7+rJOirklt4hB8hfV7oI9Inu/rOvVSPi4eca44rBBCLAwmZJjdWjhwwaMx189t95IQH9K2q4Jm/E9DBValiUDcCEH8kmnP51zFCHuRuSFiWk1QXGAu1ckLRcJ1agga1pdQAl7mUud7ZiPGKI+XiV/fCYknD1RsEgCEcWB649e2UY1Wm5sGvsByYF6Yjl+ X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?R7ESrxtPrp7WdkOb3cc9PTAg21DLXJjdknQQNS2wjNFPEHlChTRfMxk+u6tn?= =?us-ascii?Q?XQVqj32R7f/KaOgm4N6R7giFM4IF7Xcl5lj037wbcTsUseKy7pAkOih8inLp?= =?us-ascii?Q?lKNv4cNO1Fi9EYLlnU7ui5hc48Wye8TMqSgpQt336sR6ocyNhurWOcl1DWOZ?= =?us-ascii?Q?9lU6Uj5KrGJqs6/cpZYmcn0H7gQJ1yXPSzpFJrz5hPDeMZ8+qbMeO36vsRpx?= =?us-ascii?Q?de6C7nbxTAbkbSqYlUvr/nDmdnLno0Z7PzlMSKOwIwXqsZNAYx1BQuAdJhkw?= =?us-ascii?Q?F9R9nHL8BSLVMtIStUClAXNMvu9YOZT+G29H03xdQi3d0wZ1kXG+F5cWKWDr?= =?us-ascii?Q?4c23JggNidzIxKzKVBJQ9H5Drg6e5UYII/9r1s5JJbCkPHs3/39R2pEKzRVw?= =?us-ascii?Q?XmYItqiGou3EzKOPrbhHD8UFOeSgrUIrCb+ADSWFXPIDzYdze9c67NsigZHL?= =?us-ascii?Q?SfRSV6GAd7Kn7YXkzSan4L7fnS1KtUSrBjV1F4huMEcxwqCr0fqMJDJ6ZOOT?= =?us-ascii?Q?2I0njIWZ7lJg6A4rxlbSLOznrxsv5HXcnx/7gsO1eaGyMkpW6fJe7nWIJaxP?= =?us-ascii?Q?0V1+yZAd3HNHhSM6fNA13xIViVgs2Ay60acwiVWW2VptLnh2TG9V37EMRcia?= =?us-ascii?Q?eZvE8U6pCt4V4aQtAZFveVBylZcoNcomZU9MJ0i3G0K6gMSxQuS4iKVjDp2x?= =?us-ascii?Q?bdwG9qO0H+0k1WegDnKTnwKufIoJ2BlOwILD/6xgi4tZn5VRWgaWtx3RxPmu?= =?us-ascii?Q?pwr8V+7afoNBJl9pIjsW80RbFS+gn8xkZg0UJNiNrwNDrJliqDC6GPkAwqM7?= =?us-ascii?Q?YvKr8wJRSIWL5WBF7BQeSEjaU5LKTj0wkrX8SY24h1CXUm5lnYgG/3/mlHfL?= =?us-ascii?Q?zBV1+4FRDT2+GMc8YHTvEdla41p4Vdxc+tLO/qLfWOegjji0eACyLyOb8xK3?= =?us-ascii?Q?1kb1fprTxy8PXPlJHLTuGhvmhCw/2P1nkCOMRoSA7d/1e3rnSfcTaSJaXchW?= =?us-ascii?Q?6HVLGcqeqCykc9Ztg85RuE4LjKKpuIiKgCsXmPYuvLLceVTrXPg7E8S44/bW?= =?us-ascii?Q?U/3yyMgVQD0txvcw0G6/ZOp5gI0c2N2l8w3ojlcRjMiclnjidBiNg0GDwcR4?= =?us-ascii?Q?HhFxOBSOzPIOnxSeGZSjRhZDO5UV1GrmO4PVIGkb88J/I2x3KYZ/yBD+KYfY?= =?us-ascii?Q?bEdAXfOT9wunhjFJwBD1aB3cyrxLyIWSJektqER0Up5PH2gfAQ2p+HRfs5k?= =?us-ascii?Q?=3D?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 16ba4ea0-db05-41fe-5023-08db600d281e X-MS-Exchange-CrossTenant-AuthSource: DM5PR03MB3163.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 May 2023 06:23:03.9276 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO6PR03MB6260 X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 63778 Cc: 63778@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain Jim Porter writes: > > Ah, in that case, then I think you'd want to change the logic in esh-var.el so > that, when 'comint-pager' is nil, $PAGER returns the real value of PAGER from > the environment. Since this behavior is opt-in, I think it would be enough to > just make this fix (and ignore the visual command stuff), though special > handling for visual commands would still be nice to have. > I decided to work on this instead of sleeping so I apologize if these patches are of poor quality. I still haven't looked into how everything interacts with the visual commands but it took some real effort (maybe because I'm tired :P) to get what I got so far and I think it's good enough. My main pain point was trying to figure out how to maintain the ability to set/unset the PAGER variable. These current patches allow you to set/unset the PAGER variable iff you don't set comint-pager. It even allows you to do stuff like 'PAGER=cat git log' (see eshell-handle-local-variables) without modifying buffer state (as it should). Maintaining those capabilities when comint-pager is set seems very difficult so I gave up. Trying to setq-local comint-pager in the set function might honestly be a better user experience for those that set comint-pager but then doing 'PAGER=cat git log' would cause a permanent buffer local change. So currently everything works 100% great and as expected if comint-pager is nil. If comint-pager is not-nil then you cannot set PAGER in a way that will take any affect. --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Fix-infinite-loop-in-eshell-get-set-variable.patch >From 506849752916ac016457d891f4378d7d2116b0df Mon Sep 17 00:00:00 2001 From: Morgan Smith Date: Mon, 29 May 2023 02:04:42 -0400 Subject: [PATCH 1/2] Fix infinite loop in eshell-{get|set}-variable * lisp/eshell/esh-var.el (eshell-get-variable, eshell-set-variable): Short circuit if the name and target are the same. --- lisp/eshell/esh-var.el | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/lisp/eshell/esh-var.el b/lisp/eshell/esh-var.el index 7dcaff1e24f..ecb0dfe274b 100644 --- a/lisp/eshell/esh-var.el +++ b/lisp/eshell/esh-var.el @@ -682,6 +682,8 @@ If QUOTED is non-nil, this was invoked inside double-quotes." (funcall target indices))))) ((symbolp target) (eshell-apply-indices (symbol-value target) indices quoted)) + ((and (equal name target)) + (getenv target)) (t (eshell-get-variable target indices quoted)))) (unless (stringp name) @@ -724,6 +726,8 @@ to a Lisp variable)." ((and eshell-prefer-lisp-variables (stringp target)) (eshell-set-variable (intern target) value)) + ((and (equal name target)) + (setenv target value)) (t (eshell-set-variable target value)))) (cond -- 2.40.1 --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0002-Use-comint-pager-in-eshell.patch >From 01a9f036988bfa3d00b9d837dbacb2666918bc2e Mon Sep 17 00:00:00 2001 From: Morgan Smith Date: Mon, 29 May 2023 02:06:48 -0400 Subject: [PATCH 2/2] Use comint-pager in eshell * lisp/eshell/esh-var.el (eshell-variable-aliases-list): Set $PAGER environment variable from comint-pager variable --- lisp/eshell/esh-var.el | 1 + 1 file changed, 1 insertion(+) diff --git a/lisp/eshell/esh-var.el b/lisp/eshell/esh-var.el index ecb0dfe274b..b036024f065 100644 --- a/lisp/eshell/esh-var.el +++ b/lisp/eshell/esh-var.el @@ -162,6 +162,7 @@ if they are quoted with a backslash." ("COLUMNS" ,(lambda () (window-body-width nil 'remap)) t t) ("LINES" ,(lambda () (window-body-height nil 'remap)) t t) ("INSIDE_EMACS" eshell-inside-emacs t) + ("PAGER" (,(lambda () (or comint-pager (getenv "PAGER"))) . "PAGER") t t) ("UID" ,(lambda () (file-user-uid)) nil t) ;; for esh-ext.el -- 2.40.1 --=-=-= Content-Type: text/plain Thanks, Morgan --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Mon May 29 07:46:10 2023 Received: (at 63778) by debbugs.gnu.org; 29 May 2023 11:46:11 +0000 Received: from localhost ([127.0.0.1]:57261 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q3bKE-0004VS-L0 for submit@debbugs.gnu.org; Mon, 29 May 2023 07:46:10 -0400 Received: from eggs.gnu.org ([209.51.188.92]:40708) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q3bKC-0004V9-JG for 63778@debbugs.gnu.org; Mon, 29 May 2023 07:46:08 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q3bK6-00044s-3Q; Mon, 29 May 2023 07:46:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=RCzI0H310Qf26xmU4rCk20B0Ld8zYocByS0djFmV8aw=; b=GHs7XUnTgM2V rvSOxl3M/DMP3cTUk3Plfik+DWNBJeMwFdUwAp0IgZ7/VKwWts2ZVDSj3cALT4c2JbZYF0oQEnRkr JPYDQ+CxcQ5yzE5/UqxeRJxloFm8VgorjngHf1g0OmfHzzhPs1lx0pX7MIM93h3TyeolQZsL3kLtx /3yJirvRAPDnjQXujgElnZTjIHXiHCnrlPM3IETEQoLIyRBT2CmjjwFnETe0+WMhMonTvn8Zp9Y4Z iAOubgECHkgub7Ij/l0u/XnMUwpQr3GnKD4SWYL2oiaOTXyAHDo4risCNnopKYuL1hmkkd6+sICEJ w2AgbDK+nfPWPjW4xtQxGQ==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q3bK2-0006Iz-N7; Mon, 29 May 2023 07:46:01 -0400 Date: Mon, 29 May 2023 14:46:37 +0300 Message-Id: <83ttvvgy1u.fsf@gnu.org> From: Eli Zaretskii To: Jim Porter In-Reply-To: <36a8613a-7601-14d5-c659-3bd86708b63b@gmail.com> (message from Jim Porter on Sun, 28 May 2023 16:06:18 -0700) Subject: Re: bug#63778: [PATCH] Use comint-pager in eshell References: <36a8613a-7601-14d5-c659-3bd86708b63b@gmail.com> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 63778 Cc: Morgan.J.Smith@outlook.com, 63778@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Sun, 28 May 2023 16:06:18 -0700 > From: Jim Porter > > On 5/28/2023 3:45 PM, Morgan Smith wrote: > > I know many people set PAGER=cat for eshell so I wanted to add support > > to eshell for this recent feature that was added (comint-pager). > > Thanks for the patch. While I'd use this myself, I'm not sure it should > be the default though. Yes, doing this by default would be an incompatible change, so we must make this optional. From debbugs-submit-bounces@debbugs.gnu.org Tue May 30 01:14:27 2023 Received: (at 63778) by debbugs.gnu.org; 30 May 2023 05:14:27 +0000 Received: from localhost ([127.0.0.1]:59810 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q3rgg-0007pI-RL for submit@debbugs.gnu.org; Tue, 30 May 2023 01:14:27 -0400 Received: from mail-pf1-f182.google.com ([209.85.210.182]:46461) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q3rgf-0007p6-Fc for 63778@debbugs.gnu.org; Tue, 30 May 2023 01:14:25 -0400 Received: by mail-pf1-f182.google.com with SMTP id d2e1a72fcca58-64d2a613ec4so2885822b3a.1 for <63778@debbugs.gnu.org>; Mon, 29 May 2023 22:14:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1685423660; x=1688015660; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to; bh=n9KhYgya0cJftKkpqnJVU7mtlVXs0uZNISZKwkzr8Ek=; b=jZASoLX3K+ChYEPouHJhNzta8SEBv9aS0KCVAHlDMY25WJsQlSawNeGrfStGQ96hSA 45t733/+Pz9Qd5lZ1Ay8hptCQcel3sVeQcteGnYKAb/fPBCfbpts66UCgmlx3Ws8M3nO XDbjRlkZioPIZBsy6Z9QfVm1ZD4ABYfp8gaWVGlGGLwMP2Xv80UhhhZU7yeeVpVfG8KU pCKvATWebdtgZCRfwdH+kgekdMMcGdL9Te716+FiEatlL8dsRvKqKc4hJ3vTU0cVmyog F7nMWnU5mit2UpfMDk7+nlKb4o9306zDuaQ737XRp09Vxum7tsEUXAcnEnVqLBQk5R/u aY2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685423660; x=1688015660; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=n9KhYgya0cJftKkpqnJVU7mtlVXs0uZNISZKwkzr8Ek=; b=AExcUG/JwDWPDfS/toOmILBQo9GqPWui3PMqsLMjzFDcuWKUkwAJPBDSz9IYT4BofT kQp0pAUg9xQIJE4CjbYqlg0X5ddZymtzGTO7htO1yIAMZYeZs5zKALPfz81gOv+KOVdI ynw0JwEeodtqJVUqAk1H9WjFdLopAWPwxORDWXhA245GcZLZcPO6ZXsf1gTWDJPGXozY Qn9H3dQDU5TrrSubbwxfYATT4CRqLCcZ2xuybpThDsNl8prsQT6sajq8+HfJ68lMsnwA ovmKiTCvPsgSnVkf1A/LgPQfvdpX66hfM5FYzxxiNpunLFSQMWBg0vhy7cYpHOoFaDYZ j0IA== X-Gm-Message-State: AC+VfDz2UQLMLDDXmycL1rmZP38MhUg19QwyUybi/kjc5If+g3jTYPhG zZVWegQ75WxM10lFt3oAtDc= X-Google-Smtp-Source: ACHHUZ5eCQ/E64Nsg3d5jsXPhpS8MjlcT7YhZpwcLrc1CHPc/1AjwXDim8I6wb6XGQxzlncadfRCgA== X-Received: by 2002:a05:6a00:1746:b0:648:ebb2:3d6 with SMTP id j6-20020a056a00174600b00648ebb203d6mr1003704pfc.26.1685423659738; Mon, 29 May 2023 22:14:19 -0700 (PDT) Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id c24-20020aa78c18000000b0064fe332209esm788914pfd.98.2023.05.29.22.14.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 29 May 2023 22:14:19 -0700 (PDT) Message-ID: <635470cf-103b-8383-0bc5-9b69de4f324d@gmail.com> Date: Mon, 29 May 2023 22:14:18 -0700 MIME-Version: 1.0 Subject: Re: bug#63778: [PATCH] Use comint-pager in eshell Content-Language: en-US To: Morgan Smith References: <36a8613a-7601-14d5-c659-3bd86708b63b@gmail.com> From: Jim Porter In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 63778 Cc: 63778@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 5/28/2023 11:23 PM, Morgan Smith wrote: > My main pain point was trying to figure out how to maintain the ability > to set/unset the PAGER variable. These current patches allow you to > set/unset the PAGER variable iff you don't set comint-pager. It even > allows you to do stuff like 'PAGER=cat git log' (see > eshell-handle-local-variables) without modifying buffer state (as it > should). Maintaining those capabilities when comint-pager is set seems > very difficult so I gave up. Thanks. I'll think this over for a bit and try some stuff out locally too. Looking at your second patch, I think I see where the pain lies: when getting PAGER, it always treats 'comint-pager' as taking precedence over the real env var, but when setting PAGER, it only sets the env var. Therefore, with 'comint-pager' set, setting PAGER won't have the intended effect (though maybe this doesn't apply to local variables). There's probably a nice way to do this, but it might involve some tweaks to how Eshell handles variable aliases in general. I'll look into it more. From debbugs-submit-bounces@debbugs.gnu.org Wed Aug 23 19:58:22 2023 Received: (at 63778-done) by debbugs.gnu.org; 23 Aug 2023 23:58:22 +0000 Received: from localhost ([127.0.0.1]:35584 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qYxjy-0003Li-CW for submit@debbugs.gnu.org; Wed, 23 Aug 2023 19:58:22 -0400 Received: from mail-oi1-x22b.google.com ([2607:f8b0:4864:20::22b]:45322) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qYxju-0003LU-JE for 63778-done@debbugs.gnu.org; Wed, 23 Aug 2023 19:58:20 -0400 Received: by mail-oi1-x22b.google.com with SMTP id 5614622812f47-3a7d7e5fb03so4499711b6e.3 for <63778-done@debbugs.gnu.org>; Wed, 23 Aug 2023 16:58:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1692835089; x=1693439889; h=content-transfer-encoding:in-reply-to:references:cc:to:from :content-language:subject:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to; bh=BFEU7u94/c+R7YGz1/wA1PvuSfrzaX4NRnPP0YOuiQE=; b=T2IAL5m3ypZpjbqR4yhtBz6PCkLxKMCi+T+MUmuurEkK45z2sTcGiVORNRmHs6pupD Jj6XIRs9rr/nWGgLTzQmt4lmqPwsTN+j6kZ7wTYor/jq0kg/+SJaf5IM0cGBIoBhUEqv ndoYSC/Vx1aIF/6/e3UeSXVsj6t5NdwL1s5D95w4rHIHvBXB2rR9H8vVEKqYa6zS9BDG 4UezQSEaVSUiT3jnWMWYIM31y/Fc7LkS5UZLGBt1mo6xVJcBYHAAOULU+dUkGHvS+k6M 3vlRYngWULOD4uhPRSWGPnLvoDVOF1Nhr/hxA+/nWF4zId0DwU2GxQqfMFm4rYyHXdxl 5pPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692835089; x=1693439889; h=content-transfer-encoding:in-reply-to:references:cc:to:from :content-language:subject:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=BFEU7u94/c+R7YGz1/wA1PvuSfrzaX4NRnPP0YOuiQE=; b=fPUDpH454moY1BGamfpFhswKzEBMYN3sQxzRVzV53CJdm1Hzxq/25ISoTnMrw7rsyW GdHOnSgk+DBWROK9ewP9+RLxRXcu6ifmaEnEpxm2JVzH0FdGZ8AvjSp/osMEqXJqTm5v 7eaE30mD44uQFWWyZWKqYKsBamOh93tEEUvpqmhJMzBwuucaE3KY5NC0ReBTlVxlhMEK 2K39guaudjuMaplX1i33/Asig3zrbnhJAUHbRsoWewrIt8G93MydawEP8sJqAojZ4oWG ftqU24s+GEj+QLkB9ny0/73pX5c4vn8zQOln3nps0UC5p6bujEeFyh18NRmgw0vGLE5a I5FQ== X-Gm-Message-State: AOJu0YyyY73ov7fG9olph0RF83a7Uq6pWFtDbMLivzdJa762KMm4xr79 b2lkgZ7aR2DO+/Lzt0jmA7M= X-Google-Smtp-Source: AGHT+IFS8lTe/h2Si09x9dnklqxsdQGP8phgIB4rV3S6+zVlztyWY8UQuzV+9SpwqrjvDynAfwh4cw== X-Received: by 2002:a05:6808:1a90:b0:3a7:6224:8424 with SMTP id bm16-20020a0568081a9000b003a762248424mr14623766oib.56.1692835089096; Wed, 23 Aug 2023 16:58:09 -0700 (PDT) Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id v21-20020aa78095000000b00687087d8bc3sm10299797pff.141.2023.08.23.16.58.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 23 Aug 2023 16:58:08 -0700 (PDT) Message-ID: Date: Wed, 23 Aug 2023 16:58:07 -0700 MIME-Version: 1.0 Subject: Re: bug#63778: [PATCH] Use comint-pager in eshell Content-Language: en-US From: Jim Porter To: Morgan Smith References: <36a8613a-7601-14d5-c659-3bd86708b63b@gmail.com> <635470cf-103b-8383-0bc5-9b69de4f324d@gmail.com> In-Reply-To: <635470cf-103b-8383-0bc5-9b69de4f324d@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 63778-done Cc: 63778-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Version: 30.1 On 5/29/2023 10:14 PM, Jim Porter wrote: > There's probably a nice way to do this, but it might involve some tweaks > to how Eshell handles variable aliases in general. I'll look into it more. Sorry for completely forgetting about this bug for a few months; I had some trouble getting a patch to work, then got busy with other things, and never picked it back up. I've now merged an updated version of this patch as 08901e93797, so marking this done. This implementation should be 100% backwards compatible, since users have to opt in to setting the new 'comint-pager' option, and even if you do that, it's easy enough to opt back out for just Eshell (set 'comint-pager' buffer-locally to nil in 'eshell-mode-hook' or similar). From unknown Tue Jun 24 01:41:30 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 21 Sep 2023 11:24:09 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator