GNU bug report logs - #63774
[PATCH] gnu: python-zulip: Fix test failure.

Previous Next

Package: guix-patches;

Reported by: gemmaro <gemmaro.dev <at> gmail.com>

Date: Sun, 28 May 2023 14:55:02 UTC

Severity: normal

Tags: patch

Done: Christopher Baines <mail <at> cbaines.net>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Christopher Baines <mail <at> cbaines.net>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#63774: closed ([PATCH] gnu: python-zulip: Fix test failure.)
Date: Sat, 03 Jun 2023 11:46:02 +0000
[Message part 1 (text/plain, inline)]
Your message dated Sat, 03 Jun 2023 12:44:45 +0100
with message-id <877csk6a6k.fsf <at> cbaines.net>
and subject line Re: [bug#63774] [PATCH] gnu: python-zulip: Fix test failure.
has caused the debbugs.gnu.org bug report #63774,
regarding [PATCH] gnu: python-zulip: Fix test failure.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
63774: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=63774
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems
[Message part 2 (message/rfc822, inline)]
From: gemmaro <gemmaro.dev <at> gmail.com>
To: guix-patches <at> gnu.org
Cc: gemmaro <gemmaro.dev <at> gmail.com>
Subject: [PATCH] gnu: python-zulip: Fix test failure.
Date: Sun, 28 May 2023 23:54:04 +0900
* gnu/packages/messaging.scm (python-zulip): Fix test failure.
---
 gnu/packages/messaging.scm | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/messaging.scm b/gnu/packages/messaging.scm
index 46170ff31ec..a8dac86232e 100644
--- a/gnu/packages/messaging.scm
+++ b/gnu/packages/messaging.scm
@@ -39,6 +39,7 @@
 ;;; Copyright © 2022 Giovanni Biscuolo <g <at> xelera.eu>
 ;;; Copyright © 2023 Giacomo Leidi <goodoldpaul <at> autistici.org>
 ;;; Copyright © 2023 Yovan Naumovski <yovan <at> gorski.stream>
+;;; Copyright © 2023 gemmaro <gemmaro.dev <at> gmail.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -3085,7 +3086,12 @@ (define-public python-zulip
        (file-name (git-file-name name version))
        (sha256
         (base32
-         "0da1ki1v252avy27j6d7snnc0gyq0xa9fypm3qdmxhw2w79d6q36"))))
+         "0da1ki1v252avy27j6d7snnc0gyq0xa9fypm3qdmxhw2w79d6q36"))
+       (modules '((guix build utils)))
+       (snippet
+        '(begin
+           (substitute* "zulip/tests/test_default_arguments.py"
+             (("optional arguments:") "options:"))))))
     (build-system python-build-system)
     (arguments
      `(#:phases

base-commit: 6192acf8b77948384e75650ae79dfbaadb26bc37
-- 
2.40.1



[Message part 3 (message/rfc822, inline)]
From: Christopher Baines <mail <at> cbaines.net>
To: gemmaro <gemmaro.dev <at> gmail.com>
Cc: 63774-done <at> debbugs.gnu.org
Subject: Re: [bug#63774] [PATCH] gnu: python-zulip: Fix test failure.
Date: Sat, 03 Jun 2023 12:44:45 +0100
[Message part 4 (text/plain, inline)]
gemmaro <gemmaro.dev <at> gmail.com> writes:

> * gnu/packages/messaging.scm (python-zulip): Fix test failure.
> ---
>  gnu/packages/messaging.scm | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)

Thanks for the patch, I've added a comment about this being fixed in
later versions and pushed to master as
f30f8ecc6961f181f670c960fa57ffa2442c0217.

It would be nice to update, but that looks like it requires a bit of
work on how to run the tests.

Thanks again,

Chris
[signature.asc (application/pgp-signature, inline)]

This bug report was last modified 2 years and 47 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.