GNU bug report logs - #63744
28.2; fix dired-guess-default

Previous Next

Package: emacs;

Reported by: Leo Liu <sdl.web <at> gmail.com>

Date: Sat, 27 May 2023 04:11:01 UTC

Severity: normal

Tags: patch

Found in version 28.2

Full log


Message #38 received at 63744 <at> debbugs.gnu.org (full text, mbox):

From: Michael Heerdegen <michael_heerdegen <at> web.de>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 63744 <at> debbugs.gnu.org, Leo Liu <sdl.web <at> gmail.com>
Subject: Re: bug#63744: 28.2; fix dired-guess-default
Date: Tue, 30 May 2023 02:24:25 +0200
Eli Zaretskii <eliz <at> gnu.org> writes:

> I understand all that.  But you are evidently still not understanding
> what I'm asking.

If interested - else feel free to ignore.

If this didn't answer your question:

> Can't you generate the entire value of dired-guess-shell-alist-user
> dynamically, including the RE part?

then you meant to recompute the variable's value every time the user wants
to open a file with dired?

It's a defcustom so Emacs should not change the value at all.
And recomputing the whole value every time is much slower than computing
a list of defaults for one class of files matched by the regexp.  The
conditions that need to be checked are very different for different file
types in a typical scenario, and the suggested design is more efficient:
first look at the file type by matching the RE part, then decide, at the
moment of user request, what applications are appropriate for this type
of file (and only for this type) in this moment.

Michael.




This bug report was last modified 1 year and 154 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.