GNU bug report logs - #63740
broken and questionable attribute normalisation in xml.el

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Mattias Engdegård <mattias.engdegard <at> gmail.com>
Subject: bug#63740: closed (bug#63740: broken and questionable attribute
 normalisation in xml.el)
Date: Tue, 30 May 2023 15:51:02 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#63740: broken and questionable attribute normalisation in xml.el

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 63740 <at> debbugs.gnu.org.

-- 
63740: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=63740
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Mattias Engdegård <mattiase <at> acm.org>
To: 63740-done <at> debbugs.gnu.org
Subject: bug#63740: broken and questionable attribute normalisation in xml.el
Date: Tue, 30 May 2023 17:50:01 +0200

I decided that the attempt to collapse whitespace in attributes is wrong and removed the ineffective attempt to do so in 9ae212fb1e. Bug closed.

[Message part 3 (message/rfc822, inline)]

From: Mattias Engdegård <mattias.engdegard <at> gmail.com>
To: Emacs Bug Report <bug-gnu-emacs <at> gnu.org>
Cc: Juanma Barranquero <lekktu <at> gmail.com>,
 "Mark A. Hershberger" <mah <at> everybody.org>
Subject: broken and questionable attribute normalisation in xml.el
Date: Fri, 26 May 2023 17:14:53 +0200

In `xml-parse-attlist`, we see:

      ;; Multiple whitespace characters should be replaced with a single one
      ;; in the attributes
      (let ((string (match-string-no-properties 1)))
	(replace-regexp-in-string "\\s-\\{2,\\}" " " string)
        ...

The call to `replace-regexp-in-string` is of course useless and there is now a compiler warning telling us, which is how this came to light.

However, should we really collapse whitespace here? If I'm reading the spec correctly, it's not done for CDATA attributes and we have no reason to believe any other type, do we?

I'm no XML expert but it looks like the code is correct and we can just remove the call to `replace-regexp-in-string` (and the misleading comment). Or?

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.