GNU bug report logs - #63739
[PATCH] gnu: Add font-intel-one-mono

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#63739: closed ([PATCH] gnu: Add font-intel-one-mono)
Date: Sat, 01 Jul 2023 10:15:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Sat, 01 Jul 2023 12:14:00 +0200
with message-id <87sfa8j5w7.fsf <at> nicolasgoaziou.fr>
and subject line Re: [bug#63739] [PATCH] gnu: Add font-intel-one-mono
has caused the debbugs.gnu.org bug report #63739,
regarding [PATCH] gnu: Add font-intel-one-mono
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
63739: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=63739
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: gemmaro <gemmaro.dev <at> gmail.com>
To: guix-patches <at> gnu.org
Cc: gemmaro <gemmaro.dev <at> gmail.com>
Subject: [PATCH] gnu: Add font-intel-one-mono
Date: Fri, 26 May 2023 23:51:28 +0900

* gnu/packages/fonts.scm (font-intel-one-mono): New variable.
---
 gnu/packages/fonts.scm | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)

diff --git a/gnu/packages/fonts.scm b/gnu/packages/fonts.scm
index 12c6b04bd70..cfce3becf5a 100644
--- a/gnu/packages/fonts.scm
+++ b/gnu/packages/fonts.scm
@@ -55,6 +55,7 @@
 ;;; Copyright © 2023 Nicolas Graves <ngraves <at> ngraves.fr>
 ;;; Copyright © 2023 Ahmad Draidi <a.r.draidi <at> redscript.org>
 ;;; Copyright © 2023 Arnaud Lechevallier <arnaud.lechevallier <at> free.fr>
+;;; Copyright © 2023 gemmaro <gemmaro.dev <at> gmail.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -185,6 +186,27 @@ (define-public font-inconsolata
 in print.  With attention to detail for high resolution rendering.")
     (license license:silofl1.1)))
 
+(define-public font-intel-one-mono
+  (package
+    (name "font-intel-one-mono")
+    (version "1.2.0")
+    (source (origin
+              (method git-fetch)
+              (uri (git-reference
+                    (url "https://github.com/intel/intel-one-mono")
+                    (commit "9effabe19a60bdd46cbfbdcc6e81facd8a13b762")))
+              (file-name (git-file-name name version))
+              (sha256
+               (base32
+                "12lywni8bgkr8h4pz1lkw4imr2y896rnsvipbqgqv3c1b54b5g7n"))))
+    (build-system font-build-system)
+    (home-page "https://github.com/intel/intel-one-mono")
+    (synopsis "Expressive monospaced font family")
+    (description
+     "Introducing Intel One Mono, an expressive monospaced font family that's built
+with clarity, legibility, and the needs of developers in mind.")
+    (license license:silofl1.1)))
+
 (define-public font-dejavu
   (package
     (name "font-dejavu")

base-commit: a9cde26133bd98498869a3528d9dff0d3f456a96
-- 
2.40.1

[Message part 3 (message/rfc822, inline)]

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: gemmaro <gemmaro.dev <at> gmail.com>
Cc: 63739-done <at> debbugs.gnu.org, 宋文武 <iyzsong <at> envs.net>,
 Zhu Zihao <all_but_last <at> 163.com>
Subject: Re: [bug#63739] [PATCH] gnu: Add font-intel-one-mono
Date: Sat, 01 Jul 2023 12:14:00 +0200

Hello,

gemmaro <gemmaro.dev <at> gmail.com> writes:

> * gnu/packages/fonts.scm (font-intel-one-mono): New variable.

Applied with changes described below. Thank you.

> +(define-public font-intel-one-mono
> +  (package
> +    (name "font-intel-one-mono")
> +    (version "1.2.0")
> +    (source (origin
> +              (method git-fetch)
> +              (uri (git-reference
> +                    (url "https://github.com/intel/intel-one-mono")
> +                    (commit "9effabe19a60bdd46cbfbdcc6e81facd8a13b762")))

We prefer tags over raw commit hashes. In this case, the tag is
"V1.2.0", so you need to use instead:

  (string-append "V" version)

If there's no tag, we bind the hash string to a `commit' variable around
the package definition, possibly along with a `revision' if the commit
does not match any version bump,  a and write:

  (commit commit)

> +    (description
> +     "Introducing Intel One Mono, an expressive monospaced font family that's built
> +with clarity, legibility, and the needs of developers in mind.")

The description should consist of complete sentences:

 "This package introduces..."

Regards,
-- 
Nicolas Goaziou

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.