GNU bug report logs - #63739
[PATCH] gnu: Add font-intel-one-mono

Previous Next

Full log

Message #10 received at 63739-done <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: gemmaro <gemmaro.dev <at> gmail.com>
Cc: 63739-done <at> debbugs.gnu.org, 宋文武 <iyzsong <at> envs.net>,
 Zhu Zihao <all_but_last <at> 163.com>
Subject: Re: [bug#63739] [PATCH] gnu: Add font-intel-one-mono
Date: Sat, 01 Jul 2023 12:14:00 +0200

Hello,

gemmaro <gemmaro.dev <at> gmail.com> writes:

> * gnu/packages/fonts.scm (font-intel-one-mono): New variable.

Applied with changes described below. Thank you.

> +(define-public font-intel-one-mono
> +  (package
> +    (name "font-intel-one-mono")
> +    (version "1.2.0")
> +    (source (origin
> +              (method git-fetch)
> +              (uri (git-reference
> +                    (url "https://github.com/intel/intel-one-mono")
> +                    (commit "9effabe19a60bdd46cbfbdcc6e81facd8a13b762")))

We prefer tags over raw commit hashes. In this case, the tag is
"V1.2.0", so you need to use instead:

  (string-append "V" version)

If there's no tag, we bind the hash string to a `commit' variable around
the package definition, possibly along with a `revision' if the commit
does not match any version bump,  a and write:

  (commit commit)

> +    (description
> +     "Introducing Intel One Mono, an expressive monospaced font family that's built
> +with clarity, legibility, and the needs of developers in mind.")

The description should consist of complete sentences:

 "This package introduces..."

Regards,
-- 
Nicolas Goaziou

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.