Subject: bug#63739: closed (Re: [bug#63739] [PATCH] gnu: Add font-intel-one-mono)

From: [email-masked] (GNU bug Tracking System)
Date: Sat, 01 Jul 2023 10:15:02 +0000

Your bug report

#63739: [PATCH] gnu: Add font-intel-one-mono

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
63739: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=63739
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: [bug#63739] [PATCH] gnu: Add font-intel-one-mono
From: Nicolas Goaziou <[email-masked]>
To: gemmaro <[email-masked]>
Cc: [email-masked], 宋文武 <[email-masked]>, Zhu Zihao <[email-masked]>
Date: Sat, 01 Jul 2023 12:14:00 +0200
List-Id: <debbugs-submit.debbugs.gnu.org>

Hello,

gemmaro <[email-masked]> writes:

> * gnu/packages/fonts.scm (font-intel-one-mono): New variable.

Applied with changes described below. Thank you.

> +(define-public font-intel-one-mono
> +  (package
> +    (name "font-intel-one-mono")
> +    (version "1.2.0")
> +    (source (origin
> +              (method git-fetch)
> +              (uri (git-reference
> +                    (url "https://github.com/intel/intel-one-mono")
> +                    (commit "9effabe19a60bdd46cbfbdcc6e81facd8a13b762")))

We prefer tags over raw commit hashes. In this case, the tag is
"V1.2.0", so you need to use instead:

  (string-append "V" version)

If there's no tag, we bind the hash string to a `commit' variable around
the package definition, possibly along with a `revision' if the commit
does not match any version bump,  a and write:

  (commit commit)

> +    (description
> +     "Introducing Intel One Mono, an expressive monospaced font family that's built
> +with clarity, legibility, and the needs of developers in mind.")

The description should consist of complete sentences:

 "This package introduces..."

Regards,
-- 
Nicolas Goaziou

Subject: [PATCH] gnu: Add font-intel-one-mono
From: gemmaro <[email-masked]>
To: [email-masked]
Cc: gemmaro <[email-masked]>
Date: Fri, 26 May 2023 23:51:28 +0900
List-Id: <debbugs-submit.debbugs.gnu.org>

* gnu/packages/fonts.scm (font-intel-one-mono): New variable.
---
 gnu/packages/fonts.scm | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)

diff --git a/gnu/packages/fonts.scm b/gnu/packages/fonts.scm
index 12c6b04bd70..cfce3becf5a 100644
--- a/gnu/packages/fonts.scm
+++ b/gnu/packages/fonts.scm
@@ -55,6 +55,7 @@
 ;;; Copyright © 2023 Nicolas Graves <[email-masked]>
 ;;; Copyright © 2023 Ahmad Draidi <[email-masked]>
 ;;; Copyright © 2023 Arnaud Lechevallier <[email-masked]>
+;;; Copyright © 2023 gemmaro <[email-masked]>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -185,6 +186,27 @@ (define-public font-inconsolata
 in print.  With attention to detail for high resolution rendering.")
     (license license:silofl1.1)))
 
+(define-public font-intel-one-mono
+  (package
+    (name "font-intel-one-mono")
+    (version "1.2.0")
+    (source (origin
+              (method git-fetch)
+              (uri (git-reference
+                    (url "https://github.com/intel/intel-one-mono")
+                    (commit "9effabe19a60bdd46cbfbdcc6e81facd8a13b762")))
+              (file-name (git-file-name name version))
+              (sha256
+               (base32
+                "12lywni8bgkr8h4pz1lkw4imr2y896rnsvipbqgqv3c1b54b5g7n"))))
+    (build-system font-build-system)
+    (home-page "https://github.com/intel/intel-one-mono")
+    (synopsis "Expressive monospaced font family")
+    (description
+     "Introducing Intel One Mono, an expressive monospaced font family that's built
+with clarity, legibility, and the needs of developers in mind.")
+    (license license:silofl1.1)))
+
 (define-public font-dejavu
   (package
     (name "font-dejavu")

base-commit: a9cde26133bd98498869a3528d9dff0d3f456a96
-- 
2.40.1