From unknown Sun Jun 15 08:21:20 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#6373 <6373@debbugs.gnu.org> To: bug#6373 <6373@debbugs.gnu.org> Subject: Status: 23.2; advice.el unbinding warning-suppress-types Reply-To: bug#6373 <6373@debbugs.gnu.org> Date: Sun, 15 Jun 2025 15:21:20 +0000 retitle 6373 23.2; advice.el unbinding warning-suppress-types reassign 6373 emacs submitter 6373 Kevin Ryde severity 6373 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 07 18:54:47 2010 Received: (at submit) by debbugs.gnu.org; 7 Jun 2010 22:54:47 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OLlDT-0004R4-E1 for submit@debbugs.gnu.org; Mon, 07 Jun 2010 18:54:47 -0400 Received: from mx10.gnu.org ([199.232.76.166]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OLlDQ-0004Qz-JB for submit@debbugs.gnu.org; Mon, 07 Jun 2010 18:54:45 -0400 Received: from lists.gnu.org ([199.232.76.165]:54885) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1OLlDM-00005N-Cg for submit@debbugs.gnu.org; Mon, 07 Jun 2010 18:54:40 -0400 Received: from [140.186.70.92] (port=43259 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OLlDL-0007Kp-3O for bug-gnu-emacs@gnu.org; Mon, 07 Jun 2010 18:54:40 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=unavailable version=3.3.1 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OLlDJ-0005It-TY for bug-gnu-emacs@gnu.org; Mon, 07 Jun 2010 18:54:38 -0400 Received: from mailout2-15.pacific.net.au ([125.255.80.142]:41328 helo=mailout2.pacific.net.au) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OLlDJ-0005IS-KD for bug-gnu-emacs@gnu.org; Mon, 07 Jun 2010 18:54:37 -0400 Received: from mailproxy1.pacific.net.au (mailproxy1.pacific.net.au [61.8.2.162]) by mailout2.pacific.net.au (Postfix) with ESMTP id D20A31EF143 for ; Tue, 8 Jun 2010 08:54:31 +1000 (EST) Received: from blah.blah (ppp287C.dyn.pacific.net.au [61.8.40.124]) by mailproxy1.pacific.net.au (Postfix) with ESMTP id 2D5018C31 for ; Tue, 8 Jun 2010 08:54:30 +1000 (EST) Received: from gg by blah.blah with local (Exim 4.71) (envelope-from ) id 1OLlD4-0002D7-P1 for bug-gnu-emacs@gnu.org; Tue, 08 Jun 2010 08:54:22 +1000 From: Kevin Ryde To: bug-gnu-emacs@gnu.org Subject: 23.2; advice.el unbinding warning-suppress-types Date: Tue, 08 Jun 2010 08:54:22 +1000 Message-ID: <87vd9ujvxd.fsf@blah.blah> User-Agent: Gnus/5.110011 (No Gnus v0.11) Emacs/23.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-Spam-Score: -5.6 (-----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.6 (-----) If advice.el byte-compiles a piece of advice which causes byte compiler warnings, then it unbinds `warning-suppress-types'. For example (defun foo () (message "hi")) (defadvice foo (after my-advice activate compile) (car)) (display-warning 'bar "some thing") => Error void-variable warning-suppress-types It seems ad-compile-function does a let bind of warning-suppress-types without ensuring warnings.el has been loaded. In GNU Emacs 23.2.1 (i486-pc-linux-gnu, GTK+ Version 2.20.0) of 2010-05-16 on raven, modified by Debian configured using `configure '--build' 'i486-linux-gnu' '--build' 'i486-linux-gnu' '--prefix=/usr' '--sharedstatedir=/var/lib' '--libexecdir=/usr/lib' '--localstatedir=/var/lib' '--infodir=/usr/share/info' '--mandir=/usr/share/man' '--with-pop=yes' '--enable-locallisppath=/etc/emacs23:/etc/emacs:/usr/local/share/emacs/23.2/site-lisp:/usr/local/share/emacs/site-lisp:/usr/share/emacs/23.2/site-lisp:/usr/share/emacs/site-lisp:/usr/share/emacs/23.2/leim' '--with-x=yes' '--with-x-toolkit=gtk' '--with-toolkit-scroll-bars' 'build_alias=i486-linux-gnu' 'CFLAGS=-DDEBIAN -g -O2' 'LDFLAGS=-g' 'CPPFLAGS='' Important settings: value of $LC_ALL: nil value of $LC_COLLATE: nil value of $LC_CTYPE: nil value of $LC_MESSAGES: nil value of $LC_MONETARY: nil value of $LC_NUMERIC: nil value of $LC_TIME: nil value of $LANG: en_AU value of $XMODIFIERS: nil locale-coding-system: iso-latin-1-unix default enable-multibyte-characters: t From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 07 19:12:48 2010 Received: (at control) by debbugs.gnu.org; 7 Jun 2010 23:12:48 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OLlUu-00059z-HV for submit@debbugs.gnu.org; Mon, 07 Jun 2010 19:12:48 -0400 Received: from fencepost.gnu.org ([140.186.70.10]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OLlUs-00059s-Bs for control@debbugs.gnu.org; Mon, 07 Jun 2010 19:12:46 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.69) (envelope-from ) id 1OLlUo-0005k5-7c; Mon, 07 Jun 2010 19:12:42 -0400 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <19469.31978.205696.888092@fencepost.gnu.org> Date: Mon, 7 Jun 2010 19:12:42 -0400 From: Glenn Morris To: control Subject: merge bugs. does anyone search before reporting? :( X-Attribution: GM X-Mailer: VM (www.wonderworks.com/vm), GNU Emacs (www.gnu.org/software/emacs) X-Hue: magenta X-Ran: u8qT+9\`hgwT/kvy[]!)a]|}^&HChF`NSj?_5?\x%pY%D#jB\r~{pHXgA+m List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.1 (------) merge 6275 6373 From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 08 21:27:25 2010 Received: (at control) by debbugs.gnu.org; 9 Jun 2010 01:27:25 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OMA4i-0001eG-OQ for submit@debbugs.gnu.org; Tue, 08 Jun 2010 21:27:24 -0400 Received: from ironport2-out.teksavvy.com ([206.248.154.181] helo=ironport2-out.pppoe.ca) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OM9zx-0001bp-F1; Tue, 08 Jun 2010 21:22:29 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AvsEAJeJDkxFxIwr/2dsb2JhbACeQ3K/aoUWBIxs X-IronPort-AV: E=Sophos;i="4.53,387,1272859200"; d="scan'208";a="67639807" Received: from 69-196-140-43.dsl.teksavvy.com (HELO pastel.home) ([69.196.140.43]) by ironport2-out.pppoe.ca with ESMTP; 08 Jun 2010 21:22:25 -0400 Received: by pastel.home (Postfix, from userid 20848) id 4FAE98175; Tue, 8 Jun 2010 21:22:25 -0400 (EDT) From: Stefan Monnier To: SAITO Takuya Subject: Re: bug#6275: 23.2; warning-suppress-types is void after defadvice Message-ID: References: <20100526.232850.112543538.tabmore@gmail.com> Date: Tue, 08 Jun 2010 21:22:25 -0400 In-Reply-To: <20100526.232850.112543538.tabmore@gmail.com> (SAITO Takuya's message of "Wed, 26 May 2010 23:28:50 +0900 (JST)") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -1.9 (-) X-Debbugs-Envelope-To: control X-Mailman-Approved-At: Tue, 08 Jun 2010 21:27:23 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.9 (-) forcemerge 6275 6373 thanks > Debugger entered--Lisp error: (void-variable warning-suppress-types) [...] > ad-compile-function() binds warning-suppress-types with let. > I guess warnings.el is loaded inside of that let-binding. Indeed, thank you. I've installed the patch below which should fix it. Stefan === modified file 'lisp/emacs-lisp/advice.el' --- lisp/emacs-lisp/advice.el 2010-02-15 20:03:22 +0000 +++ lisp/emacs-lisp/advice.el 2010-06-09 01:16:08 +0000 @@ -2684,6 +2684,8 @@ ;; because `byte-compile' uses `fset': (ad-with-auto-activation-disabled (require 'bytecomp) + (require 'warnings) ;To define warning-suppress-types + ;before we let-bind it. (let ((symbol (make-symbol "advice-compilation")) (byte-compile-warnings byte-compile-warnings) ;; Don't pop up windows showing byte-compiler warnings. From unknown Sun Jun 15 08:21:20 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 07 Jul 2010 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator From debbugs-submit-bounces@debbugs.gnu.org Thu Oct 06 17:50:11 2011 Received: (at control) by debbugs.gnu.org; 6 Oct 2011 21:50:11 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RBvpT-0001VF-5m for submit@debbugs.gnu.org; Thu, 06 Oct 2011 17:50:11 -0400 Received: from fencepost.gnu.org ([140.186.70.10]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RBvpR-0001V9-5D for control@debbugs.gnu.org; Thu, 06 Oct 2011 17:50:09 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1RBvpG-0005ph-7O for control@debbugs.gnu.org; Thu, 06 Oct 2011 17:49:58 -0400 Date: Thu, 06 Oct 2011 17:49:58 -0400 Message-Id: Subject: control message for bug 6682 To: X-Mailer: mail (GNU Mailutils 2.1) From: Glenn Morris X-Spam-Score: -6.4 (------) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.4 (------) unarchive 6275 forcemerge 6275 6682 From unknown Sun Jun 15 08:21:20 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 04 Nov 2011 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator