Subject: bug#63729: closed (Re: [bug#63729] [PATCH] gnu: Add greaseweazle-host-tools.)

From: [email-masked] (GNU bug Tracking System)
Date: Sat, 01 Jul 2023 10:18:02 +0000

Your bug report

#63729: [PATCH] gnu: Add greaseweazle-host-tools.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
63729: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=63729
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: [bug#63729] [PATCH] gnu: Add greaseweazle-host-tools.
From: Nicolas Goaziou <[email-masked]>
To: Rikard Nordgren <[email-masked]>
Cc: [email-masked]
Date: Sat, 01 Jul 2023 12:17:30 +0200
List-Id: <debbugs-submit.debbugs.gnu.org>

Hello,

Rikard Nordgren <[email-masked]> writes:

> ---
>  gnu/packages/disk.scm | 37 +++++++++++++++++++++++++++++++++++++
>  1 file changed, 37 insertions(+)

Applied with a proper commit message and changes described below. Thank you.

> +(define-public greaseweazle-host-tools
> +  (package
> +    (name "greaseweazle-host-tools")
> +    (version "1.12")
> +    (source (origin
> +              (method git-fetch)
> +              (uri (git-reference
> +                    (url "https://github.com/keirf/greaseweazle")
> +                    (commit "v1.12")))

I re-used the version here:

  (commit (string-append "v" version))

> +    (arguments
> +     `(#:phases (modify-phases %standard-phases

I used G-expressions:

  (arguments (list #:phases #~(modify-phases ...)))

> +                  (add-before 'build 'setuptools-version
> +                    (lambda _
> +                      (setenv "SETUPTOOLS_SCM_PRETEND_VERSION" "1.8") #t))

No need for trailing #T at the end of phases; il removed it.

> +                  (add-after 'install 'install-udev-rules
> +                    (lambda* (#:key outputs #:allow-other-keys)

I removed the outputs argument...

> +                      (install-file "scripts/49-greaseweazle.rules"
> +                                    (string-append (assoc-ref outputs "out")

... and used (string-append #$output ...)

> +                                                   "/lib/udev/rules.d/")))))))
> +    (native-inputs (list python-setuptools-scm))
> +    (propagated-inputs (list python-bitarray python-pyserial python-requests
> +                             python-crcmod))

Indentation is surprising here. I changed it.

> +    (synopsis "Tools for accessing a floppy drive at the raw flux level")
> +    (description
> +     "The host tools for controlling a Greaseweazle: an Open Source USB device
> +capable of reading and writing raw data on nearly any type of floppy disk")

Descriptions should consist of full sentences:

  "This package provides host tools for..."

Regards,
-- 
Nicolas Goaziou

Subject: [PATCH] gnu: Add greaseweazle-host-tools.
From: Rikard Nordgren <[email-masked]>
To: [email-masked]
Cc: [email-masked]
Date: Thu, 25 May 2023 19:17:05 +0000
List-Id: <debbugs-submit.debbugs.gnu.org>

---
 gnu/packages/disk.scm | 37 +++++++++++++++++++++++++++++++++++++
 1 file changed, 37 insertions(+)

diff --git a/gnu/packages/disk.scm b/gnu/packages/disk.scm
index 894a542171..93be910aef 100644
--- a/gnu/packages/disk.scm
+++ b/gnu/packages/disk.scm
@@ -76,6 +76,9 @@ (define-module (gnu packages disk)
   #:use-module (gnu packages pkg-config)
   #:use-module (gnu packages popt)
   #:use-module (gnu packages python)
+  #:use-module (gnu packages python-build)
+  #:use-module (gnu packages python-crypto)
+  #:use-module (gnu packages python-web)
   #:use-module (gnu packages python-xyz)
   #:use-module (gnu packages qt)
   #:use-module (gnu packages readline)
@@ -572,6 +575,40 @@ (define-public idle3-tools
 and can dramatically shorten the lifespan of the drive if left unchecked.")
     (license license:gpl3+)))
 
+(define-public greaseweazle-host-tools
+  (package
+    (name "greaseweazle-host-tools")
+    (version "1.12")
+    (source (origin
+              (method git-fetch)
+              (uri (git-reference
+                    (url "https://github.com/keirf/greaseweazle")
+                    (commit "v1.12")))
+              (file-name (git-file-name name version))
+              (sha256
+               (base32
+                "1lpvjlf2xg4ccwik8npiihi0lgw9dx5h12pp4ry343gkz4pwgk9x"))))
+    (build-system python-build-system)
+    (arguments
+     `(#:phases (modify-phases %standard-phases
+                  (add-before 'build 'setuptools-version
+                    (lambda _
+                      (setenv "SETUPTOOLS_SCM_PRETEND_VERSION" "1.8") #t))
+                  (add-after 'install 'install-udev-rules
+                    (lambda* (#:key outputs #:allow-other-keys)
+                      (install-file "scripts/49-greaseweazle.rules"
+                                    (string-append (assoc-ref outputs "out")
+                                                   "/lib/udev/rules.d/")))))))
+    (native-inputs (list python-setuptools-scm))
+    (propagated-inputs (list python-bitarray python-pyserial python-requests
+                             python-crcmod))
+    (synopsis "Tools for accessing a floppy drive at the raw flux level")
+    (description
+     "The host tools for controlling a Greaseweazle: an Open Source USB device
+capable of reading and writing raw data on nearly any type of floppy disk")
+    (home-page "https://github.com/keirf/greaseweazle")
+    (license license:public-domain)))
+
 (define-public gparted
   (package
     (name "gparted")

base-commit: 1be6baed2b58a75868cdcc9f51b78624c2fefc4f
-- 
2.30.2