Subject: [bug#63714] [PATCH] gnu: Add emacs-x509

From: Nicolas Goaziou <[email-masked]>
Date: Thu, 25 May 2023 22:29:34 +0200

Hello,

David Conner <[email-masked]> writes:

> From: David Conner <[email-masked]>
>
> * gnu/packages/emacs-xyz.scm (emacs-x509): New variable.

Thank you. Some comments follow.

> +(define-public emacs-x509-mode
> +  (package
> +    (name "emacs-x509-mode")
> +    (version "20230430.1518")

Guix doesn't use versioning system from MELPA. Unfortunately, this
package doesn't seem to set a Version keyword. So the version should be "0".

> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (string-append "https://melpa.org/packages/x509-mode-"
> +                           version ".tar"))

Please use GitHub as upstream.

> +    (arguments
> +     `(#:include (cons* "^keywords.txt"
> +                        "^keyword\\+constant.txt"
> +                        "^constants.txt"
> +                        "^long-name.txt"
> +                        %default-include)))

What about something like:

  (list #:include (cons "\\.txt$" %default-include))

> +    (description "Major mode for viewing certificates, CRLs, and other
> +PKI-related files.  Uses OpenSSL for viewing PEM and DER encoded PKI
> +entities.")

The description should consist of complete sentences.

Could you send an updated patch? Also, could you run tests?

Regards,
-- 
Nicolas Goaziou