GNU bug report logs - #63708
29.0.60; rust-ts-mode not properly handling apostrophe

Previous Next

Package: emacs;

Reported by: Йордан Миладинов <yordanm <at> proton.me>

Date: Thu, 25 May 2023 03:58:02 UTC

Severity: normal

Merged with 63709

Found in version 29.0.60

Done: Eli Zaretskii <eliz <at> gnu.org>

Bug is archived. No further changes may be made.

Full log


Message #49 received at 63708 <at> debbugs.gnu.org (full text, mbox):

From: Randy Taylor <dev <at> rjt.dev>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: yordanm <at> proton.me, casouri <at> gmail.com, 63708 <at> debbugs.gnu.org
Subject: Re: bug#63708: 29.0.60; rust-ts-mode not properly handling apostrophe
Date: Mon, 29 May 2023 13:20:58 +0000
[Message part 1 (text/plain, inline)]
On Monday, May 29th, 2023 at 09:12, Eli Zaretskii <eliz <at> gnu.org> wrote:
> > Date: Mon, 29 May 2023 12:18:38 +0000
> 
> > From: Randy Taylor dev <at> rjt.dev
> > Cc: yordanm <at> proton.me, 63708 <at> debbugs.gnu.org, casouri <at> gmail.com
> > 
> > On Monday, May 29th, 2023 at 08:12, Eli Zaretskii eliz <at> gnu.org wrote:
> > 
> > > > Date: Mon, 29 May 2023 01:29:31 +0000
> > > 
> > > > From: Randy Taylor dev <at> rjt.dev
> > > > Cc: Eli Zaretskii eliz <at> gnu.org, 63708 <at> debbugs.gnu.org, casouri <at> gmail.com
> > > > 
> > > > I won't be committing them (don't have the ability) but Eli likely will.
> > > > 
> > > > If you'd like to go through them all and check, that would be great. However, for non-trivial contributions (i.e. more than 15 lines of code changes across all your contributions I believe) you will need to assign copyright to the FSF, otherwise the changes can't be accepted. Eli can send you the form to fill out if you're interested.
> > > 
> > > It is unfortunate that the patch was posted before asking about such
> > > non-trivial submissions, because we are now stuck due to lack of
> > > copyright assignment, and the release branch must either wait for the
> > > assignment or live with the bug.
> > > 
> > > Йордан, can you think of a way of rewriting the go-ts-mode patch so
> > > that it uses fewer than 15 lines?
> > 
> > The go-ts-mode patch can be rewritten in a single line by just updating the syntax table directly like I suggested. Then we should be OK.
> 
> 
> Thanks, then please post such a patch.

Attached.

> 
> What about rust-ts-mode?

I will reply to that thread directly.
[0001-go-ts-mode-Treat-apostrophes-as-strings-Bug-63708.patch (text/x-patch, attachment)]

This bug report was last modified 1 year and 355 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.