GNU bug report logs - #63708
29.0.60; rust-ts-mode not properly handling apostrophe

Previous Next

Full log

View this message in rfc822 format

From: Йордан Миладинов
 <yordanm <at> proton.me>
To: Randy Taylor <dev <at> rjt.dev>
Cc: Eli Zaretskii <eliz <at> gnu.org>, 63708 <at> debbugs.gnu.org, casouri <at> gmail.com
Subject: bug#63708: 29.0.60; rust-ts-mode not properly handling apostrophe
Date: Fri, 26 May 2023 19:14:37 +0000

[Message part 1 (text/plain, inline)]

Here's a patch that implements Randy's idea.




Sent with Proton Mail secure email.

------- Original Message -------
On Friday, May 26th, 2023 at 5:21 AM, Randy Taylor <dev <at> rjt.dev> wrote:


> On Thursday, May 25th, 2023 at 09:12, Eli Zaretskii eliz <at> gnu.org wrote:
> 
> > > Date: Thu, 25 May 2023 12:52:18 +0000
> > 
> > > From: Randy Taylor dev <at> rjt.dev
> > > Cc: Йордан Миладинов yordanm <at> proton.me, 63708 <at> debbugs.gnu.org, Yuan Fu casouri <at> gmail.com
> > > 
> > > We probably need to augment rust-ts-mode--syntax-propertize where we apply the string syntax property to any char_literal nodes. It would probably be too late for emacs-29 though.
> > 
> > No, it won't be too late. rust-ts-mode is new in Emacs 29, so we
> > should fix it in Emacs 29. So please try to find a fix for that;
> > bonus points for making the fix as safe as possible for the release
> > branch.
> > 
> > Thanks.
> 
> 
> Sure, I'll take a look tomorrow or sometime during the weekend.

[0001-Fix-apostrophe-handling-in-rust-ts-mode.patch (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.