GNU bug report logs - #63708
29.0.60; rust-ts-mode not properly handling apostrophe

Previous Next

Package: emacs;

Reported by: Йордан Миладинов <yordanm <at> proton.me>

Date: Thu, 25 May 2023 03:58:02 UTC

Severity: normal

Merged with 63709

Found in version 29.0.60

Done: Eli Zaretskii <eliz <at> gnu.org>

Bug is archived. No further changes may be made.

Full log


Message #13 received at 63708 <at> debbugs.gnu.org (full text, mbox):

From: Randy Taylor <dev <at> rjt.dev>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: Йордан Миладинов
 <yordanm <at> proton.me>, Yuan Fu <casouri <at> gmail.com>, 63708 <at> debbugs.gnu.org
Subject: Re: bug#63708: 29.0.60; rust-ts-mode not properly handling apostrophe
Date: Thu, 25 May 2023 12:52:18 +0000
On Thursday, May 25th, 2023 at 01:30, Eli Zaretskii <eliz <at> gnu.org> wrote:
> 
> > Date: Wed, 24 May 2023 21:40:30 +0000
> 
> > From: yordanm--- via "Bug reports for GNU Emacs,
> > the Swiss army knife of text editors" bug-gnu-emacs <at> gnu.org
> > 
> > In Rust (rust-ts-mode) apostrophe-doublequote-apostrophe break many
> > parsing functions (scan-lists being the core one) as the apostrophe
> > character is parsed as punctuation, not as a string (as it is in
> > c-ts-mode for example).
> 
> 
> Randy, can you please look into this?

Thanks for the patch Yordan.

Apostrophes are also used to denote lifetimes in Rust, so I'm not sure this is the right fix. They are also used for loop labels, too.

We probably need to augment rust-ts-mode--syntax-propertize where we apply the string syntax property to any char_literal nodes. It would probably be too late for emacs-29 though.




This bug report was last modified 1 year and 355 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.