GNU bug report logs - #63707
[PATCH] gnu: Add font-ipa.

Previous Next

Full log

Message #13 received at 63707-done <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Wolf <wolf <at> wolfsden.cz>
Cc: 63707-done <at> debbugs.gnu.org, Zhu Zihao <all_but_last <at> 163.com>,
 宋文武 <iyzsong <at> envs.net>
Subject: Re: [bug#63707] [PATCH] gnu: Add font-ipa.
Date: Sat, 01 Jul 2023 12:23:34 +0200

Hello,

Wolf <wolf <at> wolfsden.cz> writes:

> * gnu/packages/fonts.scm (font-ipa): New variable.

Applied with the changes below. Thank you.
> ---
> +    (build-system font-build-system)
> +    (arguments
> +     (list #:phases #~(modify-phases %standard-phases
> +                        (add-after 'unpack 'make-read-only

I fixed indentation, which consumes way too much horizontal space here.

> +                        (add-after 'install 'install-doc
> +                          (lambda* (#:key outputs #:allow-other-keys)

outputs argument is not necessary when using G-expressions. You don't
use it either in your phases.

> +    (description "Japanese outline fonts by Information-technology Promotion
> +Agency, Japan (IPA)")

The description should consist of full sentences:

  "These package provides Japanese outline fonts..."

Regards,
-- 
Nicolas Goaziou

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.