Subject: Re: [bug#63641] [PATCH v2 5/8] gnu: Add libc-for-target and glibc/hurd.

From: Janneke Nieuwenhuizen <[email-masked]>
Date: Wed, 24 May 2023 10:11:01 +0200

Josselin Poiret via Guix-patches via writes:

Hi!

> From: Josselin Poiret <[email-masked]>
>
> * gnu/packages/patches/glibc-2.37-hurd-clock_t_centiseconds.patch
> * gnu/packages/patches/glibc-2.37-hurd-local-clock_gettime_MONOTONIC.patch
> * gnu/packages/patches/glibc-2.37-ldd-x86_64.patch
> * gnu/packages/patches/glibc-2.37-versioned-locpath.patch: New patches.
> * gnu/local.mk (dist_patch_DATA): Register them.
>
> * gnu/packages/base.scm (glibc/hurd, libc-for-target): New variables.
> (glibc/hurd-headers): Use glibc/hurd.
> * gnu/packages/commencement.scm (glibc-final-with-bootstrap-bash,
> glibc-final): Use libc-for-target.
> * gnu/packages/cross-base.scm (cross-libc/deprecated, cross-libc*): Use
> libc-for-target.

Very nice!

[..]

> diff --git a/gnu/packages/patches/glibc-2.37-hurd-local-clock_gettime_MONOTONIC.patch b/gnu/packages/patches/glibc-2.37-hurd-local-clock_gettime_MONOTONIC.patch
> new file mode 100644
> index 0000000000..3207a94550
> --- /dev/null
> +++ b/gnu/packages/patches/glibc-2.37-hurd-local-clock_gettime_MONOTONIC.patch
> @@ -0,0 +1,133 @@
> +Use the realtime clock for the monotonic clock. This is of course not a proper
> +implementation (which is being done in Mach), but will permit to fix at least
> +the iceweasel stack.
> +
> +vlc however doesn't build when _POSIX_CLOCK_SELECTION is enabled but
> +_POSIX_TIMERS is not, and they refuse to fix that (see #765578), so disable the
> +former.

Maybe add a note about upstream status/url for this patch (taken from
upstream, I guess).

> diff --git a/gnu/packages/patches/glibc-2.37-ldd-x86_64.patch b/gnu/packages/patches/glibc-2.37-ldd-x86_64.patch
> new file mode 100644
> index 0000000000..078cb38bd0
> --- /dev/null
> +++ b/gnu/packages/patches/glibc-2.37-ldd-x86_64.patch
> @@ -0,0 +1,8 @@
> +By default, 'RTDLLIST' in 'ldd' refers to 'lib64/ld-linux-x86-64.so', whereas
> +it's in 'lib/' for us.  This patch fixes that.

Maybe add something like: "Upstream status: Not presented upstream"?

> diff --git a/gnu/packages/patches/glibc-2.37-versioned-locpath.patch b/gnu/packages/patches/glibc-2.37-versioned-locpath.patch
> new file mode 100644
> index 0000000000..1964be4b4b
> --- /dev/null
> +++ b/gnu/packages/patches/glibc-2.37-versioned-locpath.patch
> @@ -0,0 +1,247 @@
> +From d73ba2caa10b8e9f51ff4239cc32eeb4e0de4279 Mon Sep 17 00:00:00 2001
> +Message-Id: <[email-masked]>
> +From: Josselin Poiret <[email-masked]>
> +Date: Sat, 13 May 2023 14:10:43 +0200
> +Subject: [PATCH] Add versioned locpath

Likewise, please add a note about upstream status of this patch.

Otherwise, L--more-than--GTM, awesome!  Plus, this most probably fixed
my rumpdisk!

Greetings,
Janneke

-- 
Janneke Nieuwenhuizen <[email-masked]>  | GNU LilyPond https://LilyPond.org
Freelance IT https://www.JoyOfSource.com | Avatar® https://AvatarAcademy.com