GNU bug report logs - #63625
29.0.90; package-install inserts package directory into load-path twice.

Previous Next

Full log

Message #38 received at 63625 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Robert Pluim <rpluim <at> gmail.com>
Cc: philipk <at> posteo.net, toddasmith <at> mac.com, monnier <at> iro.umontreal.ca,
 63625 <at> debbugs.gnu.org
Subject: Re: bug#63625: 29.0.90;
 package-install inserts package directory into load-path  twice.
Date: Mon, 22 May 2023 18:53:47 +0300

> Cc: Philip Kaludercic <philipk <at> posteo.net>, 63625 <at> debbugs.gnu.org,
>  todd smith <toddasmith <at> mac.com>
> From: Robert Pluim <rpluim <at> gmail.com>
> Date: Mon, 22 May 2023 17:36:09 +0200
> 
>     Stefan> (package--reload-previously-loaded pkg-desc))
>     Stefan> (with-demoted-errors "Error loading autoloads: %s"
>     Stefan> (load (package--autoloads-file-name pkg-desc) nil t))
>     Stefan> -        (add-to-list 'load-path (directory-file-name pkg-dir)))
>     Stefan> +        ;; FIXME: Since 2013 (commit 4fac34cee97a), the autoload files take
>     Stefan> +        ;; care of changing the `load-path', so maybe it's time to
>     Stefan> +        ;; remove this fallback code?
>     Stefan> +        (unless (or (member (file-name-as-directory pkg-dir) load-path)
>     Stefan> +                    (member (directory-file-name pkg-dir) load-path))
>     Stefan> +          (add-to-list 'load-path pkg-dir)))
> 
>     Stefan> Maybe we can have that patch in emacs-29 and remove the code altogether
>     Stefan> on `master`?
> 
> That seems reasonable. Eli?

I'm a bit confused by "that patch" and stuff, and would prefer to see
the patch for emacs-29 and another for master, please.

Thanks.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.