Subject: bug#63625: 29.0.90; package-install inserts package directory into load-path twice.

From: Eli Zaretskii <[email-masked]>
Date: Mon, 22 May 2023 18:53:47 +0300

> Cc: Philip Kaludercic <[email-masked]>, [email-masked],
>  todd smith <[email-masked]>
> From: Robert Pluim <[email-masked]>
> Date: Mon, 22 May 2023 17:36:09 +0200
> 
>     Stefan> (package--reload-previously-loaded pkg-desc))
>     Stefan> (with-demoted-errors "Error loading autoloads: %s"
>     Stefan> (load (package--autoloads-file-name pkg-desc) nil t))
>     Stefan> -        (add-to-list 'load-path (directory-file-name pkg-dir)))
>     Stefan> +        ;; FIXME: Since 2013 (commit 4fac34cee97a), the autoload files take
>     Stefan> +        ;; care of changing the `load-path', so maybe it's time to
>     Stefan> +        ;; remove this fallback code?
>     Stefan> +        (unless (or (member (file-name-as-directory pkg-dir) load-path)
>     Stefan> +                    (member (directory-file-name pkg-dir) load-path))
>     Stefan> +          (add-to-list 'load-path pkg-dir)))
> 
>     Stefan> Maybe we can have that patch in emacs-29 and remove the code altogether
>     Stefan> on `master`?
> 
> That seems reasonable. Eli?

I'm a bit confused by "that patch" and stuff, and would prefer to see
the patch for emacs-29 and another for master, please.

Thanks.