GNU bug report logs - #63566
[PATCH] gnu: add tcptrack

Previous Next

Package: guix-patches;

Reported by: Jakob Kirsch <jakob.kirsch <at> web.de>

Date: Thu, 18 May 2023 03:51:02 UTC

Severity: normal

Tags: patch

Done: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#63566: closed ([PATCH] gnu: add tcptrack)
Date: Fri, 01 Sep 2023 14:40:01 +0000
[Message part 1 (text/plain, inline)]
Your message dated Fri, 01 Sep 2023 10:38:50 -0400
with message-id <87h6oe2c1x.fsf_-_ <at> gmail.com>
and subject line Re: bug#63566: [PATCH] gnu: add tcptrack
has caused the debbugs.gnu.org bug report #63566,
regarding [PATCH] gnu: add tcptrack
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
63566: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=63566
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems
[Message part 2 (message/rfc822, inline)]
From: Jakob Kirsch <jakob.kirsch <at> web.de>
To: guix-patches <at> gnu.org
Cc: Jakob Kirsch <jakob.kirsch <at> web.de>
Subject: [PATCH] gnu: add tcptrack
Date: Wed, 17 May 2023 20:35:53 +0200
---
 gnu/packages/admin.scm | 24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)

diff --git a/gnu/packages/admin.scm b/gnu/packages/admin.scm
index 047b0ebcc6..0ae883e0b4 100644
--- a/gnu/packages/admin.scm
+++ b/gnu/packages/admin.scm
@@ -4255,6 +4255,30 @@ (define-public thermald
     (supported-systems '("i686-linux" "x86_64-linux"))
     (license license:gpl2)))

+(define-public tcptrack
+  (package
+    (name "tcptrack")
+    (version "1.4.3")
+    (source (origin
+              (method git-fetch)
+              (uri (git-reference
+                    (url "https://github.com/bchretien/tcptrack")
+                    (commit (string-append "v" version))))
+              (file-name (git-file-name name version))
+              (sha256
+               (base32
+                "08lh3l67wn4kq9q0nfspc7rj0jvp9dzwjgxpvqliwcif8cy5mi45"))))
+    (build-system gnu-build-system)
+    (arguments
+     `(#:tests? #f))
+    (inputs (list libpcap ncurses))
+    (synopsis "Display information about TCP connections")
+    (description
+     "A sniffer which displays information about TCP connections it
+sees on a network interface. (backup from Steve Bensons's tcptrack)")
+    (home-page "https://github.com/bchretien/tcptrack")
+    (license license:lgpl2.1)))
+
 (define-public masscan
   (package
     (name "masscan")

base-commit: c8e599b9391f789a8a3e2183fc8f0c2a5061ceb0
--
2.39.2



[Message part 3 (message/rfc822, inline)]
From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Jakob Kirsch <jakob.kirsch <at> web.de>
Cc: Jelle Licht <jlicht <at> fsfe.org>, 63566-done <at> debbugs.gnu.org
Subject: Re: bug#63566: [PATCH] gnu: add tcptrack
Date: Fri, 01 Sep 2023 10:38:50 -0400
Hi,

Jakob Kirsch <jakob.kirsch <at> web.de> writes:

> * gnu/packages/admin.scm (tcptrack): New variable
> ---
>  gnu/packages/admin.scm | 23 +++++++++++++++++++++++
>  1 file changed, 23 insertions(+)
>
> diff --git a/gnu/packages/admin.scm b/gnu/packages/admin.scm
> index 529a477ed0..3dd8b25836 100644
> --- a/gnu/packages/admin.scm
> +++ b/gnu/packages/admin.scm
> @@ -4256,6 +4256,29 @@ (define-public thermald
>      (supported-systems '("i686-linux" "x86_64-linux"))
>      (license license:gpl2)))
>
> +(define-public tcptrack
> +  (package
> +    (name "tcptrack")
> +    (version "1.4.3")
> +    (source (origin
> +              (method git-fetch)
> +              (uri (git-reference
> +                    (url "https://github.com/bchretien/tcptrack")
> +                    (commit (string-append "v" version))))
> +              (file-name (git-file-name name version))
> +              (sha256
> +               (base32
> +                "08lh3l67wn4kq9q0nfspc7rj0jvp9dzwjgxpvqliwcif8cy5mi45"))))
> +    (build-system gnu-build-system)
> +    (inputs (list libpcap ncurses))
> +    (synopsis "Display information about TCP connections")
> +    (description
> +     "Tcptrack is a sniffer which displays information about TCP connections
> +it sees on a network interface.  This is a fork of Steve Benson’s tcptrack.")
> +    (home-page "https://github.com/bchretien/tcptrack")
> +    ; the COPYING file states the following license but the tcptrack.spec states just 'GPL'
> +    (license license:lgpl2.1)))

I've made the following small changes:

--8<---------------cut here---------------start------------->8---
modified   gnu/packages/admin.scm
@@ -4291,13 +4291,12 @@ (define-public tcptrack
                 "08lh3l67wn4kq9q0nfspc7rj0jvp9dzwjgxpvqliwcif8cy5mi45"))))
     (build-system gnu-build-system)
     (inputs (list libpcap ncurses))
-    (synopsis "Display information about TCP connections")
+    (synopsis "TCP connections sniffer")
     (description
      "Tcptrack is a sniffer which displays information about TCP connections
 it sees on a network interface.  This is a fork of Steve Benson’s tcptrack.")
     (home-page "https://github.com/bchretien/tcptrack")
-    ; the COPYING file states the following license but the tcptrack.spec states just 'GPL'
-    (license license:lgpl2.1)))
+    (license license:lgpl2.1+)))
 
 (define-public masscan
   (package
--8<---------------cut here---------------end--------------->8---

Fixing the license (note the + which means 'or later').  Conventionally
the synopsis is worded to describe what it *is* rather than what it
does (the later is kept for the description).

I've now installed the change, thank you!

-- 
Thanks,
Maxim


This bug report was last modified 1 year and 323 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.