GNU bug report logs - #63556
29.0.90; Use of _Generic breaks Emacs build on GCC <4.9

Previous Next

Package: emacs;

Reported by: Spencer Baugh <sbaugh <at> janestreet.com>

Date: Wed, 17 May 2023 17:39:02 UTC

Severity: normal

Found in version 29.0.90

Done: Paul Eggert <eggert <at> cs.ucla.edu>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: Eli Zaretskii <eliz <at> gnu.org>
To: Po Lu <luangruo <at> yahoo.com>
Cc: sbaugh <at> janestreet.com, eggert <at> cs.ucla.edu, 63556 <at> debbugs.gnu.org
Subject: bug#63556: 29.0.90; Use of _Generic breaks Emacs build on GCC <4.9
Date: Thu, 18 May 2023 14:42:27 +0300
> Cc: Spencer Baugh <sbaugh <at> janestreet.com>, 63556 <at> debbugs.gnu.org
> Date: Thu, 18 May 2023 19:11:07 +0800
> From:  Po Lu via "Bug reports for GNU Emacs,
>  the Swiss army knife of text editors" <bug-gnu-emacs <at> gnu.org>
> 
> Paul Eggert <eggert <at> cs.ucla.edu> writes:
> 
> > Thanks for reporting the problem. Since _Generic is used here merely
> > as a micro-optimization on 32-bit platforms, it's not worth whatever
> > porting hassle you've run into, so I installed the attached patch so
> > that modiff no longer uses _Generic.
> 
> Would anyone mind if I made configure check for that?

Depends on how complex is that, and what problem does it solve.

> Btw, couldn't the macro be defined to something along the lines of this
> when the compiler only supports C99?
> 
>   #define foo(expression)			  \
>     (sizeof (expression) == sizeof (signed char)  \
>      ? code_for_signed_char			  \
>      : (sizeof (expression) == sizeof (short int) \
> 	? code_for_short_int			  \
> 	: (sizeof (expression) == sizeof (int)	  \
> 	   ? code_for_int			  \
> 	   ... and so on

AFAIR, sizeof is a compile-time expression, the preprocessor cannot
evaluate it.




This bug report was last modified 2 years and 1 day ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.