From unknown Mon Aug 18 00:05:38 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#63552 <63552@debbugs.gnu.org> To: bug#63552 <63552@debbugs.gnu.org> Subject: Status: 29.0.91; M-x completion-predicate does not account for python-ts-mode Reply-To: bug#63552 <63552@debbugs.gnu.org> Date: Mon, 18 Aug 2025 07:05:38 +0000 retitle 63552 29.0.91; M-x completion-predicate does not account for python= -ts-mode reassign 63552 emacs submitter 63552 Basil Contovounesios severity 63552 minor tag 63552 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Wed May 17 07:55:16 2023 Received: (at submit) by debbugs.gnu.org; 17 May 2023 11:55:16 +0000 Received: from localhost ([127.0.0.1]:49178 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pzFkR-0003mP-6W for submit@debbugs.gnu.org; Wed, 17 May 2023 07:55:16 -0400 Received: from lists.gnu.org ([209.51.188.17]:45808) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pzFkO-0003m5-Ui for submit@debbugs.gnu.org; Wed, 17 May 2023 07:55:14 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pzFkO-0002qo-Fx for bug-gnu-emacs@gnu.org; Wed, 17 May 2023 07:55:12 -0400 Received: from mail-wm1-x335.google.com ([2a00:1450:4864:20::335]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pzFkD-0000gU-RD for bug-gnu-emacs@gnu.org; Wed, 17 May 2023 07:55:10 -0400 Received: by mail-wm1-x335.google.com with SMTP id 5b1f17b1804b1-3f42d937d2eso4427385e9.2 for ; Wed, 17 May 2023 04:54:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd.ie; s=google21; t=1684324498; x=1686916498; h=mime-version:message-id:date:subject:to:from:from:to:cc:subject :date:message-id:reply-to; bh=uGfWFtrDOOGpMPE/7TFNm6oF89lpZCgzNVZtapQcmyA=; b=K4mhIywfZ4AMvQokR0FxV0vhGhq5r3+UDgMZ6HBpvFpuYIXbfdBrOmbgfs+VqaOenk TYxqqz96b5jaelF6kIj++ohhKVv0rxkN6ezQODdNguDeWZvt44EZD62zOlckjOQC6LjR 2iIjm3OH85BVo3bSvuIk+XbhrbAAn/LfPkVjK0O/X9eneHAYkxDgc8SxjRIMO/X6TPa8 daGcEDFcmbtMZuIjA4r1OpRrnPltvQYKRTRpuQaNdb2l8ek6ilr3dhI+xQSWk2tgAKqF 2xMvRq45N3ZpFM1bkZsI18TJifeF7Bfe/mJ7zuFgroEjBG/Z8lkEpIGKvd03B/z6ywcw 7/+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684324498; x=1686916498; h=mime-version:message-id:date:subject:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=uGfWFtrDOOGpMPE/7TFNm6oF89lpZCgzNVZtapQcmyA=; b=OE9aT99qVOWtRCg9wbk6kKxUUR2+CxhYX9ndP9qUZTXyzvrnhdbNBTWuhCrve701T2 XxE0WqIB+48ixTDigGxcQPUwC4fM2pRLYrAY0uZuWJQuUZcnL1zMzQMiG4i2tJmM/4gT JBrBqCG7m8Iwn3po7flSmmHmES48za6kP2lqBxjN1NqX0Ete4py4juP/UpCKR3bGDJNj gXYvOBHjDE24TgluARRWhnL1/gzjLOfls2XIEoycl+Jkm4Rl2wSFsckA8rh9/8lZiB7k i4fxkVuoacl2WHHz5VuPbzrcsDdbC5txoBQOPF0WRhQlo9ExLGDkfXfPAog61qCzIi50 Pd3w== X-Gm-Message-State: AC+VfDzpPOYSD3HkQ0657aZXscQoRNbDuIl6AcTyuXx4+BSxwzp6njdM RRe+Yxm3osPak2lQ4bfESfl+bxiSDFGqcYgH4Ww= X-Google-Smtp-Source: ACHHUZ4f2uJd0I88R8sFpm8guUiyZSkeUO8glvgMtg+yFDw9PVKErsrL43NXgHDkszhcBZWgIyUvcQ== X-Received: by 2002:adf:e112:0:b0:307:834f:7159 with SMTP id t18-20020adfe112000000b00307834f7159mr519802wrz.4.1684324498157; Wed, 17 May 2023 04:54:58 -0700 (PDT) Received: from localhost ([217.173.96.166]) by smtp.gmail.com with ESMTPSA id w13-20020adfee4d000000b003063176ef09sm2669485wro.6.2023.05.17.04.54.57 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 May 2023 04:54:57 -0700 (PDT) From: Basil Contovounesios To: bug-gnu-emacs@gnu.org Subject: 29.0.91; M-x completion-predicate does not account for python-ts-mode X-Debbugs-Cc: Augusto Stoffel Date: Wed, 17 May 2023 12:54:56 +0100 Message-ID: <87353vrx4f.fsf@tcd.ie> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=2a00:1450:4864:20::335; envelope-from=contovob@tcd.ie; helo=mail-wm1-x335.google.com X-Spam_score_int: -16 X-Spam_score: -1.7 X-Spam_bar: - X-Spam_report: (-1.7 / 5.0 requ) BAYES_00=-1.9, DKIM_INVALID=0.1, DKIM_SIGNED=0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) --=-=-= Content-Type: text/plain Severity: minor Tags: patch At the time of https://bugs.gnu.org/57184 python-ts-mode did not yet exist, so the completion-predicates added to python.el as part of that report understandably assumed only python-mode exists. Here's what that means in practice: 0. emacs -Q 1. (setq read-extended-command-predicate #'command-completion-default-include-p) 2. C-x C-e 3. M-x python-ts-mode RET 4. M-x python-sort TAB => [No match] And yet python-sort-imports is present in the local map: 5. C-g 6. C-h f python-sort-imports RET => It is bound to C-c TAB s. By contrast, in python-mode: 7. M-x python-mode RET 8. M-x python-sort TAB => Completes to python-sort-imports The following patch fixes this by associating M-x completion with python-base-mode rather than python-mode: --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=0001-Fix-M-x-completion-predicate-under-python-ts-mode.patch >From e71f85ef40e99e8ebc65b7907c5d487d47b0a66f Mon Sep 17 00:00:00 2001 From: "Basil L. Contovounesios" Date: Mon, 15 May 2023 16:28:56 +0100 Subject: [PATCH] Fix M-x completion-predicate under python-ts-mode * lisp/progmodes/python.el: (python-skeleton-define): Filter M-x completion based on python-base-mode instead of python-mode. This allows for python-ts-mode as well. Use command-modes as a shorthand for completion-predicate. (python--completion-predicate, python-shell--completion-predicate): Remove accordingly; no longer used. (python-define-auxiliary-skeleton): Prefer function-put over put. --- lisp/progmodes/python.el | 22 ++++++---------------- 1 file changed, 6 insertions(+), 16 deletions(-) diff --git a/lisp/progmodes/python.el b/lisp/progmodes/python.el index bbabce80b4d..92ac84ff099 100644 --- a/lisp/progmodes/python.el +++ b/lisp/progmodes/python.el @@ -4964,11 +4964,6 @@ 'python-mode-skeleton-abbrev-table (not (python-syntax-comment-or-string-p)) python-skeleton-autoinsert))) -(defun python--completion-predicate (_ buffer) - (provided-mode-derived-p - (buffer-local-value 'major-mode buffer) - 'python-mode)) - (defmacro python-skeleton-define (name doc &rest skel) "Define a `python-mode' skeleton using NAME DOC and SKEL. The skeleton will be bound to python-skeleton-NAME and will @@ -4977,7 +4972,7 @@ python-skeleton-define (let* ((name (symbol-name name)) (function-name (intern (concat "python-skeleton-" name)))) `(progn - (put ',function-name 'completion-predicate #'python--completion-predicate) + (function-put ',function-name 'command-modes '(python-base-mode)) (define-abbrev python-mode-skeleton-abbrev-table ,name "" ',function-name :system t) (setq python-skeleton-available @@ -5004,7 +4999,7 @@ python-define-auxiliary-skeleton `(< ,(format "%s:" name) \n \n > _ \n))) `(progn - (put ',function-name 'completion-predicate #'ignore) + (function-put ',function-name 'completion-predicate #'ignore) (define-skeleton ,function-name ,(or doc (format "Auxiliary skeleton for %s statement." name)) @@ -6752,7 +6747,7 @@ python-ts-mode (add-to-list 'interpreter-mode-alist '("python[0-9.]*" . python-ts-mode)))) ;;; Completion predicates for M-x -;; Commands that only make sense when editing Python code +;; Commands that only make sense when editing Python code. (dolist (sym '(python-add-import python-check python-fill-paragraph @@ -6786,12 +6781,7 @@ python-ts-mode python-shell-send-defun python-shell-send-statement python-sort-imports)) - (put sym 'completion-predicate #'python--completion-predicate)) - -(defun python-shell--completion-predicate (_ buffer) - (provided-mode-derived-p - (buffer-local-value 'major-mode buffer) - 'python-mode 'inferior-python-mode)) + (function-put sym 'command-modes '(python-base-mode))) ;; Commands that only make sense in the Python shell or when editing ;; Python code. @@ -6806,8 +6796,8 @@ python-shell--completion-predicate python-shell-font-lock-turn-off python-shell-font-lock-turn-on python-shell-package-enable - python-shell-completion-complete-or-indent )) - (put sym 'completion-predicate #'python-shell--completion-predicate)) + python-shell-completion-complete-or-indent)) + (function-put sym 'command-modes '(python-base-mode inferior-python-mode))) (provide 'python) -- 2.34.1 --=-=-= Content-Type: text/plain WDYT? Thanks, -- Basil In GNU Emacs 29.0.91 (build 1, x86_64-pc-linux-gnu, X toolkit, cairo version 1.16.0, Xaw3d scroll bars) of 2023-05-17 built on blc Repository revision: b5bfd808c6b40f47fdef8eb9986bc3127ca63c12 Repository branch: wt/emacs-29 Windowing system distributor 'The X.Org Foundation', version 11.0.12101004 System Description: Ubuntu 22.04.2 LTS Configured using: 'configure CC=gcc-12 'CFLAGS=-Og -ggdb3' --prefix=/home/bic/.local --with-program-suffix=-29 --with-file-notification=yes --with-x --with-x-toolkit=lucid' Configured features: ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ JPEG JSON LCMS2 LIBOTF LIBSELINUX LIBSYSTEMD LIBXML2 M17N_FLT MODULES NOTIFY INOTIFY PDUMPER PNG RSVG SECCOMP SOUND SQLITE3 THREADS TIFF TOOLKIT_SCROLL_BARS TREE_SITTER WEBP X11 XAW3D XDBE XIM XINPUT2 XPM LUCID ZLIB Important settings: value of $LC_MONETARY: en_IE.UTF-8 value of $LC_NUMERIC: en_IE.UTF-8 value of $LC_TIME: en_IE.UTF-8 value of $LANG: en_GB.UTF-8 value of $XMODIFIERS: @im=ibus locale-coding-system: utf-8-unix Major mode: Python Minor modes in effect: tooltip-mode: t global-eldoc-mode: t eldoc-mode: t show-paren-mode: t electric-indent-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t line-number-mode: t transient-mark-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t Load-path shadows: None found. Features: (shadow sort mail-extr emacsbug message mailcap yank-media puny dired dired-loaddefs rfc822 mml mml-sec password-cache epa derived epg rfc6068 epg-config gnus-util text-property-search time-date subr-x mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils python rx project byte-opt gv bytecomp byte-compile pcase treesit cl-seq comint ansi-osc ring cl-loaddefs cl-lib ansi-color rmc iso-transl tooltip cconv eldoc paren electric uniquify ediff-hook vc-hooks lisp-float-type elisp-mode mwheel term/x-win x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors frame minibuffer nadvice seq simple cl-generic indonesian philippine cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite emoji-zwj charscript charprop case-table epa-hook jka-cmpr-hook help abbrev obarray oclosure cl-preloaded button loaddefs theme-loaddefs faces cus-face macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget keymap hashtable-print-readable backquote threads dbusbind inotify lcms2 dynamic-setting system-font-setting font-render-setting cairo x-toolkit xinput2 x multi-tty make-network-process emacs) Memory information: ((conses 16 55041 6025) (symbols 48 7135 0) (strings 32 20473 1599) (string-bytes 1 602759) (vectors 16 13421) (vector-slots 8 186939 9110) (floats 8 27 35) (intervals 56 274 0) (buffers 984 10)) --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Wed May 17 08:40:18 2023 Received: (at 63552) by debbugs.gnu.org; 17 May 2023 12:40:18 +0000 Received: from localhost ([127.0.0.1]:49228 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pzGS1-000552-Qq for submit@debbugs.gnu.org; Wed, 17 May 2023 08:40:18 -0400 Received: from eggs.gnu.org ([209.51.188.92]:41434) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pzGS0-00054q-Ck for 63552@debbugs.gnu.org; Wed, 17 May 2023 08:40:17 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pzGRt-0001al-Kn; Wed, 17 May 2023 08:40:10 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=Dx35MX1lZsnd713zVb/SAEunf+8Gq4JsaIydiniNgN0=; b=OXSfF5N8JIUJ qXCZECgUWhp//jkiwk9RYSSecPyfG9eNVSVD4S4CJS74JyzRlnbRXvhvc3rJ6SrGNfVhrb2VjDr/A dhgcdRvY+hOp9zitdUqdLGR+xOZphnH2XHBBN0dQS0xz1RW5mOw+BTzk34afhabg2/0ikq5lGYCTD UM6CMR7xfwq0zMefmBhc5JLyJJpc+shGTpo8ZVZ/KUe5AKSZ9s79+hG9B7hXOGUSw05U+dUYJPfpv 1mDK9r/XNed6ixo08PFUzJ3gXBjzs7902im83SmI8RA4/wzJBtSZLwLWP1r0eEqT1Y5h6eYzcNFTr lxNStx5VdCifaWqdLjAXIA==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pzGRe-0004no-Du; Wed, 17 May 2023 08:40:09 -0400 Date: Wed, 17 May 2023 15:40:03 +0300 Message-Id: <83h6sbxhb0.fsf@gnu.org> From: Eli Zaretskii To: Basil Contovounesios In-Reply-To: <87353vrx4f.fsf@tcd.ie> (bug-gnu-emacs@gnu.org) Subject: Re: bug#63552: 29.0.91; M-x completion-predicate does not account for python-ts-mode References: <87353vrx4f.fsf@tcd.ie> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 63552 Cc: 63552@debbugs.gnu.org, arstoffel@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Cc: Augusto Stoffel > Date: Wed, 17 May 2023 12:54:56 +0100 > From: Basil Contovounesios via "Bug reports for GNU Emacs, > the Swiss army knife of text editors" > > At the time of https://bugs.gnu.org/57184 python-ts-mode did not yet > exist, so the completion-predicates added to python.el as part of that > report understandably assumed only python-mode exists. > > Here's what that means in practice: > > 0. emacs -Q > 1. (setq read-extended-command-predicate > #'command-completion-default-include-p) > 2. C-x C-e > 3. M-x python-ts-mode RET > 4. M-x python-sort TAB > => [No match] > > And yet python-sort-imports is present in the local map: > > 5. C-g > 6. C-h f python-sort-imports RET > => It is bound to C-c TAB s. > > By contrast, in python-mode: > > 7. M-x python-mode RET > 8. M-x python-sort TAB > => Completes to python-sort-imports > > The following patch fixes this by associating M-x completion with > python-base-mode rather than python-mode: Thanks. We need to fix tis on the emacs-29 branch, so I wonder whether the fix can be simpler? After all, we just need to test one more major mode, right? If a simpler fix is less clean, we could install a simpler change on emacs-29 and a cleaner one on master. From debbugs-submit-bounces@debbugs.gnu.org Wed May 17 08:59:59 2023 Received: (at 63552) by debbugs.gnu.org; 17 May 2023 12:59:59 +0000 Received: from localhost ([127.0.0.1]:49251 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pzGl4-0005mh-Tu for submit@debbugs.gnu.org; Wed, 17 May 2023 08:59:59 -0400 Received: from mail-wr1-f50.google.com ([209.85.221.50]:46341) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pzGl2-0005mR-Je for 63552@debbugs.gnu.org; Wed, 17 May 2023 08:59:57 -0400 Received: by mail-wr1-f50.google.com with SMTP id ffacd0b85a97d-3075e802738so720764f8f.1 for <63552@debbugs.gnu.org>; Wed, 17 May 2023 05:59:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd.ie; s=google21; t=1684328391; x=1686920391; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=bnacFNd9rb9u4LIdjvzW89gIhlzgtW5DsPl53x6d2A0=; b=AHcpJ3oEXx6+uMEIxnTWkiO0DqHOwBd81rGgovZ8QMVqfKJWoZsmifU/QDCC7GwEfI hss4MBC7uONSQrfVQytwIIL/+8TMfxwbhDV5ArBGuDGJZSL2Y5+7EvHlAvZknKJ9QGIs M/xwtpd4NtQsl9iGk4cGnkCfCgDeReBXPt3blQEp+5/DnKpHTS+WDd24NDdJNW9q8MP4 GQWPkO6eFNxiVLkE4YprCJh7kiiU/sl+E3BD9AVcAwPt2f/uMO/I9GKc/IfMqHKq/vLa c7lQ+/QX5EBJcetghQrxbCEchfymh7Ksjb3jbtX3buI/e7GEeRHPodiXfbtLyiw/m+LL qZyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684328391; x=1686920391; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=bnacFNd9rb9u4LIdjvzW89gIhlzgtW5DsPl53x6d2A0=; b=D9yTP2fd0gIhQCO7h+SH8Y45XztuD38/9POWZ2byCXlhjkVTr55ssWVKcBJEdkxMXi Z0OCV29zKE7T4oF5abJ+g7sF6Gk1KnMbsV654opRtS3ZnVsgGoHujHetFjGsThu7yncy NLSfdFsO7Hwv9u4zNJmVq0+5NTLKkou++EQz5JMBwyOut4KlpC9oojMPozPSLQxaxdHs CPS4G8aptIY4wWWg7q7xNoq1FpZZGxcEQIPitGRCLM4iZ80oPiNtFWSgu4r74tOIslzT jYNjUIZAapbnGAbZ7/cJ+J8esGcSIOqIBTUGMSqnaIAGF5cyTscsUeYtAy3X5zmlvFlc UKRg== X-Gm-Message-State: AC+VfDwJB9NTxaCtgi/zWJIzd3Cz2az2PtjUOOOH5TsKTL2SiY7sWno8 JE040lzZohR52S0q1AMdCgiVDg== X-Google-Smtp-Source: ACHHUZ5Xri0xKHFHVXrlXKhVerxqizBkAFxK8hJMXClMFGIprfFkBCRMoFRddX4+LXOfGlX3VsQYRg== X-Received: by 2002:a05:6000:104b:b0:309:cb7:1935 with SMTP id c11-20020a056000104b00b003090cb71935mr702948wrx.25.1684328390665; Wed, 17 May 2023 05:59:50 -0700 (PDT) Received: from localhost ([217.173.96.166]) by smtp.gmail.com with ESMTPSA id i15-20020a5d630f000000b003079ed1f0a0sm2663447wru.44.2023.05.17.05.59.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 May 2023 05:59:49 -0700 (PDT) From: Basil Contovounesios To: Eli Zaretskii Subject: Re: bug#63552: 29.0.91; M-x completion-predicate does not account for python-ts-mode In-Reply-To: <83h6sbxhb0.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 17 May 2023 15:40:03 +0300") References: <87353vrx4f.fsf@tcd.ie> <83h6sbxhb0.fsf@gnu.org> Date: Wed, 17 May 2023 13:59:48 +0100 Message-ID: <87pm6z8663.fsf@tcd.ie> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 63552 Cc: 63552@debbugs.gnu.org, arstoffel@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain Eli Zaretskii [2023-05-17 15:40 +0300] wrote: > We need to fix tis on the emacs-29 branch, so I wonder whether the fix > can be simpler? After all, we just need to test one more major mode, > right? Right. How's this for emacs-29: --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=0001-Fix-M-x-completion-predicate-under-python-ts-mode.patch >From 07a1869671a7a7bd3a24bb3605f5b4bb88469405 Mon Sep 17 00:00:00 2001 From: "Basil L. Contovounesios" Date: Wed, 17 May 2023 13:48:09 +0100 Subject: [PATCH] Fix M-x completion-predicate under python-ts-mode * lisp/progmodes/python.el (python--completion-predicate) (python-shell--completion-predicate): Filter M-x completion based on python-base-mode instead of python-mode. This allows for python-ts-mode as well (bug#63552). --- lisp/progmodes/python.el | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lisp/progmodes/python.el b/lisp/progmodes/python.el index bbabce80b4d..f810f1e2164 100644 --- a/lisp/progmodes/python.el +++ b/lisp/progmodes/python.el @@ -4967,7 +4967,7 @@ 'python-mode-skeleton-abbrev-table (defun python--completion-predicate (_ buffer) (provided-mode-derived-p (buffer-local-value 'major-mode buffer) - 'python-mode)) + 'python-base-mode)) (defmacro python-skeleton-define (name doc &rest skel) "Define a `python-mode' skeleton using NAME DOC and SKEL. @@ -6791,7 +6791,7 @@ python-ts-mode (defun python-shell--completion-predicate (_ buffer) (provided-mode-derived-p (buffer-local-value 'major-mode buffer) - 'python-mode 'inferior-python-mode)) + 'python-base-mode 'inferior-python-mode)) ;; Commands that only make sense in the Python shell or when editing ;; Python code. -- 2.34.1 --=-=-= Content-Type: text/plain > If a simpler fix is less clean, we could install a simpler change on > emacs-29 and a cleaner one on master. And this for master, once the patch above is merged: --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=0001-Simplify-python.el-completion-predicate.patch >From 17519e4dbdc1b90c6fb9d02297a00e1e30e7c3b0 Mon Sep 17 00:00:00 2001 From: "Basil L. Contovounesios" Date: Wed, 17 May 2023 13:53:09 +0100 Subject: [PATCH] Simplify python.el completion-predicate * lisp/progmodes/python.el: (python-skeleton-define): Use command-modes as a shorthand for completion-predicate (bug#63552). (python--completion-predicate, python-shell--completion-predicate): Remove accordingly; no longer used. (python-define-auxiliary-skeleton): Prefer function-put over put. --- lisp/progmodes/python.el | 22 ++++++---------------- 1 file changed, 6 insertions(+), 16 deletions(-) diff --git a/lisp/progmodes/python.el b/lisp/progmodes/python.el index 0ddce92b21e..4f57eda3cfc 100644 --- a/lisp/progmodes/python.el +++ b/lisp/progmodes/python.el @@ -5029,11 +5029,6 @@ 'python-mode-skeleton-abbrev-table (not (python-syntax-comment-or-string-p)) python-skeleton-autoinsert))) -(defun python--completion-predicate (_ buffer) - (provided-mode-derived-p - (buffer-local-value 'major-mode buffer) - 'python-base-mode)) - (defmacro python-skeleton-define (name doc &rest skel) "Define a `python-mode' skeleton using NAME DOC and SKEL. The skeleton will be bound to python-skeleton-NAME and will @@ -5042,7 +5037,7 @@ python-skeleton-define (let* ((name (symbol-name name)) (function-name (intern (concat "python-skeleton-" name)))) `(progn - (put ',function-name 'completion-predicate #'python--completion-predicate) + (function-put ',function-name 'command-modes '(python-base-mode)) (define-abbrev python-mode-skeleton-abbrev-table ,name "" ',function-name :system t) (setq python-skeleton-available @@ -5069,7 +5064,7 @@ python-define-auxiliary-skeleton `(< ,(format "%s:" name) \n \n > _ \n))) `(progn - (put ',function-name 'completion-predicate #'ignore) + (function-put ',function-name 'completion-predicate #'ignore) (define-skeleton ,function-name ,(or doc (format "Auxiliary skeleton for %s statement." name)) @@ -6817,7 +6812,7 @@ python-ts-mode (add-to-list 'interpreter-mode-alist '("python[0-9.]*" . python-ts-mode)))) ;;; Completion predicates for M-x -;; Commands that only make sense when editing Python code +;; Commands that only make sense when editing Python code. (dolist (sym '(python-add-import python-check python-fill-paragraph @@ -6851,12 +6846,7 @@ python-ts-mode python-shell-send-defun python-shell-send-statement python-sort-imports)) - (put sym 'completion-predicate #'python--completion-predicate)) - -(defun python-shell--completion-predicate (_ buffer) - (provided-mode-derived-p - (buffer-local-value 'major-mode buffer) - 'python-base-mode 'inferior-python-mode)) + (function-put sym 'command-modes '(python-base-mode))) ;; Commands that only make sense in the Python shell or when editing ;; Python code. @@ -6871,8 +6861,8 @@ python-shell--completion-predicate python-shell-font-lock-turn-off python-shell-font-lock-turn-on python-shell-package-enable - python-shell-completion-complete-or-indent )) - (put sym 'completion-predicate #'python-shell--completion-predicate)) + python-shell-completion-complete-or-indent)) + (function-put sym 'command-modes '(python-base-mode inferior-python-mode))) (provide 'python) -- 2.34.1 --=-=-= Content-Type: text/plain Thanks, -- Basil --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Wed May 17 09:33:18 2023 Received: (at 63552) by debbugs.gnu.org; 17 May 2023 13:33:19 +0000 Received: from localhost ([127.0.0.1]:49290 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pzHHK-0000mF-H5 for submit@debbugs.gnu.org; Wed, 17 May 2023 09:33:18 -0400 Received: from eggs.gnu.org ([209.51.188.92]:58474) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pzHHI-0000lx-8C for 63552@debbugs.gnu.org; Wed, 17 May 2023 09:33:17 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pzHHC-00042Y-II; Wed, 17 May 2023 09:33:10 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=hd8AFiDxHnHwtx/HuZjTMPIXksFMCXEHXZP7zaKctOA=; b=lob/6/acmenS rg/YYUa04R8Z80GlGtwhnrLUCa1fFqzy2vqK74cw8EUTwu13Ca3YOXYXObqdhb3+csvBTTGIpxdNL qX9JyY42zmw9+hvwS1rVfYjefCSDqy4FSZ3bciirtcNpD6LSbLDkfS5FLXFPtn699P01gYXPF1BJn 7X4gvw/SIPeWTEEJycsSwAhrmEpBg6CHUVzcCLfv+iT2th/CFmuKNCpGDClnhLgF9pMPhEXXHZecZ beHyeW3LVX5kkg1ou7eeP3x36EFUJto6eeR9rWVU1QbP9t48u30M/XWs6EtUkh3RzrzTCkfQ13VVm XnekN1gdrBnaiqlj+QAbkQ==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pzHHB-0003Bu-Pj; Wed, 17 May 2023 09:33:10 -0400 Date: Wed, 17 May 2023 16:33:19 +0300 Message-Id: <83cz2zxeu8.fsf@gnu.org> From: Eli Zaretskii To: Basil Contovounesios In-Reply-To: <87pm6z8663.fsf@tcd.ie> (message from Basil Contovounesios on Wed, 17 May 2023 13:59:48 +0100) Subject: Re: bug#63552: 29.0.91; M-x completion-predicate does not account for python-ts-mode References: <87353vrx4f.fsf@tcd.ie> <83h6sbxhb0.fsf@gnu.org> <87pm6z8663.fsf@tcd.ie> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 63552 Cc: 63552@debbugs.gnu.org, arstoffel@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Basil Contovounesios > Cc: 63552@debbugs.gnu.org, arstoffel@gmail.com > Date: Wed, 17 May 2023 13:59:48 +0100 > > Eli Zaretskii [2023-05-17 15:40 +0300] wrote: > > > We need to fix tis on the emacs-29 branch, so I wonder whether the fix > > can be simpler? After all, we just need to test one more major mode, > > right? > > Right. How's this for emacs-29: Perfect, please install. > And this for master, once the patch above is merged: LGTM, thanks. From debbugs-submit-bounces@debbugs.gnu.org Wed May 17 10:16:16 2023 Received: (at 63552) by debbugs.gnu.org; 17 May 2023 14:16:17 +0000 Received: from localhost ([127.0.0.1]:50577 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pzHwu-0004zq-KD for submit@debbugs.gnu.org; Wed, 17 May 2023 10:16:16 -0400 Received: from mail-wm1-f46.google.com ([209.85.128.46]:53648) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pzHws-0004zc-QA for 63552@debbugs.gnu.org; Wed, 17 May 2023 10:16:15 -0400 Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-3f42bcf5df1so8284125e9.3 for <63552@debbugs.gnu.org>; Wed, 17 May 2023 07:16:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd.ie; s=google21; t=1684332969; x=1686924969; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=CL+YomppvLR5svom1xviwK0SaiTp80TY/hr+gV1R+14=; b=DFXiCTc8+3Q9hJBBttWcnatR57jLyXAKN2UomwyztpbgYj9zA66TSYcWpU9VP0rwVx f9MCA/hZHBbGYJB+0R/1wul3mcHXPbjOuIoHZPlTgvAibCU5EUzR6aFPwYK9pFfHwYA3 VkdSI6/7v3MWhvXOV2/m83oYT6YFkCF4KDtxfJtUs85xlulROjhTfWeG+rZfuWqbo/fS pojHAUTDSZEAEQsWlU7NHL52SecJFErh+6B8mgKd4eUj9N7o8EhytK8F/8f+3R/F6tV0 qgVXAPsn6wpTMg8aL1JpWVQo5R9clpH1heAfKomOx2rZvMb8krNPCfP+PjQy7y5eb+wo cfig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684332969; x=1686924969; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=CL+YomppvLR5svom1xviwK0SaiTp80TY/hr+gV1R+14=; b=F63ZrjQ2mkSVV0Mnt/Dgdwc72+8rsJQIA2zgrCX3dQusOQVv8ob+YmpcHyBEsdPDSg vgXNcFD2hV5xCGmSsYDGfUpU7WqRS07iSWHOg2cViDQ5Zj6MrJY01Fg/tkmCK83lVobD voskE9LZ3jrwElxAinf1yGln6nO7bymGnmlDRmNsCBqgpG0JJQWUfrOuzmhabGv1Ckh6 AcnktlJjnzfrqMf1DYN6ZEiHkgBb15tNMtfr/5y7oZ68PZcjR91gRh7PKLzkYYqhP2D6 OLeXjBTCKJlCU+PMc6iKtQxBXOID8L5//9zt1mJg8hYb92VZeb+de3vVJTzSBXJwOZzI wkyw== X-Gm-Message-State: AC+VfDzdvYBGLZjUjH24FFyrYw+EG8o+SkopLUubkNjQiIqyFn61u//R CsgHuWGz47/f3VHb/R4guoJaLA== X-Google-Smtp-Source: ACHHUZ7OkXyVsby0ix+KB8DsxtWUvVNf82XnbCzNWwzYMCKIHA88y/RolRf/HfP+GMDgSBpwACPZKA== X-Received: by 2002:a1c:7708:0:b0:3f4:278a:bb5a with SMTP id t8-20020a1c7708000000b003f4278abb5amr21454156wmi.14.1684332968922; Wed, 17 May 2023 07:16:08 -0700 (PDT) Received: from localhost ([217.173.96.166]) by smtp.gmail.com with ESMTPSA id a18-20020a1cf012000000b003f42d8dd7d1sm2481126wmb.7.2023.05.17.07.16.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 May 2023 07:16:08 -0700 (PDT) From: Basil Contovounesios To: Eli Zaretskii Subject: Re: bug#63552: 29.0.91; M-x completion-predicate does not account for python-ts-mode In-Reply-To: <83cz2zxeu8.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 17 May 2023 09:33:11 -0400") References: <87353vrx4f.fsf@tcd.ie> <83h6sbxhb0.fsf@gnu.org> <87pm6z8663.fsf@tcd.ie> <83cz2zxeu8.fsf@gnu.org> Date: Wed, 17 May 2023 15:16:07 +0100 Message-ID: <87h6sb82mw.fsf@tcd.ie> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 63552 Cc: 63552@debbugs.gnu.org, arstoffel@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii [2023-05-17 09:33 -0400] wrote: >> From: Basil Contovounesios >> Cc: 63552@debbugs.gnu.org, arstoffel@gmail.com >> Date: Wed, 17 May 2023 13:59:48 +0100 >> >> Eli Zaretskii [2023-05-17 15:40 +0300] wrote: >> >> > We need to fix tis on the emacs-29 branch, so I wonder whether the fix >> > can be simpler? After all, we just need to test one more major mode, >> > right? >> >> Right. How's this for emacs-29: > > Perfect, please install. Done: Fix M-x completion-predicate under python-ts-mode d879847cd4d 2023-05-17 15:14:09 +0100 https://git.sv.gnu.org/cgit/emacs.git/commit/?id=d879847cd4d >> And this for master, once the patch above is merged: > > LGTM, thanks. Thanks. I'll wait until someone else merges emacs-29 into master first since it's not easy for me to do so at the moment. -- Basil From debbugs-submit-bounces@debbugs.gnu.org Thu May 18 07:55:43 2023 Received: (at 63552) by debbugs.gnu.org; 18 May 2023 11:55:43 +0000 Received: from localhost ([127.0.0.1]:52315 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pzcER-0002QH-0M for submit@debbugs.gnu.org; Thu, 18 May 2023 07:55:43 -0400 Received: from eggs.gnu.org ([209.51.188.92]:45392) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pzcEO-0002PJ-Dx for 63552@debbugs.gnu.org; Thu, 18 May 2023 07:55:42 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pzcEI-0005oP-Oc; Thu, 18 May 2023 07:55:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=8q3tDvXP95VXdx86f08uOsmmm6i9nxFISDAvVPNc81U=; b=gU//ilO/t75A pS0wI4nSRxuAbPtAbf2kJiruCiZg0oZ0+vF8Wtat3rTuCN39aOJ0PdJXW2Qs/tZuePsivKF1u9kUy sMuQ3Zrtm51izYfxlgsXPJyQgyTF019TADXUvAZ1tPKbQhmYBMdQacbi6OmAVN6un9taGdp38/n8I +z8Yo4pCoMV8pSZts5t+ygu2bKk+qYCdYN/VjD9lK8+lgdxTdeuvz1RCCDlBP02aD1uXWyWfhX5hp D47nUtGSwPmfu8tVqeXJx/angNfb9u4E2EXZOKKzpAwnPU+bXjK8mgfOKjUs+pBKXLMeODsUv+Lm0 kma/ta2zQHw4vleWsEgN0w==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pzcEI-0002GO-14; Thu, 18 May 2023 07:55:34 -0400 Date: Thu, 18 May 2023 14:55:45 +0300 Message-Id: <83ttw9voou.fsf@gnu.org> From: Eli Zaretskii To: Basil Contovounesios In-Reply-To: <87h6sb82mw.fsf@tcd.ie> (message from Basil Contovounesios on Wed, 17 May 2023 15:16:07 +0100) Subject: Re: bug#63552: 29.0.91; M-x completion-predicate does not account for python-ts-mode References: <87353vrx4f.fsf@tcd.ie> <83h6sbxhb0.fsf@gnu.org> <87pm6z8663.fsf@tcd.ie> <83cz2zxeu8.fsf@gnu.org> <87h6sb82mw.fsf@tcd.ie> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 63552 Cc: 63552@debbugs.gnu.org, arstoffel@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Basil Contovounesios > Cc: 63552@debbugs.gnu.org, arstoffel@gmail.com > Date: Wed, 17 May 2023 15:16:07 +0100 > > > LGTM, thanks. > > Thanks. I'll wait until someone else merges emacs-29 into master first > since it's not easy for me to do so at the moment. I've done the merge from emacs-29 to master now, so you can go ahead with the changes on master. From debbugs-submit-bounces@debbugs.gnu.org Thu May 18 08:15:40 2023 Received: (at control) by debbugs.gnu.org; 18 May 2023 12:15:40 +0000 Received: from localhost ([127.0.0.1]:52463 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pzcXj-0002zE-Jz for submit@debbugs.gnu.org; Thu, 18 May 2023 08:15:39 -0400 Received: from mail-wm1-f51.google.com ([209.85.128.51]:62808) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pzcXf-0002yn-QD for control@debbugs.gnu.org; Thu, 18 May 2023 08:15:37 -0400 Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-3f509ec3196so71801005e9.1 for ; Thu, 18 May 2023 05:15:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd.ie; s=google21; t=1684412130; x=1687004130; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=phDARTxODtlscZcPDvHsl+A53p4j0g3YSRbOOyMob+M=; b=AyUg8eQXnNd40kIi5wDVxBNstP1LI9b1r9dQKXMqX3Mb8iJKLdQUh2iKcLbNnR/+uw FZDM0SWMpy43jcbALCcsjop8q/SVRjM7xqBnxYk4P5hHvng+MlEN33YxHIucz/y3MEky 1rZHljMJu37moeJzwqUW2puWOnMOyuin2Sf8U79BQRhU2K2SUQbKFrq3tYXDSRFKhcIi VWodSoIAyYyclJyhHqSlojvbqXdKjI/4AZsvJq4PhMVwAwkqu19r++K3OEZK0scnt4r3 FhtDKk/FJ4+9N8iSX8nqETQ2heABUOYGEl3MsUlTz2hanpxoTXnScECooBjuEgLdYc66 6h7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684412130; x=1687004130; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=phDARTxODtlscZcPDvHsl+A53p4j0g3YSRbOOyMob+M=; b=bb3JZiCgDEK9KUXuhkhZwDNBD0ULyHuUJhu9PwN1fyQDi59RUFCPBHSLPm1Ccb2b8E nqPrbWdLPVPSbtjGErgXp8tXdQnMT3iFZQotSIkaJOd+s9RQ3pZwVoACiIw/8ct6UclV 2sAi271a7hgmd4Lq4HE5SixP74YFdZ7OUgGdQV7/StRB7R/KJt9HD12bm59on0GhmSND ECu82xSzjJhpdAUTWOLc+73Fe4Ga3wOLWuqT9ryqzHxJwjAM7tEB8r/g5MUG0LukgDji LcjuNOpvy5XTl/OpAxw8Dke+zb0p02LF2krjVeV0nSyaVM4Y7biqXzy97EmhejQxHfla 8SQw== X-Gm-Message-State: AC+VfDxK0CzeedAAZkOmZPNcSyhyHZjKrIjvdXKAjQlPwOGKpQ44jpvi WrdpU9sAcRJVWtSHKfaeQgG/VA== X-Google-Smtp-Source: ACHHUZ61zCIZjVw/GiYALJr6bSooUdiN8pAbpa/iviEytmga2YxhDkhie/0yP52r2p10rBbB+o8vYQ== X-Received: by 2002:a5d:6e01:0:b0:309:48eb:993d with SMTP id h1-20020a5d6e01000000b0030948eb993dmr1201669wrz.15.1684412129772; Thu, 18 May 2023 05:15:29 -0700 (PDT) Received: from localhost ([217.173.96.166]) by smtp.gmail.com with ESMTPSA id z2-20020adfe542000000b0030647449730sm2045293wrm.74.2023.05.18.05.15.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 May 2023 05:15:29 -0700 (PDT) From: Basil Contovounesios To: Eli Zaretskii Subject: Re: bug#63552: 29.0.91; M-x completion-predicate does not account for python-ts-mode In-Reply-To: <83ttw9voou.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 18 May 2023 07:55:35 -0400") References: <87353vrx4f.fsf@tcd.ie> <83h6sbxhb0.fsf@gnu.org> <87pm6z8663.fsf@tcd.ie> <83cz2zxeu8.fsf@gnu.org> <87h6sb82mw.fsf@tcd.ie> <83ttw9voou.fsf@gnu.org> Date: Thu, 18 May 2023 13:15:27 +0100 Message-ID: <875y8pltsw.fsf@tcd.ie> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: control Cc: 63552-done@debbugs.gnu.org, arstoffel@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) close 63552 29.1 quit Eli Zaretskii [2023-05-18 07:55 -0400] wrote: >> From: Basil Contovounesios >> Cc: 63552@debbugs.gnu.org, arstoffel@gmail.com >> Date: Wed, 17 May 2023 15:16:07 +0100 >> >> Thanks. I'll wait until someone else merges emacs-29 into master first >> since it's not easy for me to do so at the moment. > > I've done the merge from emacs-29 to master now, so you can go ahead > with the changes on master. Great, thank you. Done and closing: Simplify python.el completion-predicate d1404d3a119 2023-05-18 13:10:09 +0100 https://git.sv.gnu.org/cgit/emacs.git/commit/?id=d1404d3a119 -- Basil From unknown Mon Aug 18 00:05:38 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 16 Jun 2023 11:24:08 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator