GNU bug report logs - #63550
proced-refine-with-update-test is racy

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Mattias Engdegård <mattias.engdegard <at> gmail.com>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#63550: closed (proced-refine-with-update-test is racy)
Date: Sun, 28 May 2023 11:40:03 +0000

[Message part 1 (text/plain, inline)]

Your message dated Sun, 28 May 2023 13:39:16 +0200
with message-id <251295F6-588A-4CDD-8B59-5730CC4F2430 <at> gmail.com>
and subject line Re: bug#63550: proced-refine-with-update-test is racy
has caused the debbugs.gnu.org bug report #63550,
regarding proced-refine-with-update-test is racy
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
63550: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=63550
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Mattias Engdegård <mattias.engdegard <at> gmail.com>
To: Emacs Bug Report <bug-gnu-emacs <at> gnu.org>
Cc: Laurence Warne <laurencewarne <at> gmail.com>
Subject: proced-refine-with-update-test is racy
Date: Wed, 17 May 2023 11:38:22 +0200

The proced test `proced-refine-with-update-test` seems to have an update race which makes it fail randomly. (This is on macOS, but I see no reason it would be much different elsewhere.)
I'm marking it :unstable for now.

[Message part 3 (message/rfc822, inline)]

From: Mattias Engdegård <mattias.engdegard <at> gmail.com>
To: Laurence Warne <laurencewarne <at> gmail.com>
Cc: Basil Contovounesios <contovob <at> tcd.ie>, Eli Zaretskii <eliz <at> gnu.org>,
 63550-done <at> debbugs.gnu.org
Subject: Re: bug#63550: proced-refine-with-update-test is racy
Date: Sun, 28 May 2023 13:39:16 +0200

27 maj 2023 kl. 21.14 skrev Laurence Warne <laurencewarne <at> gmail.com>:

> Sorry I was wrong here, if the process used for the refinement exited between proced being called, and then `(proced-update t)` being called, then the whole process list will be shown as proced would skip applying the refinement.  So I think using (proced-update) instead of (proced-update t) is the simplest fix since it means `proced-process-alist` will never be refreshed.  I've re-attached the patch from before, but with a bit more explanation.

Looks fine, applied and pushed and closing the bug. Thank you!
(I took the liberty to reflow the comments to fit within 80 columns.)

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.