From unknown Sun Aug 10 07:32:50 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#63545] [PATCH 0/3] gnu: heimdal: Drop obsolete user tools. Resent-From: Felix Lechner Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 17 May 2023 04:20:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 63545 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 63545@debbugs.gnu.org Cc: Felix Lechner X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.168429719916580 (code B ref -1); Wed, 17 May 2023 04:20:02 +0000 Received: (at submit) by debbugs.gnu.org; 17 May 2023 04:19:59 +0000 Received: from localhost ([127.0.0.1]:48463 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pz8dq-0004JM-TC for submit@debbugs.gnu.org; Wed, 17 May 2023 00:19:59 -0400 Received: from lists.gnu.org ([209.51.188.17]:56082) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pz8dn-0004JD-K8 for submit@debbugs.gnu.org; Wed, 17 May 2023 00:19:57 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pz8dm-0007yB-Mj for guix-patches@gnu.org; Wed, 17 May 2023 00:19:55 -0400 Received: from sail-ipv4.us-core.com ([208.82.101.137]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_CHACHA20_POLY1305:256) (Exim 4.90_1) (envelope-from ) id 1pz8dk-0006BL-Pe for guix-patches@gnu.org; Wed, 17 May 2023 00:19:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=2017; bh=SodSCpCrTSu+G9V 84lKWXoMuh7IDBr4m8Js1QqMNrSk=; h=date:subject:cc:to:from; d=lease-up.com; b=Zk9LDi9OLLL2lGgKCJp29DRg51Ivv0hs6FB7gIr8Z/dj1S+FLnt1 UpuYxBbo2QWmdAZdqqY7pAga+MN/HZdSuXgnObNqwQZwgMhox3h2iz+8rYddK60mTvkZFL oDFE8raWcxHfVsHjxiiPy1n0dlHVTaySAA9kz0Cq2aQtW7Y3E= Received: by sail-ipv4.us-core.com (OpenSMTPD) with ESMTPSA id d7bffa0b (TLSv1.3:TLS_CHACHA20_POLY1305_SHA256:256:NO); Wed, 17 May 2023 04:19:46 +0000 (UTC) Received: from localhost (localhost [local]) by localhost (OpenSMTPD) with ESMTPA id 6aeecd69; Wed, 17 May 2023 04:19:46 +0000 (UTC) From: Felix Lechner Date: Tue, 16 May 2023 21:19:39 -0700 Message-Id: X-Mailer: git-send-email 2.40.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=208.82.101.137; envelope-from=felix.lechner@us-core.com; helo=sail-ipv4.us-core.com X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HEADER_FROM_DIFFERENT_DOMAINS=0.25, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01, UNPARSEABLE_RELAY=0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.1 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.1 (--) This patch stops Guix from shipping user tools that, according to two Heimdal maintainers have been obsolete for over five years. While mostly harmless, those tools shadowed legitimate tools like 'su' from core-utils. [1] [1] https://lists.gnu.org/archive/html/guix-devel/2023-04/msg00364.html Felix Lechner (3): gnu: heimdal: Build from Git. gnu: heimdal: Drop obsolete and insecure user tools. gnu: heimdal: Re-indent code; no functional change. gnu/packages/kerberos.scm | 202 +++++++++++++++++++------------------- 1 file changed, 103 insertions(+), 99 deletions(-) base-commit: 6e38ec447f98383e0722ac300734f8d7c8c5c7b0 -- 2.40.1 From unknown Sun Aug 10 07:32:50 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#63545] [PATCH 1/3] gnu: heimdal: Build from Git. Resent-From: Felix Lechner Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 17 May 2023 04:22:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63545 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 63545@debbugs.gnu.org Cc: Felix Lechner Received: via spool by 63545-submit@debbugs.gnu.org id=B63545.168429726616781 (code B ref 63545); Wed, 17 May 2023 04:22:01 +0000 Received: (at 63545) by debbugs.gnu.org; 17 May 2023 04:21:06 +0000 Received: from localhost ([127.0.0.1]:48469 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pz8ev-0004MU-Dd for submit@debbugs.gnu.org; Wed, 17 May 2023 00:21:05 -0400 Received: from sail-ipv4.us-core.com ([208.82.101.137]:33608) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pz8et-0004MK-A8 for 63545@debbugs.gnu.org; Wed, 17 May 2023 00:21:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=2017; bh=9t70UJFpElPLKBV JE3igeyzlaALUjPTIKGHSJJDfZ+E=; h=references:in-reply-to:date:subject: cc:to:from; d=lease-up.com; b=gbgAmIERhgdmZst7sqN7bugZHVWkib3QLYSfdMcL 2cXFbr32VBVlmlhW8lM5eiwkba+CCfzL7b3Bm4iitbUjcGe2qccrF8LlEOmm7gDL1Vfv7/ J1ozj15KJCV5BhLN3XUhf9RLsskj/j+dU1UwxvKBX9q6tridyMOCfy2E8ZZmM= Received: by sail-ipv4.us-core.com (OpenSMTPD) with ESMTPSA id 04f4983f (TLSv1.3:TLS_CHACHA20_POLY1305_SHA256:256:NO); Wed, 17 May 2023 04:21:02 +0000 (UTC) Received: from localhost (localhost [local]) by localhost (OpenSMTPD) with ESMTPA id 6fe3c869; Wed, 17 May 2023 04:21:02 +0000 (UTC) From: Felix Lechner Date: Tue, 16 May 2023 21:20:55 -0700 Message-Id: <2262ef65f5191b0c3d925ea6688c1bd8bf0587d0.1684296904.git.felix.lechner@lease-up.com> X-Mailer: git-send-email 2.40.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.2 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.8 (/) This is in preparation to drop obsolete tools from the Automake files. The tarball comes with a ./configure script. It was not clear to the author what the best way was to run 'autoreconf -f -i' with the tarball in Guix's gnu-build-system. * gnu/packages/kerberos (heimdal): Build from Git; prepare to drop obsolete tools from Automake. --- gnu/packages/kerberos.scm | 39 +++++++++++++++++++++++---------------- 1 file changed, 23 insertions(+), 16 deletions(-) diff --git a/gnu/packages/kerberos.scm b/gnu/packages/kerberos.scm index c553f8180a..af67bff6c9 100644 --- a/gnu/packages/kerberos.scm +++ b/gnu/packages/kerberos.scm @@ -56,6 +56,7 @@ (define-module (gnu packages kerberos) #:use-module (guix packages) #:use-module (guix download) #:use-module (guix gexp) + #:use-module (guix git-download) #:use-module (guix utils) #:use-module (guix build-system gnu)) @@ -171,26 +172,22 @@ (define-public shishi (license license:gpl3+))) (define-public heimdal + (let ((commit "a6cf94577c0d1e5bca5304342e4ddffb18255afe") + (revision "1")) (package (name "heimdal") - (version "7.8.0") + (version (git-version "7.8.0" revision commit)) (source (origin - (method url-fetch) - (uri (string-append - "https://github.com/heimdal/heimdal/releases/download/" - "heimdal-" version "/" "heimdal-" version ".tar.gz")) + (method git-fetch) + (uri (git-reference + (url "https://github.com/heimdal/heimdal") + (commit commit))) + (file-name (git-file-name name version)) (sha256 (base32 - "0f4dblav859p5hn7b2jdj1akw6d8p32as6bj6zym19kghh3s51zx")) + "0df646hzi10s0w07kqzj10aniv6jsbmlpx6j3lqjvpsjpmm9lww9")) (patches - (search-patches "heimdal-CVE-2022-45142.patch")) - (modules '((guix build utils))) - (snippet - '(begin - (substitute* "configure" - (("User=.*$") "User=Guix\n") - (("Host=.*$") "Host=GNU") - (("Date=.*$") "Date=2022\n")))))) + (search-patches "heimdal-CVE-2022-45142.patch")))) (build-system gnu-build-system) (arguments `(#:configure-flags @@ -224,6 +221,10 @@ (define-public heimdal (add-before 'configure 'pre-configure (lambda* (#:key inputs #:allow-other-keys) (substitute* "configure" + ;; Reproducible build date, etc. + (("User=.*$") "User=Guix\n") + (("Host=.*$") "Host=GNU") + (("Date=.*$") "Date=2022\n") ;; The e2fsprogs input is included for libcom_err, ;; let's use it even if cross-compiling. (("test \"\\$\\{krb_cv_com_err\\}\" = \"yes\"") @@ -255,12 +256,17 @@ (define-public heimdal (format #t "#!~a~%exit 1~%" (which "sh"))))))) ;; Tests fail when run in parallel. #:parallel-tests? #f)) - (native-inputs (list bison + (native-inputs (list autoconf + automake + bison e2fsprogs ;for 'compile_et' flex + libtool texinfo unzip ;for tests pkg-config + perl + perl-json python)) (inputs (list readline bash-minimal @@ -274,4 +280,5 @@ (define-public heimdal (description "Heimdal is an implementation of Kerberos 5 network authentication service.") - (license license:bsd-3))) + (license license:bsd-3)))) + -- 2.40.1 From unknown Sun Aug 10 07:32:50 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#63545] [PATCH 2/3] gnu: heimdal: Drop obsolete and insecure user tools. Resent-From: Felix Lechner Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 17 May 2023 04:22:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63545 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 63545@debbugs.gnu.org Cc: Felix Lechner Received: via spool by 63545-submit@debbugs.gnu.org id=B63545.168429727016800 (code B ref 63545); Wed, 17 May 2023 04:22:01 +0000 Received: (at 63545) by debbugs.gnu.org; 17 May 2023 04:21:10 +0000 Received: from localhost ([127.0.0.1]:48472 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pz8f0-0004Mu-2M for submit@debbugs.gnu.org; Wed, 17 May 2023 00:21:10 -0400 Received: from sail-ipv4.us-core.com ([208.82.101.137]:33608) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pz8eu-0004MK-LG for 63545@debbugs.gnu.org; Wed, 17 May 2023 00:21:05 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=2017; bh=Kstn4lm/P+/FX9P +Z5b3HDYZKpe65nBlXme/c0dsMiE=; h=references:in-reply-to:date:subject: cc:to:from; d=lease-up.com; b=OJlTviyfLmFoUbnaNE8I0Nvh3GG2vQkvs6Qe+iym 9rHtgGX+PZcFSe/mr6Px+QU1myLcTJkENdc+SsD3Ji5VoLgcg7hyYu1XmRPlUg6ugy0br0 ReFGZM7JwNQceODhTz4gI+d8iCFC8YIYb9fNgxiRPPJwdup6Syhbx05HqzZuM= Received: by sail-ipv4.us-core.com (OpenSMTPD) with ESMTPSA id f63cf357 (TLSv1.3:TLS_CHACHA20_POLY1305_SHA256:256:NO); Wed, 17 May 2023 04:21:03 +0000 (UTC) Received: from localhost (localhost [local]) by localhost (OpenSMTPD) with ESMTPA id d36e6a79; Wed, 17 May 2023 04:21:03 +0000 (UTC) From: Felix Lechner Date: Tue, 16 May 2023 21:20:56 -0700 Message-Id: <08b45237b932692ab246f0a0e36da4fcdb67988b.1684296904.git.felix.lechner@lease-up.com> X-Mailer: git-send-email 2.40.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.3 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) According to messages from the Heimdal maintainers Brian May and Nico Williams, no one should be using their version of 'su' anymore. It was deleted from the development branch five years ago [1] and is only being shipped because the 7.8.0 is based on an older, stable branch. [1] https://github.com/heimdal/heimdal/commit/8a77f45aff366b1cd8c70c43ce63eb16a0c9839c Following the directions from the maintainers, this commit drops all executables built from the ./appl folder via deletion of that SUBDIR from the top-level Makefile.am. Unfortunately, the heimdal-discuss mailing list does not appear to have a public archive. The relevant SMTP Message-Id was: Since the 7.8.0 tarball shipped with all the files generated by 'autoreconf' it seemed superior to build from Git instead. For that, please see the preceeding commit. * gnu/packages/kerberos.scm (heimdal): Drop obsolete and insecure user tools. --- gnu/packages/kerberos.scm | 15 ++++++--------- 1 file changed, 6 insertions(+), 9 deletions(-) diff --git a/gnu/packages/kerberos.scm b/gnu/packages/kerberos.scm index af67bff6c9..cc5f3f9ef2 100644 --- a/gnu/packages/kerberos.scm +++ b/gnu/packages/kerberos.scm @@ -218,6 +218,12 @@ (define-public heimdal "/libexec/heimdal"))) #~())) #:phases (modify-phases %standard-phases + ;; Skip the appl folder as obsolete per message from Brian May + ;; + (add-after 'unpack 'drop-obsolete-executables + (lambda* (#:key inputs #:allow-other-keys) + (substitute* '("Makefile.am") + (("appl") "")))) (add-before 'configure 'pre-configure (lambda* (#:key inputs #:allow-other-keys) (substitute* "configure" @@ -233,15 +239,6 @@ (define-public heimdal ;; which confuses heimdal. (("ac_cv_prog_COMPILE_ET=\\$\\{with_cross_tools\\}compile_et") "ac_cv_PROG_COMPILE_ET=compile_et")) - (substitute* '("appl/afsutil/pagsh.c" "appl/su/su.c") - (("/bin/sh") - (search-input-file inputs "bin/sh")) - ;; Use the cross-compiled bash instead of the - ;; native bash (XXX shouldn't _PATH_BSHELL point - ;; to a cross-compiled bash?). - (("_PATH_BSHELL") - (string-append - "\"" (search-input-file inputs "bin/sh") "\""))) (substitute* '("tools/Makefile.in") (("/bin/sh") (which "sh"))))) (add-before 'check 'pre-check -- 2.40.1 From unknown Sun Aug 10 07:32:50 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#63545] [PATCH 3/3] gnu: heimdal: Re-indent code; no functional change. Resent-From: Felix Lechner Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 17 May 2023 04:22:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63545 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 63545@debbugs.gnu.org Cc: Felix Lechner Received: via spool by 63545-submit@debbugs.gnu.org id=B63545.168429727116808 (code B ref 63545); Wed, 17 May 2023 04:22:02 +0000 Received: (at 63545) by debbugs.gnu.org; 17 May 2023 04:21:11 +0000 Received: from localhost ([127.0.0.1]:48474 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pz8f0-0004N0-Gw for submit@debbugs.gnu.org; Wed, 17 May 2023 00:21:11 -0400 Received: from sail-ipv4.us-core.com ([208.82.101.137]:33608) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pz8ev-0004MK-NZ for 63545@debbugs.gnu.org; Wed, 17 May 2023 00:21:06 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=2017; bh=VOyF+/bWe3rxv0C +QlXbgiidxx5qfVv3O43/lnTfcBo=; h=references:in-reply-to:date:subject: cc:to:from; d=lease-up.com; b=Az8uNhHt3noXZw7UKpaYzq6c0VBQC8v1zc7w3gbW C8D9Y4QMuXXXvfsJ8zAjcSFRu6olfgoodZuzuT69z2dp+7CvJRnE+HIwCoTaXmqo2tlReH H5iOZfzNgi5funzH8TC36A683RXYyGHwyCodS/7k4Pd99kFiJgfeurPXPv05s= Received: by sail-ipv4.us-core.com (OpenSMTPD) with ESMTPSA id fbb20529 (TLSv1.3:TLS_CHACHA20_POLY1305_SHA256:256:NO); Wed, 17 May 2023 04:21:04 +0000 (UTC) Received: from localhost (localhost [local]) by localhost (OpenSMTPD) with ESMTPA id a7f59a96; Wed, 17 May 2023 04:21:04 +0000 (UTC) From: Felix Lechner Date: Tue, 16 May 2023 21:20:57 -0700 Message-Id: <28905e7dadc7acfe4abf335bdaf30d8925503570.1684296904.git.felix.lechner@lease-up.com> X-Mailer: git-send-email 2.40.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.3 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) * gnu/packages/kerberos (heimdal): Re-indent code; no functional change. --- gnu/packages/kerberos.scm | 198 +++++++++++++++++++------------------- 1 file changed, 99 insertions(+), 99 deletions(-) diff --git a/gnu/packages/kerberos.scm b/gnu/packages/kerberos.scm index cc5f3f9ef2..3bfeefd558 100644 --- a/gnu/packages/kerberos.scm +++ b/gnu/packages/kerberos.scm @@ -174,108 +174,108 @@ (define-public shishi (define-public heimdal (let ((commit "a6cf94577c0d1e5bca5304342e4ddffb18255afe") (revision "1")) - (package - (name "heimdal") - (version (git-version "7.8.0" revision commit)) - (source (origin - (method git-fetch) - (uri (git-reference - (url "https://github.com/heimdal/heimdal") - (commit commit))) - (file-name (git-file-name name version)) - (sha256 - (base32 - "0df646hzi10s0w07kqzj10aniv6jsbmlpx6j3lqjvpsjpmm9lww9")) - (patches - (search-patches "heimdal-CVE-2022-45142.patch")))) - (build-system gnu-build-system) - (arguments - `(#:configure-flags - ,#~(list - ;; Avoid 7 MiB of .a files. - "--disable-static" + (package + (name "heimdal") + (version (git-version "7.8.0" revision commit)) + (source (origin + (method git-fetch) + (uri (git-reference + (url "https://github.com/heimdal/heimdal") + (commit commit))) + (file-name (git-file-name name version)) + (sha256 + (base32 + "0df646hzi10s0w07kqzj10aniv6jsbmlpx6j3lqjvpsjpmm9lww9")) + (patches + (search-patches "heimdal-CVE-2022-45142.patch")))) + (build-system gnu-build-system) + (arguments + `(#:configure-flags + ,#~(list + ;; Avoid 7 MiB of .a files. + "--disable-static" - ;; Do not build libedit. - (string-append - "--with-readline-lib=" - (assoc-ref %build-inputs "readline") "/lib") - (string-append - "--with-readline-include=" - (assoc-ref %build-inputs "readline") "/include") + ;; Do not build libedit. + (string-append + "--with-readline-lib=" + (assoc-ref %build-inputs "readline") "/lib") + (string-append + "--with-readline-include=" + (assoc-ref %build-inputs "readline") "/include") - ;; Do not build sqlite. - (string-append - "--with-sqlite3=" - (assoc-ref %build-inputs "sqlite")) + ;; Do not build sqlite. + (string-append + "--with-sqlite3=" + (assoc-ref %build-inputs "sqlite")) - #$@(if (%current-target-system) - ;; The configure script is too pessimistic. - ;; Setting this also resolves a linking error. - #~("ac_cv_func_getpwnam_r_posix=yes" - ;; Allow 'slc' and 'asn1_compile' to be found. - (string-append "--with-cross-tools=" - #+(file-append this-package - "/libexec/heimdal"))) - #~())) - #:phases (modify-phases %standard-phases - ;; Skip the appl folder as obsolete per message from Brian May - ;; - (add-after 'unpack 'drop-obsolete-executables - (lambda* (#:key inputs #:allow-other-keys) - (substitute* '("Makefile.am") - (("appl") "")))) - (add-before 'configure 'pre-configure - (lambda* (#:key inputs #:allow-other-keys) - (substitute* "configure" - ;; Reproducible build date, etc. - (("User=.*$") "User=Guix\n") - (("Host=.*$") "Host=GNU") - (("Date=.*$") "Date=2022\n") - ;; The e2fsprogs input is included for libcom_err, - ;; let's use it even if cross-compiling. - (("test \"\\$\\{krb_cv_com_err\\}\" = \"yes\"") - ":") - ;; Our 'compile_et' is not in --with-cross-tools, - ;; which confuses heimdal. - (("ac_cv_prog_COMPILE_ET=\\$\\{with_cross_tools\\}compile_et") - "ac_cv_PROG_COMPILE_ET=compile_et")) - (substitute* '("tools/Makefile.in") - (("/bin/sh") (which "sh"))))) - (add-before 'check 'pre-check - (lambda _ - ;; For 'getxxyyy-test'. - (setenv "USER" (passwd:name (getpwuid (getuid)))) + #$@(if (%current-target-system) + ;; The configure script is too pessimistic. + ;; Setting this also resolves a linking error. + #~("ac_cv_func_getpwnam_r_posix=yes" + ;; Allow 'slc' and 'asn1_compile' to be found. + (string-append "--with-cross-tools=" + #+(file-append this-package + "/libexec/heimdal"))) + #~())) + #:phases (modify-phases %standard-phases + ;; Skip the appl folder as obsolete per message from Brian May + ;; + (add-after 'unpack 'drop-obsolete-executables + (lambda* (#:key inputs #:allow-other-keys) + (substitute* '("Makefile.am") + (("appl") "")))) + (add-before 'configure 'pre-configure + (lambda* (#:key inputs #:allow-other-keys) + (substitute* "configure" + ;; Reproducible build date, etc. + (("User=.*$") "User=Guix\n") + (("Host=.*$") "Host=GNU") + (("Date=.*$") "Date=2022\n") + ;; The e2fsprogs input is included for libcom_err, + ;; let's use it even if cross-compiling. + (("test \"\\$\\{krb_cv_com_err\\}\" = \"yes\"") + ":") + ;; Our 'compile_et' is not in --with-cross-tools, + ;; which confuses heimdal. + (("ac_cv_prog_COMPILE_ET=\\$\\{with_cross_tools\\}compile_et") + "ac_cv_PROG_COMPILE_ET=compile_et")) + (substitute* '("tools/Makefile.in") + (("/bin/sh") (which "sh"))))) + (add-before 'check 'pre-check + (lambda _ + ;; For 'getxxyyy-test'. + (setenv "USER" (passwd:name (getpwuid (getuid)))) - ;; Skip 'db' and 'kdc' tests for now. - ;; FIXME: figure out why 'kdc' tests fail. - (with-output-to-file "tests/db/have-db.in" - (lambda () - (format #t "#!~a~%exit 1~%" (which "sh"))))))) - ;; Tests fail when run in parallel. - #:parallel-tests? #f)) - (native-inputs (list autoconf - automake - bison - e2fsprogs ;for 'compile_et' - flex - libtool - texinfo - unzip ;for tests - pkg-config - perl - perl-json - python)) - (inputs (list readline - bash-minimal - bdb - e2fsprogs ;for libcom_err - libcap-ng - openldap - sqlite)) - (home-page "http://www.h5l.org/") - (synopsis "Kerberos 5 network authentication") - (description - "Heimdal is an implementation of Kerberos 5 network authentication + ;; Skip 'db' and 'kdc' tests for now. + ;; FIXME: figure out why 'kdc' tests fail. + (with-output-to-file "tests/db/have-db.in" + (lambda () + (format #t "#!~a~%exit 1~%" (which "sh"))))))) + ;; Tests fail when run in parallel. + #:parallel-tests? #f)) + (native-inputs (list autoconf + automake + bison + e2fsprogs ;for 'compile_et' + flex + libtool + texinfo + unzip ;for tests + pkg-config + perl + perl-json + python)) + (inputs (list readline + bash-minimal + bdb + e2fsprogs ;for libcom_err + libcap-ng + openldap + sqlite)) + (home-page "http://www.h5l.org/") + (synopsis "Kerberos 5 network authentication") + (description + "Heimdal is an implementation of Kerberos 5 network authentication service.") - (license license:bsd-3)))) + (license license:bsd-3)))) -- 2.40.1 From unknown Sun Aug 10 07:32:50 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#63545] [PATCH 1/3] gnu: heimdal: Build from Git. Resent-From: Josselin Poiret Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 17 May 2023 20:21:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63545 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 63545@debbugs.gnu.org Cc: Felix Lechner X-Debbugs-Original-To: Felix Lechner via Guix-patches via , 63545@debbugs.gnu.org Received: via spool by submit@debbugs.gnu.org id=B.168435483330734 (code B ref -1); Wed, 17 May 2023 20:21:02 +0000 Received: (at submit) by debbugs.gnu.org; 17 May 2023 20:20:33 +0000 Received: from localhost ([127.0.0.1]:51172 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pzNdQ-0007ze-Uu for submit@debbugs.gnu.org; Wed, 17 May 2023 16:20:33 -0400 Received: from lists.gnu.org ([209.51.188.17]:54930) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pzNdP-0007zV-6t for submit@debbugs.gnu.org; Wed, 17 May 2023 16:20:31 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pzNdO-0000Au-C9 for guix-patches@gnu.org; Wed, 17 May 2023 16:20:31 -0400 Received: from jpoiret.xyz ([206.189.101.64]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pzNdM-0005Jn-Sd for guix-patches@gnu.org; Wed, 17 May 2023 16:20:30 -0400 Received: from authenticated-user (jpoiret.xyz [206.189.101.64]) by jpoiret.xyz (Postfix) with ESMTPA id 7D48A18530D; Wed, 17 May 2023 20:20:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jpoiret.xyz; s=dkim; t=1684354825; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=p5A0L66GFgIOHmymMQFCcFETUk8C12wcJn1uuvPMoJA=; b=b2fWwJQ9ysUuY2BxWVJhkAtN6CKhiAevMD5xKhtbAgws2o+kC/81RFUBj+khr5L61U7Ckj l0H+2McVlVMaTlScETp02Z6XUMUE4VnmEF79bpxjpCuRMUUojOMVNOiRiuFe23/z8/KBoM GTj6EcTJrtpOIWT4rffQqhCA+vZDjizADJOW0Xm+4VNGPqs0EUiFAr0X5KSrkDjDhPLvK2 93XkJ8Yngdauft1XuSFWbzAlU45apEeuVsai9iXtCYfjlCCoR3WoAQcvNNa0c89KH5Hy2S 3Z+zN8Dmxu5t5B2brfO8lLLgmWpZHkCJ7bbrw4fp5MNWrp3GtAxQnhI+SKjGQA== From: Josselin Poiret In-Reply-To: <2262ef65f5191b0c3d925ea6688c1bd8bf0587d0.1684296904.git.felix.lechner@lease-up.com> References: <2262ef65f5191b0c3d925ea6688c1bd8bf0587d0.1684296904.git.felix.lechner@lease-up.com> Date: Wed, 17 May 2023 22:20:19 +0200 Message-ID: <87wn161zi4.fsf@jpoiret.xyz> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spamd-Bar: / Authentication-Results: jpoiret.xyz; auth=pass smtp.auth=jpoiret@jpoiret.xyz smtp.mailfrom=dev@jpoiret.xyz Received-SPF: pass client-ip=206.189.101.64; envelope-from=dev@jpoiret.xyz; helo=jpoiret.xyz X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.4 (-) --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Hi Felix, I am no user of Heimdal, but this looks good to me apart from some nitpicks below. Felix Lechner via Guix-patches via writes: > (define-public heimdal > + (let ((commit "a6cf94577c0d1e5bca5304342e4ddffb18255afe") > + (revision "1")) No need to use commit+revision for fixed releases, unless upstream has the bad habit of moving their upstream tags. I see the tag heimdal-7.8.0, which you should use in (commit ...), possibly with (commit (string-append "heimdall-" version)). > (package > (name "heimdal") > - (version "7.8.0") > + (version (git-version "7.8.0" revision commit)) This would lead to a very ugly version string for what is actually 7.8.0, no need to change this. The other patches seem fine, although I think you don't need to go as far as make the indentation change its own patch (and by dropping the commit+revision thing, there shouldn't be one). I haven't tried building this yet though, will let QA go over it. Best, =2D-=20 Josselin Poiret --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQHEBAEBCgAuFiEEOSSM2EHGPMM23K8vUF5AuRYXGooFAmRlNwMQHGRldkBqcG9p cmV0Lnh5egAKCRBQXkC5FhcailfQDACcfWKScDjfg6OuiGeMg3ZqKaBfNQxdVA69 7fA8AKeVkD3so4eSR1nxbStNi5tZFHG/wqLHcF5hxMEan7lgJ8n9B0+BiZTOM4BJ 8IB8KkkuDLNmiv2qsv1bQTEvUgR0dsk4N72qn9z46J7ZrIaqoT7XDNKZnZIMxhps Ww8U2j+Yvqx4AxTZPWQo7N1egJKWFj8OhOlM0IU0CU6C+DlQ10eeKfjuePOJOP/Z G1+DF0k9mwWWvSIxHN9uj480IAk42WyvNLXEeq5zOzA2Z+ZYbKAY3eFPkWNqG5F4 TmTdzKlJRmh0jGqj7tb5vipfEvJdxcF5mC7b0GK5eilltg6ApGnXHeyrdqqHwcvU Jws8g0luXwWvUFYwieClmRxdqhDGk4H4In+gVm2Y88B1oQgdg5rlzbYScxCd3l1O e2lR9oio+NyXbj7OeVAVIuDepKyKm1D0a5X98Sq392MDleWxID1RSTm1iDt8tkRV gD7EBprxSzT87n61+WlmcotbcyudbjQ= =j2aT -----END PGP SIGNATURE----- --=-=-=-- From unknown Sun Aug 10 07:32:50 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#63545] [PATCH v2 1/2] gnu: heimdal: Run autoreconf. References: In-Reply-To: Resent-From: Felix Lechner Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 29 May 2023 00:20:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63545 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 63545@debbugs.gnu.org Cc: Josselin Poiret , Felix Lechner Received: via spool by 63545-submit@debbugs.gnu.org id=B63545.168531958430005 (code B ref 63545); Mon, 29 May 2023 00:20:01 +0000 Received: (at 63545) by debbugs.gnu.org; 29 May 2023 00:19:44 +0000 Received: from localhost ([127.0.0.1]:56668 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q3Qbv-0007nt-LE for submit@debbugs.gnu.org; Sun, 28 May 2023 20:19:43 -0400 Received: from sail-ipv4.us-core.com ([208.82.101.137]:60618) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q3Qbt-0007ni-RC for 63545@debbugs.gnu.org; Sun, 28 May 2023 20:19:42 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=2017; bh=VafNrJYQCYncgVP KIXAhrLXbhDf6nRRZyPUBiczHpgc=; h=date:subject:cc:to:from; d=lease-up.com; b=Jb0aJRmXY/u5MJRaXNoYmrc3B5WdsY59YWhGF/6Z6foDJU275iPG c4k19ZThj8NZso6r4YEc8CJOucKE/jc40p3+akzPv+EWTPlEGKtWY5YNE6PB+ZcwRTkmvY 33gFf+D6ToS6NlkNEyDWGR/XQIwO3fq559958CMmVE262C1MY= Received: by sail-ipv4.us-core.com (OpenSMTPD) with ESMTPSA id a174531d (TLSv1.3:TLS_CHACHA20_POLY1305_SHA256:256:NO); Mon, 29 May 2023 00:19:40 +0000 (UTC) Received: from localhost (localhost [local]) by localhost (OpenSMTPD) with ESMTPA id e3649568; Mon, 29 May 2023 00:19:39 +0000 (UTC) From: Felix Lechner Date: Sun, 28 May 2023 17:19:17 -0700 Message-Id: <700bdb497cd0431ea9f3d71516f4168f55882ce4.1685319429.git.felix.lechner@lease-up.com> X-Mailer: git-send-email 2.40.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.2 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.8 (/) * gnu/packages/kerberos.scm (heimdal): Run autoreconf. --- Hi Josselin, Thanks for your review! I sidestepped your suggestions by continuing to build from the tarball, and running 'autoreconf.' Kind regards Felix gnu/packages/kerberos.scm | 21 ++++++++++++--------- 1 file changed, 12 insertions(+), 9 deletions(-) diff --git a/gnu/packages/kerberos.scm b/gnu/packages/kerberos.scm index c553f8180a..f06410b8f8 100644 --- a/gnu/packages/kerberos.scm +++ b/gnu/packages/kerberos.scm @@ -183,14 +183,7 @@ (define-public heimdal (base32 "0f4dblav859p5hn7b2jdj1akw6d8p32as6bj6zym19kghh3s51zx")) (patches - (search-patches "heimdal-CVE-2022-45142.patch")) - (modules '((guix build utils))) - (snippet - '(begin - (substitute* "configure" - (("User=.*$") "User=Guix\n") - (("Host=.*$") "Host=GNU") - (("Date=.*$") "Date=2022\n")))))) + (search-patches "heimdal-CVE-2022-45142.patch")))) (build-system gnu-build-system) (arguments `(#:configure-flags @@ -223,7 +216,12 @@ (define-public heimdal #:phases (modify-phases %standard-phases (add-before 'configure 'pre-configure (lambda* (#:key inputs #:allow-other-keys) + (invoke (search-input-file inputs "bin/autoreconf") "--install" "--force") (substitute* "configure" + ;; Reproducible build date, etc. + (("User=.*$") "User=Guix\n") + (("Host=.*$") "Host=GNU\n") + (("Date=.*$") "Date=2022\n") ;; The e2fsprogs input is included for libcom_err, ;; let's use it even if cross-compiling. (("test \"\\$\\{krb_cv_com_err\\}\" = \"yes\"") @@ -255,12 +253,17 @@ (define-public heimdal (format #t "#!~a~%exit 1~%" (which "sh"))))))) ;; Tests fail when run in parallel. #:parallel-tests? #f)) - (native-inputs (list bison + (native-inputs (list autoconf + automake + bison e2fsprogs ;for 'compile_et' flex + libtool texinfo unzip ;for tests pkg-config + perl + perl-json python)) (inputs (list readline bash-minimal base-commit: d64d6ea2cf5a1be801be355031fb2cfa5901a92a -- 2.40.1 From unknown Sun Aug 10 07:32:50 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#63545] [PATCH v2 2/2] gnu: heimdal: Drop obsolete and insecure user tools. Resent-From: Felix Lechner Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 29 May 2023 00:20:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63545 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 63545@debbugs.gnu.org Cc: Josselin Poiret , Felix Lechner Received: via spool by 63545-submit@debbugs.gnu.org id=B63545.168531958730020 (code B ref 63545); Mon, 29 May 2023 00:20:02 +0000 Received: (at 63545) by debbugs.gnu.org; 29 May 2023 00:19:47 +0000 Received: from localhost ([127.0.0.1]:56670 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q3Qby-0007o8-Uu for submit@debbugs.gnu.org; Sun, 28 May 2023 20:19:47 -0400 Received: from sail-ipv4.us-core.com ([208.82.101.137]:60618) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q3Qbu-0007ni-TG for 63545@debbugs.gnu.org; Sun, 28 May 2023 20:19:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=2017; bh=Hh2MTLJT2J/hrDp mZ+H5OKYZntKrkJsCakYrrmlfELs=; h=references:in-reply-to:date:subject: cc:to:from; d=lease-up.com; b=rE4XF/EUh/bs02OunAEc28J2+kivK2yEPDUPFM1f q+IvDtWqcriuLc1JrlYzHP2YttYuXv3y1DNfHp+4eJmtZbisExC5+QOtpkG9n9cXGFM+el OsNOPcgV0Ur93WpgMXJDOJIUiJqENN4eW7iswI8TIpQCZJAJoqllSaIQIa5w0= Received: by sail-ipv4.us-core.com (OpenSMTPD) with ESMTPSA id fce3d390 (TLSv1.3:TLS_CHACHA20_POLY1305_SHA256:256:NO); Mon, 29 May 2023 00:19:41 +0000 (UTC) Received: from localhost (localhost [local]) by localhost (OpenSMTPD) with ESMTPA id d571a8e1; Mon, 29 May 2023 00:19:41 +0000 (UTC) From: Felix Lechner Date: Sun, 28 May 2023 17:19:18 -0700 Message-Id: X-Mailer: git-send-email 2.40.1 In-Reply-To: <700bdb497cd0431ea9f3d71516f4168f55882ce4.1685319429.git.felix.lechner@lease-up.com> References: <700bdb497cd0431ea9f3d71516f4168f55882ce4.1685319429.git.felix.lechner@lease-up.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.3 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) According to messages from the Heimdal maintainers Brian May and Nico Williams, no one should be using their version of 'su' anymore. It was deleted from the development branch five years ago [1] and is only being shipped because the 7.8.0 is based on an older, stable branch. [1] https://github.com/heimdal/heimdal/commit/8a77f45aff366b1cd8c70c43ce63eb16a0c9839c Following the directions from the maintainers, this commit drops all executables built from the ./appl folder via deletion of that SUBDIR from the top-level Makefile.am. Unfortunately, the heimdal-discuss mailing list does not appear to have a public archive. The relevant SMTP Message-Id was: Since the 7.8.0 tarball shipped with all the files generated by 'autoreconf' it seemed superior to build from Git instead. For that, please see the preceeding commit. * gnu/packages/kerberos.scm (heimdal): Drop obsolete and insecure user tools. --- gnu/packages/kerberos.scm | 15 ++++++--------- 1 file changed, 6 insertions(+), 9 deletions(-) diff --git a/gnu/packages/kerberos.scm b/gnu/packages/kerberos.scm index f06410b8f8..241881ea47 100644 --- a/gnu/packages/kerberos.scm +++ b/gnu/packages/kerberos.scm @@ -214,6 +214,12 @@ (define-public heimdal "/libexec/heimdal"))) #~())) #:phases (modify-phases %standard-phases + ;; Skip the appl folder as obsolete per message from Brian May + ;; + (add-after 'unpack 'drop-obsolete-executables + (lambda* (#:key inputs #:allow-other-keys) + (substitute* '("Makefile.am") + (("appl") "")))) (add-before 'configure 'pre-configure (lambda* (#:key inputs #:allow-other-keys) (invoke (search-input-file inputs "bin/autoreconf") "--install" "--force") @@ -230,15 +236,6 @@ (define-public heimdal ;; which confuses heimdal. (("ac_cv_prog_COMPILE_ET=\\$\\{with_cross_tools\\}compile_et") "ac_cv_PROG_COMPILE_ET=compile_et")) - (substitute* '("appl/afsutil/pagsh.c" "appl/su/su.c") - (("/bin/sh") - (search-input-file inputs "bin/sh")) - ;; Use the cross-compiled bash instead of the - ;; native bash (XXX shouldn't _PATH_BSHELL point - ;; to a cross-compiled bash?). - (("_PATH_BSHELL") - (string-append - "\"" (search-input-file inputs "bin/sh") "\""))) (substitute* '("tools/Makefile.in") (("/bin/sh") (which "sh"))))) (add-before 'check 'pre-check -- 2.40.1 From unknown Sun Aug 10 07:32:50 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Felix Lechner Subject: bug#63545: closed (Re: [PATCH v2 1/2] gnu: heimdal: Run autoreconf.) Message-ID: References: <87cz2befc0.fsf@jpoiret.xyz> X-Gnu-PR-Message: they-closed 63545 X-Gnu-PR-Package: guix-patches X-Gnu-PR-Keywords: patch Reply-To: 63545@debbugs.gnu.org Date: Sun, 04 Jun 2023 09:40:04 +0000 Content-Type: multipart/mixed; boundary="----------=_1685871604-15818-1" This is a multi-part message in MIME format... ------------=_1685871604-15818-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #63545: [PATCH 0/3] gnu: heimdal: Drop obsolete user tools. which was filed against the guix-patches package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 63545@debbugs.gnu.org. --=20 63545: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D63545 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1685871604-15818-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 63545-done) by debbugs.gnu.org; 4 Jun 2023 09:39:49 +0000 Received: from localhost ([127.0.0.1]:45032 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q5kDF-00045r-7b for submit@debbugs.gnu.org; Sun, 04 Jun 2023 05:39:49 -0400 Received: from jpoiret.xyz ([206.189.101.64]:54746) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q5kDC-00045i-Tj for 63545-done@debbugs.gnu.org; Sun, 04 Jun 2023 05:39:47 -0400 Received: from authenticated-user (jpoiret.xyz [206.189.101.64]) by jpoiret.xyz (Postfix) with ESMTPA id A6376184F27; Sun, 4 Jun 2023 09:39:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jpoiret.xyz; s=dkim; t=1685871585; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=fNO+0nm6eQGC9G3Ojy1NfBaQcDeXmHikWMaIn6yND+c=; b=TBcYrIARh2rR2lO9Q8CwA83ciu0XkrUMuBb3ToAUGxXZVykrlG3A/+rh2j9fQESBkIJqR8 8UdnxAoWWSluTrJdEXRonvmWRiRsYjPtpGz696GDpTDELGwkTDta1MhQQjsmeUc2pnB3Fv pWqvPqxAD0EOrbIvOoxipY2R6mEWgmi+OK79qjGRsat9eHTnMbJfp5q/bs5NU0Gc36VLV8 uFUKmPgwF5gFK8m5H0F9utHtTkcVMWr4N2Dr2M3u5oBMT6iBVfbiOlfbh+CpFITbDioqok yBJzSlMuGtv2z31Z4T3ZA8jsG+q9MMkPZoSKzmBy5cmCKJIZhC6cFG2X1uhk4Q== From: Josselin Poiret To: Felix Lechner , 63545-done@debbugs.gnu.org Subject: Re: [PATCH v2 1/2] gnu: heimdal: Run autoreconf. In-Reply-To: <700bdb497cd0431ea9f3d71516f4168f55882ce4.1685319429.git.felix.lechner@lease-up.com> References: <700bdb497cd0431ea9f3d71516f4168f55882ce4.1685319429.git.felix.lechner@lease-up.com> Date: Sun, 04 Jun 2023 11:39:43 +0200 Message-ID: <87cz2befc0.fsf@jpoiret.xyz> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spamd-Bar: / Authentication-Results: jpoiret.xyz; auth=pass smtp.auth=jpoiret@jpoiret.xyz smtp.mailfrom=dev@jpoiret.xyz X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 63545-done Cc: Felix Lechner X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Hi Felix, Felix Lechner writes: > Hi Josselin, > > Thanks for your review! I sidestepped your suggestions by continuing > to build from the tarball, and running 'autoreconf.' > > Kind regards > Felix Thanks, pushed as d89247150fe6e97c2fceed8d578fd119a782624d. I removed the last sentence of the second commit message, as it was no longer applicable. Best, =2D-=20 Josselin Poiret --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQHEBAEBCgAuFiEEOSSM2EHGPMM23K8vUF5AuRYXGooFAmR8W98QHGRldkBqcG9p cmV0Lnh5egAKCRBQXkC5FhcaioZCDACOs4a6C101r8ojPzm9XGsUebZZgLzs8+tY 7yS+CFI2EOlQJPi+AGrslve7PADiwfGp8l1cKxvxQd8VOqzKFHXSAOcqmiC4OBnX a/MDszzh6i6uttvj8KjwPApT2hCueq4bI9F/2iVeNWZ/pnxU+RFDEK1k5aKQrhyr zMAfh8n9koXcJWS+ltHx6DSkPVBwv6mppFL2IzsVAOzJ7XXeBF+HIA+eHrg+sHiJ Pql1vFMQQ3MrXnJW1V7r7EDPom/q9q1yKsgN5VXG3M2qAr4pEXkFlF2U5X8035xm QR/AN09K3QpPmF781TAm6ydzZrSuZj1+CMhvbpWbNRdh7/wl9ZsZBNYv1TFlho4m 3Lh1XbKuL10oY5Y+IkVbyUO6n/bgsmWMPzYdoI3ES9Afjh7Bes2ULPwWvSYAt5qm Q4O6FX3jQgQsM5xfDLVCbsR9uAl1PX26bR0AC0koK1lYbisBFK2mz3+7anYq5CFq tdkPURynWr1SBERjakEEMV/Vwy0rn3g= =W055 -----END PGP SIGNATURE----- --=-=-=-- ------------=_1685871604-15818-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 17 May 2023 04:19:59 +0000 Received: from localhost ([127.0.0.1]:48463 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pz8dq-0004JM-TC for submit@debbugs.gnu.org; Wed, 17 May 2023 00:19:59 -0400 Received: from lists.gnu.org ([209.51.188.17]:56082) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pz8dn-0004JD-K8 for submit@debbugs.gnu.org; Wed, 17 May 2023 00:19:57 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pz8dm-0007yB-Mj for guix-patches@gnu.org; Wed, 17 May 2023 00:19:55 -0400 Received: from sail-ipv4.us-core.com ([208.82.101.137]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_CHACHA20_POLY1305:256) (Exim 4.90_1) (envelope-from ) id 1pz8dk-0006BL-Pe for guix-patches@gnu.org; Wed, 17 May 2023 00:19:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=2017; bh=SodSCpCrTSu+G9V 84lKWXoMuh7IDBr4m8Js1QqMNrSk=; h=date:subject:cc:to:from; d=lease-up.com; b=Zk9LDi9OLLL2lGgKCJp29DRg51Ivv0hs6FB7gIr8Z/dj1S+FLnt1 UpuYxBbo2QWmdAZdqqY7pAga+MN/HZdSuXgnObNqwQZwgMhox3h2iz+8rYddK60mTvkZFL oDFE8raWcxHfVsHjxiiPy1n0dlHVTaySAA9kz0Cq2aQtW7Y3E= Received: by sail-ipv4.us-core.com (OpenSMTPD) with ESMTPSA id d7bffa0b (TLSv1.3:TLS_CHACHA20_POLY1305_SHA256:256:NO); Wed, 17 May 2023 04:19:46 +0000 (UTC) Received: from localhost (localhost [local]) by localhost (OpenSMTPD) with ESMTPA id 6aeecd69; Wed, 17 May 2023 04:19:46 +0000 (UTC) From: Felix Lechner To: guix-patches@gnu.org Subject: [PATCH 0/3] gnu: heimdal: Drop obsolete user tools. Date: Tue, 16 May 2023 21:19:39 -0700 Message-Id: X-Mailer: git-send-email 2.40.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=208.82.101.137; envelope-from=felix.lechner@us-core.com; helo=sail-ipv4.us-core.com X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HEADER_FROM_DIFFERENT_DOMAINS=0.25, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01, UNPARSEABLE_RELAY=0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.1 (-) X-Debbugs-Envelope-To: submit Cc: Felix Lechner X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.1 (--) This patch stops Guix from shipping user tools that, according to two Heimdal maintainers have been obsolete for over five years. While mostly harmless, those tools shadowed legitimate tools like 'su' from core-utils. [1] [1] https://lists.gnu.org/archive/html/guix-devel/2023-04/msg00364.html Felix Lechner (3): gnu: heimdal: Build from Git. gnu: heimdal: Drop obsolete and insecure user tools. gnu: heimdal: Re-indent code; no functional change. gnu/packages/kerberos.scm | 202 +++++++++++++++++++------------------- 1 file changed, 103 insertions(+), 99 deletions(-) base-commit: 6e38ec447f98383e0722ac300734f8d7c8c5c7b0 -- 2.40.1 ------------=_1685871604-15818-1--